dradis-csv 5.3.0 → 5.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9fc992eccc61f6f4f2b7a0d2696dbda946add4cb50a38cb92cc435dea0dc1038
-  data.tar.gz: 993fdee3bc19179b7f42801f6e0a078fa6e26d0e8eec09ae60a4e89006627e09
+  metadata.gz: f66806e2230745ce4ab608c4930c575d92e35f577c7a86ff9f888327c313cda9
+  data.tar.gz: 2510f5a2d96208375f1a339976dc16c03490cdbabb297728095e178c635f2a20
 SHA512:
-  metadata.gz: 7f3322fbe5e012b8bbe5eaab98450f71c3273461398f5e1d5e814c626152037216288fafe53614305789dd8a415c5ac5071bc6ed1b0ae01ee8268bd0f71964c1
-  data.tar.gz: be698324c4a89f500d9da324016e149b8d9d09842f5af2ae26a922130eb2fa21aab85d9b4baa6d76f3b3254d7ba28acb343d56a576d07dac3dc73492a87acf45
+  metadata.gz: 5a6e489369e1d0a13bb3c60a02b02f1352680a0fe85c39448828891aac46b85a18227d97f62bc7486385dba3345bbb3027edf5fec786485bb54f2956ec5c720e
+  data.tar.gz: 90f1df72e003a07b155c3f445905332c63b902d49d753b0b167a33ad6158cfdc5a0408e22565ff36f42868a52f290d97aded1336d4354854d074fd294e45e645

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+v5.4.0 (September 2026)
+  - No changes
+
 v5.3.0 (August 2026)
   - Add support for managing Mappings through the Mappings Manager
   - Add support for saving column assignments from the upload mapper

data/lib/dradis/plugins/csv/gem_version.rb

@@ -8,7 +8,7 @@ module Dradis
 
       module VERSION
         MAJOR = 5
-        MINOR = 3
+        MINOR = 4
         TINY = 0
         PRE = nil
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dradis-csv
 version: !ruby/object:Gem::Version
-  version: 5.3.0
+  version: 5.4.0
 platform: ruby
 authors:
 - Daniel Martin
@@ -56,12 +56,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/pull_request_template.md"
-- ".gitignore"
 - CHANGELOG.md
-- CHANGELOG.template
-- CONTRIBUTING.md
-- Gemfile
 - LICENSE
 - README.md
 - Rakefile
@@ -75,7 +70,6 @@ files:
 - app/views/dradis/plugins/csv/upload/new.html.erb
 - config/initializers/inflections.rb
 - config/routes.rb
-- dradis-csv.gemspec
 - lib/dradis-csv.rb
 - lib/dradis/plugins/csv.rb
 - lib/dradis/plugins/csv/engine.rb
@@ -85,13 +79,6 @@ files:
 - lib/dradis/plugins/csv/mapping.rb
 - lib/dradis/plugins/csv/mapping_form.rb
 - lib/dradis/plugins/csv/version.rb
-- spec/features/upload_spec.rb
-- spec/fixtures/files/simple (copy).csv
-- spec/fixtures/files/simple.csv
-- spec/fixtures/files/simple_malformed.csv
-- spec/jobs/dradis/plugins/csv/mapping_import_job_spec.rb
-- spec/lib/dradis/plugins/csv/importer_spec.rb
-- spec/lib/dradis/plugins/csv/mapping_form_spec.rb
 homepage: http://dradis.com
 licenses:
 - GPL-2
@@ -113,11 +100,4 @@ requirements: []
 rubygems_version: 3.6.9
 specification_version: 4
 summary: CSV add-on for the Dradis Framework.
-test_files:
-- spec/features/upload_spec.rb
-- spec/fixtures/files/simple (copy).csv
-- spec/fixtures/files/simple.csv
-- spec/fixtures/files/simple_malformed.csv
-- spec/jobs/dradis/plugins/csv/mapping_import_job_spec.rb
-- spec/lib/dradis/plugins/csv/importer_spec.rb
-- spec/lib/dradis/plugins/csv/mapping_form_spec.rb
+test_files: []

data/.github/pull_request_template.md

@@ -1,45 +0,0 @@
-Please review [CONTRIBUTING.md](https://github.com/dradis/dradis-ce/blob/develop/CONTRIBUTING.md) and remove this line.
-
-### Summary
-
-Provide a general description of the code changes in your pull
-request... were there any bugs you had fixed? If so, mention them. If
-these bugs have open GitHub issues, be sure to tag them here as well,
-to keep the conversation linked together.
-
-
-### Testing Steps
-
-Provide steps to test functionality, described in detail for someone not familiar with this part of the application / code base
-
-
-### Other Information
-
-If there's anything else that's important and relevant to your pull
-request, mention that information here. This could include
-benchmarks, or other information.
-
-Thanks for contributing to Dradis!
-
-
-### Copyright assignment
-
-Collaboration is difficult with commercial closed source but we want
-to keep as much of the OSS ethos as possible available to users
-who want to fix it themselves.
-
-In order to unambiguously own and sell Dradis Framework commercial
-products, we must have the copyright associated with the entire
-codebase. Any code you create which is merged must be owned by us.
-That's not us trying to be a jerks, that's just the way it works.
-
-You can delete this section, but the following sentence needs to
-remain in the PR's description:
-
-> I assign all rights, including copyright, to any future Dradis
-> work by myself to Security Roots.
-
-### Check List
-
-- [ ] Added a CHANGELOG entry
-- [ ] Added specs

data/.gitignore

@@ -1,5 +0,0 @@
-.DS_Store
-
-pkg/
-
-Gemfile.lock

data/CHANGELOG.template

@@ -1,12 +0,0 @@
-[v#.#.#] ([month] [YYYY])
-  - [future tense verb] [feature]
-  - Upgraded gems:
-    - [gem]
-  - Bugs fixes:
-    - [future tense verb] [bug fix]
-    - Bug tracker items:
-      - [item]
-  - Security Fixes:
-    - High: (Authenticated|Unauthenticated) (admin|author|contributor) [vulnerability description]
-    - Medium: (Authenticated|Unauthenticated) (admin|author|contributor) [vulnerability description]
-    - Low: (Authenticated|Unauthenticated) (admin|author|contributor) [vulnerability description]

data/CONTRIBUTING.md

@@ -1,3 +0,0 @@
-# Plugin contribution guidelines
-
-See the Dradis Framework's [CONTRIBUTING.md](https://github.com/dradis/dradisframework/blob/master/CONTRIBUTING.md)

data/Gemfile

@@ -1,23 +0,0 @@
-source 'https://rubygems.org'
-
-# Declare your gem's dependencies in dradispro-duoweb.gemspec.
-# Bundler will treat runtime dependencies like base dependencies, and
-# development dependencies will be added by default to the :development group.
-gemspec
-
-# jquery-rails is used by the dummy application
-# gem "jquery-rails"
-
-# Declare any dependencies that are still in development here instead of in
-# your gemspec. These might include edge Rails or gems from your path or
-# Git. Remember to move these dependencies to your gemspec before releasing
-# your gem to rubygems.org.
-
-# To use debugger
-# gem 'debugger'
-
-if Dir.exist?('../dradis-plugins')
-  gem 'dradis-plugins', path: '../dradis-plugins'
-else
-  gem 'dradis-plugins', github: 'dradis/dradis-plugins'
-end

data/dradis-csv.gemspec

@@ -1,25 +0,0 @@
-$:.push File.expand_path('../lib', __FILE__)
-require 'dradis/plugins/csv/version'
-version = Dradis::Plugins::CSV::VERSION::STRING
-
-# Describe your gem and declare its dependencies:
-Gem::Specification.new do |spec|
-  spec.platform    = Gem::Platform::RUBY
-  spec.name        = 'dradis-csv'
-  spec.version     = version
-  spec.summary     = 'CSV add-on for the Dradis Framework.'
-  spec.description = 'This add-on allows you to upload and parse CSV output into Dradis.'
-
-  spec.license     = 'GPL-2'
-
-  spec.authors     = ['Daniel Martin']
-  spec.homepage    = 'http://dradis.com'
-
-  spec.files       = `git ls-files`.split("\n")
-  spec.executables = spec.files.grep(%r{^bin/}).map { |f| File.basename(f) }
-  spec.test_files  = spec.files.grep(%r{^(spec|features)/})
-
-  spec.add_dependency 'dradis-plugins', '>= 4.0'
-  spec.add_development_dependency 'bundler', '~> 2.0'
-  spec.add_development_dependency 'rake'
-end

data/spec/features/upload_spec.rb

@@ -1,381 +0,0 @@
-require 'rails_helper'
-
-# To run, execute from Dradis main app folder:
-#   bin/rspec [dradis-plugins path]/spec/features/upload_spec.rb
-
-describe 'upload feature', js: true do
-  before do
-    login_to_project_as_user
-    visit project_upload_path(@project)
-  end
-
-  context 'uploading a CSV file' do
-    let(:file_path) { File.expand_path('../fixtures/files/simple.csv', __dir__) }
-    before do
-      @headers = CSV.open(file_path, &:readline)
-
-      find('#state + .combobox').click
-      find('#state ~ .combobox-menu .combobox-option', text: 'Published').click
-
-      find('#uploader + .combobox').click
-      find('#uploader ~ .combobox-menu .combobox-option', text: 'Dradis::Plugins::CSV').click
-
-      attach_file 'file', file_path, visible: false, disabled: false
-
-      expect(page).to have_text('CSV Upload Mapping', wait: 30)
-    end
-
-    it 'redirects to the mapping page' do
-      expect(current_path).to eq(csv.new_project_upload_path(@project))
-    end
-
-    it 'lists the fields in the table' do
-      within('tbody') do
-        @headers.each do |header|
-          expect(page).to have_selector('td', text: header)
-        end
-      end
-    end
-
-    context 'mapping CSV columns' do
-      context 'when identifier not selected' do
-        it 'shows a validation message on the page' do
-          within all('tbody tr')[3] do
-            select 'Evidence Field'
-          end
-
-          click_button 'Import CSV'
-          expect(page).to have_text('An Issue ID must be selected.')
-        end
-      end
-
-      context 'when there are evidence type but no node type selected' do
-        it 'shows a validation message on the page' do
-          within all('tbody tr')[2] do
-            select 'Issue ID'
-          end
-
-          within all('tbody tr')[3] do
-            select 'Evidence Field'
-          end
-
-          click_button 'Import CSV'
-          expect(page).to have_text('A Node Label must be selected to import evidence records.')
-        end
-      end
-
-      context 'valid states' do
-        it 'imports the issues based on the selected state' do
-          select 'Issue ID', from: 'mappings[field_attributes][0][type]'
-          select 'Node', from: 'mappings[field_attributes][3][type]'
-          select 'Evidence Field', from: 'mappings[field_attributes][4][type]'
-          select 'Evidence Field', from: 'mappings[field_attributes][5][type]'
-
-          perform_enqueued_jobs do
-            click_button 'Import CSV'
-
-            find('#console .log', wait: 30, match: :first)
-
-            expect(page).to have_text('Worker process completed.')
-
-            expect(Issue.published.count).to eq(1)
-          end
-        end
-      end
-
-      context 'invalid states' do
-        it 'imports the issues as draft' do
-          select 'Issue ID', from: 'mappings[field_attributes][0][type]'
-          select 'Node', from: 'mappings[field_attributes][3][type]'
-          select 'Evidence Field', from: 'mappings[field_attributes][4][type]'
-          select 'Evidence Field', from: 'mappings[field_attributes][5][type]'
-
-          page.execute_script(<<~JS)
-            const select = document.querySelector('#state');
-            select.value = 'tampered_value';
-          JS
-
-          perform_enqueued_jobs do
-            click_button 'Import CSV'
-
-            find('#console .log', wait: 30, match: :first)
-
-            expect(page).to have_text('Worker process completed.')
-
-            expect(Issue.published.count).to eq(0)
-          end
-        end
-      end
-
-      context 'when project does not have RTP' do
-        it 'imports all columns as fields' do
-          select 'Issue ID', from: 'mappings[field_attributes][0][type]'
-          select 'Node', from: 'mappings[field_attributes][3][type]'
-          select 'Evidence Field', from: 'mappings[field_attributes][4][type]'
-          select 'Evidence Field', from: 'mappings[field_attributes][5][type]'
-
-          perform_enqueued_jobs do
-            click_button 'Import CSV'
-
-            find('#console .log', wait: 30, match: :first)
-
-            expect(page).to have_text('Worker process completed.')
-
-            issue = Issue.last
-            expect(issue.fields).to eq({ 'Description' => 'Test CSV', 'Title' => 'SQL Injection', 'VulnerabilityCategory' =>'High', 'plugin' => 'csv', 'plugin_id' => '1' })
-
-            node = issue.affected.first
-            expect(node.label).to eq('10.0.0.1')
-
-            evidence = node.evidence.first
-            expect(evidence.fields).to eq({ 'Label' => '10.0.0.1', 'Title' => 'SQL Injection', 'Location' => '10.0.0.1', 'Port' => '443' })
-
-            expect(Mapping.where(component: 'csv')).to be_empty
-          end
-        end
-      end
-
-      context 'when project have RTP' do
-        before do
-          rtp = create(:report_template_properties, evidence_fields: evidence_fields, issue_fields: issue_fields)
-          @project.update(report_template_properties: rtp)
-
-          page.refresh
-        end
-
-        context 'without fields' do
-          let (:evidence_fields) { [] }
-          let (:issue_fields) { [] }
-
-          it 'creates records with fields from the headers' do
-            select 'Issue ID', from: 'mappings[field_attributes][0][type]'
-            select 'Node', from: 'mappings[field_attributes][3][type]'
-            select 'Evidence Field', from: 'mappings[field_attributes][4][type]'
-            select 'Evidence Field', from: 'mappings[field_attributes][5][type]'
-
-            perform_enqueued_jobs do
-              click_button 'Import CSV'
-
-              find('#console .log', wait: 30, match: :first)
-
-              expect(page).to have_text('Worker process completed.')
-
-              issue = Issue.last
-              expect(issue.fields).to eq({ 'Description' => 'Test CSV', 'Title' => 'SQL Injection', 'Vulnerability Category' =>'High', 'plugin' => 'csv', 'plugin_id' => '1' })
-
-              node = issue.affected.first
-              expect(node.label).to eq('10.0.0.1')
-
-              evidence = node.evidence.first
-              expect(evidence.fields).to eq({ 'Label' => '10.0.0.1', 'Location' => '10.0.0.1', 'Title' => 'SQL Injection', 'Port' => '443' })
-            end
-          end
-        end
-
-        context 'with fields' do
-          let (:evidence_fields) {
-            [
-              { name: 'Location', type: :string, default: true },
-              { name: 'Port', type: :string, default: true}
-            ]
-          }
-
-          let (:issue_fields) {
-            [
-              { name: 'Title', type: :string, default: true },
-              { name: 'Description', type: :string, default: true},
-              { name: 'Severity', type: :string, default: true}
-            ]
-          }
-
-          it 'shows the available fields for the selected type' do
-            select 'Issue Field', from: 'mappings[field_attributes][1][type]'
-
-            issue_fields.each do |field|
-              expect(page).to have_selector('option', text: field[:name])
-            end
-
-            select 'Evidence Field', from: 'mappings[field_attributes][4][type]'
-
-            evidence_fields.each do |field|
-              expect(page).to have_selector('option', text: field[:name])
-            end
-          end
-
-          it 'can select which columns to import' do
-            select 'Issue ID', from: 'mappings[field_attributes][0][type]'
-
-            select 'Issue Field', from: 'mappings[field_attributes][1][type]'
-            select 'Title', from: 'mappings[field_attributes][1][field]'
-
-            select 'Issue Field', from: 'mappings[field_attributes][2][type]'
-            select 'Description', from: 'mappings[field_attributes][2][field]'
-
-            select 'Node', from: 'mappings[field_attributes][3][type]'
-
-            select 'Evidence Field', from: 'mappings[field_attributes][4][type]'
-            select 'Location', from: 'mappings[field_attributes][4][field]'
-
-            select 'Evidence Field', from: 'mappings[field_attributes][5][type]'
-            select 'Port', from: 'mappings[field_attributes][5][field]'
-
-            select 'Issue Field', from: 'mappings[field_attributes][6][type]'
-            select 'Severity', from: 'mappings[field_attributes][6][field]'
-
-            perform_enqueued_jobs do
-              click_button 'Import CSV'
-
-              find('#console .log', wait: 30, match: :first)
-
-              expect(page).to have_text('Worker process completed.')
-
-              issue = Issue.last
-              expect(issue.fields).to eq({ 'Description' => 'Test CSV', 'Title' => 'SQL Injection', 'Severity' => 'High', 'plugin' => 'csv', 'plugin_id' => '1' })
-
-              node = issue.affected.first
-              expect(node.label).to eq('10.0.0.1')
-
-              evidence = node.evidence.first
-              expect(evidence.fields).to eq({ 'Label' => '10.0.0.1', 'Location' => '10.0.0.1', 'Title' => 'SQL Injection', 'Port' => '443' })
-
-              headers = CSV.open(file_path, &:readline)
-              issue_source = Dradis::Plugins::CSV.mapping_source(headers: headers, entity: :issue)
-              evidence_source = Dradis::Plugins::CSV.mapping_source(headers: headers, entity: :evidence)
-              expect(Mapping.where(component: 'csv').pluck(:source)).to match_array([issue_source, evidence_source])
-            end
-          end
-        end
-
-        context 'when no evidence fields' do
-          let (:evidence_fields) { [] }
-          let (:issue_fields) { [] }
-
-          it 'still creates evidence record' do
-            within all('tbody tr')[0] do
-              select 'Issue ID'
-            end
-
-            within all('tbody tr')[1] do
-              select 'Issue Field'
-            end
-
-            within all('tbody tr')[3] do
-              select 'Node'
-            end
-
-            within all('tbody tr')[5] do
-              select 'Issue Field'
-            end
-
-            perform_enqueued_jobs do
-              click_button 'Import CSV'
-
-              find('#console .log', wait: 30, match: :first)
-
-              expect(page).to have_text('Worker process completed.')
-
-              issue = Issue.last
-              expect(issue.fields).to include({ 'Title' => 'SQL Injection', 'plugin' => 'csv', 'plugin_id' => '1' })
-
-              node = issue.affected.first
-              expect(node.label).to eq('10.0.0.1')
-
-              evidence = node.evidence.first
-              expect(evidence.content).to eq('')
-            end
-          end
-        end
-      end
-    end
-  end
-
-  context 'uploading a CSV file with a saved mapping' do
-    let(:file_path) { File.expand_path('../fixtures/files/simple.csv', __dir__) }
-
-    before do
-      rtp = create(
-        :report_template_properties,
-        evidence_fields: [{ name: 'Location', type: :string, default: true }],
-        issue_fields: [{ name: 'Title', type: :string, default: true }]
-      )
-      @project.update(report_template_properties: rtp)
-
-      headers = CSV.open(file_path, &:readline)
-      issue_mapping = Mapping.create!(
-        component: 'csv',
-        source: Dradis::Plugins::CSV.mapping_source(headers: headers, entity: :issue),
-        destination: rtp.as_mapping_destination
-      )
-      issue_mapping.mapping_fields.create!(
-        source_field: 'Id', destination_field: 'plugin_id', content: '{{ csv[Id] }}'
-      )
-      issue_mapping.mapping_fields.create!(
-        source_field: 'Title', destination_field: 'Title', content: '{{ csv[Title] }}'
-      )
-
-      evidence_mapping = Mapping.create!(
-        component: 'csv',
-        source: Dradis::Plugins::CSV.mapping_source(headers: headers, entity: :evidence),
-        destination: rtp.as_mapping_destination
-      )
-      evidence_mapping.mapping_fields.create!(
-        source_field: 'Host', destination_field: 'node_label', content: '{{ csv[Host] }}'
-      )
-      evidence_mapping.mapping_fields.create!(
-        source_field: 'Location', destination_field: 'Location', content: '{{ csv[Location] }}'
-      )
-
-      page.refresh
-
-      find('#uploader + .combobox').click
-      find('#uploader ~ .combobox-menu .combobox-option', text: 'Dradis::Plugins::CSV').click
-    end
-
-    it 'imports immediately using the saved mapping, without showing the mapper' do
-      attach_file 'file', file_path, visible: false, disabled: false
-
-      expect(page).to have_text('CSV imported using its saved mapping', wait: 30)
-      expect(current_path).to eq(main_app.project_upload_manager_path(@project))
-
-      issue = Issue.last
-      expect(issue.fields).to include('Title' => 'SQL Injection', 'plugin' => 'csv', 'plugin_id' => '1')
-
-      node = issue.affected.first
-      expect(node.label).to eq('10.0.0.1')
-
-      evidence = node.evidence.first
-      expect(evidence.fields).to include('Location' => '10.0.0.1')
-    end
-  end
-
-  describe 'CSV file samples' do
-    before do
-      find('#uploader + .combobox').click
-      find('#uploader ~ .combobox-menu .combobox-option', text: 'Dradis::Plugins::CSV').click
-
-      attach_file 'file', file_path, visible: false, disabled: false
-    end
-
-    context 'uploading a malformed CSV file' do
-      let(:file_path) { File.expand_path('../fixtures/files/simple_malformed.csv', __dir__) }
-
-      it 'redirects to upload manager with error' do
-        find('.alert.alert-danger', wait: 30)
-
-        expect(page).to have_text('The uploaded file is not a valid CSV file')
-        expect(current_path).to eq(main_app.project_upload_manager_path(@project))
-      end
-    end
-
-    context 'uploading any file other than CSV' do
-      let(:file_path) { Rails.root.join('spec/fixtures/files/rails.png') }
-
-      it 'redirects to upload manager with error' do
-        find('.alert.alert-danger', wait: 30)
-
-        expect(page).to have_text('The uploaded file is not a CSV file.')
-        expect(current_path).to eq(main_app.project_upload_manager_path(@project))
-      end
-    end
-  end
-end

data/spec/fixtures/files/simple (copy).csv

@@ -1,2 +0,0 @@
-"Id","Title","Description","Host","Location","Port","Vulnerability Category"
-"1","SQL Injection","Test CSV","10.0.0.1","10.0.0.1","443","High"

data/spec/fixtures/files/simple.csv

@@ -1,2 +0,0 @@
-"Id","Title","Description","Host","Location","Port","Vulnerability Category"
-"1","SQL Injection","Test CSV","10.0.0.1","10.0.0.1","443","High"

data/spec/fixtures/files/simple_malformed.csv

@@ -1,2 +0,0 @@
-"Id";"Title";"Description";"Host";"Location";"Port"
-"1";"SQL Injection";"Test CSV";"10.0.0.1";"10.0.0.1";"443"

data/spec/jobs/dradis/plugins/csv/mapping_import_job_spec.rb

@@ -1,32 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Dradis::Plugins::CSV::MappingImportJob do
-  let(:file) { File.expand_path('../../../.../../../fixtures/files/simple.csv', __dir__) }
-
-  let(:perform_job) do
-    described_class.new.perform(
-      default_user_id: create(:user).id,
-      file: file,
-      headers: CSV.open(file, &:readline),
-      mappings: {},
-      project_id: create(:project).id,
-      state: 'draft',
-      uid: 1
-    )
-  end
-
-  describe '#perform' do
-    it 'calls Importer#import_rows' do
-      dbl = double('Importer')
-      allow(Dradis::Plugins::CSV::Importer).to receive(:new).and_return(dbl)
-      expect(dbl).to receive(:import_rows).and_return(true)
-
-      perform_job
-    end
-
-    it 'writes a known final line in the log' do
-      perform_job
-      expect(Log.last.text).to eq 'Worker process completed.'
-    end
-  end
-end

data/spec/lib/dradis/plugins/csv/importer_spec.rb

@@ -1,223 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Dradis::Plugins::CSV::Importer do
-  let(:file) { File.expand_path('../../../.../../../fixtures/files/simple.csv', __dir__) }
-  let(:headers) { CSV.open(file, &:readline) }
-  let(:project) { create(:project) }
-
-  let(:instance) do
-    described_class.new(
-      default_user_id: create(:user).id,
-      logger: Log.new(uid: 1),
-      plugin: Dradis::Plugins::CSV,
-      project_id: project.id
-    )
-  end
-
-  let(:import_rows) do
-    instance.import_rows(file: file, headers: headers, mappings: mappings)
-  end
-
-  describe '#import_rows' do
-    context 'when project has RTP' do
-      let(:mappings) do
-        {
-          '0' => { 'type' => 'identifier' },
-          '1' => { 'type' => 'issue', 'field' => 'MyTitle' },
-          '3' => { 'type' => 'node', 'field' => '' },
-          '4' => { 'type' => 'evidence', 'field' => 'MyLocation' },
-          '5' => { 'type' => 'evidence', 'field' => '' }
-        }
-      end
-
-      before do
-        project.update(report_template_properties: create(:report_template_properties))
-      end
-
-      it 'uses the field as Dradis Field' do
-        import_rows
-
-        issue = Issue.first
-        expect(issue.fields).to eq({ 'MyTitle' => 'SQL Injection', 'plugin' => 'csv', 'plugin_id' => '1' })
-
-        node = issue.affected.first
-        expect(node.label).to eq('10.0.0.1')
-
-        evidence = node.evidence.first
-        expect(evidence.fields).to eq({ 'Label' => '10.0.0.1', 'Title' => '(No #[Title]# field)', 'MyLocation' => '10.0.0.1' })
-      end
-    end
-
-    context 'when project does not have RTP' do
-      let(:mappings) do
-        {
-          '0' => { 'type' => 'identifier' },
-          '1' => { 'type' => 'issue', 'field' => 'MyTitle' },
-          '3' => { 'type' => 'node', 'field' => '' },
-          '4' => { 'type' => 'evidence', 'field' => 'MyLocation' },
-          '5' => { 'type' => 'evidence', 'field' => '' },
-          '6' => { 'type' => 'issue', 'field' => '' }
-        }
-      end
-
-      it 'uses the column name as Dradis Field' do
-        import_rows
-
-        issue = Issue.first
-        expect(issue.fields).to eq({ 'Title' => 'SQL Injection', 'VulnerabilityCategory' => 'High', 'plugin' => 'csv', 'plugin_id' => '1' })
-
-        node = issue.affected.first
-        expect(node.label).to eq('10.0.0.1')
-
-        evidence = node.evidence.first
-        expect(evidence.fields).to eq({ 'Label' => '10.0.0.1', 'Location' => '10.0.0.1', 'Port' => '443', 'Title' => 'SQL Injection' })
-      end
-
-      it 'strips out whitespace from column header' do
-        import_rows
-
-        issue = Issue.first
-        expect(issue.fields.keys).to include('VulnerabilityCategory')
-      end
-    end
-
-    context 'when mapping does not have a node type' do
-      let(:mappings) do
-        {
-          '0' => { 'type' => 'identifier' },
-          '1' => { 'type' => 'issue' },
-          '4' => { 'type' => 'evidence' }
-        }
-      end
-
-      it 'does not create node and evidence' do
-        import_rows
-
-        issue = Issue.last
-        expect(issue.affected.length).to eq(0)
-        expect(issue.evidence.length).to eq(0)
-      end
-    end
-
-    context 'when no identifier is passed in' do
-      let(:mappings) do
-        {
-          '1' => { 'type' => 'issue' },
-          '4' => { 'type' => 'evidence' }
-        }
-      end
-
-      it 'uses filename and row index as csv_id' do
-        import_rows
-
-        issue = Issue.last
-        expect(issue.fields).to eq({ 'Title' => 'SQL Injection', 'plugin' => 'csv', 'plugin_id' => 'simple.csv-0' })
-      end
-    end
-
-    context 'when no evidence fields' do
-      let(:mappings) do
-        {
-          '0' => { 'type' => 'identifier' },
-          '1' => { 'type' => 'issue', 'field' => 'MyTitle' },
-          '3' => { 'type' => 'node', 'field' => '' }
-        }
-      end
-
-      it 'still creates evidence record' do
-        import_rows
-
-        issue = Issue.first
-        expect(issue.fields).to eq({ 'Title' => 'SQL Injection', 'plugin' => 'csv', 'plugin_id' => '1' })
-
-        node = issue.affected.first
-        expect(node.label).to eq('10.0.0.1')
-
-        evidence = node.evidence.first
-        expect(evidence.content).to eq('')
-      end
-    end
-  end
-
-  describe '#import' do
-    context 'when the project has no RTP' do
-      it 'does not import anything' do
-        expect(instance.import(file: file)).to eq(false)
-        expect(Issue.count).to eq(0)
-      end
-    end
-
-    context 'when the project has RTP but no saved mapping' do
-      before do
-        project.update(report_template_properties: create(:report_template_properties))
-      end
-
-      it 'does not import anything' do
-        expect(instance.import(file: file)).to eq(false)
-        expect(Issue.count).to eq(0)
-      end
-    end
-
-    context 'when a saved mapping exists for these headers' do
-      let(:rtp) { create(:report_template_properties) }
-
-      before do
-        project.update(report_template_properties: rtp)
-
-        issue_mapping = Mapping.create!(
-          component: 'csv',
-          source: Dradis::Plugins::CSV.mapping_source(headers: headers, entity: :issue),
-          destination: rtp.as_mapping_destination
-        )
-        issue_mapping.mapping_fields.create!(
-          source_field: 'Id', destination_field: 'plugin_id', content: '{{ csv[Id] }}'
-        )
-        issue_mapping.mapping_fields.create!(
-          source_field: 'Title', destination_field: 'Title', content: '{{ csv[Title] }}'
-        )
-
-        evidence_mapping = Mapping.create!(
-          component: 'csv',
-          source: Dradis::Plugins::CSV.mapping_source(headers: headers, entity: :evidence),
-          destination: rtp.as_mapping_destination
-        )
-        evidence_mapping.mapping_fields.create!(
-          source_field: 'Host', destination_field: 'node_label', content: '{{ csv[Host] }}'
-        )
-        evidence_mapping.mapping_fields.create!(
-          source_field: 'Location', destination_field: 'Location', content: '{{ csv[Location] }}'
-        )
-      end
-
-      it 'imports using the saved mapping' do
-        expect(instance.import(file: file)).to eq(true)
-
-        issue = Issue.last
-        expect(issue.fields).to include('Title' => 'SQL Injection', 'plugin_id' => '1')
-
-        node = issue.affected.first
-        expect(node.label).to eq('10.0.0.1')
-
-        evidence = node.evidence.first
-        expect(evidence.fields).to include('Location' => '10.0.0.1')
-      end
-    end
-  end
-
-  describe '.templates' do
-    let(:rtp) { create(:report_template_properties) }
-    let(:issue_source) { Dradis::Plugins::CSV.mapping_source(headers: headers, entity: :issue) }
-    let(:evidence_source) { Dradis::Plugins::CSV.mapping_source(headers: headers, entity: :evidence) }
-
-    before do
-      Mapping.create!(component: 'csv', source: issue_source, destination: rtp.as_mapping_destination)
-      Mapping.create!(component: 'csv', source: evidence_source, destination: rtp.as_mapping_destination)
-    end
-
-    it 'groups the currently known sources by entity' do
-      expect(described_class.templates).to eq(
-        issue: [issue_source], evidence: [evidence_source]
-      )
-    end
-  end
-end

data/spec/lib/dradis/plugins/csv/mapping_form_spec.rb

@@ -1,139 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Dradis::Plugins::CSV::MappingForm do
-  let(:headers) { ['Id', 'Title', 'Host', 'Vulnerability Category'] }
-  let(:destination) { 'rtp_1' }
-  let(:rtp_fields) { { issue: ['Title'], evidence: ['Rating'] } }
-  let(:column_mappings) do
-    {
-      '0' => { 'type' => 'identifier' },
-      '1' => { 'type' => 'issue', 'field' => 'Title' },
-      '2' => { 'type' => 'node', 'field' => '' },
-      '3' => { 'type' => 'evidence', 'field' => 'Rating' }
-    }
-  end
-
-  let(:issue_source) do
-    Dradis::Plugins::CSV.mapping_source(headers: headers, entity: :issue)
-  end
-  let(:evidence_source) do
-    Dradis::Plugins::CSV.mapping_source(headers: headers, entity: :evidence)
-  end
-
-  subject(:form) do
-    described_class.new(destination: destination, headers: headers, rtp_fields: rtp_fields)
-  end
-
-  let(:save) { form.save(column_mappings: column_mappings) }
-
-  describe '#save' do
-    it 'creates one mapping per entity with normalized source fields' do
-      expect { save }.to change { Mapping.count }.by(2)
-
-      issue_mapping = Mapping.find_by(
-        component: 'csv', source: issue_source, destination: destination
-      )
-      expect(issue_mapping.mapping_fields.pluck(:destination_field, :source_field, :content)).to match_array([
-        ['plugin_id', 'Id', '{{ csv[Id] }}'],
-        ['Title', 'Title', '{{ csv[Title] }}']
-      ])
-
-      evidence_mapping = Mapping.find_by(
-        component: 'csv', source: evidence_source, destination: destination
-      )
-      expect(evidence_mapping.mapping_fields.pluck(:destination_field, :source_field, :content)).to match_array([
-        ['node_label', 'Host', '{{ csv[Host] }}'],
-        ['Rating', 'VulnerabilityCategory', '{{ csv[VulnerabilityCategory] }}']
-      ])
-    end
-
-    context 'without a destination' do
-      let(:destination) { nil }
-
-      it 'does not create any mappings' do
-        expect { save }.not_to change { Mapping.count }
-      end
-    end
-
-    context 'when only skipped or blank columns are assigned to an entity' do
-      let(:column_mappings) do
-        {
-          '0' => { 'type' => 'identifier' },
-          '1' => { 'type' => 'issue', 'field' => '' },
-          '3' => { 'type' => 'skip' }
-        }
-      end
-
-      it 'only stores the fields with a destination' do
-        expect { save }.to change { Mapping.count }.by(1)
-
-        issue_mapping = Mapping.find_by(
-          component: 'csv', source: issue_source, destination: destination
-        )
-        expect(issue_mapping.mapping_fields.pluck(:destination_field)).to eq(['plugin_id'])
-      end
-    end
-
-    context 'when the RTP has no fields defined for an entity' do
-      let(:rtp_fields) { { issue: ['Title'], evidence: [] } }
-
-      it 'does not create a mapping for that entity, even for its identifier/node column' do
-        expect { save }.to change { Mapping.count }.by(1)
-
-        expect(Mapping.find_by(source: evidence_source)).to be_nil
-
-        issue_mapping = Mapping.find_by(
-          component: 'csv', source: issue_source, destination: destination
-        )
-        expect(issue_mapping.mapping_fields.pluck(:destination_field)).to match_array(['plugin_id', 'Title'])
-      end
-    end
-
-    context 'when the RTP has no fields defined for either entity' do
-      let(:rtp_fields) { { issue: [], evidence: [] } }
-
-      it 'does not create any mappings' do
-        expect { save }.not_to change { Mapping.count }
-      end
-    end
-
-    context 'when a column is assigned to a custom field' do
-      let(:column_mappings) do
-        {
-          '0' => { 'type' => 'identifier' },
-          '1' => { 'type' => 'issue', 'field' => 'Custom Field', 'custom_field' => 'CVSS Score' },
-          '2' => { 'type' => 'node', 'field' => '' },
-          '3' => { 'type' => 'evidence', 'field' => 'Rating' }
-        }
-      end
-
-      it 'stores the typed-in name as the destination field' do
-        save
-
-        issue_mapping = Mapping.find_by(
-          component: 'csv', source: issue_source, destination: destination
-        )
-        expect(issue_mapping.mapping_fields.pluck(:destination_field)).to match_array(['plugin_id', 'CVSS Score'])
-      end
-
-      context 'when no custom field name is provided' do
-        let(:column_mappings) do
-          {
-            '0' => { 'type' => 'identifier' },
-            '1' => { 'type' => 'issue', 'field' => 'Custom Field', 'custom_field' => '' },
-            '3' => { 'type' => 'skip' }
-          }
-        end
-
-        it 'does not store a field for that column' do
-          save
-
-          issue_mapping = Mapping.find_by(
-            component: 'csv', source: issue_source, destination: destination
-          )
-          expect(issue_mapping.mapping_fields.pluck(:destination_field)).to eq(['plugin_id'])
-        end
-      end
-    end
-  end
-end