dradis-coreimpact 4.10.0 → 4.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f2684cc69ebcdf43db4aac8fb9a2082c1ee52375bf209c277e5e5821dd3bf3a4
-  data.tar.gz: abb7c74ed576b2af6b59289a68aff0e6fd5db3b70d8345f4f8b01da80c3443d8
+  metadata.gz: 383860c5e3bf9433426b6a0e87325211d5b4aa298ca37abf1b0fc5386c3e28a3
+  data.tar.gz: a8854fc5cb6a7ff08b704a1b48856ec976307dc4bfc9c2fb61ad7052a5186078
 SHA512:
-  metadata.gz: dcfd452f365c6087731ba88d4e51313c8ea08124d9cc8ca453aa05f36d3ff0c3542557ae44314fb85160e860f0e6bba1d11008fbc31f6e9396a9f3f64b87b607
-  data.tar.gz: 513f90456c0f15ada2598b2c02fe76fe8de5b0a543b3646601b38a9bb293b9ef888e97c6a4fb07f8a1ca4bb9384e44e20d2d48cdcd52327ce8f1d8a80f50d25e
+  metadata.gz: 722fa23de92d106a7228ad8d81a737ff1e1f28e6977d7a29293d80b63d2baca12c4360ccd425be4581fcd3ea3db95fea4339d65cad05e85f1a77b6dc947a1c10
+  data.tar.gz: 873d0c0d8903aaa319411aa93ba0e3cbabda8f462737c45fa8c089ef89a4021ffddcb6c0aff207ef1aaf6935481ff952ba0064de534a52a5bca96d2fd20ed842

data/.github/pull_request_template.md

@@ -1,3 +1,5 @@
+Please review [CONTRIBUTING.md](https://github.com/dradis/dradis-ce/blob/develop/CONTRIBUTING.md) and remove this line.
+
 ### Summary
 
 Provide a general description of the code changes in your pull
@@ -6,6 +8,11 @@ these bugs have open GitHub issues, be sure to tag them here as well,
 to keep the conversation linked together.
 
 
+### Testing Steps
+
+Provide steps to test functionality, described in detail for someone not familiar with this part of the application / code base
+
+
 ### Other Information
 
 If there's anything else that's important and relevant to your pull
@@ -26,11 +33,13 @@ products, we must have the copyright associated with the entire
 codebase. Any code you create which is merged must be owned by us.
 That's not us trying to be a jerks, that's just the way it works.
 
-Please review the [CONTRIBUTING.md](https://github.com/dradis/dradis-ce/blob/master/CONTRIBUTING.md)
-file for the details.
-
 You can delete this section, but the following sentence needs to
 remain in the PR's description:
 
 > I assign all rights, including copyright, to any future Dradis
 > work by myself to Security Roots.
+
+### Check List
+
+- [ ] Added a CHANGELOG entry
+- [ ] Added specs

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+v4.12.0 (May 2024)
+ - Migrate integration to use Mappings Manager
+ - Update Dradis links in README
+
+v4.11.0 (January 2024)
+  - No changes
+
 v4.10.0 (September 2023)
   - Update gemspec links
 

data/README.md

@@ -4,17 +4,16 @@
 
 Upload [CORE Impact](https://www.coresecurity.com/core-impact/) XML output into Dradis.
 
-The add-on requires [Dradis CE](https://dradisframework.com/ce/) > 3.0, or [Dradis Pro](https://dradisframework.com/pro/).
-
+The add-on requires [Dradis CE](https://dradis.com/ce/) > 3.0, or [Dradis Pro](https://dradis.com/).
 
 ## More information
 
-See the Dradis Framework's [README.md](https://github.com/dradis/dradisframework/blob/master/README.md)
+See the Dradis Framework's [README.md](https://github.com/dradis/dradis-ce/blob/develop/README.md)
 
 
 ## Contributing
 
-See the Dradis Framework's [CONTRIBUTING.md](https://github.com/dradis/dradisframework/blob/master/CONTRIBUTING.md)
+See the Dradis Framework's [CONTRIBUTING.md](https://github.com/dradis/dradis-ce/blob/develop/CONTRIBUTING.md)
 
 
 ## License

data/lib/dradis/plugins/coreimpact/gem_version.rb

@@ -8,7 +8,7 @@ module Dradis
 
       module VERSION
         MAJOR = 4
-        MINOR = 10
+        MINOR = 12
         TINY = 0
         PRE = nil
 

data/lib/dradis/plugins/coreimpact/importer.rb

@@ -94,13 +94,13 @@ module Dradis::Plugins::Coreimpact
     def add_vulnerability(xml_container, node)
       plugin_id = xml_container.at_xpath('./property[@type="container"]')['key']
 
-      issue_text = template_service.process_template(data: xml_container, template: 'issue')
+      issue_text = mapping_service.apply_mapping(source: 'issue', data: xml_container)
       issue = content_service.create_issue(id: plugin_id, text: issue_text)
       logger.info{ "\tCreating new issue (plugin_id: #{plugin_id})"}
 
-      evidence_content = template_service.process_template(
-        data: xml_container.at_xpath('./property[@type="container"]/property[@key="Modules"]'),
-        template: 'evidence'
+      evidence_content = mapping_service.apply_mapping(
+        source: 'evidence',
+        data: xml_container.at_xpath('./property[@type="container"]/property[@key="Modules"]')
       )
       content_service.create_evidence(content: evidence_content, issue: issue, node: node)
       logger.info{ "\t\tAdding reference to this host"}

data/lib/dradis/plugins/coreimpact/mapping.rb

@@ -0,0 +1,37 @@
+module Dradis::Plugins::Coreimpact
+  module Mapping
+    DEFAULT_MAPPING = {
+      evidence: {
+        'AgentDeployed' => '{{ coreimpact[evidence.agent_deployed] }}',
+        'Description' => '{{ coreimpact[evidence.description] }}',
+        'Port' => '{{ coreimpact[evidence.port] }}',
+        'TriedToInstallAgent' => '{{ coreimpact[evidence.tried_to_install_agent] }}'
+      },
+      issue: {
+        'Title' => '{{ coreimpact[issue.title] }}',
+        'AgentDeployed' => '{{ coreimpact[issue.agent_deployed] }}',
+        'CVE' => '{{ coreimpact[issue.cve] }}',
+        'Description' => '{{ coreimpact[issue.description] }}',
+        'Port' => '{{ coreimpact[issue.port] }}',
+        'TriedToInstallAgent' => '{{ coreimpact[issue.tried_to_install_agent] }}'
+      }
+    }.freeze
+
+    SOURCE_FIELDS = {
+      evidence: [
+        'evidence.agent_deployed',
+        'evidence.description',
+        'evidence.tried_to_install_agent',
+        'evidence.port'
+      ],
+      issue: [
+        'issue.title',
+        'issue.agent_deployed',
+        'issue.cve',
+        'issue.description',
+        'issue.port',
+        'issue.tried_to_install_agent'
+      ]
+    }.freeze
+  end
+end

data/lib/dradis/plugins/coreimpact.rb

@@ -7,5 +7,6 @@ end
 
 require 'dradis/plugins/coreimpact/engine'
 require 'dradis/plugins/coreimpact/field_processor'
+require 'dradis/plugins/coreimpact/mapping'
 require 'dradis/plugins/coreimpact/importer'
 require 'dradis/plugins/coreimpact/version'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dradis-coreimpact
 version: !ruby/object:Gem::Version
-  version: 4.10.0
+  version: 4.12.0
 platform: ruby
 authors:
 - Daniel Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-09-07 00:00:00.000000000 Z
+date: 2024-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dradis-plugins
@@ -107,18 +107,15 @@ files:
 - lib/dradis/plugins/coreimpact/field_processor.rb
 - lib/dradis/plugins/coreimpact/gem_version.rb
 - lib/dradis/plugins/coreimpact/importer.rb
+- lib/dradis/plugins/coreimpact/mapping.rb
 - lib/dradis/plugins/coreimpact/version.rb
 - lib/tasks/thorfile.rb
 - spec/coreimpact/importer_spec.rb
 - spec/coreimpact_upload_spec.rb
 - spec/fixtures/files/example.xml
 - spec/spec_helper.rb
-- templates/evidence.fields
 - templates/evidence.sample
-- templates/evidence.template
-- templates/issue.fields
 - templates/issue.sample
-- templates/issue.template
 homepage: https://dradis.com/integrations/coreimpact.html
 licenses:
 - GPL-2

data/templates/evidence.fields

@@ -1,4 +0,0 @@
-evidence.agent_deployed
-evidence.description
-evidence.tried_to_install_agent
-evidence.port

data/templates/evidence.template

@@ -1,11 +0,0 @@
-#[AgentDeployed]#
-%evidence.agent_deployed%
-
-#[Description]#
-%evidence.description%
-
-#[Port]#
-%evidence.port%
-
-#[TriedToInstallAgent]#
-%evidence.tried_to_install_agent%

data/templates/issue.fields

@@ -1,6 +0,0 @@
-issue.title
-issue.agent_deployed
-issue.cve
-issue.description
-issue.port
-issue.tried_to_install_agent

data/templates/issue.template

@@ -1,17 +0,0 @@
-#[Title]#
-%issue.title%
-
-#[AgentDeployed]#
-%issue.agent_deployed%
-
-#[CVE]#
-%issue.cve%
-
-#[Description]#
-%issue.description%
-
-#[Port]#
-%issue.port%
-
-#[TriedToInstallAgent]#
-%issue.tried_to_install_agent%