dpl-firebase 1.10.1.travis.2932.6 → 1.10.1.travis.2947.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88d95432b6f8401f8b2ecc532f1a1781b630ff253797943ca03d21eb89820f1e
-  data.tar.gz: 31f58bdea306a0b767feab846f65677c7563dcf68d49e7374599c51ff2b817ab
+  metadata.gz: e3032c60f1b02211f0e79e2cb6370bd2889bc1d78e6f9aa8e164284b4f827b27
+  data.tar.gz: d31bea446df9351a75cf8eaa9b2644c795bf6595901e3cf0947ddcbdf90d853e
 SHA512:
-  metadata.gz: 01f1952dc370e18e3d8909469920cd353c0b70697d6676730aa94f98c1c96c9fedd7947ec2cef0854de8d7177e3d307427793646c1d5dc628e08c132fbd9824a
-  data.tar.gz: cab758d2aeaf9022f6e4be1dd02965e936f3c9c6c731b0129779568a1a6b554dca42820a45f8d7e1a90c29a0742e3686758966a043a5288b062d89959e435ec1
+  metadata.gz: 25ab585f2d2a43d32d3dcbec917035c7ebd6c97d2c032c1009077124137cc323b9ad5be76e64e02b82fd0938b5b1eecc84279f9c956f590a884e8d23283cf568
+  data.tar.gz: a36f62e2442ef0efb1b86e2d4ed2f05001bbec2748fdd9b1371bf74f7ea157823f36d0530682cc360dbda192406e06fd58685eea4be4bf3d1038a24b70dc8344

data/lib/dpl/provider/firebase.rb

@@ -20,7 +20,7 @@ module DPL
         command << " --project #{options[:project]}" if options[:project]
         command << " --message '#{options[:message]}'" if options[:message]
         command << " --token '#{options[:token]}'" if options[:token]
-        context.shell command
+        context.shell command or raise Error, "Firebase deployment failed"
       end
     end
   end

data/spec/provider/firebase_spec.rb

@@ -22,19 +22,26 @@ describe DPL::Provider::Firebase do
   describe "#push_app" do
     it 'should include the project specified' do
       provider.options.update(:project => 'myapp-dev')
-      expect(provider.context).to receive(:shell).with("firebase deploy --non-interactive --project myapp-dev --token 'abc123'")
+      expect(provider.context).to receive(:shell).with("firebase deploy --non-interactive --project myapp-dev --token 'abc123'").and_return(true)
       provider.push_app
     end
 
     it 'should include the message specified' do
       provider.options.update(:message => 'test message')
-      expect(provider.context).to receive(:shell).with("firebase deploy --non-interactive --message 'test message' --token 'abc123'")
+      expect(provider.context).to receive(:shell).with("firebase deploy --non-interactive --message 'test message' --token 'abc123'").and_return(true)
       provider.push_app
     end
 
     it 'should default to no project override' do
-      expect(provider.context).to receive(:shell).with("firebase deploy --non-interactive --token 'abc123'")
+      expect(provider.context).to receive(:shell).with("firebase deploy --non-interactive --token 'abc123'").and_return(true)
       provider.push_app
     end
+
+    it 'should report an error when deployment fails' do
+      expect(provider.context).to receive(:shell).with("firebase deploy --non-interactive --token 'abc123'").and_return(false)
+      expect {
+        provider.push_app
+      }.to raise_error(DPL::Error)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dpl-firebase
 version: !ruby/object:Gem::Version
-  version: 1.10.1.travis.2932.6
+  version: 1.10.1.travis.2947.6
 platform: ruby
 authors:
 - Konstantin Haase
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-17 00:00:00.000000000 Z
+date: 2018-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dpl
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.10.1.travis.2932.6
+        version: 1.10.1.travis.2947.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.10.1.travis.2932.6
+        version: 1.10.1.travis.2947.6
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement