dpickett-thinking-sphinx 1.1.12 → 1.1.23

data/spec/unit/thinking_sphinx/facet_spec.rb

@@ -43,4 +43,260 @@ describe ThinkingSphinx::Facet do
       ThinkingSphinx::Facet.attribute_name_for(ThinkingSphinx::Facet.name_for('attribute_facet')).should == 'attribute_facet'
     end
   end
+  
+  describe ".attribute_name_from_value" do
+    it "should append _facet if the value is a string" do
+      ThinkingSphinx::Facet.attribute_name_from_value('attribute', 'string').
+        should == 'attribute_facet'
+    end
+    
+    it "should not append _facet if the value isn't a string" do
+      ThinkingSphinx::Facet.attribute_name_from_value('attribute', 1).
+        should == 'attribute'
+      ThinkingSphinx::Facet.attribute_name_from_value('attribute', Time.now).
+        should == 'attribute'
+      ThinkingSphinx::Facet.attribute_name_from_value('attribute', true).
+        should == 'attribute'
+      ThinkingSphinx::Facet.attribute_name_from_value('attribute', 1.23).
+        should == 'attribute'
+    end
+    
+    it "should append _facet is the value is an array of strings" do
+      ThinkingSphinx::Facet.attribute_name_from_value('attribute', ['a', 'b']).
+        should == 'attribute_facet'
+    end
+    
+    it "should not append _facet if the value is an array of integers" do
+      ThinkingSphinx::Facet.attribute_name_from_value('attribute', [1, 2]).
+        should == 'attribute'
+    end
+  end
+  
+  describe ".translate?" do
+    before :each do
+      @index     = ThinkingSphinx::Index.new(Alpha)
+      @source    = ThinkingSphinx::Source.new(@index)
+      @attribute = ThinkingSphinx::Attribute.new(
+        @source, ThinkingSphinx::Index::FauxColumn.new(:name)
+      )
+    end
+    
+    it "should return true if the property is a field" do
+      field = ThinkingSphinx::Field.new(
+        @source, ThinkingSphinx::Index::FauxColumn.new(:name)
+      )
+      
+      ThinkingSphinx::Facet.translate?(field).should be_true
+    end
+    
+    it "should return true if the property is a string attribute" do
+      @attribute.stub_method(:type => :string)
+      
+      ThinkingSphinx::Facet.translate?(@attribute).should be_true
+    end
+    
+    it "should return false if the property is an integer attribute" do
+      @attribute.stub_method(:type => :integer)
+      
+      ThinkingSphinx::Facet.translate?(@attribute).should be_false
+    end
+    
+    it "should return false if the property is a boolean attribute" do
+      @attribute.stub_method(:type => :boolean)
+      
+      ThinkingSphinx::Facet.translate?(@attribute).should be_false
+    end
+    
+    it "should return false if the property is a timestamp attribute" do
+      @attribute.stub_method(:type => :datetime)
+      
+      ThinkingSphinx::Facet.translate?(@attribute).should be_false
+    end
+    
+    it "should return false if the property is a float attribute" do
+      @attribute.stub_method(:type => :float)
+      
+      ThinkingSphinx::Facet.translate?(@attribute).should be_false
+    end
+    
+    it "should return false if the property is an MVA of integer values" do
+      @attribute.stub_method(:type => :multi, :all_ints? => true)
+      
+      ThinkingSphinx::Facet.translate?(@attribute).should be_false
+    end
+    
+    it "should return true if the property is an MVA of string values" do
+      @attribute.stub_method(:type => :multi, :all_ints? => false)
+      
+      ThinkingSphinx::Facet.translate?(@attribute).should be_true
+    end
+  end
+  
+  describe "#translate?" do
+    before :each do
+      @index     = ThinkingSphinx::Index.new(Alpha)
+      @source    = ThinkingSphinx::Source.new(@index)
+      @attribute = ThinkingSphinx::Attribute.new(
+        @source, ThinkingSphinx::Index::FauxColumn.new(:name)
+      )
+    end
+    
+    it "should return true if the property is a field" do
+      field = ThinkingSphinx::Field.new(
+        @source, ThinkingSphinx::Index::FauxColumn.new(:name)
+      )
+      
+      ThinkingSphinx::Facet.new(field).translate?.should be_true
+    end
+    
+    it "should return true if the property is a string attribute" do
+      @attribute.stub_method(:type => :string)
+      
+      ThinkingSphinx::Facet.new(@attribute).translate?.should be_true
+    end
+    
+    it "should return false if the property is an integer attribute" do
+      @attribute.stub_method(:type => :integer)
+      
+      ThinkingSphinx::Facet.new(@attribute).translate?.should be_false
+    end
+    
+    it "should return false if the property is a boolean attribute" do
+      @attribute.stub_method(:type => :boolean)
+      
+      ThinkingSphinx::Facet.new(@attribute).translate?.should be_false
+    end
+    
+    it "should return false if the property is a timestamp attribute" do
+      @attribute.stub_method(:type => :datetime)
+      
+      ThinkingSphinx::Facet.new(@attribute).translate?.should be_false
+    end
+    
+    it "should return false if the property is a float attribute" do
+      @attribute.stub_method(:type => :float)
+      
+      ThinkingSphinx::Facet.new(@attribute).translate?.should be_false
+    end
+    
+    it "should return false if the property is an MVA of integer values" do
+      @attribute.stub_method(:type => :multi, :all_ints? => true)
+      
+      ThinkingSphinx::Facet.new(@attribute).translate?.should be_false
+    end
+    
+    it "should return true if the property is an MVA of string values" do
+      @attribute.stub_method(:type => :multi, :all_ints? => false)
+      
+      ThinkingSphinx::Facet.new(@attribute).translate?.should be_true
+    end
+  end
+  
+  describe "#attribute_name" do
+    before :each do
+      @index     = ThinkingSphinx::Index.new(Alpha)
+      @source    = ThinkingSphinx::Source.new(@index)
+      @attribute = ThinkingSphinx::Attribute.new(
+        @source, ThinkingSphinx::Index::FauxColumn.new(:name)
+      )
+    end
+    
+    it "should return the attribute name if built off an integer attribute" do
+      @attribute.stub_method(:type => :integer)
+      
+      ThinkingSphinx::Facet.new(@attribute).attribute_name.should == "name"
+    end
+    
+    it "should return the attribute name if built off a boolean attribute" do
+      @attribute.stub_method(:type => :boolean)
+      
+      ThinkingSphinx::Facet.new(@attribute).attribute_name.should == "name"
+    end
+    
+    it "should return the attribute name if built off a float attribute" do
+      @attribute.stub_method(:type => :float)
+      
+      ThinkingSphinx::Facet.new(@attribute).attribute_name.should == "name"
+    end
+    
+    it "should return the attribute name if built off a timestamp attribute" do
+      @attribute.stub_method(:type => :datetime)
+      
+      ThinkingSphinx::Facet.new(@attribute).attribute_name.should == "name"
+    end
+    
+    it "should return the attribute name with _facet suffix if built off a string attribute" do
+      @attribute.stub_method(:type => :string)
+      
+      ThinkingSphinx::Facet.new(@attribute).attribute_name.should == "name_facet"
+    end
+    
+    it "should return the attribute name with _facet suffix if built off a field" do
+      field = ThinkingSphinx::Field.new(
+        @source, ThinkingSphinx::Index::FauxColumn.new(:name)
+      )
+      
+      ThinkingSphinx::Facet.new(field).attribute_name.should == "name_facet"
+    end
+    
+    it "should return the attribute name if build off an integer MVA" do
+      @attribute.stub_method(:type => :multi, :all_ints? => true)
+      
+      ThinkingSphinx::Facet.new(@attribute).attribute_name.should == "name"
+    end
+    
+    it "should return the attribute name with the _facet suffix if build off an non-integer MVA" do
+      @attribute.stub_method(:type => :multi, :all_ints? => false)
+      
+      ThinkingSphinx::Facet.new(@attribute).attribute_name.should == "name_facet"
+    end
+  end
+  
+  describe "#type" do
+    before :each do
+      @index     = ThinkingSphinx::Index.new(Alpha)
+      @source    = ThinkingSphinx::Source.new(@index)
+    end
+    
+    it "should return :string if the property is a field" do
+      field = ThinkingSphinx::Field.new(
+        @source, ThinkingSphinx::Index::FauxColumn.new(:name)
+      )
+      
+      ThinkingSphinx::Facet.new(field).type.should == :string
+    end
+    
+    it "should return the attribute type if the property is an attribute" do
+      attribute = ThinkingSphinx::Attribute.new(
+        @source, ThinkingSphinx::Index::FauxColumn.new(:name)
+      )
+      attribute.stub_method(:type => :anything)
+      
+      ThinkingSphinx::Facet.new(attribute).type.should == :anything
+    end
+  end
+  
+  describe "#value" do
+    before :each do
+      @index  = ThinkingSphinx::Index.new(Friendship)
+      @source = ThinkingSphinx::Source.new(@index)
+      @field  = ThinkingSphinx::Field.new(
+        @source, ThinkingSphinx::Index::FauxColumn.new(:person, :first_name)
+      )
+      @facet  = ThinkingSphinx::Facet.new(@field)
+    end
+    
+    it "should return association values" do
+      person      = Person.find(:first)
+      friendship  = Friendship.new(:person => person)
+      
+      @facet.value(friendship, 1).should == person.first_name
+    end
+    
+    it "should return nil if the association is nil" do
+      friendship = Friendship.new(:person => nil)
+      
+      @facet.value(friendship, 1).should be_nil
+    end
+  end
 end

data/spec/unit/thinking_sphinx/field_spec.rb

@@ -1,23 +1,28 @@
 require 'spec/spec_helper'
 
 describe ThinkingSphinx::Field do
+  before :each do
+    @index     = ThinkingSphinx::Index.new(Alpha)
+    @source    = ThinkingSphinx::Source.new(@index)
+  end
+  
   describe '#initialize' do
     it 'raises if no columns are provided so that configuration errors are easier to track down' do
       lambda {
-        ThinkingSphinx::Field.new([])
+        ThinkingSphinx::Field.new(@source, [])
       }.should raise_error(RuntimeError)
     end
 
     it 'raises if an element of the columns param is an integer - as happens when you use id instead of :id - so that configuration errors are easier to track down' do
       lambda {
-        ThinkingSphinx::Field.new([1234])
+        ThinkingSphinx::Field.new(@source, [1234])
       }.should raise_error(RuntimeError)
     end
   end
   
   describe "unique_name method" do
     before :each do
-      @field = ThinkingSphinx::Field.new [
+      @field = ThinkingSphinx::Field.new @source, [
         Object.stub_instance(:__stack => [], :__name => "col_name")
       ]
     end
@@ -42,13 +47,15 @@ describe ThinkingSphinx::Field do
 
   describe "prefixes method" do
     it "should default to false" do
-      @field = ThinkingSphinx::Field.new([Object.stub_instance(:__stack => [])])
+      @field = ThinkingSphinx::Field.new(
+        @source, [Object.stub_instance(:__stack => [])]
+      )
       @field.prefixes.should be_false
     end
     
     it "should be true if the corresponding option is set" do
       @field = ThinkingSphinx::Field.new(
-        [Object.stub_instance(:__stack => [])], :prefixes => true
+        @source, [Object.stub_instance(:__stack => [])], :prefixes => true
       )
       @field.prefixes.should be_true
     end
@@ -56,13 +63,15 @@ describe ThinkingSphinx::Field do
   
   describe "infixes method" do
     it "should default to false" do
-      @field = ThinkingSphinx::Field.new([Object.stub_instance(:__stack => [])])
+      @field = ThinkingSphinx::Field.new(
+        @source, [Object.stub_instance(:__stack => [])]
+      )
       @field.infixes.should be_false
     end
     
     it "should be true if the corresponding option is set" do
       @field = ThinkingSphinx::Field.new(
-        [Object.stub_instance(:__stack => [])], :infixes => true
+        @source, [Object.stub_instance(:__stack => [])], :infixes => true
       )
       @field.infixes.should be_true
     end
@@ -70,21 +79,21 @@ describe ThinkingSphinx::Field do
   
   describe "column_with_prefix method" do
     before :each do
-      @field = ThinkingSphinx::Field.new [
+      @field = ThinkingSphinx::Field.new @source, [
         ThinkingSphinx::Index::FauxColumn.new(:col_name)
       ]
       @field.columns.each { |col| @field.associations[col] = [] }
       @field.model = Person
       
-      @first_join   = Object.stub_instance(:aliased_table_name => "tabular")
-      @second_join  = Object.stub_instance(:aliased_table_name => "data")
+      @first_join   = Object.new
+      @first_join.stub!(:aliased_table_name => "tabular")
+      @second_join  = Object.new
+      @second_join.stub!(:aliased_table_name => "data")
       
-      @first_assoc  = ThinkingSphinx::Association.stub_instance(
-        :join => @first_join, :has_column? => true
-      )
-      @second_assoc = ThinkingSphinx::Association.stub_instance(
-        :join => @second_join, :has_column? => true
-      )
+      @first_assoc  = ThinkingSphinx::Association.new nil, nil
+      @first_assoc.stub!(:join => @first_join, :has_column? => true)
+      @second_assoc = ThinkingSphinx::Association.new nil, nil
+      @second_assoc.stub!(:join => @second_join, :has_column? => true)
     end
     
     it "should return the column name if the column is a string" do
@@ -116,7 +125,7 @@ describe ThinkingSphinx::Field do
       @assoc_c = Object.stub_instance(:is_many? => true)
       
       @field = ThinkingSphinx::Field.new(
-        [ThinkingSphinx::Index::FauxColumn.new(:col_name)]
+        @source, [ThinkingSphinx::Index::FauxColumn.new(:col_name)]
       )
       @field.associations = {
         :a => @assoc_a, :b => @assoc_b, :c => @assoc_c

data/spec/unit/thinking_sphinx/index/builder_spec.rb

@@ -1,5 +1,355 @@
 require 'spec/spec_helper'
 
 describe ThinkingSphinx::Index::Builder do
-  #
+  describe ".generate without source scope" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name, last_name
+        has birthday
+        has id, :as => :internal_id
+        
+        set_property :sql_range_step => 1000
+        
+        where "birthday <= NOW()"
+        group_by "first_name"
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    it "should return an index" do
+      @index.should be_a_kind_of(ThinkingSphinx::Index)
+    end
+    
+    it "should have one source for the index" do
+      @index.sources.length.should == 1
+    end
+    
+    it "should have two fields" do
+      @source.fields.length.should == 2
+      @source.fields[0].unique_name.should == :first_name
+      @source.fields[1].unique_name.should == :last_name
+    end
+    
+    it "should have two attributes alongside the four internal ones" do
+      @source.attributes.length.should == 6
+      @source.attributes[4].unique_name.should == :birthday
+      @source.attributes[5].unique_name.should == :internal_id
+    end
+    
+    it "should have one condition" do
+      @source.conditions.length.should == 1
+      @source.conditions.first.should == "birthday <= NOW()"
+    end
+    
+    it "should have one grouping" do
+      @source.groupings.length.should == 1
+      @source.groupings.first.should == "first_name"
+    end
+    
+    it "should have one option" do
+      @source.options.length.should == 1
+      @source.options[:sql_range_step].should == 1000
+    end
+  end
+  
+  describe "sortable field" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name, :sortable => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    it "should have one field" do
+      @source.fields.length.should == 1
+    end
+    
+    it "should have one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+    
+    it "should set the attribute name to have the _sort suffix" do
+      @source.attributes.last.unique_name.should == :first_name_sort
+    end
+    
+    it "should set the attribute column to be the same as the field" do
+      @source.attributes.last.columns.length.should == 1
+      @source.attributes.last.columns.first.__name.should == :first_name
+    end
+  end
+  
+  describe "faceted field" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Person.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have one field" do
+      @source.fields.length.should == 1
+    end
+    
+    it "should have one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+    
+    it "should set the attribute name to have the _facet suffix" do
+      @source.attributes.last.unique_name.should == :first_name_facet
+    end
+    
+    it "should set the attribute type to integer" do
+      @source.attributes.last.type.should == :integer
+    end
+    
+    it "should set the attribute column to be the same as the field" do
+      @source.attributes.last.columns.length.should == 1
+      @source.attributes.last.columns.first.__name.should == :first_name
+    end
+  end
+  
+  describe "faceted integer attribute" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Alpha) do
+        indexes :name
+        has value, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Alpha.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have just one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+  end
+  
+  describe "faceted timestamp attribute" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
+        has birthday, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Person.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have just one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+  end
+  
+  describe "faceted boolean attribute" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Beta) do
+        indexes :name
+        has delta, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Beta.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have just one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+  end
+  
+  describe "faceted float attribute" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Alpha) do
+        indexes :name
+        has cost, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Alpha.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have just one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+  end
+  
+  describe "faceted string attribute" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
+        has last_name, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Person.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have two attributes alongside the four internal ones" do
+      @source.attributes.length.should == 6
+    end
+    
+    it "should set the facet attribute name to have the _facet suffix" do
+      @source.attributes.last.unique_name.should == :last_name_facet
+    end
+    
+    it "should set the attribute type to integer" do
+      @source.attributes.last.type.should == :integer
+    end
+    
+    it "should set the attribute column to be the same as the field" do
+      @source.attributes.last.columns.length.should == 1
+      @source.attributes.last.columns.first.__name.should == :last_name
+    end
+  end
+  
+  describe "no fields" do
+    it "should raise an exception" do
+      lambda {
+        ThinkingSphinx::Index::Builder.generate(Person) do
+          #
+        end
+      }.should raise_error
+    end
+  end
+  
+  describe "explicit source" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        define_source do
+          indexes first_name, last_name
+          has birthday
+          has id, :as => :internal_id
+        
+          set_property :delta => true
+        
+          where "birthday <= NOW()"
+          group_by "first_name"
+        end
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    it "should return an index" do
+      @index.should be_a_kind_of(ThinkingSphinx::Index)
+    end
+    
+    it "should have one source for the index" do
+      @index.sources.length.should == 1
+    end
+    
+    it "should have two fields" do
+      @source.fields.length.should == 2
+      @source.fields[0].unique_name.should == :first_name
+      @source.fields[1].unique_name.should == :last_name
+    end
+    
+    it "should have two attributes alongside the four internal ones" do
+      @source.attributes.length.should == 6
+      @source.attributes[4].unique_name.should == :birthday
+      @source.attributes[5].unique_name.should == :internal_id
+    end
+  end
+  
+  describe "multiple sources" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        define_source do
+          indexes first_name
+          has birthday
+        end
+        
+        define_source do
+          indexes last_name
+          has :id, :as => :internal_id
+        end
+      end
+    end
+    
+    it "should have two sources" do
+      @index.sources.length.should == 2
+    end
+    
+    it "should have two fields" do
+      @index.fields.length.should == 2
+    end
+    
+    it "should have one field in each source" do
+      @index.sources.each do |source|
+        source.fields.length.should == 1
+      end
+    end
+    
+    it "should have two attributes alongside the eight internal ones" do
+      @index.attributes.length.should == 10
+    end
+    
+    it "should have one attribute in each source alongside the four internal ones" do
+      @index.sources.each do |source|
+        source.attributes.length.should == 5
+      end
+    end
+  end
+  
+  describe "index options" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
+        
+        set_property :charset_type => "utf16"
+        set_property :group_concat_max_len => 1024
+      end
+    end
+    
+    it "should store the index setting for the index" do
+      @index.local_options[:charset_type].should == "utf16"
+    end
+    
+    it "should store non-Sphinx settings for the index" do
+      @index.local_options[:group_concat_max_len].should == 1024
+    end
+  end
+  
+  describe "delta options" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
+        
+        set_property :delta => true
+      end
+    end
+    
+    it "should not keep the delta setting in source options" do
+      @index.sources.first.options.should be_empty
+    end
+    
+    it "should not keep the delta setting in index options" do
+      @index.local_options.should be_empty
+    end
+    
+    it "should set the index delta object set" do
+      @index.delta_object.should be_a_kind_of(ThinkingSphinx::Deltas::DefaultDelta)
+    end
+  end
 end