down 5.6.1 → 5.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 04d70935026de1e61cbda54578c360164e4ab252658c2b7a5531701e8195f55d
-  data.tar.gz: 047bbd998f10b26ad7865f4dc445a5ddc4ad811c4639ba51b8691eb1436cb6af
+  metadata.gz: dafd791660ca13ac117b8db2da6a31a38b5c6008735039dcbf4263b60438cf6a
+  data.tar.gz: 1ce7f027452f7c21421f169be6f967d3a180c3e34940d07c0d41be35fb1015cf
 SHA512:
-  metadata.gz: '0924393fcdee5795751393b9965e3cb2221da29baa5797d30bdd19115edb63972e8c6119310e1f65f77feeae7aae61ef5f03452394c77b57a57aaa1d8663a0da'
-  data.tar.gz: 808f8ac45f19f7a54e708b9b51ca4e659474eebe2bd14d894157a9454d4a2726d1260d323c61445218d8cc00f4b25497fb1c680c527e0fbc51a9cf1f374d605c
+  metadata.gz: 32d796dfff756b332fbf688d2560a08820f3636b1e64b7e5545bb896f2955a5c5def44c9866207a7a9898eba0bbb45bee8d8d663e7c1060a43157556624cd176
+  data.tar.gz: 13fedb0b5618d6c7ff9dda385835e6fb15a9a3d6bdad30db201c4ee216ddb6b508cbad374e7dd48d08df5ff26b39b2ca8e837789f44a6e59df2beab164c705c0

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 5.6.2 (2026-11-01)
+
+* Return `nil` `Down::ChunkedIO#size` from `Down::NetHttp.open` when net/http decompresses the body (@wtn)
+
+* Set `Down::ResponseError#response` to the response object on invalid redirect URIs in `Down::NetHttp` (@wtn)
+
 ## 5.6.1 (2026-10-18)
 
 * Avoid warnings on requiring `cgi` on Ruby 4.0+ (@janko)

data/README.md

@@ -109,7 +109,7 @@ internally downloads chunks of the remote file, but only how much is needed.
 
 ```rb
 remote_file = Down.open("http://example.com/image.jpg")
-remote_file.size # read from the "Content-Length" header
+remote_file.size # read from the "Content-Length" header, nil if unknown
 
 remote_file.read(1024) # downloads and returns first 1 KB
 remote_file.read(1024) # downloads and returns next 1 KB
@@ -121,6 +121,17 @@ remote_file.eof? #=> true
 remote_file.close # closes the HTTP connection and deletes the internal Tempfile
 ```
 
+The size is `nil` when the server doesn't send a `Content-Length`. With the
+Net::HTTP backend it's also `nil` when the response body is compressed, because
+Net::HTTP decompresses it on the fly and the header holds the compressed size. If
+you need the size, you can set your own `Accept-Encoding`, which turns off
+decompression; the body may then need to be decompressed by hand if the server
+sends it compressed anyway:
+
+```rb
+remote_file = Down.open("http://example.com/file.json", headers: { "Accept-Encoding" => "identity" })
+```
+
 The following IO methods are implemented:
 
 * `#read` & `#readpartial`

data/lib/down/net_http.rb

@@ -17,6 +17,10 @@ module Down
       addressable_uri.normalize.to_s
     end
 
+    # Content encodings that Net::HTTP transparently decodes.
+    DECODED_ENCODINGS = %w[gzip x-gzip deflate].freeze
+    private_constant :DECODED_ENCODINGS
+
     DEFAULT_OPTIONS = {
       headers:        { "User-Agent" => "Down/#{Down::VERSION}" }.freeze,
       max_redirects:  2,
@@ -127,7 +131,7 @@ module Down
       # Build an IO-like object that will retrieve response body on-demand.
       Down::ChunkedIO.new(
         chunks:     enum_for(:stream_body, response),
-        size:       response["Content-Length"]&.to_i,
+        size:       content_length(response),
         encoding:   response.type_params["charset"],
         rewindable: options.fetch(:rewindable, true),
         on_close:   -> { request.resume }, # close HTTP connnection
@@ -153,7 +157,7 @@ module Down
       rescue Down::InvalidUrl
         response = rebuild_response_from_open_uri_exception(exception)
 
-        raise ResponseError.new("Invalid Redirect URI: #{exception.uri}", response:)
+        raise ResponseError.new("Invalid Redirect URI: #{exception.uri}", response)
       end
 
       # do not leak credentials on redirect
@@ -176,7 +180,7 @@ module Down
 
       # open-uri attempts to parse the redirect URI, so we re-raise that exception
       if exception.message.include?("(Invalid Location URI)")
-        raise ResponseError.new("Invalid Redirect URI: #{response["Location"]}", response:)
+        raise ResponseError.new("Invalid Redirect URI: #{response["Location"]}", response)
       end
 
       response_error!(response)
@@ -233,7 +237,7 @@ module Down
         begin
           location = ensure_uri(response["Location"], allow_relative: true)
         rescue Down::InvalidUrl
-          raise ResponseError.new("Invalid Redirect URI: #{response["Location"]}", response:)
+          raise ResponseError.new("Invalid Redirect URI: #{response["Location"]}", response)
         end
 
         # do not leak credentials on redirect
@@ -297,6 +301,20 @@ module Down
       request_error!(exception)
     end
 
+    # Returns the Content-Length, unless a Transfer-Encoding is present or
+    # Net::HTTP will decode the body, in which case it doesn't reflect the
+    # number of bytes read. Decoding conditions mirror Net::HTTPResponse#inflater.
+    def content_length(response)
+      return if response["Transfer-Encoding"]
+
+      length = response.content_length
+      return length if length.nil? || length.zero?
+      return if response.decode_content && !response["Content-Range"] &&
+                DECODED_ENCODINGS.include?(response["Content-Encoding"]&.downcase)
+
+      length
+    end
+
     # Checks that the url is a valid URI and that its scheme is http or https.
     def ensure_uri(url, allow_relative: false)
       begin

data/lib/down/version.rb

@@ -1,5 +1,5 @@
 # frozen-string-literal: true
 
 module Down
-  VERSION = "5.6.1"
+  VERSION = "5.6.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: down
 version: !ruby/object:Gem::Version
-  version: 5.6.1
+  version: 5.6.2
 platform: ruby
 authors:
 - Janko Marohnić
@@ -179,7 +179,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.13
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Robust streaming downloads using Net::HTTP, http.rb or HTTPX.
 test_files: []