down 5.4.0 → 5.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e0544a70de3afab2a00c68df6923572a5533f05a0964b8c5186728019d04e55b
-  data.tar.gz: 3474da6a6c7a182aa02deb72139002ebf97ac98bee9c4a833de2b0413e373924
+  metadata.gz: a8a87deb869d776663b7fa4a32a87fcf73ffe2434e2fbe4fdef1ce7d6e48cf55
+  data.tar.gz: 294efe7598f57309b0cbc3a3190685663384c9b3374c9afa621e728205bc367e
 SHA512:
-  metadata.gz: 64d22c0a25ddf60f2dea37cb03264ec5770a8c7877fb7a843052abca4b043ba9d2d0c8eed830fc2cec97bb852338b114e2907c357aaf4b68aad26a6860459f67
-  data.tar.gz: 992209a7e4201cab464958bac0960ba4a6dc0344cd410b7ceaec2a02b89ebc1bd876396349204bb0bfe175a279fbdb41900c9fee85eee7e98d74eec7afa2e7a0
+  metadata.gz: 1d7d3f067b9de755a9976d572e668cad8d39e38968da71f209a5044debd3b0db14c7f70bf96b4237eae1da73178cdcafd454f28cc1bba34e6d92f02194ee94e0
+  data.tar.gz: 9638590a3e4ee48ccd9c6409aadd140182315a0a648896b52a14fd5419c67bba1a4266cf00e51ec9dca6b17e77520373373ef7693d8155bfeb5409078c3ca9f6

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## 5.4.2 (2024-04-19)
+
+* Add support for HTTPX 1.x (@HoneyryderChuck)
+
+## 5.4.1 (2023-05-20)
+
+* Handle additional params in `Content-Disposition` header (@janko)
+
+* Add ability to detect response URI when using net/http (@aglushkov)
+
+* Avoid deprecation warning in HTTPX (@ollym)
+
+* Handle unknown response status in net/http backend (@janko)
+
 ## 5.4.0 (2022-12-26)
 
 * Add new HTTPX backend, which supports HTTP/2 protocol among other features (@HoneyryderChuck)

data/README.md

@@ -511,17 +511,6 @@ wget.download("http://nature.com/forest.jpg")
 wget.open("http://nature.com/forest.jpg")
 ```
 
-## Supported Ruby versions
-
-* MRI 2.3
-* MRI 2.4
-* MRI 2.5
-* MRI 2.6
-* MRI 2.7
-* MRI 3.0
-* MRI 3.1
-* JRuby 9.3
-
 ## Development
 
 Tests require that a [httpbin] server is running locally, which you can do via Docker:

data/down.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest", "~> 5.8"
   spec.add_development_dependency "mocha", "~> 1.5"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "httpx", "~> 0.22", ">= 0.22.2"
+  spec.add_development_dependency "httpx", "~> 0", "< 2.0.0"
   # http 5.0 drop support of ruby 2.3 and 2.4. We still support those versions.
   if RUBY_VERSION >= "2.5"
     spec.add_development_dependency "http", "~> 5.0"

data/lib/down/httpx.rb

@@ -14,12 +14,14 @@ module Down
 
     USER_AGENT = "Down/#{Down::VERSION}"
 
+    BASIC_AUTH = HTTPX::VERSION >= "1.0.0" ? :basic_auth : :basic_authentication
+
     def initialize(**options, &block)
       @method = options.delete(:method) || :get
       headers = options.delete(:headers) || {}
       @client = HTTPX
           .plugin(:follow_redirects, max_redirects: 2)
-          .plugin(:basic_authentication)
+          .plugin(BASIC_AUTH)
           .plugin(:stream)
           .with(
             headers: { "user-agent": USER_AGENT }.merge(headers),
@@ -128,7 +130,7 @@ module Down
       end
       client = block.call(client) if block
 
-      client.request(method, uri, stream: true, **options)
+      client.request(method.to_s.upcase, uri, stream: true, **options)
     rescue => exception
       request_error!(exception)
     end
@@ -172,4 +174,4 @@ module Down
       end
     end
   end
-end
+end

data/lib/down/net_http.rb

@@ -270,7 +270,7 @@ module Down
       headers = options[:headers].to_h
       headers["Accept-Encoding"] = "" # Net::HTTP's inflater causes FiberErrors
 
-      get = Net::HTTP::Get.new(uri.request_uri, headers)
+      get = Net::HTTP::Get.new(uri, headers)
 
       user, password = options[:http_basic_authentication] || [uri.user, uri.password]
       get.basic_auth(user, password) if user || password
@@ -312,13 +312,14 @@ module Down
     # rebuild the Net::HTTP response object.
     def rebuild_response_from_open_uri_exception(exception)
       code, message = exception.io.status
+      message ||= "Unknown"
 
       response_class = Net::HTTPResponse::CODE_TO_OBJ.fetch(code) do |c|
         Net::HTTPResponse::CODE_CLASS_TO_OBJ.fetch(c[0]) do
           Net::HTTPUnknownResponse
         end
       end
-      response       = response_class.new(nil, code, message)
+      response = response_class.new(nil, code, message)
 
       exception.io.metas.each do |name, values|
         values.each { |value| response.add_field(name, value) }

data/lib/down/utils.rb

@@ -11,7 +11,7 @@ module Down
       escaped_filename =
         content_disposition[/filename\*=UTF-8''(\S+)/, 1] ||
         content_disposition[/filename="([^"]*)"/, 1] ||
-        content_disposition[/filename=(\S+)/, 1]
+        content_disposition[/filename=([^\s;]+)/, 1]
 
       filename = CGI.unescape(escaped_filename.to_s)
 

data/lib/down/version.rb

@@ -1,5 +1,5 @@
 # frozen-string-literal: true
 
 module Down
-  VERSION = "5.4.0"
+  VERSION = "5.4.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: down
 version: !ruby/object:Gem::Version
-  version: 5.4.0
+  version: 5.4.2
 platform: ruby
 authors:
 - Janko Marohnić
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-26 00:00:00.000000000 Z
+date: 2024-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -72,20 +72,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.22'
-    - - ">="
+        version: '0'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.22.2
+        version: 2.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.22'
-    - - ">="
+        version: '0'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.22.2
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: http
   requirement: !ruby/object:Gem::Requirement
@@ -182,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: Robust streaming downloads using Net::HTTP, HTTP.rb or wget.