down 1.1.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae5eb943b2a1423b964812f6eabaab6e2db3ac80
-  data.tar.gz: d94df3114f9784599967e67bd74b2efaa53ff0de
+  metadata.gz: d6bfc27c3e2b954afac30e137fa798cf1455914a
+  data.tar.gz: 3b4dac64774179f307ff94bd235815a404f412f8
 SHA512:
-  metadata.gz: 858b972338a5b2252c6674cd55199ce29b491406fba507bac8c86ae8c342c62ca78d9f84bbf7d6f64f3c739e5d15e4328268d0be77e4682da58b1600cb8dda90
-  data.tar.gz: 33399d6ee408a32882b3077fc88478527fc3a5d3ce2fd1bbd53e14e77df9ff5bb3668e6950b0720d636c30b8d029c1af5b775ca22959fe00dc1a6c60505ae227
+  metadata.gz: 8eea506a22d4f612acbcd6de0cd5b5a1a8416edb8cd768dc2b3f66b3f4f20a26185b978e1a7502278afb6d94c3b9f3ee909028c36ab184a0b425cd1d5b956c96
+  data.tar.gz: 102506a0f63fd5d87393a9a317bdf2ac60b155fe4467e121000b16c0cd1fe94c444a0383a9ad82a2e40e66fe76ec434d0d6567c5568073dd029a2d01b7a11a84

data/README.md

@@ -78,8 +78,7 @@ Down.download "http://example.com/image.jpg",
 
 ### Download errors
 
-Firstly, Down encodes unencoded URLs, `open-uri` will for example trip if the
-URL has a space. There are a lot of ways that a download can fail:
+There are a lot of ways in which a download can fail:
 
 * URL is really invalid (`URI::InvalidURIError`)
 * URL is a little bit invalid, e.g. "http:/example.com" (`Errno::ECONNREFUSED`)
@@ -88,8 +87,8 @@ URL has a space. There are a lot of ways that a download can fail:
 * Request went into a redirect loop (`RuntimeError`)
 * Request timeout out (`Timeout::Error`)
 
-Down unifies all of these errors, and simply throws `Down::NotFound` error
-(because this is what actually happened from the outside perspective).
+Down unifies all of these errors into one `Down::NotFound` error (because this
+is what actually happened from the outside perspective).
 
 ### Timeout
 

data/down.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "down"
-  spec.version       = "1.1.0"
+  spec.version       = "2.0.0"
   spec.authors       = ["Janko Marohnić"]
   spec.email         = ["janko.marohnic@gmail.com"]
 

data/lib/down.rb

@@ -11,13 +11,13 @@ module Down
   module_function
 
   def download(url, options = {})
-    url = URI.encode(URI.decode(url))
+    uri = URI.parse(url)
 
     max_size = options.delete(:max_size)
     progress = options.delete(:progress)
     timeout  = options.delete(:timeout)
 
-    downloaded_file = URI(url).open({
+    downloaded_file = uri.open({
       "User-Agent" => "Down/1.0.0",
       content_length_proc: proc { |size|
         raise Down::TooLarge if size && max_size && size > max_size
@@ -36,7 +36,7 @@ module Down
     # file extension, so we want to run it against #copy_to_tempfile which
     # does.
     open_uri_file = downloaded_file
-    downloaded_file = copy_to_tempfile(URI(url).path, open_uri_file)
+    downloaded_file = copy_to_tempfile(uri.path, open_uri_file)
     OpenURI::Meta.init downloaded_file, open_uri_file
 
     downloaded_file.extend DownloadedFile
@@ -44,7 +44,7 @@ module Down
 
   rescue => error
     raise if error.is_a?(Down::Error)
-    raise Down::NotFound, error.message
+    raise Down::NotFound, "#{error.class}: #{error.message}"
   end
 
   def copy_to_tempfile(basename, io)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: down
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Janko Marohnić
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-26 00:00:00.000000000 Z
+date: 2016-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake