dougcole-friendly_id 2.0.5 → 2.0.6

data/test/slugged_model_test.rb

@@ -0,0 +1,263 @@
+# encoding: utf-8
+
+require File.dirname(__FILE__) + '/test_helper'
+
+class SluggedModelTest < Test::Unit::TestCase
+
+  context "A slugged model with default FriendlyId options" do
+
+    setup do
+      Post.friendly_id_options = FriendlyId::DEFAULT_FRIENDLY_ID_OPTIONS.merge(:column => :title, :use_slug => true)
+      Post.delete_all
+      Person.delete_all
+      Slug.delete_all
+      @post = Post.new :title => "Test post", :content => "Test content"
+      @post.save!
+    end
+
+    should "have friendly_id options" do
+      assert_not_nil Post.friendly_id_options
+    end
+
+    should "have a slug" do
+      assert_not_nil @post.slug
+    end
+
+    should "be findable by its friendly_id" do
+      assert Post.find(@post.friendly_id)
+    end
+
+    should "be findable by its regular id" do
+      assert Post.find(@post.id)
+    end
+
+    should "generate slug text" do
+      post = Post.new :title => "Test post", :content => "Test content"
+      assert_not_nil @post.slug_text
+    end
+
+    should "respect finder conditions" do
+      assert_raises ActiveRecord::RecordNotFound do
+        Post.find(@post.friendly_id, :conditions => "1 = 2")
+      end
+    end
+
+    should "raise an error if the friendly_id text is reserved" do
+      assert_raises(FriendlyId::SlugGenerationError) do
+        Post.create!(:title => "new")
+      end
+    end
+
+    should "raise an error if the friendly_id text is blank" do
+      assert_raises(FriendlyId::SlugGenerationError) do
+        Post.create(:title => "")
+      end
+    end
+
+    should "raise an error if the normalized friendly id becomes blank" do
+      assert_raises(FriendlyId::SlugGenerationError) do
+        post = Post.create!(:title => "-.-")
+      end
+    end
+
+    should "not make a new slug unless the friendly_id method value has changed" do
+      @post.content = "Changed content"
+      @post.save!
+      assert_equal 1, @post.slugs.size
+    end
+
+    should "make a new slug if the friendly_id method value has changed" do
+      @post.title = "Changed title"
+      @post.save!
+      assert_equal 2, @post.slugs.size
+    end
+
+    should "have a slug sequence of 1 by default" do
+      assert_equal 1, @post.slug.sequence
+    end
+
+    should "increment sequence for duplicate slug names" do
+      @post2 = Post.create! :title => @post.title, :content => "Test content for post2"
+      assert_equal 2, @post2.slug.sequence
+    end
+
+    should "have a friendly_id that terminates with -- and the slug sequence if the sequence is greater than 1" do
+      @post2 = Post.create! :title => @post.title, :content => "Test content for post2"
+      assert_match(/--2\z/, @post2.friendly_id)
+    end
+
+    should "not strip diacritics" do
+      @post = Post.new(:title => "¡Feliz año!")
+      assert_match(/#{'ñ'}/, @post.slug_text)
+    end
+
+    should "not convert to ASCII" do
+      @post = Post.new(:title => "katakana: ゲコゴサザシジ")
+      assert_equal "katakana-ゲコゴサザシジ", @post.slug_text
+    end
+    
+    should "allow the same friendly_id across models" do
+      @person = Person.create!(:name => @post.title)
+      assert_equal @person.friendly_id, @post.friendly_id
+    end
+
+    should "truncate slug text longer than the max length" do
+      @post = Post.new(:title => "a" * (Post.friendly_id_options[:max_length] + 1))
+      assert_equal @post.slug_text.length, Post.friendly_id_options[:max_length]
+    end
+
+    should "be able to reuse an old friendly_id without incrementing the sequence" do
+      old_title = @post.title
+      old_friendly_id = @post.friendly_id
+      @post.title = "A changed title"
+      @post.save!
+      @post.title = old_title
+      @post.save!
+      assert_equal old_friendly_id, @post.friendly_id
+    end
+
+    should "allow eager loading of slugs" do
+      assert_nothing_raised do
+        Post.find(@post.friendly_id, :include => :slugs)
+      end
+    end
+
+    context "and configured to strip diacritics" do
+      setup do
+        Post.friendly_id_options = Post.friendly_id_options.merge(:strip_diacritics => true)
+      end
+
+      should "strip diacritics from Roman alphabet based characters" do
+        @post = Post.new(:title => "¡Feliz año!")
+        assert_no_match(/#{'ñ'}/, @post.slug_text)
+      end
+    end
+
+    context "and configured to convert to ASCII" do
+      setup do
+        Post.friendly_id_options = Post.friendly_id_options.merge(:strip_non_ascii => true)
+      end
+
+      should "strip non-ascii characters" do
+        @post = Post.new(:title => "katakana: ゲコゴサザシジ")
+        assert_equal "katakana", @post.slug_text
+      end
+    end
+
+    context "that doesn't have a slug" do
+
+      setup do
+        @post.slug.destroy
+        @post = Post.find(@post.id)
+      end
+
+      should "have a to_param method that returns the id cast to a string" do
+        assert_equal @post.id.to_s, @post.to_param
+      end
+
+    end
+
+    context "when found using its friendly_id" do
+      setup do
+        @post = Post.find(@post.friendly_id)
+      end
+
+      should "indicate that it was found using the friendly_id" do
+        assert @post.found_using_friendly_id?
+      end
+
+      should "not indicate that it has a better id" do
+        assert !@post.has_better_id?
+      end
+
+      should "not indicate that it was found using its numeric id" do
+        assert !@post.found_using_numeric_id?
+      end
+
+      should "have a finder slug" do
+        assert_not_nil @post.finder_slug
+      end
+
+    end
+
+    context "when found using its regular id" do
+      setup do
+        @post = Post.find(@post.id)
+      end
+
+      should "indicate that it was not found using the friendly id" do
+        assert !@post.found_using_friendly_id?
+      end
+
+      should "indicate that it has a better id" do
+        assert @post.has_better_id?
+      end
+
+      should "indicate that it was found using its numeric id" do
+        assert @post.found_using_numeric_id?
+      end
+
+      should "not have a finder slug" do
+        assert_nil @post.finder_slug
+      end
+
+    end
+
+    context "when found using an outdated friendly id" do
+      setup do
+        old_id = @post.friendly_id
+        @post.title = "Title changed"
+        @post.save!
+        @post = Post.find(old_id)
+      end
+
+      should "indicate that it was found using a friendly_id" do
+        assert @post.found_using_friendly_id?
+      end
+
+      should "indicate that it has a better id" do
+        assert @post.has_better_id?
+      end
+
+      should "not indicate that it was found using its numeric id" do
+        assert !@post.found_using_numeric_id?
+      end
+
+      should "should have a finder slug different from its default slug" do
+        assert_not_equal @post.slug, @post.finder_slug
+      end
+
+    end
+
+    context "when using an array as the find argument" do
+
+      setup do
+        @post2 = Post.create!(:title => "another post", :content => "more content")
+      end
+
+      should "return results" do
+        assert_equal 2, Post.find([@post.friendly_id, @post2.friendly_id]).size
+      end
+
+      should "indicate that the results were found using a friendly_id" do
+        @posts = Post.find [@post.friendly_id, @post2.friendly_id]
+        @posts.each { |p| assert p.found_using_friendly_id? }
+      end
+
+      should "raise an error when all records are not found" do
+        assert_raises(ActiveRecord::RecordNotFound) do
+          Post.find([@post.friendly_id, 'non-existant-slug-record'])
+        end
+      end
+
+      should "allow eager loading of slugs" do
+        assert_nothing_raised do
+          Post.find([@post.friendly_id, @post2.friendly_id], :include => :slugs)
+        end
+      end
+
+    end
+
+  end
+
+end

data/test/sti_test.rb

@@ -0,0 +1,48 @@
+# encoding: utf-8
+
+require File.dirname(__FILE__) + '/test_helper'
+
+class SluggedModelTest < Test::Unit::TestCase
+
+  context "A slugged model using single table inheritance" do
+
+    setup do
+      Novel.friendly_id_options = FriendlyId::DEFAULT_FRIENDLY_ID_OPTIONS.merge(:column => :title, :use_slug => true)
+      Novel.delete_all
+      Slug.delete_all
+      @novel = Novel.new :title => "Test novel"
+      @novel.save!
+    end
+
+    should "have a slug" do
+      assert_not_nil @novel.slug
+    end
+    
+    context "found by its friendly id" do
+      
+      setup do
+        @novel = Novel.find(@novel.friendly_id)
+      end
+
+      should "not indicate that it has a better id" do
+        assert !@novel.has_better_id?
+      end
+
+    end
+    
+
+    context "found by its numeric id" do
+      
+      setup do
+        @novel = Novel.find(@novel.id)
+      end
+
+      should "indicate that it has a better id" do
+        assert @novel.has_better_id?
+      end
+
+    end
+
+  end
+
+end

data/test/test_helper.rb

@@ -1,35 +1,36 @@
 $:.unshift(File.dirname(__FILE__) + '/../lib')
-$VERBOSE = false
-
-ENV['RAILS_ENV'] = 'test'
-require File.dirname(__FILE__) + '/rails/2.x/config/environment.rb'
-ActiveRecord::Base.logger = Logger.new(File.dirname(__FILE__) + "/debug.log")
-
+$:.unshift(File.dirname(__FILE__))
+$VERBOSE=false
+require 'rubygems'
 require 'test/unit'
-require 'active_record/fixtures'
-require 'action_controller/test_process'
-require 'sqlite3'
-require 'friendly_id/slug'
-
-config = YAML::load(IO.read(File.dirname(__FILE__) + '/database.yml'))
-ActiveRecord::Base.establish_connection
-
-silence_stream(STDOUT) do
-  load(File.dirname(__FILE__) + "/schema.rb")
+require 'shoulda'
+# You can use "rake test AR_VERSION=2.0.5" to test against 2.0.5, for example.
+# The default is to use the latest installed ActiveRecord.
+if ENV["AR_VERSION"]
+  gem 'activerecord', "#{ENV["AR_VERSION"]}"
 end
+require 'active_record'
 
-Test::Unit::TestCase.fixture_path = File.dirname(__FILE__) + "/fixtures"
-$LOAD_PATH.unshift(Test::Unit::TestCase.fixture_path)
+require 'friendly_id'
+require 'models/post'
+require 'models/person'
+require 'models/user'
+require 'models/country'
+require 'models/book'
+require 'models/novel'
+require 'models/thing'
 
-class Test::Unit::TestCase #:nodoc:
-  include ActionController::TestProcess
-  def create_fixtures(*table_names)
-    if block_given?
-      Fixtures.create_fixtures(Test::Unit::TestCase.fixture_path, table_names) { yield }
-    else
-      Fixtures.create_fixtures(Test::Unit::TestCase.fixture_path, table_names)
-    end
-  end
-  self.use_transactional_fixtures = true
-  self.use_instantiated_fixtures  = false
+# Borrowed from ActiveSupport
+def silence_stream(stream)
+  old_stream = stream.dup
+  stream.reopen(RUBY_PLATFORM =~ /mswin/ ? 'NUL:' : '/dev/null')
+  stream.sync = true
+  yield
+ensure
+  stream.reopen(old_stream)
 end
+
+ActiveRecord::Base.establish_connection :adapter => "sqlite3", :database => ":memory:"
+silence_stream(STDOUT) do
+  load(File.dirname(__FILE__) + "/schema.rb")
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: dougcole-friendly_id
 version: !ruby/object:Gem::Version 
-  version: 2.0.5
+  version: 2.0.6
 platform: ruby
 authors: 
 - Norman Clarke
@@ -11,11 +11,12 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-02-05 00:00:00 -08:00
+date: 2009-02-17 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: schacon-git
+  type: :runtime
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
@@ -25,6 +26,7 @@ dependencies:
     version: 
 - !ruby/object:Gem::Dependency 
   name: unicode
+  type: :runtime
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
@@ -67,42 +69,35 @@ files:
 - lib/friendly_id/non_sluggable_instance_methods.rb
 - lib/friendly_id/slug.rb
 - lib/friendly_id/non_sluggable_class_methods.rb
-- lib/friendly_id/shoulda_macros.rb
 - lib/friendly_id/helpers.rb
 - lib/friendly_id/sluggable_class_methods.rb
 - lib/friendly_id/sluggable_instance_methods.rb
 - lib/friendly_id/version.rb
 - lib/friendly_id.rb
+- test/sti_test.rb
 - test/slug_test.rb
+- test/slugged_model_test.rb
 - test/scoped_model_test.rb
 - test/test_helper.rb
 - test/fixtures
-- test/fixtures/posts.yml
-- test/fixtures/user.rb
-- test/fixtures/people.yml
-- test/fixtures/person.rb
-- test/fixtures/countries.yml
-- test/fixtures/slugs.yml
-- test/fixtures/users.yml
-- test/fixtures/country.rb
-- test/fixtures/post.rb
-- test/database.yml
-- test/sluggable_test.rb
+- test/models
+- test/models/user.rb
+- test/models/book.rb
+- test/models/person.rb
+- test/models/novel.rb
+- test/models/country.rb
+- test/models/post.rb
+- test/models/thing.rb
+- test/custom_slug_normalizer_test.rb
 - test/schema.rb
 - test/rails
 - test/rails/2.x
 - test/rails/2.x/app
 - test/rails/2.x/app/controllers
-- test/rails/2.x/app/controllers/application.rb
 - test/rails/2.x/log
 - test/rails/2.x/log/test.log
 - test/rails/2.x/config
-- test/rails/2.x/config/boot.rb
 - test/rails/2.x/config/environments
-- test/rails/2.x/config/environments/test.rb
-- test/rails/2.x/config/routes.rb
-- test/rails/2.x/config/database.yml
-- test/rails/2.x/config/environment.rb
 - test/non_slugged_test.rb
 - init.rb
 has_rdoc: true