doubleshot 0.2.0-java → 0.3.0-java

data/lib/doubleshot/resolver/gem_resolver/source.rb

@@ -0,0 +1,36 @@
+require "uri"
+
+class Doubleshot
+  class Resolver
+    class GemResolver
+
+      class Source
+
+        def self.map(*mime_types)
+          mime_types.each do |mime_type|
+            mappings[mime_type.to_s] = self
+          end
+        end
+
+        def self.mappings
+          @@mappings ||= {}
+        end
+
+        def self.new(uri)
+          uri = URI.parse(uri.to_s)
+          instance = mappings[uri.scheme].allocate
+          instance.send(:initialize, uri)
+          instance
+        end
+
+        def initialize(uri)
+          @uri = uri
+        end
+
+        SUPPORTED_PLATFORMS = [ /\bjava\b/i, /^jruby$/i, /^ruby$/i ]
+      end
+    end
+  end
+end
+
+require "doubleshot/resolver/gem_resolver/gem_source"

data/lib/doubleshot/resolver/jar_resolver.rb

@@ -1,5 +1,3 @@
-java_import "org.sam.doubleshot.Aether"
-
 class Doubleshot
   class Resolver
     class JarResolver < Resolver
@@ -8,7 +6,7 @@ class Doubleshot
       def initialize(*repositories)
         super
         # Change the second argument to "true" to get verbose output.
-        @aether = Aether.new(Pathname("~/.m2").expand_path.to_s, false, false)
+        @aether = org.sam.doubleshot.Aether.new(Pathname("~/.m2").expand_path.to_s, false, false)
         @repositories.each do |repository|
           @aether.add_repository repository.host, repository.to_s
         end

data/lib/ruby/gem/requirement.rb

@@ -1,4 +1,13 @@
 class Gem::Requirement
+  # TODO: refactor Doubleshot to only use satisfied_by?(Gem::Version) instead of satisfies?(String|Gem::Version)
+  def satisfies?(version)
+    unless version.is_a? Gem::Version
+      version = Gem::Version.new(version.to_s)
+    end
+    satisfied_by? version
+  end
+  alias :satisfies :satisfies?
+
   def eql?(other)
     self == other
   end

data/test/compiler_spec.rb

@@ -4,12 +4,12 @@ require_relative "helper"
 
 describe Doubleshot::Compiler do
 
-  def compile
+  def compile(source = "java", target = "target")
     Helper::tmp do |tmp|
-      source = tmp + "java"
+      source = tmp + source
       source.mkdir
 
-      target = tmp + "target"
+      target = tmp + target
       target.mkdir
 
       (source + "Cow.java").open("w+") do |cow|
@@ -43,6 +43,34 @@ describe Doubleshot::Compiler do
 
   describe "#pending?" do
 
+    it "must be pending if the target doesn't exist" do
+      Helper::tmp do |tmp|
+        source = tmp + "java"
+        source.mkdir
+
+        target = tmp + "notarget"
+        # We're testing that target doesn't exist so:
+        # target.mkdir
+
+        (source + "Cow.java").open("w+") do |cow|
+          cow << <<-EOS.margin
+          package org.sam.doubleshot;
+
+          public class Cow {
+            public Cow() {}
+
+            public String moo() {
+              return "MOO!";
+            }
+          }
+          EOS
+        end
+
+        compiler = Doubleshot::Compiler.new(source, target)
+        compiler.must_be :pending
+      end
+    end
+
     it "wont be pending after a build" do
       compile do |compiler|
         compiler.build!

data/test/configuration_spec.rb

@@ -62,12 +62,12 @@ describe Doubleshot::Configuration do
 
   describe "repositories" do
     it "must add Maven repositories" do
-      @config.mvn_repository "http://repository.jboss.com/maven2/"
-      @config.mvn_repositories.must_include "http://repository.jboss.com/maven2/"
+      @config.mvn_repository "http://repository.jboss.com/maven2"
+      @config.mvn_repositories.must_include "http://repository.jboss.com/maven2"
     end
 
     it "must return the passed value from mvn_repository" do
-      example = "http://repository.jboss.com/maven2/"
+      example = "http://repository.jboss.com/maven2"
       @config.mvn_repository(example).must_be_same_as example
     end
 
@@ -80,6 +80,14 @@ describe Doubleshot::Configuration do
       example = "http://rubyforge.org"
       @config.gem_repository(example).must_be_same_as example
     end
+
+    it "must default to rubygems.org if no other gem repositories are specified" do
+      @config.gem_repositories.must_include "http://rubygems.org"
+    end
+
+    it "must default to central if no other maven repositories are specified" do
+      @config.mvn_repositories.must_include "http://repo1.maven.org/maven2"
+    end
   end
 
   describe "jar" do

data/test/dependencies/gem_dependency_spec.rb

@@ -39,23 +39,9 @@ describe Doubleshot::Dependencies::GemDependency do
       @dependency.to_s.must_equal "listen"
     end
 
-    it "must have a long-form that includes requirements" do
-      @dependency.to_s(true).must_equal "listen (= 0.5.3, >= 0.5)"
-    end
-  end
-
-  describe "gemspec" do
-    it "must return a Gem::Specification" do
-      skip
-      @dependency.gemspec = Gem::Specification.new
-      @dependency.gemspec.must_be_kind_of Gem::Specification
-    end
-  end
-
-  describe "dependencies" do
-    it "must return a Doubleshot::Dependencies::DependencyList" do
-      skip
-      @dependency.dependencies.must_be_kind_of Doubleshot::Dependencies::DependencyList
+    it "must have a long-form that includes version if present" do
+      @dependency.lock "0.5.3"
+      @dependency.to_s(true).must_equal "listen:0.5.3"
     end
   end
 end

data/test/dependencies/jar_dependency_spec.rb

@@ -65,4 +65,24 @@ describe Doubleshot::Dependencies::JarDependency do
     Doubleshot::Dependencies::JarDependency.new("ch.qos.logback:logback-core:1.0.6")
       .to_s(true).must_equal "ch.qos.logback:logback-core:jar:1.0.6"
   end
+
+  describe "exclude" do
+    before do
+      @jar_dependency = Doubleshot::Dependencies::JarDependency.new "org.sonatype.aether:aether-connector-wagon:1.13.1"
+    end
+
+    it "allows you to exclude a groupId:artifactId for use in POM-file dependency exclusions" do
+      @jar_dependency.exclude("org.sonatype.sisu:sisu-guice")
+      @jar_dependency.exclusions.must_equal [ "org.sonatype.sisu:sisu-guice" ]
+    end
+
+    it "should verify that your exclusion string contains one and only one colon" do
+      -> { @jar_dependency.exclude "missing-colon" }.must_raise(ArgumentError)
+      -> { @jar_dependency.exclude "too:many:colons" }.must_raise(ArgumentError)
+    end
+
+    it "should return self so you can chain exclusions" do
+      @jar_dependency.exclude("org.sonatype.sisu:sisu-guice").must_equal @jar_dependency
+    end
+  end
 end

data/test/helper.rb

@@ -50,4 +50,6 @@ module Helper
   ensure
     dir.rmtree if dir.exist?
   end
-end
+end
+
+require(Pathname(__FILE__).dirname + "helpers/stub_source")

data/test/helpers/stub_source.rb

@@ -0,0 +1,120 @@
+module Helper
+  class StubSource < Doubleshot::Resolver::GemResolver::Source
+    map :stub
+
+    def self.index(gems)
+      @@index = {}
+      gems.each_pair do |name, versions|
+        specs = @@index[name] ||= {}
+        versions.each_pair do |version, dependencies|
+          spec = specs[Gem::Version.new(version)] = Gem::Specification.new
+          spec.name = name
+          spec.version = version
+          dependencies.each_pair do |name, versions|
+            spec.add_runtime_dependency name, *versions
+          end
+        end
+      end
+    end
+
+    def versions(name)
+      @@index[name.to_s].keys
+    end
+
+    def spec(name, version)
+      @@index[name.to_s][version]
+    end
+
+    index(
+      "rdoc" => {
+        "3.12" => { "json" => "~>1.4" },
+        "3.9.0" => {},
+        "3.8.3" => { "json" => "=1.7.2" }
+      },
+      "json" => {
+        "1.7.5" => { "erubis" => "~>2.6.6" },
+        "1.7.4" => {},
+        "1.7.3" => {},
+        "1.7.2" => { "erubis" => "2.6.5" }
+      },
+      "minitest-wscolor" => {
+        "0.0.3" => { "minitest" => ">=2.3.1" },
+        "0.0.2" => {}
+      },
+      "minitest" => {
+        "3.0.4" => {},
+        "3.0.3" => {},
+        "3.0.0" => {},
+        "2.3.1" => {},
+        "2.3.0" => {},
+      },
+      "erubis" => {
+        "2.7.0" => { "minitest" => ">=3.0.0" },
+        "2.6.6" => {},
+        "2.6.5" => {}
+      },
+      "rack" => {
+        "1.4.1" => {},
+        "1.4.0" => {},
+        "1.3.6" => {},
+        "1.2.5" => {},
+        "1.1.3" => {}
+      },
+      "harbor" => {
+        "0.16.12" => { "erubis" => ">=0", "rack" => "~>1.0.0", "json" => ">=0" },
+        "0.16.11" => { "erubis" => ">=0", "rack" => "~>1.0.0" },
+        "0.16.10" => { "erubis" => ">=0", "rack" => ">=0" }
+      },
+      "hello" => {
+        "4.0" => { "harbor" => "~>0.16.10", "json" => "~>1.7.0", "minitest-wscolor" => "=0.0.3" },
+        "3.9" => { "harbor" => ">=0", "json" => ">=0", "minitest-wscolor" => ">=0", "minitest" => "~>2.3" },
+        "3.8" => { "harbor" => ">=0", "erubis" => "~>2.6.5" },
+        "2.2" => { "harbor" => ">=0" }
+      },
+      "top-level" => {
+        "1.0" => { "mid-level-1" => ">=0", "mid-level-2" => ">=0" }
+      },
+      "mid-level-1" => {
+        "2.0" => { "bottom-level" => [ ">=1.0", "<=3.0" ] },
+        "1.0" => {}
+      },
+      "mid-level-2" => {
+        "2.0" => { "bottom-level" => ">=2.0" },
+        "1.0" => {}
+      },
+      "bottom-level" => {
+        "2.3" => {},
+        "2.0" => {},
+        "1.3" => {},
+        "1.0" => {},
+        "0.9" => {}
+      },
+      "get-the-old-one" => {
+        "1.0" => { "locked-mid-1" => ">=0", "locked-mid-2" => ">=0" },
+        "0.5" => {}
+      },
+      "locked-mid-1" => {
+        "2.0" => { "old-bottom" => "=2.0" },
+        "1.3" => { "old-bottom" => "=0.5" },
+        "1.0" => {}
+      },
+      "locked-mid-2" => {
+        "2.0" => { "old-bottom" => "=2.1" },
+        "1.4" => { "old-bottom" => "=0.5" },
+        "1.0" => {}
+      },
+      "old-bottom" => {
+        "2.1" => {},
+        "2.0" => {},
+        "1.0" => {},
+        "0.5" => {}
+      },
+      "oops" => {
+        "1.0" => { "oops-2" => "=2.0" }
+      },
+      "oops-2" => {
+        "1.0" => {}
+      }
+    )
+  end
+end

data/test/lockfile_spec.rb

@@ -195,32 +195,24 @@ describe Doubleshot::Lockfile do
       @lockfile_contents = <<-EOS.margin
         ---
         GEMS:
-          backports (2.6.4): []
-          ffi (1.0.11): []
-          ffi (1.0.11-java): []
-          hitimes (1.1.1): []
-          hitimes (1.1.1-java): []
-          minitest (3.4.0): []
-          minitest-wscolor (0.0.3):
-          - minitest (>= 2.3.1)
-          multi_json (1.3.6): []
-          path (1.3.1): []
-          perfer (0.2.0):
-          - backports (~> 2.6.3)
-          - ffi (~> 1.0.11)
-          - hitimes (~> 1.1.1)
-          - path (~> 1.3.1)
+          - backports:2.6.4
+          - ffi:1.0.11
+          - hitimes:1.1.1
+          - minitest:3.4.0
+          - minitest-wscolor:0.0.3
+          - multi_json:1.3.6
+          - path:1.3.1
+          - perfer:0.2.0
         JARS: []
       EOS
     end
 
     it "must handle proper YAML format" do
-      skip
       lockfile "test_good.lock" do |lockfile|
         lockfile.path.open("w+") do |file|
           file << @lockfile_contents
         end
-        lockfile.gems.size.must_equal 10
+        lockfile.gems.size.must_equal 8
       end
     end
 

data/test/pom_spec.rb

@@ -15,6 +15,8 @@ describe Doubleshot::Pom do
       config.jar "org.jruby:jruby-complete:jar:1.7.0.RC1"
       config.jar "org.sonatype.aether:aether-api:jar:1.13.1"
       config.jar "org.sonatype.aether:aether-util:jar:1.13.1"
+      config.jar("org.sonatype.aether:aether-connector-wagon:1.13.1").exclude("org.sonatype.sisu:sisu-guice")
+      config.jar("testing:chaining-exclusions:jar:0.0.1").exclude("testing:exclusion-1").exclude("testing:exclusion-2")
 
       config.gemspec do |spec|
         spec.summary       = "Build, Dependencies and Testing all in one!"
@@ -59,8 +61,36 @@ describe Doubleshot::Pom do
             <type>jar</type>
             <version>1.13.1</version>
           </dependency>
+          <dependency>
+            <groupId>org.sonatype.aether</groupId>
+            <artifactId>aether-connector-wagon</artifactId>
+            <type>jar</type>
+            <version>1.13.1</version>
+            <exclusions>
+              <exclusion>
+                <groupId>org.sonatype.sisu</groupId>
+                <artifactId>sisu-guice</artifactId>
+              </exclusion>
+            </exclusions>
+          </dependency>
+          <dependency>
+            <groupId>testing</groupId>
+            <artifactId>chaining-exclusions</artifactId>
+            <type>jar</type>
+            <version>0.0.1</version>
+            <exclusions>
+              <exclusion>
+                <groupId>testing</groupId>
+                <artifactId>exclusion-1</artifactId>
+              </exclusion>
+              <exclusion>
+                <groupId>testing</groupId>
+                <artifactId>exclusion-2</artifactId>
+              </exclusion>
+            </exclusions>
+          </dependency>
         </dependencies>
       </project>
     EOS
   end
-end
+end

data/test/resolver/gem_resolver/artifact_spec.rb

@@ -0,0 +1,106 @@
+#!/usr/bin/env jruby
+
+# encoding: utf-8
+
+require_relative "../../helper"
+
+describe Doubleshot::Resolver::GemResolver::Artifact do
+
+  before do
+    @graph = Doubleshot::Resolver::GemResolver::Graph.new
+    @artifact = Doubleshot::Resolver::GemResolver::Artifact.new(@graph, "listen", "1.0")
+  end
+
+  describe "equality" do
+    it "must equal another artifact with the same name and version" do
+      artifact_1 = Doubleshot::Resolver::GemResolver::Artifact.new(@graph, "listen", "1.0")
+      artifact_2 = Doubleshot::Resolver::GemResolver::Artifact.new(@graph, "listen", "1.0")
+      artifact_1.must_equal artifact_2
+    end
+
+    it "must not equal another artifact with the same name but different version" do
+      artifact_1 = Doubleshot::Resolver::GemResolver::Artifact.new(@graph, "listen", "1.0")
+      artifact_2 = Doubleshot::Resolver::GemResolver::Artifact.new(@graph, "listen", "2.0")
+      artifact_1.wont_equal artifact_2
+    end
+
+    it "must not equal another artifact with the same version but different name" do
+      artifact_1 = Doubleshot::Resolver::GemResolver::Artifact.new(@graph, "listen", "1.0")
+      artifact_2 = Doubleshot::Resolver::GemResolver::Artifact.new(@graph, "not_listen", "1.0")
+      artifact_1.wont_equal artifact_2
+    end
+  end
+
+  describe "sorting" do
+    it "must sort artifacts by their name, then version number" do
+      artifact_1 = Doubleshot::Resolver::GemResolver::Artifact.new(@graph, "listen", "1.0")
+      artifact_2 = Doubleshot::Resolver::GemResolver::Artifact.new(@graph, "listen", "2.0")
+
+      [artifact_2, artifact_1].sort.must_equal [artifact_1, artifact_2]
+    end
+  end
+
+  describe "#dependencies" do
+    it "returns an array" do
+      @artifact.dependencies.must_be_kind_of Array
+    end
+
+    it "returns an empty array if no dependencies have been accessed" do
+      @artifact.dependencies.must_be_empty
+    end
+  end
+
+  describe "#depends" do
+    before do
+      @name = "nginx"
+      @constraint = "~> 0.101.5"
+    end
+
+    describe "given a name and constraint argument" do
+      describe "given the dependency of the given name and constraint does not exist" do
+        it "returns a Solve::Artifact" do
+          @artifact.depends(@name, @constraint).must_be_kind_of Doubleshot::Resolver::GemResolver::Artifact
+        end
+
+        it "adds a dependency with the given name and constraint to the list of dependencies" do
+          @artifact.depends(@name, @constraint)
+
+          @artifact.dependencies.size.must_equal 1
+          @artifact.dependencies.first.name.must_equal @name
+          @artifact.dependencies.first.constraint.to_s.must_equal @constraint
+        end
+      end
+    end
+
+    describe "given only a name argument" do
+      it "adds a dependency with a all constraint (>= 0.0.0)" do
+        @artifact.depends(@name)
+
+        @artifact.dependencies.size.must_equal 1
+        @artifact.dependencies.first.constraint.to_s.must_equal ">= 0"
+      end
+    end
+  end
+
+  describe "::get_dependency" do
+
+    it "returns an instance of Solve::Dependency matching the given name and constraint" do
+      @artifact.depends("nginx", "~> 1.2.3")
+      dependency = @artifact.get_dependency("nginx", "~> 1.2.3")
+
+      dependency.must_be_kind_of Doubleshot::Resolver::GemResolver::Dependency
+      dependency.name.must_equal "nginx"
+      dependency.constraint.to_s.must_equal "~> 1.2.3"
+    end
+  end
+
+  describe "#delete" do
+
+    describe "given the artifact is not the member of a graph" do
+      it "returns nil" do
+        artifact = Doubleshot::Resolver::GemResolver::Artifact.new(nil, "listen", "1.0")
+        artifact.delete.must_be_nil
+      end
+    end
+  end
+end