double_write_cache_stores 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c1b53be871c512480d251a6d411cc3dcd2ff391e
-  data.tar.gz: 47c427763f33ef56bbef8ab5e7fa921bef77fcaa
+  metadata.gz: 5dbec8739b2952e40813ae8355317815e4ac6769
+  data.tar.gz: 7f17258222ba0e1211ee777e69193def91723fc4
 SHA512:
-  metadata.gz: 416562388ed98b45fca02ee8f14025218553fbed0d0e212e5e418b9864ebc0edd25d9fb1da77bf3bc33a7f5d929b1498f62646ca363b933c23190ba89bd83f2d
-  data.tar.gz: f4499eb06af3667fef35803205773aad6f91909c86976609c58d2db7adffce5df36f75f1892dada4488b06ba43fdbae7415210adc682f4f1242a379b231c5b06
+  metadata.gz: 1c84a1e5255940a10299a068298666a82138f99e9623d737256f20f572bc6f792be8bc90ea5a93ac2fc8eef76ed0b1e1fdfd778fb865e08e3d1d186b1ef6d3c8
+  data.tar.gz: bc644b50386794570dc390a7e40af9bc4a86e6bb1f527df621a7da213f89bb8d6936714f2deecf1c423b42d9b58c242c58de9dabb64e8d06f295e810ed908fd0

data/README.md

@@ -2,10 +2,16 @@
 
 pre-warning(double write to cach store and other cache store) cache store wrapper. will switch cache store.
 
-## Support
+## Convertible interface, get/set by cache store
 
+- Padrino::Cache(moneta)
 - ActiveSupport::Cache::DalliStore(Dalli)
-- Padrino::Cache(v0.12.x)
+- Padrino::Cache::Store::Memcache
+
+## Support backend cache store
+
+- ActiveSupport::Cache::DalliStore(Dalli)
+- Padrino::Cache::Store::Memcache
 
 ## Installation
 

data/double_write_cache_stores.gemspec

@@ -22,7 +22,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "activesupport", "= 3.2.15"
-  spec.add_development_dependency "dalli", "= 2.6.4"
+  spec.add_development_dependency "dalli", "= 2.7.0"
   spec.add_development_dependency "pry"
-  spec.add_development_dependency "padrino", "0.12.2"
+  spec.add_development_dependency "padrino", "0.10.7"
+  spec.add_development_dependency "tilt", "1.3.7"
 end

data/lib/double_write_cache_stores/client.rb

@@ -17,6 +17,20 @@ class DoubleWriteCacheStores::Client
     get_or_read_method_call key
   end
 
+  def get_cas(key)
+    @read_and_write_store.get_cas key
+  end
+
+  def set_cas(key, value, cas, options = nil)
+    cas_unique = @read_and_write_store.set_cas key, value, cas, options
+
+    if @write_only_store && cas_unique
+      set_or_write_method_call @write_only_store, key, value, options
+    end
+
+    cas_unique
+  end
+
   def read(key)
     get_or_read_method_call key
   end
@@ -27,11 +41,7 @@ class DoubleWriteCacheStores::Client
   end
 
   def []=(key, value)
-    write_cache_store key, value
-  end
-
-  def store(key, value, options = nil)
-    write_cache_store key, value, options
+    set key, value
   end
 
   def set(key, value, options = nil)
@@ -44,9 +54,7 @@ class DoubleWriteCacheStores::Client
 
   def touch(key)
     result = false
-
-    read_and_write_backend = get_backend @read_and_write_store
-
+    read_and_write_backend = @read_and_write_store.instance_variable_get('@backend') || @read_and_write_store.instance_variable_get('@data')
     if read_and_write_backend && read_and_write_backend.respond_to?(:touch)
       result = read_and_write_backend.touch key
       write_only_store_touch key
@@ -55,43 +63,22 @@ class DoubleWriteCacheStores::Client
   end
 
   def flush
-    if flush_cache_store || flush_cache_store(:flush)
+    if flush_cache_store || flush_cache_store(:clear)
       true
     else
       false
     end
   end
 
-  alias :clear :flush
-
   private
 
-  def get_backend cache_store
-    if cache_store.is_a? Padrino::Cache::LegacyStore
-      cache_store.instance_variable_get('@adapter').instance_variable_get('@adapter').instance_variable_get('@backend')
-    else
-      cache_store.instance_variable_get '@backend'
-    end
-  end
-
   def write_cache_store(key, value, options = nil)
     set_or_write_method_call @read_and_write_store, key, value, options
     set_or_write_method_call @write_only_store, key, value, options if @write_only_store
   end
 
   def set_or_write_method_call cache_store, key, value, options
-    if cache_store.is_a? Padrino::Cache::LegacyStore
-      if options && options[:expires_in]
-        options[:expires] = options[:expires_in].to_i
-        options[:expires_in] = nil
-      end
-    end
-
-    if cache_store.respond_to?(:[]=) && options.nil?
-      cache_store[key] = value
-    elsif cache_store.respond_to? :store
-      cache_store.store key, value, options
-    elsif cache_store.respond_to? :set
+    if cache_store.respond_to? :set
       cache_store.set key, value, options
     elsif cache_store.respond_to? :write
       cache_store.write key, value, options
@@ -99,16 +86,14 @@ class DoubleWriteCacheStores::Client
   end
 
   def get_or_read_method_call key
-    if @read_and_write_store.respond_to? :[]
-      @read_and_write_store[key]
-    elsif @read_and_write_store.respond_to? :get
+    if @read_and_write_store.respond_to? :get
       @read_and_write_store.get key
     elsif @read_and_write_store.respond_to? :read
       @read_and_write_store.read key
     end
   end
 
-  def flush_cache_store(method = :clear)
+  def flush_cache_store(method = :flush)
     if @read_and_write_store.respond_to? method
       if @write_only_store && @write_only_store.respond_to?(method)
         @write_only_store.send method
@@ -121,7 +106,8 @@ class DoubleWriteCacheStores::Client
 
   def write_only_store_touch(key)
     if @write_only_store
-      if write_only_backend = get_backend(@write_only_store)
+      write_only_backend = @write_only_store.instance_variable_get('@backend') || @write_only_store.instance_variable_get('@data')
+      if write_only_backend
         write_only_backend.touch key if write_only_backend.respond_to?(:touch)
       end
     end

data/lib/double_write_cache_stores/version.rb

@@ -1,3 +1,3 @@
 module DoubleWriteCacheStores
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

data/spec/double_write_cache_stores/client_spec.rb

@@ -29,13 +29,10 @@ describe DoubleWriteCacheStores::Client do
     end
   end
 
-  describe '#[]=' do
-    before do
+  describe 'set #[]=(key, value) and get #[](key)' do
+    it 'set value and get value' do
       copy_cache_store['key'] = 'example-value'
-    end
-    it 'set value to multi store' do
-      expect(read_and_write_store.read 'key').to eq 'example-value'
-      expect(write_only_store.read 'key').to eq 'example-value'
+      expect(copy_cache_store['key']).to eq 'example-value'
     end
   end
 
@@ -59,10 +56,10 @@ describe DoubleWriteCacheStores::Client do
       { :namespace => "app_v1", :compress => true }
     end
     let :support_touch_read_and_write_store do
-      Padrino::Cache.new(:Memcached, :backend => ::Dalli::Client.new('localhost:11211', options))
+      Padrino::Cache::Store::Memcache.new(::Dalli::Client.new('localhost:11211', options))
     end
     let :support_touch_write_only_store do
-      Padrino::Cache.new(:Memcached, :backend => ::Dalli::Client.new('localhost:21211', options))
+      Padrino::Cache::Store::Memcache.new(::Dalli::Client.new('localhost:21211', options))
     end
     let :support_touch_copy_cache_store do
       DoubleWriteCacheStores::Client.new support_touch_read_and_write_store, support_touch_write_only_store
@@ -70,30 +67,26 @@ describe DoubleWriteCacheStores::Client do
     before do
       support_touch_copy_cache_store.set 'touch-key', 'touch-value', :expires_in => 1.day
     end
-    it 'example' do
-      expect(support_touch_copy_cache_store.touch 'touch-key').to be_true
-      expect(support_touch_copy_cache_store.touch 'non-set-key').to be_nil
-    end
-    context 'when touch non support backend' do
-      before do
-        copy_cache_store.write 'unsupport-touch-key', 'touch-value', :expires_in => 1.day
-      end
-      it 'not doing touch' do
-        expect(copy_cache_store.touch 'unsupport-touch-key').to be_false
+
+    context 'Dalli::Client' do
+      it 'example' do
+        expect(support_touch_copy_cache_store.touch 'touch-key').to be true
+        expect(support_touch_copy_cache_store.touch 'non-set-key').to be nil
       end
     end
-  end
 
-  describe '#[]' do
-    context 'when standard case' do
-      before do
-        copy_cache_store.write 'key', 'example-read-value', :expires_in => 1.day
+    context 'ActiveSupport::Cache::DalliStore' do
+      let :double_write_dalli_store do
+        DoubleWriteCacheStores::Client.new ActiveSupport::Cache::DalliStore.new('localhost:11211', options), ActiveSupport::Cache::DalliStore.new('localhost:21211', options)
       end
-      it 'get read key value from multi store' do
-        expect(copy_cache_store['key']).to eq 'example-read-value'
+
+      before do
+        double_write_dalli_store.set 'touch-key', 'touch-valule', :expires_in => 1.day
       end
-      it 'not get no set key-value' do
-        expect(copy_cache_store['not-set-key']).to be_nil
+
+      it 'example' do
+        expect(double_write_dalli_store.touch 'touch-key').to be true
+        expect(double_write_dalli_store.touch 'non-set-key').to be nil
       end
     end
   end
@@ -139,10 +132,10 @@ describe DoubleWriteCacheStores::Client do
         { :namespace => "app_v1", :compress => true }
       end
       let :support_flash_read_and_write_store do
-        Padrino::Cache.new(:Memcached, :backend => ::Dalli::Client.new('localhost:11211', options))
+        Padrino::Cache::Store::Memcache.new(::Dalli::Client.new('localhost:11211', options))
       end
       let :support_flash_write_only_store do
-        Padrino::Cache.new(:Memcached, :backend => ::Dalli::Client.new('localhost:21211', options))
+        Padrino::Cache::Store::Memcache.new(::Dalli::Client.new('localhost:21211', options))
       end
       let :support_flash_copy_cache_store do
         DoubleWriteCacheStores::Client.new support_flash_read_and_write_store, support_flash_write_only_store
@@ -152,54 +145,66 @@ describe DoubleWriteCacheStores::Client do
       end
       it 'example' do
         expect(support_flash_copy_cache_store.get 'will-flush-key').to eq 'will-flush-value'
-        expect(support_flash_copy_cache_store.flush).to be_true
+        expect(support_flash_copy_cache_store.flush).to be true
         expect(support_flash_copy_cache_store.get 'will-flush-key').to be_nil
       end
     end
   end
 
-  describe '#clear' do
-    before do
-      copy_cache_store.write 'will-flush-key', 'will-flush-value', :expires_in => 1.day
-    end
-    it 'alias #flush' do
-      expect(copy_cache_store.clear).to eq true
-      expect(copy_cache_store.read 'will-flush-key').to be_nil
-    end
-  end
+  describe "#get_cas" do
+    context "when support get_cas method in backend cache store" do
+      let :support_get_cas_cache_store do
+        read_and_write = ::Dalli::Client.new(['localhost:11211'])
+        write_only = ::Dalli::Client.new(['localhost:21211'])
+        DoubleWriteCacheStores::Client.new read_and_write, write_only
+      end
 
-  describe 'check any cache_store' do
-      let :options do
-        { :namespace => "app_v1", :compress => true }
+      before do
+        support_get_cas_cache_store.set 'cas-dalli-key', 'cas-dalli-value'
       end
 
-    it 'ActiveSupport::Cache::DalliStore x ActiveSupport::Cache::DalliStore' do
-      any_cach_store_checks ActiveSupport::Cache.lookup_store(:dalli_store, 'localhost:11211'), ActiveSupport::Cache.lookup_store(:dalli_store, 'localhost:21211')
+      it 'example' do
+        expect(support_get_cas_cache_store.get_cas('cas-dalli-key')[0]).to eq 'cas-dalli-value'
+        expect(support_get_cas_cache_store.get_cas('cas-dalli-key')[1]).to be_kind_of(Integer)
+      end
     end
 
-    it 'Padrino::Cache x Padrino::Cache' do
-      write_and_read_memcached = ::Dalli::Client.new 'localhost:11211', options
-      read_only_memcached = ::Dalli::Client.new 'localhost:21211', options
-      any_cach_store_checks Padrino::Cache.new(:Memcached, :backend => write_and_read_memcached), Padrino::Cache.new(:Memcached, :backend => read_only_memcached)
+    context "when doesn't support get_cas method in backend cache store" do
+      let :not_support_get_cas_cache_store do
+        DoubleWriteCacheStores::Client.new ActiveSupport::Cache::DalliStore.new('localhost:11211'), ActiveSupport::Cache::DalliStore.new('localhost:21211')
+      end
+
+      it 'should raise NoMethodError' do
+        expect{ not_support_get_cas_cache_store.get_cas 'cas-key' }.to raise_error(NoMethodError)
+      end
     end
+  end
 
-    def any_cach_store_checks read_and_write_store, write_only_store
-      double_write_cache_store = DoubleWriteCacheStores::Client.new read_and_write_store, write_only_store
-      double_write_cache_store['aaa'] = 'aaa-value'
-      double_write_cache_store.set 'bbb', 'bbb-value'
-      double_write_cache_store.write 'ccc', 'ccc-value'
-      double_write_cache_store.store 'ddd', 'ddd-value'
+  describe "#set_cas" do
+    context "when support set_cas method in backend cache store" do
+      let :support_set_cas_cache_store do
+        read_and_write = ::Dalli::Client.new(['localhost:11211'])
+        write_only = ::Dalli::Client.new(['localhost:21211'])
+        DoubleWriteCacheStores::Client.new read_and_write, write_only
+      end
+      let :cas_unique do
+        support_set_cas_cache_store.set('cas-dalli-key', 'cas-value')
+        support_set_cas_cache_store.get_cas('cas-dalli-key')[1]
+      end
 
+      it 'example' do
+        expect(support_set_cas_cache_store.set_cas('cas-dalli-key', 'cas-dalli-value', cas_unique)).to be_kind_of(Integer)
+      end
+    end
 
-      expect(double_write_cache_store['aaa']).to eq 'aaa-value'
-      expect(double_write_cache_store.get 'bbb').to eq 'bbb-value'
-      expect(double_write_cache_store.read 'ccc').to eq 'ccc-value'
-      expect(double_write_cache_store['ddd']).to eq 'ddd-value'
+    context "when doesn't support set_cas method in backend cache store" do
+      let :not_support_set_cas_cache_store do
+        DoubleWriteCacheStores::Client.new ActiveSupport::Cache::DalliStore.new('localhost:11211'), ActiveSupport::Cache::DalliStore.new('localhost:21211')
+      end
 
-      expect(double_write_cache_store['zzz']).to eq nil
-      expect(double_write_cache_store.get 'zzz').to eq nil
-      expect(double_write_cache_store.read 'zzz').to eq nil
+      it 'should raise NoMethodError' do
+        expect{ not_support_set_cas_cache_store.set_cas('cas-key', 'cas-value', 1) }.to raise_error(NoMethodError)
+      end
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -2,6 +2,7 @@ $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 require 'double_write_cache_stores'
 require 'active_support'
 require 'dalli'
+require 'dalli/cas/client'
 require 'pry'
 require 'padrino-cache'
 

metadata

@@ -1,55 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: double_write_cache_stores
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - hirocaster
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-21 00:00:00.000000000 Z
+date: 2015-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -72,26 +72,26 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.4
+        version: 2.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.4
+        version: 2.7.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -100,25 +100,39 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.12.2
+        version: 0.10.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.12.2
-description: ' pre-warning(double write to cach store and other cache store) cache
-  store wrapper. will switch cache store. '
+        version: 0.10.7
+- !ruby/object:Gem::Dependency
+  name: tilt
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.3.7
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.3.7
+description: " pre-warning(double write to cach store and other cache store) cache
+  store wrapper. will switch cache store. "
 email:
 - hohtsuka@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -140,17 +154,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Double write cache stores wrapper.