double_entry 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2de3c5bcd2513815b3240072a87abed07c054176
-  data.tar.gz: 441671942df5faff21b7db426075a8dd26822fbc
+  metadata.gz: 4d879d4baf12d4479b4533fb5032c27c0ef4968f
+  data.tar.gz: dfeda86d6a9147c2cb99313c3136f1fe2bbe3ca3
 SHA512:
-  metadata.gz: 88e504ea0d5504c1ce05e63a01ad5697b1cc045298c51a02b52b8bfafb969e5facf0235e727ba600f83b317483b72c9ce284d3dd6e5ac1227aefb40d339696f9
-  data.tar.gz: a669b5f44cc5e955f9c942301748bac1622f58e34082f892b9c12f38dd76aa8d16a85533d8e8e08ab0d2a6440498eba81b93c4cc2311a67538cc8fd5607cd3ae
+  metadata.gz: 4415c2eae26420297541d515cabf79eb2eb7833c10c4984724e391d9f3ebad20f86178837fad21ee91baebf9ee57332554c617a2ab3cb856375b21df9a92dc07
+  data.tar.gz: 45c892f2e32784e8aefcbadb014372729e59ce9089c7ab5ebd075679b50be04a87bc5b81f9c00638dca4d79466cd18a6390f8b970a24ed9377d3eaabf89d83b3

data/.travis.yml

@@ -1,32 +1,29 @@
 language: ruby
+sudo: false
 before_script:
   - cp spec/support/database.travis.yml spec/support/database.yml
   - mysql -e 'create database double_entry_test;'
   - psql -c 'create database double_entry_test;' -U postgres
 script:
-  - rake spec
+  - bundle exec rake spec
   - ruby script/jack_hammer -t 2000
-  - rake rubocop
 matrix:
   include:
-    - rvm: 1.9.3
-      gemfile: spec/support/gemfiles/Gemfile.rails-4.2.x
-      env: DB=mysql
-    - rvm: 2.0.0
-      gemfile: spec/support/gemfiles/Gemfile.rails-4.2.x
+    - rvm: 2.1
+      gemfile: spec/support/gemfiles/Gemfile.rails-3.2.x
       env: DB=mysql
-    - rvm: 2.2.2
+    - rvm: 2.2
       gemfile: spec/support/gemfiles/Gemfile.rails-4.1.x
       env: DB=mysql
-    - rvm: 2.2.2
+    - rvm: 2.2
       gemfile: spec/support/gemfiles/Gemfile.rails-4.2.x
       env: DB=mysql
-    - rvm: 2.2.2
-      gemfile: spec/support/gemfiles/Gemfile.rails-4.2.x
+    - rvm: 2.3
+      gemfile: spec/support/gemfiles/Gemfile.rails-5.0.x
+      env: DB=mysql
+    - rvm: 2.3
+      gemfile: spec/support/gemfiles/Gemfile.rails-5.0.x
       env: DB=sqlite
-    - rvm: 2.2.2
-      gemfile: spec/support/gemfiles/Gemfile.rails-4.2.x
+    - rvm: 2.3
+      gemfile: spec/support/gemfiles/Gemfile.rails-5.0.x
       env: DB=postgres
-    - rvm: 2.1.6
-      gemfile: spec/support/gemfiles/Gemfile.rails-3.2.x
-      env: DB=mysql

data/README.md

@@ -3,7 +3,7 @@
 
 [![License MIT](https://img.shields.io/badge/license-MIT-brightgreen.svg)](https://github.com/envato/double_entry/blob/master/LICENSE.md)
 [![Gem Version](https://badge.fury.io/rb/double_entry.svg)](http://badge.fury.io/rb/double_entry)
-[![Build Status](https://travis-ci.org/envato/double_entry.svg?branch=master)](https://travis-ci.org/envato/double_entry)
+[![Build Status](https://travis-ci.org/envato/double_entry.svg?branch=1-stable)](https://travis-ci.org/envato/double_entry)
 [![Code Climate](https://codeclimate.com/github/envato/double_entry.png)](https://codeclimate.com/github/envato/double_entry)
 
 ![Show me the Money](http://24.media.tumblr.com/tumblr_m3bwbqNJIG1rrgbmqo1_500.gif)
@@ -22,15 +22,15 @@ DoubleEntry uses the [Money gem](https://github.com/RubyMoney/money) to encapsul
 DoubleEntry is tested against:
 
 Ruby
- * 1.9.3
- * 2.0.0
- * 2.1.5
- * 2.2.0
+ * 2.1.x
+ * 2.2.x
+ * 2.3.x
 
 Rails
  * 3.2.x
  * 4.1.x
  * 4.2.x
+ * 5.0.x
 
 Databases
  * MySQL
@@ -227,7 +227,7 @@ Run a concurrency test on the code.
 This spawns a bunch of processes, and does random transactions between a set
 of accounts, then validates that all the numbers add up at the end.
 
-You can also tell out it to flush out the account balances table at regular
+You can also tell it to flush out the account balances table at regular
 intervals, to validate that new account balances records get created with the
 correct balances from the lines table.
 

data/Rakefile

@@ -1,21 +1,15 @@
 require 'rspec/core/rake_task'
 require 'bundler/gem_tasks'
-require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.verbose = false
   t.ruby_opts = '-w'
 end
 
-RuboCop::RakeTask.new(:rubocop) do |t|
-  t.fail_on_error = true
-end
-
 task :default do
   %w(mysql postgres sqlite).each do |db|
     puts "Running tests with `DB=#{db}`"
     ENV['DB'] = db
     Rake::Task['spec'].execute
   end
-  Rake::Task['rubocop'].execute
 end

data/double_entry.gemspec

@@ -5,17 +5,17 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'double_entry/version'
 
 Gem::Specification.new do |gem|
-  gem.name          = 'double_entry'
-  gem.version       = DoubleEntry::VERSION
-  gem.authors       = ['Anthony Sellitti', 'Keith Pitt', 'Martin Jagusch', 'Martin Spickermann', 'Mark Turnley', 'Orien Madgwick', 'Pete Yandall', 'Stephanie Staub']
-  gem.email         = ['anthony.sellitti@envato.com', 'me@keithpitt.com', '_@mj.io', 'spickemann@gmail.com', 'mark@envato.com', '_@orien.io', 'pete@envato.com', 'staub.steph@gmail.com']
-  gem.summary       = 'Tools to build your double entry financial ledger'
-  gem.homepage      = 'https://github.com/envato/double_entry'
+  gem.name                  = 'double_entry'
+  gem.version               = DoubleEntry::VERSION
+  gem.authors               = ['Anthony Sellitti', 'Keith Pitt', 'Martin Jagusch', 'Martin Spickermann', 'Mark Turnley', 'Orien Madgwick', 'Pete Yandall', 'Stephanie Staub', 'Giancarlo Salamanca']
+  gem.email                 = ['anthony.sellitti@envato.com', 'me@keithpitt.com', '_@mj.io', 'spickemann@gmail.com', 'mark@envato.com', '_@orien.io', 'pete@envato.com', 'staub.steph@gmail.com', 'giancarlo@salamanca.net.au']
+  gem.summary               = 'Tools to build your double entry financial ledger'
+  gem.homepage              = 'https://github.com/envato/double_entry'
 
-  gem.files         = `git ls-files`.split($/)
-  gem.executables   = gem.files.grep(%r{bin/}).map { |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.require_paths = ['lib']
+  gem.files                 = `git ls-files`.split($/)
+  gem.executables           = gem.files.grep(%r{bin/}).map { |f| File.basename(f) }
+  gem.test_files            = gem.files.grep(%r{^(test|spec|features)/})
+  gem.require_paths         = ['lib']
 
   gem.post_install_message = <<-'POSTINSTALLMESSAGE'
 Please note the following changes in DoubleEntry:
@@ -62,7 +62,7 @@ POSTINSTALLMESSAGE
   gem.add_development_dependency 'generator_spec'
   gem.add_development_dependency 'machinist'
   gem.add_development_dependency 'timecop'
-  gem.add_development_dependency 'rubocop', '~> 0.32.0'
+  gem.add_development_dependency 'test-unit'
 
   gem.add_development_dependency 'pry'
   gem.add_development_dependency 'pry-doc'

data/lib/double_entry/line.rb

@@ -132,11 +132,11 @@ module DoubleEntry
     end
 
     def decrease?
-      amount < Money.zero
+      amount.negative?
     end
 
     def increase?
-      amount > Money.zero
+      amount.positive?
     end
 
     # Query out just the id and created_at fields for lines, without
@@ -151,10 +151,10 @@ module DoubleEntry
   private
 
     def check_balance_will_remain_valid
-      if account.positive_only && balance < Money.zero
+      if account.positive_only && balance.negative?
         fail AccountWouldBeSentNegative, account
       end
-      if account.negative_only && balance > Money.zero
+      if account.negative_only && balance.positive?
         fail AccountWouldBeSentPositiveError, account
       end
     end

data/lib/double_entry/reporting/line_aggregate_filter.rb

@@ -15,13 +15,11 @@ module DoubleEntry
 
     private
 
-      attr_reader :account, :code, :range, :filter_criteria
-
       def apply_filters
         collection = apply_filter_criteria.
-                     where(:account => account).
-                     where(:created_at => range.start..range.finish)
-        collection = collection.where(:code => code) if code
+                     where(:account => @account).
+                     where(:created_at => @range.start..@range.finish)
+        collection = collection.where(:code => @code) if @code
 
         collection
       end
@@ -52,7 +50,7 @@ module DoubleEntry
       #     }
       #   ]
       def apply_filter_criteria
-        filter_criteria.reduce(DoubleEntry::Line) do |collection, filter|
+        @filter_criteria.reduce(DoubleEntry::Line) do |collection, filter|
           if filter[:scope].present?
             filter_by_scope(collection, filter[:scope])
           elsif filter[:metadata].present?

data/lib/double_entry/transfer.rb

@@ -16,7 +16,7 @@ module DoubleEntry
 
       # @api private
       def transfer(amount, options = {})
-        fail TransferIsNegative if amount < Money.zero
+        fail TransferIsNegative if amount.negative?
         from_account = options[:from]
         to_account = options[:to]
         code = options[:code]

data/lib/double_entry/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module DoubleEntry
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/script/jack_hammer

@@ -5,7 +5,7 @@
 # This spawns a bunch of processes, and does random transactions between a set
 # of accounts, then validates that all the numbers add up at the end.
 #
-# You can also tell out it to flush our the account balances table at regular
+# You can also tell it to flush our the account balances table at regular
 # intervals, to validate that new account balances records get created with the
 # correct balances from the lines table.
 #
@@ -109,6 +109,7 @@ def run_tests
   $balance_flush_count.times do
     puts "Flushing balances"
     DoubleEntry::AccountBalance.delete_all
+    ActiveRecord::Base.connection_pool.disconnect!
 
     if $use_threads
       puts "Using threads as workers"
@@ -127,14 +128,11 @@ def run_tests
 
       pids.each {|pid| Process.wait2(pid) }
     end
-
-    ActiveRecord::Base.connection_pool.disconnect!
   end
 end
 
 
 def run_process(iterations, process_num)
-  ActiveRecord::Base.connection_pool.disconnect!  # Get a unique DB connection for this process.
   srand  # Seed the random number generator separately for each process.
 
   puts "Process #{process_num} running #{iterations} transfers..."

data/spec/generators/double_entry/install/install_generator_spec.rb

@@ -13,7 +13,7 @@ RSpec.describe DoubleEntry::Generators::InstallGenerator do
   end
 
   specify do
-    expect(destination_root).to have_structure do
+    expect(destination_root).to have_structure {
       directory 'db' do
         directory 'migrate' do
           migration 'create_double_entry_tables' do
@@ -25,6 +25,6 @@ RSpec.describe DoubleEntry::Generators::InstallGenerator do
           end
         end
       end
-    end
+    }
   end
 end

data/spec/spec_helper.rb

@@ -3,6 +3,11 @@ require 'bundler/setup'
 require 'active_record'
 require 'active_support'
 
+if ActiveRecord::VERSION::MAJOR < 4
+  require 'test-unit'
+  Test::Unit::AutoRunner.need_auto_run = false
+end
+
 db_engine = ENV['DB'] || 'mysql'
 
 FileUtils.mkdir_p 'tmp'

data/spec/support/gemfiles/Gemfile.rails-3.2.x

@@ -2,6 +2,7 @@ source 'https://rubygems.org'
 
 gemspec :path => '../../../'
 
+gem 'mysql2', '< 0.4'
 gem 'i18n', '0.6.11'
 gem 'rails', '~> 3.2.0'
-gem 'minitest', '~> 4.7.5'
+

data/spec/support/gemfiles/Gemfile.rails-4.1.x

@@ -2,4 +2,5 @@ source 'https://rubygems.org'
 
 gemspec :path => '../../../'
 
+gem 'mysql2', '< 0.4'
 gem 'rails', '~> 4.1.0'

data/spec/support/gemfiles/Gemfile.rails-5.0.x

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gemspec :path => '../../../'
+
+gem 'rails', '~> 5.0.0'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: double_entry
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Anthony Sellitti
@@ -12,10 +12,11 @@ authors:
 - Orien Madgwick
 - Pete Yandall
 - Stephanie Staub
+- Giancarlo Salamanca
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-04 00:00:00.000000000 Z
+date: 2018-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money
@@ -228,19 +229,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.32.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.32.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -335,13 +336,13 @@ email:
 - _@orien.io
 - pete@envato.com
 - staub.steph@gmail.com
+- giancarlo@salamanca.net.au
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".rubocop.yml"
 - ".travis.yml"
 - ".yardopts"
 - Gemfile
@@ -412,6 +413,7 @@ files:
 - spec/support/gemfiles/Gemfile.rails-3.2.x
 - spec/support/gemfiles/Gemfile.rails-4.1.x
 - spec/support/gemfiles/Gemfile.rails-4.2.x
+- spec/support/gemfiles/Gemfile.rails-5.0.x
 - spec/support/performance_helper.rb
 - spec/support/reporting_configuration.rb
 - spec/support/schema.rb
@@ -459,7 +461,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Tools to build your double entry financial ledger
@@ -495,7 +497,7 @@ test_files:
 - spec/support/gemfiles/Gemfile.rails-3.2.x
 - spec/support/gemfiles/Gemfile.rails-4.1.x
 - spec/support/gemfiles/Gemfile.rails-4.2.x
+- spec/support/gemfiles/Gemfile.rails-5.0.x
 - spec/support/performance_helper.rb
 - spec/support/reporting_configuration.rb
 - spec/support/schema.rb
-has_rdoc: 

data/.rubocop.yml

@@ -1,65 +0,0 @@
-AllCops:
-  Exclude:
-    - .bundle/**/*
-    - bin/**/*
-    - tmp/**/*
-    - script/jack_hammer
-    - spec/support/schema.rb
-    - lib/generators/double_entry/install/templates/**/*
-
-Style/AccessModifierIndentation:
-  EnforcedStyle: outdent
-
-Style/DotPosition:
-  EnforcedStyle: trailing
-
-Style/GuardClause:
-  Enabled: false
-
-Style/HashSyntax:
-  EnforcedStyle: hash_rockets
-
-Style/SpecialGlobalVars:
-  Enabled: false
-
-Style/TrailingComma:
-  EnforcedStyleForMultiline: comma
-
-# TODO Enable these checks and fix codes
-
-Style/ClassVars:
-  Enabled: false
-
-Style/Documentation:
-  Enabled: false
-
-Style/DoubleNegation:
-  Enabled: false
-
-Style/ModuleFunction:
-  Enabled: false
-
-Style/ParallelAssignment:
-  Enabled: false
-
-Style/SingleLineBlockParams:
-  Enabled: false
-
-Metrics/AbcSize:
-  Max: 47 #15
-
-Metrics/CyclomaticComplexity:
-  Max: 13 #6
-
-Metrics/LineLength:
-  Max: 185
-
-Metrics/MethodLength:
-  Max: 30 # 10
-
-Metrics/ModuleLength:
-  Exclude:
-    - spec/**/*
-
-Metrics/PerceivedComplexity:
-  Max: 13 #7