double_entry 0.3.0 → 0.3.1

data/lib/double_entry/reporting/time_range_array.rb

@@ -12,9 +12,8 @@ module DoubleEntry
       end
 
       def make(start = nil, finish = nil)
-        raise "Must specify start of range" if start == nil && require_start?
-        start = type.from_time(Time.parse(start || Reporting.configuration.start_of_business))
-        finish = finish ? type.from_time(Time.parse(finish)) : type.current
+        start = start_range(start)
+        finish = finish_range(finish)
         [ start ].tap do |array|
           while start != finish
             start = start.next
@@ -23,6 +22,16 @@ module DoubleEntry
         end
       end
 
+      def start_range(start = nil)
+        raise "Must specify start of range" if start.blank? && require_start?
+        start_time = start ? Time.parse(start) : Reporting.configuration.start_of_business
+        type.from_time(start_time)
+      end
+
+      def finish_range(finish = nil)
+        finish ? type.from_time(Time.parse(finish)) : type.current
+      end
+
       FACTORIES = {
         'hour'  => new(:type => HourRange,  :require_start => true),
         'day'   => new(:type => DayRange,   :require_start => true),

data/lib/double_entry/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module DoubleEntry
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/spec/double_entry/reporting/time_range_array_spec.rb

@@ -110,12 +110,13 @@ module DoubleEntry::Reporting
     context 'for "year" range type' do
       let(:range_type) { 'year' }
 
-      context 'given start is "2007-05-03" and finish is "2008-08-24"' do
-        let(:start)  { '2007-05-03' }
-        let(:finish) { '2008-08-24' }
+      context 'given the date is "2009-11-23"' do
+        before { Timecop.freeze(Time.new(2009, 11, 23)) }
+
+        context 'given start is "2007-05-03" and finish is "2008-08-24"' do
+          let(:start)  { '2007-05-03' }
+          let(:finish) { '2008-08-24' }
 
-        context 'and the date is "2009-11-23"' do
-          before { Timecop.freeze(Time.new(2009, 11, 23)) }
 
           it 'takes notice of start and finish' do
             should eq [
@@ -123,9 +124,17 @@ module DoubleEntry::Reporting
               YearRange.from_time(Time.new(2008)),
             ]
           end
+        end
+
+        context 'given the start of business is "2006-07-10"' do
+          before do
+            allow(DoubleEntry::Reporting).
+              to receive_message_chain('configuration.start_of_business').
+              and_return(Time.new(2006, 7, 10))
+          end
 
-          context 'given finish is nil' do
-            let(:start)  { '2006-08-03' }
+          context 'given start and finish are nil' do
+            let(:start)  { nil }
             let(:finish) { nil }
             it {
               should eq [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: double_entry
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
   prerelease: 
 platform: ruby
 authors: