dotsync 0.4.1 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f1914fdcd07e4e248821a67f44903e98dd2445bb33c8fc5932af156d6da2c759
-  data.tar.gz: e6cf1fa237ebf65356524856ef1f57243dc0c8a22ce113836c0ff32622d94ec6
+  metadata.gz: 3c3cafce147e8573ff819e662666f78cd1d2cb7a2735c112cddcfccad00238a0
+  data.tar.gz: aa9e6385afc45546411af829bd269808ca4f6539bdb50153147ba86498c22e12
 SHA512:
-  metadata.gz: 55195d77f422a37d3746180f4ce42b9cc6b5b5a80ee02b4a735973d3403adfebe305653e7595345b75961be0d2d2c2179ee71c33513c94a952b20265435985e7
-  data.tar.gz: 10516395feb7ea6aaacab2ee7636eefda0a555c53d7d8f6b462532fb3e31e7c86bfd9dab4320d78322f8e6df6d940f3e116b597cf318fe0ef60e97627bb2d2da
+  metadata.gz: 4bd02887f8602282d62f40cedd9e969122861275428751d4056a6bc83beda5ef4ce1ee9574dd1ee71744148378c7b294281b6029c11440104fd990ba150e612a
+  data.tar.gz: 3278ed54194865ed62296a0976e2e468f0248716342b27c53971207fe2ebcb2a6634af225dabd68943e7300dd9aed3dc075ceaed78000580dfa3142d28ed30ae

data/AGENTS.md

@@ -1,93 +1,27 @@
-# Agents
-
-This document describes AI agents and automation helpers that can assist with developing and maintaining the Dotsync project.
-
-## Development Agents
-
-### Code Review Agent
-
-**Purpose**: Review code changes for quality, consistency, and adherence to Ruby best practices.
-
-**When to use**:
-- Before submitting pull requests
-- After implementing new features
-- When refactoring existing code
-
-**What it checks**:
-- Ruby style guide compliance (follows .rubocop.yml)
-- Test coverage for new functionality
-- Proper error handling
-- Documentation completeness
-- Performance considerations
-
-### Test Generation Agent
-
-**Purpose**: Generate and enhance RSpec tests for Dotsync functionality.
-
-**When to use**:
-- When adding new actions or utilities
-- When test coverage is insufficient
-- When refactoring existing code
-
-**Focus areas**:
-- Unit tests for models (Mapping, Diff)
-- Integration tests for actions (PullAction, PushAction, WatchAction)
-- Edge cases and error scenarios
-- File system operations
-
-### Documentation Agent
-
-**Purpose**: Maintain and improve project documentation.
-
-**When to use**:
-- After adding new features
-- When configuration options change
-- When updating usage examples
-
-**Responsibilities**:
-- Keep README.md synchronized with code
-- Update inline code documentation
-- Maintain CHANGELOG.md
-- Generate usage examples
-
-## Maintenance Agents
-
-### Dependency Update Agent
-
-**Purpose**: Monitor and suggest updates for gem dependencies.
-
-**What it monitors**:
-- Security vulnerabilities in dependencies
-- New versions of runtime and development dependencies
-- Ruby version compatibility
-
-### Release Agent
-
-**Purpose**: Assist with the release process following RELEASING.md guidelines.
-
-**Checklist**:
-- Version number updated in version.rb
-- CHANGELOG.md updated with changes
-- Tests passing
-- RuboCop compliance
-- Tag creation and push
-- Gem publication to rubygems.org
-
-## Usage
-
-To work with these agents effectively:
-
-1. **Be specific**: Provide clear context about what you're working on
-2. **Reference files**: Point to specific files or line numbers when discussing issues
-3. **Run tests**: Always run `rake spec` after changes
-4. **Follow conventions**: Adhere to existing code patterns and Ruby style guide
-
-## Contributing
-
-When working with agents on this project:
-
-- Review generated code carefully before committing
-- Ensure all tests pass (`rake spec`)
-- Run RuboCop (`bundle exec rubocop`)
-- Update documentation as needed
-- Follow the project's [Code of Conduct](CODE_OF_CONDUCT.md)
+# Coding Agent Guidelines
+
+## Commands
+- Run all tests: `rake spec` or `bundle exec rspec`
+- Run single test: `bundle exec rspec spec/path/to/file_spec.rb` or `bundle exec rspec spec/path/to/file_spec.rb:42`
+- Lint: `bundle exec rubocop` (auto-fix: `bundle exec rubocop -a`)
+- Build gem: `rake build`
+
+## Code Style
+- **Ruby version**: >= 3.2.0
+- **Frozen string literal**: Always include `# frozen_string_literal: true` at top of files
+- **Indentation**: 2 spaces, no tabs
+- **Strings**: Double quotes (`"string"`)
+- **Hash syntax**: Modern style (`{ a: 1 }`)
+- **Method definitions**: Always use parentheses for methods with parameters
+- **Spacing**: Space after colons, commas, around operators; `foo { bar }` not `foo {bar}`
+
+## Project Structure
+- Actions: `lib/dotsync/actions/` - Core operations (PullAction, PushAction, WatchAction)
+- Config: `lib/dotsync/config/` - Configuration management with XDG support
+- Models: `lib/dotsync/models/` - Domain models (Mapping, Diff)
+- Utils: `lib/dotsync/utils/` - Helpers (FileTransfer, DirectoryDiffer, Logger, PathUtils)
+- Tests: `spec/` - RSpec tests mirroring lib structure
+
+## Error Handling
+- Use custom errors from `lib/dotsync/errors.rb`: `ConfigError`, `FileTransferError`, `PermissionError`, `DiskFullError`, `SymlinkError`, `TypeConflictError`
+- Always use `raise ErrorClass, "message"` for explicit error handling

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+## [0.4.3] - 2026-03-22
+
+### Fixed
+
+- Fix backup to respect `only`/`ignore` filters via FileTransfer reuse (#37)
+  - Backup no longer copies entire destination directories — only files matching sync filters are backed up
+  - Fixes `Permission denied` crash when destination contains restricted files (e.g. `.git/objects`) outside the filter
+  - Removes `cp_r_regular_files` in favor of reusing `FileTransfer` with a backup mapping
+
+## [0.4.2] - 2026-03-22
+
+### Fixed
+
+- Fix `cp_r_regular_files` crash on pre-existing symlinks during backup (#35)
+  - Add `FileUtils.rm_f` before `FileUtils.ln_s` to handle leftover symlinks from partial backup runs
+
 ## [0.4.1] - 2026-03-17
 
 ### Fixed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    dotsync (0.4.1)
+    dotsync (0.4.2)
       fileutils (~> 1.7.3)
       find (~> 0.2.0)
       listen (~> 3.9.0)

data/lib/dotsync/actions/pull_action.rb

@@ -62,29 +62,19 @@ module Dotsync
           if File.file?(mapping.src)
             FileUtils.cp(mapping.dest, backup_path)
           else
-            cp_r_regular_files(mapping.dest, backup_path)
+            backup_mapping = Dotsync::Mapping.new(
+              "src" => mapping.dest,
+              "dest" => backup_path,
+              "only" => mapping.original_only,
+              "ignore" => mapping.original_ignores,
+              "force" => false
+            )
+            Dotsync::FileTransfer.new(backup_mapping).transfer
           end
         end
         true
       end
 
-      # Recursively copy a directory, skipping sockets, FIFOs, and device files.
-      # FileUtils.cp_r fails on macOS when socket paths exceed the 104-byte limit.
-      def cp_r_regular_files(src, dest)
-        FileUtils.mkdir_p(dest)
-        Dir.each_child(src) do |entry|
-          src_entry = File.join(src, entry)
-          dest_entry = File.join(dest, entry)
-          if File.symlink?(src_entry)
-            FileUtils.ln_s(File.readlink(src_entry), dest_entry)
-          elsif File.directory?(src_entry)
-            cp_r_regular_files(src_entry, dest_entry)
-          elsif File.file?(src_entry)
-            FileUtils.cp(src_entry, dest_entry, preserve: true)
-          end
-        end
-      end
-
       def purge_old_backups
         backups = Dir[File.join(backups_root, "*")].sort.reverse
         if backups.size > 10

data/lib/dotsync/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dotsync
-  VERSION = "0.4.1"
+  VERSION = "0.4.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dotsync
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.3
 platform: ruby
 authors:
 - David Sáenz