dotloop-ruby 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d9450ad3b72ebdec3b08d6c87cbf0d8156c7023
-  data.tar.gz: 6abd113d8ff881ec69944233cee6aea021da3da6
+  metadata.gz: 17645308e8e87710f2002c12623dd94fd61ffcef
+  data.tar.gz: 3d0cb0d85f0802b363dce68a8f3a6e3ce53cc6bf
 SHA512:
-  metadata.gz: 56f646bde1d2076c90e79adc55eadac386f3e2346bc1abc61945aa0e97197b81ec7344eb04e8797b971b9bf9cc14ac2501e89fadbe0dc534941b494c2d974e73
-  data.tar.gz: 90eebb0f75382d8765fe5048396b12c327ddae1f5ba72a852f8600872d411428de18acf2fafcbf50c28fc5be91187d66fc65b2895afc86b828b33c71bcbe9860
+  metadata.gz: 53d5ee6e5cc94f6d3613cbb1c51cab670713372615f9e437b90167df9e69a602b7857bf9f28e5f8642c41f27dba92862ae0442d0298b9cd6b974e529bfbd2d0a
+  data.tar.gz: b7e6b1a121f777b79409db82a85a4f6237b0cfe01ba1e946fd87c05f807010dedd65edd3c0a4d2f5705e72458fc4f771a9e24113f16ba27ec97a37f18abfaca3

data/lib/dotloop/loop.rb

@@ -52,15 +52,16 @@ module Dotloop
     end
 
     def all(options = {})
-      loops = []
-      options[:batch_size] = BATCH_SIZE
-      (1..MAX_LOOPS).each do |i|
-        options[:batch_number] = i
-        current_batch = batch(options)
-        loops += current_batch
-        break if current_batch.size < options[:batch_size]
-      end
-      loops
+      raise_if_invalid_batch_size(options)
+      options[:batch_size] ||= BATCH_SIZE
+      Array.new.tap do |arr|
+        (1..MAX_LOOPS).each do |i|
+          options[:batch_number] = i
+          current_batch = batch(options)
+          arr.push current_batch
+          break if current_batch.size < options[:batch_size]
+        end
+      end.flatten
     end
 
     def batch(options = {})
@@ -144,6 +145,10 @@ module Dotloop
 
     private
 
+    def raise_if_invalid_batch_size(options)
+      raise 'invalid batch size provided, allowed values minimum 1 and maximum 100' if !options[:batch_size].nil? && (options[:batch_size] < 1 || options[:batch_size] > 100)
+    end
+
     def query_params(options)
       {
         batch_number:        batch_number(options),

data/lib/dotloop/version.rb

@@ -1,3 +1,3 @@
 module Dotloop
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dotloop-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - sampatbadhe
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-09 00:00:00.000000000 Z
+date: 2018-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov