dotdiff 0.2.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a75ccb6fb5904fe3d752dfc6ef04b0cc3f20f36e
-  data.tar.gz: 1601668d36ff26e3480a7795c30dfe8dcd6535fa
+  metadata.gz: 9997ae1ee2c000b67cfdd6e76abfc3e5cfc28849
+  data.tar.gz: c35cc13323a21458161535f406b2e7c4af68421a
 SHA512:
-  metadata.gz: c5f06e9d2162395d9a639a568c237b8965b2995169150f9f09d6ac63077b73a00518f1aaac63427e94f567dd20ceff0d0cff4e3b3d3733596d0aeb81c9323ef3
-  data.tar.gz: 04833912622a7122d5f4c216fd01e6eacc2a1e86051d2beef166abc62de883aaccb9017541260789356a9ed6e3b2c56ca77385f4fd39ff337a504ff8aa5683fc
+  metadata.gz: 752d3c3960ab4630c43e68c69826caec7da722171e267ec71fc9ce4bd227902e54c73c63aaea33dbd43934dd0a64804c61414d181dceb78bdc68e145ba6fbb43
+  data.tar.gz: 9e4d4391cda1b47e0163366253c438fdc53f52724f8daf705559dd82c3d0526d7a95cf9fb55905fcb5c99325a6f01d4eb26067476ef460eb737a0d06b2148618

data/lib/dotdiff/element_handler.rb

@@ -8,23 +8,29 @@ module DotDiff
     end
 
     def hide
-      elements.each do |elem|
-        if element_exists?(elem)
-          driver.execute_script("#{elem}.style.visibility = 'hidden'")
+      elements.each do |xpath|
+        if element_exists?(xpath)
+          driver.execute_script("#{js_element(xpath)}.style.visibility = 'hidden'")
         end
       end
     end
 
     def show
-      elements.each do |elem|
-        if element_exists?(elem)
-          driver.execute_script("#{elem}.style.visibility = ''")
+      elements.each do |xpath|
+        if element_exists?(xpath)
+          driver.execute_script("#{js_element(xpath)}.style.visibility = ''")
         end
       end
     end
 
-    def element_exists?(element)
-      driver.evaluate_script("#{element} != undefined")
+    def js_element(xpath)
+      "document.evaluate(\"#{xpath}\", "\
+      "document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue"
+    end
+
+    def element_exists?(xpath)
+      # TODO: Allow custom overriding beyond Capybara.default_max_wait_time
+      driver.find(:xpath, xpath, wait: 2, visible: :all) rescue nil
     end
 
     def elements

data/lib/dotdiff/image.rb

@@ -22,9 +22,7 @@ module DotDiff
         compare_to_image = capture_from_browser
         result = CommandWrapper.new
 
-        element_handler.hide
         result.run(base_image_file, compare_to_image)
-        element_handler.show
 
         if result.failed? && DotDiff.failure_image_path
           FileUtils.mkdir_p(File.join(DotDiff.failure_image_path, subdir.to_s))

data/lib/dotdiff/version.rb

@@ -1,3 +1,3 @@
 module DotDiff
-  VERSION = "0.2.0"
+  VERSION = "0.3.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dotdiff
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Jon Normington
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-03-13 00:00:00.000000000 Z
+date: 2016-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler