dota 0.0.20 → 0.0.21

data/lib/dota/api/ability.rb

@@ -5,11 +5,12 @@ module Dota
 
       attr_reader :id, :name, :full_name
 
+      alias_method :full_name, :name
+
       def initialize(id)
         @id = id
         @internal_name = mapping[id][0]
-        @name = mapping[id][1]
-        @full_name = mapping[id][2]
+        @name = mapping[id][1] || @internal_name
       end
 
       def image_url(type = :lg)
@@ -18,11 +19,7 @@ module Dota
         # :hp2 - 105x105 PNG image
         # :lg - 128x128 PNG image
 
-        if internal_name == 'stats'
-          "https://steamcdn-a.akamaihd.net/apps/dota2/images/workshop/itembuilder/stats.png"
-        else
-          "http://cdn.dota2.com/apps/dota2/images/abilities/#{internal_name}_#{type}.png"
-        end
+        "http://cdn.dota2.com/apps/dota2/images/abilities/#{internal_name}_#{type}.png"
       end
 
       private
@@ -30,4 +27,4 @@ module Dota
       attr_reader :internal_name
     end
   end
-end
+end

data/lib/dota/api/client.rb

@@ -28,7 +28,7 @@ module Dota
         if options.is_a?(Integer)
           id = options
           response = get("IDOTA2Match_570", "GetTeamInfoByTeamID", start_at_team_id: id, teams_requested: 1)["result"]["teams"][0]
-          Team.new(response) if response
+          Team.new(response) if response && id == response["team_id"]
         else
           options[:start_at_team_id] = options.delete(:after) if options[:after]
           options[:teams_requested]  = options.delete(:limit) if options[:limit]

data/lib/dota/version.rb

@@ -1,3 +1,3 @@
 module Dota
-  VERSION = "0.0.20"
+  VERSION = "0.0.21"
 end

data/spec/dota/api/ability_spec.rb

@@ -4,19 +4,28 @@ RSpec.describe Dota::API::Ability do
   specify ".all" do
     abilities = described_class.all
     expect(abilities.first).to be_a described_class
-    expect(abilities.count).to eq 570
+    expect(abilities.count).to eq 1077
   end
 
   specify "#id" do
     expect(ability.id).to eq 5003
   end
 
-  specify "#name" do
-    expect(ability.name).to eq "Mana Break"
+  describe "#name" do
+    specify "returns a human-friendly name" do
+      expect(ability.name).to eq "Mana Break"
+    end
+
+    specify "falls back to internal name" do
+      ability = described_class.new(9993)
+      expect(ability.name).to eq "roshan_halloween_wave_of_force"
+    end
   end
 
   specify "#full_name" do
-    expect(ability.full_name).to eq "Antimage Mana Break"
+    # DEPRECATED: Used to just concatenate hero name
+    # with ability (e.g., "Antimage Mana Break")
+    expect(ability.full_name).to eq "Mana Break"
   end
 
   specify "#image_url" do

data/spec/dota/api/hero_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe Dota::API::Hero do
   specify ".all" do
     heroes = described_class.all
     expect(heroes.first).to be_a described_class
-    expect(heroes.count).to eq 111
+    expect(heroes.count).to eq 113
   end
 
   specify ".find" do

data/spec/dota/api/item_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe Dota::API::Item do
   specify ".all" do
     items = described_class.all
     expect(items.first).to be_a described_class
-    expect(items.count).to eq 275
+    expect(items.count).to eq 282
   end
 
   specify "#id" do

data/spec/dota_spec.rb

@@ -51,7 +51,7 @@ RSpec.describe Dota do
       end
     end
 
-    describe "#matches" do
+    describe "#teams" do
       context "given an id" do
         it "returns a single team" do
           VCR.use_cassette("GetTeamInfoByTeamID") do
@@ -76,8 +76,8 @@ RSpec.describe Dota do
           after: :start_at_team_id,
           limit: :teams_requested
         }
-        accepted_params.each do |local, remote|
 
+        accepted_params.each do |local, remote|
           specify ":#{local} should translate to :#{remote}" do
             random_value = SecureRandom.hex
             VCR.use_cassette("GetTeamInfoByTeamID") do
@@ -87,6 +87,27 @@ RSpec.describe Dota do
           end
         end
       end
+
+      context "when team cannot be found" do
+        around do |example|
+          VCR.use_cassette("GetMatchDetails") do
+            example.run
+          end
+        end
+
+        it "returns nil when api returns a different team" do
+          different_team_id = sample_team_id + 1
+          response = {
+            "result" => {
+              "status" => 1,
+              "teams" => [{ "team_id" => different_team_id }],
+            },
+          }
+          expect(api).to receive(:get).with("IDOTA2Match_570", "GetTeamInfoByTeamID", start_at_team_id: sample_team_id, teams_requested: 1) { response }
+          team = api.teams(sample_team_id)
+          expect(team).to eq nil
+        end
+      end
     end
 
     specify "#leagues" do
@@ -111,8 +132,8 @@ RSpec.describe Dota do
           from: :date_min,
           to:   :date_max
         }
-        accepted_params.each do |local, remote|
 
+        accepted_params.each do |local, remote|
           specify ":#{local} should translate to :#{remote}" do
             random_value = SecureRandom.hex
             VCR.use_cassette("GetScheduledLeagueGames") do
@@ -139,8 +160,8 @@ RSpec.describe Dota do
           league_id: :league_id,
           match_id:  :match_id
         }
-        accepted_params.each do |local, remote|
 
+        accepted_params.each do |local, remote|
           specify ":#{local} should translate to :#{remote}" do
             random_value = SecureRandom.hex
             VCR.use_cassette("GetLiveLeagueGames") do
@@ -168,9 +189,9 @@ RSpec.describe Dota do
       end
     end
 
-    describe "#teams" do
+    describe "#matches" do
       context "given an id" do
-        it "returns a single team" do
+        it "returns a single match" do
           VCR.use_cassette("GetMatchDetails") do
             match = api.matches(sample_match_id)
             expect(match).to be_a Dota::API::Match
@@ -201,8 +222,8 @@ RSpec.describe Dota do
           limit:       :matches_requested,
           league_only: :tournament_games_only
         }
-        accepted_params.each do |local, remote|
 
+        accepted_params.each do |local, remote|
           specify ":#{local} should translate to :#{remote}" do
             random_value = SecureRandom.hex
             VCR.use_cassette("GetMatchHistory") do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dota
 version: !ruby/object:Gem::Version
-  version: 0.0.20
+  version: 0.0.21
 platform: ruby
 authors:
 - Vinni Carlo Caños
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-11 00:00:00.000000000 Z
+date: 2017-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: facets
@@ -171,7 +171,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".env.sample"
+- ".env.example"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"