dorsale 3.8.1 → 3.9.0

data/spec/models/dorsale/users_spec.rb

@@ -1,7 +1,6 @@
 require "rails_helper"
 
 RSpec.describe User, type: :model do
-
   it "should have a valid factores" do
     expect(create(:user)).to be_valid
   end
@@ -14,17 +13,17 @@ RSpec.describe User, type: :model do
       expect(@user.is_active).to eq true
     end
 
-    it 'should create a valid password upon creation' do
+    it "should create a valid password upon creation" do
       user = create(:user, password: nil, password_confirmation: nil)
       expect(user).to be_persisted
     end
 
-    it 'should not override choosen password' do
+    it "should not override choosen password" do
       user = create(:user, password: "totototo", password_confirmation: nil)
       expect(user.password).to eq "totototo"
     end
 
-    it 'should send a welcome message upon creation' do
+    it "should send a welcome message upon creation" do
       expect {
         create(:user)
       }.to change(ActionMailer::Base.deliveries, :count).by(1)
@@ -63,5 +62,4 @@ RSpec.describe User, type: :model do
       expect(@user.avatar_url).to be_present
     end
   end
-
 end

data/spec/pdfs/dorsale/billing_machine/invoice_multiple_vat_pdf_spec.rb

@@ -32,16 +32,11 @@ describe ::Dorsale::BillingMachine::InvoiceMultipleVatPdf, pdfs: true do
     expect(content).to include "TVA %"
   end
 
-  describe "empty invoice" do
-    let(:invoice) {
-      id_card = Dorsale::BillingMachine::IdCard.new
-      id_card.save(validate: false)
-      invoice = ::Dorsale::BillingMachine::Invoice.create!(id_card: id_card)
-    }
-
-    it "should work" do
-      expect { generate! }.to_not raise_error
-    end
-  end # describe "empty invoice"
+  it "should work with empty invoice" do
+    invoice = ::Dorsale::BillingMachine::Invoice.new
 
+    expect {
+      described_class.new(invoice).tap(&:build).render_with_attachments
+    }.to_not raise_error
+  end
 end

data/spec/pdfs/dorsale/billing_machine/invoice_single_vat_pdf_spec.rb

@@ -32,15 +32,11 @@ describe ::Dorsale::BillingMachine::InvoiceSingleVatPdf, pdfs: true do
     expect(content).to_not include "TVA %"
   end
 
-  describe "empty invoice" do
-    let(:invoice) {
-      id_card = Dorsale::BillingMachine::IdCard.new
-      id_card.save(validate: false)
-      invoice = ::Dorsale::BillingMachine::Invoice.create!(id_card: id_card)
-    }
-
-    it "should work" do
-      expect { generate! }.to_not raise_error
-    end
-  end # describe "empty invoice"
+  it "should work with empty invoice" do
+    invoice = ::Dorsale::BillingMachine::Invoice.new
+
+    expect {
+      described_class.new(invoice).tap(&:build).render_with_attachments
+    }.to_not raise_error
+  end
 end

data/spec/pdfs/dorsale/billing_machine/quotation_multiple_vat_pdf_spec.rb

@@ -32,16 +32,11 @@ describe ::Dorsale::BillingMachine::QuotationMultipleVatPdf, pdfs: true do
     expect(content).to include "TVA %"
   end
 
-  describe "empty quotation" do
-    let(:quotation) {
-      id_card = Dorsale::BillingMachine::IdCard.new
-      id_card.save(validate: false)
-      quotation = ::Dorsale::BillingMachine::Quotation.create!(id_card: id_card)
-    }
-
-    it "should work" do
-      expect { generate! }.to_not raise_error
-    end
-  end # describe "empty quotation"
+  it "should work with empty quotation" do
+    quotation = ::Dorsale::BillingMachine::Quotation.new
 
+    expect {
+      described_class.new(quotation).tap(&:build).render_with_attachments
+    }.to_not raise_error
+  end
 end

data/spec/pdfs/dorsale/billing_machine/quotation_single_vat_pdf_spec.rb

@@ -25,23 +25,20 @@ describe ::Dorsale::BillingMachine::QuotationSingleVatPdf, pdfs: true do
     generate!
     Yomu.new(quotation.pdf_file.path).text
   }
+
   it "should display global vat rate" do
     expect(content).to include "TVA 19,60 %"
     expect(content).to_not include "MONTANT TVA"
     expect(content).to_not include "TVA %"
   end
 
-  describe "empty quotation" do
-    let(:quotation) {
-      id_card = Dorsale::BillingMachine::IdCard.new
-      id_card.save(validate: false)
-      quotation = ::Dorsale::BillingMachine::Quotation.create!(id_card: id_card)
-    }
+  it "should work with empty quotation" do
+    quotation = ::Dorsale::BillingMachine::Quotation.new
 
-    it "should work" do
-      expect { generate! }.to_not raise_error
-    end
-  end # describe "empty quotation"
+    expect {
+      described_class.new(quotation).tap(&:build).render_with_attachments
+    }.to_not raise_error
+  end
 
   describe "attachments" do
     let(:quotation) {
@@ -55,8 +52,4 @@ describe ::Dorsale::BillingMachine::QuotationSingleVatPdf, pdfs: true do
       expect(content).to include "page 2"
     end
   end # describe "attachments"
-
 end
-
-
-

data/spec/rails_helper.rb

@@ -52,7 +52,7 @@ RSpec.configure do |config|
   # https://relishapp.com/rspec/rspec-rails/docs
   config.infer_spec_type_from_file_location!
 
-  config.include FactoryGirl::Syntax::Methods
+  config.include FactoryBot::Syntax::Methods
 
   config.after { Timecop.return }
 end

data/spec/routing/dorsale/billing_machine/invoices_routing_spec.rb

@@ -58,6 +58,5 @@ describe ::Dorsale::BillingMachine::InvoicesController, type: :routing do
       expect(post "/billing_machine/invoices/1/email").to \
       route_to("dorsale/billing_machine/invoices#email", id: "1")
     end
-
   end
 end

data/spec/routing/dorsale/billing_machine/quotations_routing_spec.rb

@@ -48,6 +48,5 @@ describe ::Dorsale::BillingMachine::QuotationsController do
       expect(get "/billing_machine/quotations/1/create_invoice").to \
       route_to("dorsale/billing_machine/quotations#create_invoice", id: "1")
     end
-
   end
 end

data/spec/routing/dorsale/comments_routing_spec.rb

@@ -4,7 +4,6 @@ RSpec.describe Dorsale::CommentsController, type: :routing do
   routes { Dorsale::Engine.routes }
 
   describe "routing" do
-
     it "routes to #create" do
       expect(post: "/comments").to route_to("dorsale/comments#create")
     end
@@ -20,6 +19,5 @@ RSpec.describe Dorsale::CommentsController, type: :routing do
     it "routes to #destroy" do
       expect(delete: "/comments/3").to route_to("dorsale/comments#destroy", id: "3")
     end
-
   end
 end

data/spec/routing/dorsale/customer_vault/people_routing_spec.rb

@@ -106,5 +106,4 @@ RSpec.describe ::Dorsale::CustomerVault::PeopleController, type: :routing do
       eq "/dorsale/customer_vault/individuals"
     end
   end # describe "route helpers"
-
 end

data/spec/routing/dorsale/expense_gun/expenses_routing_spec.rb

@@ -58,6 +58,5 @@ describe ::Dorsale::ExpenseGun::ExpensesController, type: :routing do
       expect(get "/expense_gun/expenses/1/copy").to \
       route_to("dorsale/expense_gun/expenses#copy", id: "1")
     end
-
   end
 end

data/spec/routing/dorsale/flyboy/task_comments_routing_spec.rb

@@ -7,6 +7,5 @@ describe ::Dorsale::Flyboy::TaskCommentsController, type: :routing do
     it "routes to #create" do
       expect(post("flyboy/task_comments")).to route_to("dorsale/flyboy/task_comments#create")
     end
-
   end
 end

data/spec/routing/dorsale/users_routing_spec.rb

@@ -35,4 +35,4 @@ RSpec.describe ::Dorsale::UsersController, type: :routing do
       expect(:delete => "users/1").not_to be_routable
     end
   end
-end
+end

data/spec/services/dorsale/billing_machine/quotation/copy_spec.rb

@@ -36,8 +36,8 @@ RSpec.describe Dorsale::BillingMachine::Quotation::Copy do
   end
 
   it "should reset date" do
-    expect(quotation.date).to_not eq Time.zone.now.to_date
-    expect(copy.date).to          eq Time.zone.now.to_date
+    expect(quotation.date).to_not eq Date.current
+    expect(copy.date).to          eq Date.current
   end
 
   it "should reset unique_index, tracking_id, created_at, updated_at" do

data/spec/services/dorsale/expense_gun/expense/copy_spec.rb

@@ -5,14 +5,14 @@ RSpec.describe ::Dorsale::ExpenseGun::Expense::Copy do
     expense = Dorsale::ExpenseGun::Expense.create!(
       :user  => create(:user),
       :name  => "ExpenseName",
-      :date  => Time.zone.now.to_date,
+      :date  => Date.current,
       :state => "accepted",
     )
 
     line = create(:expense_gun_expense_line,
       :expense => expense,
       :name    => "ExpenseLineName",
-      :date    => Time.zone.now.to_date,
+      :date    => Date.current,
     )
 
     expense.reload
@@ -28,19 +28,17 @@ RSpec.describe ::Dorsale::ExpenseGun::Expense::Copy do
 
   it "should duplicate expense lines attributes" do
     expect(copy.expense_lines.length).to eq 1
-    expect(copy.expense_lines.first.name).to eq "ExpenseLineName"
-
-    expect(copy.expense_lines.first.category).to be_present
-    expect(copy.expense_lines.first.category).to eq expense.expense_lines.first.category
-
-    expect(copy.expense_lines.first.total_all_taxes).to be_present
-    expect(copy.expense_lines.first.total_all_taxes).to eq expense.expense_lines.first.total_all_taxes
-
-    expect(copy.expense_lines.first.vat).to be_present
-    expect(copy.expense_lines.first.vat).to eq expense.expense_lines.first.vat
-
-    expect(copy.expense_lines.first.company_part).to be_present
-    expect(copy.expense_lines.first.company_part).to eq expense.expense_lines.first.company_part
+    expense_line = copy.expense_lines.first
+
+    expect(expense_line.name).to eq "ExpenseLineName"
+    expect(expense_line.category).to be_present
+    expect(expense_line.category).to eq expense.expense_lines.first.category
+    expect(expense_line.total_all_taxes).to be_present
+    expect(expense_line.total_all_taxes).to eq expense.expense_lines.first.total_all_taxes
+    expect(expense_line.vat).to be_present
+    expect(expense_line.vat).to eq expense.expense_lines.first.vat
+    expect(expense_line.company_part).to be_present
+    expect(expense_line.company_part).to eq expense.expense_lines.first.company_part
   end
 
   it "should not be persisted" do
@@ -82,6 +80,4 @@ RSpec.describe ::Dorsale::ExpenseGun::Expense::Copy do
     expect(expense.expense_lines.first.updated_at).to be_present
     expect(copy.expense_lines.first.updated_at).to be_nil
   end
-
 end
-

data/spec/services/dorsale/flyboy/task/copy_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Dorsale::Flyboy::Task::Copy do
 
   let(:copy) {
     copy = Dorsale::Flyboy::Task::Copy.(task)
-    copy.save
+    copy.save!
     copy
   }
 
@@ -21,5 +21,4 @@ RSpec.describe Dorsale::Flyboy::Task::Copy do
   it "is expected to set the progress to 0" do
     expect(copy.progress).to eq 0
   end
-
 end

data/spec/services/dorsale/flyboy/task/snoozer_spec.rb

@@ -1,4 +1,4 @@
-require 'rails_helper'
+require "rails_helper"
 
 describe Dorsale::Flyboy::Task::Snoozer do
   describe "#snooze" do
@@ -54,7 +54,7 @@ describe Dorsale::Flyboy::Task::Snoozer do
     it "should true if term is today" do
       task = create(:flyboy_task,
         :done              => false,
-        :term              => Date.today,
+        :term              => Date.current,
         :reminder_type     => nil,
       )
 
@@ -86,7 +86,7 @@ describe Dorsale::Flyboy::Task::Snoozer do
         :done              => false,
         :term              => "2017-04-20", # future
         :reminder_type     => "custom",
-        :reminder_date     => Date.today,
+        :reminder_date     => Date.current,
       )
 
       expect(task.snoozer.snoozable?).to be true

data/spec/spec_helper.rb

@@ -1,3 +1,4 @@
+require "simplecov"
 # This file was generated by the `rails generate rspec:install` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
 # The generated `.rspec` file contains `--require spec_helper` which will cause this

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dorsale
 version: !ruby/object:Gem::Version
-  version: 3.8.1
+  version: 3.9.0
 platform: ruby
 authors:
 - agilidée
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-24 00:00:00.000000000 Z
+date: 2017-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -530,7 +530,6 @@ files:
 - app/controllers/dorsale/alexandrie/attachments_controller.rb
 - app/controllers/dorsale/application_controller.rb
 - app/controllers/dorsale/billing_machine/application_controller.rb
-- app/controllers/dorsale/billing_machine/id_cards_controller.rb
 - app/controllers/dorsale/billing_machine/invoices_controller.rb
 - app/controllers/dorsale/billing_machine/payment_terms_controller.rb
 - app/controllers/dorsale/billing_machine/quotations_controller.rb
@@ -579,7 +578,6 @@ files:
 - app/models/dorsale/alexandrie/attachment_type.rb
 - app/models/dorsale/application_record.rb
 - app/models/dorsale/billing_machine.rb
-- app/models/dorsale/billing_machine/id_card.rb
 - app/models/dorsale/billing_machine/invoice.rb
 - app/models/dorsale/billing_machine/invoice_line.rb
 - app/models/dorsale/billing_machine/payment_term.rb
@@ -608,15 +606,16 @@ files:
 - app/models/dorsale/users/avatar.rb
 - app/models/dorsale/users/password_generation.rb
 - app/pdfs/concerns/dorsale/alexandrie/prawn/render_with_attachments.rb
+- app/pdfs/dorsale/application_pdf.rb
 - app/pdfs/dorsale/billing_machine/invoice_multiple_vat_pdf.rb
 - app/pdfs/dorsale/billing_machine/invoice_single_vat_pdf.rb
 - app/pdfs/dorsale/billing_machine/quotation_multiple_vat_pdf.rb
 - app/pdfs/dorsale/billing_machine/quotation_pdf_common_methods.rb
 - app/pdfs/dorsale/billing_machine/quotation_single_vat_pdf.rb
+- app/pdfs/dorsale/prawn_helpers.rb
 - app/policies/dorsale/alexandrie/attachment_policy_helper.rb
 - app/policies/dorsale/alexandrie/attachment_type_policy_helper.rb
 - app/policies/dorsale/application_policy.rb
-- app/policies/dorsale/billing_machine/id_card_policy_helper.rb
 - app/policies/dorsale/billing_machine/invoice_policy_helper.rb
 - app/policies/dorsale/billing_machine/payment_term_policy_helper.rb
 - app/policies/dorsale/billing_machine/quotation_policy_helper.rb
@@ -659,12 +658,6 @@ files:
 - app/views/dorsale/alexandrie/attachments/_new_disabled.html.slim
 - app/views/dorsale/alexandrie/attachments/_progress_bar.html.slim
 - app/views/dorsale/alexandrie/attachments/index.html.slim
-- app/views/dorsale/billing_machine/id_cards/_form.html.slim
-- app/views/dorsale/billing_machine/id_cards/_index_actions.html.slim
-- app/views/dorsale/billing_machine/id_cards/_list.html.slim
-- app/views/dorsale/billing_machine/id_cards/edit.html.slim
-- app/views/dorsale/billing_machine/id_cards/index.html.slim
-- app/views/dorsale/billing_machine/id_cards/new.html.slim
 - app/views/dorsale/billing_machine/invoices/_details.html.slim
 - app/views/dorsale/billing_machine/invoices/_filters.html.slim
 - app/views/dorsale/billing_machine/invoices/_form.html.slim
@@ -847,6 +840,7 @@ files:
 - db/migrate/20160910164840_create_dorsale_customer_vault_people.rb
 - db/migrate/20160930073538_create_dorsale_alexandrie_attachment_types.rb
 - db/migrate/20161118071317_dorsale_add_missing_indexes.rb
+- db/migrate/20161119064536_delete_id_cards.rb
 - db/migrate/20170127131537_delete_folders.rb
 - db/migrate/20170127151610_fix_expense_state.rb
 - db/migrate/20170127155636_billing_machine_add_pdf_file.rb
@@ -863,7 +857,6 @@ files:
 - db/migrate/20171023133219_customer_vault_events_add_contact_type.rb
 - db/migrate/20171024075514_customer_vault_contact_type_default_value.rb
 - features/access.feature
-- features/billing_machine_id_cards.feature
 - features/billing_machine_invoices.feature
 - features/billing_machine_multiple_vat.feature
 - features/billing_machine_payment_terms.feature
@@ -885,7 +878,6 @@ files:
 - features/flyboy_tasks_summary.feature
 - features/step_definitions/access_steps.rb
 - features/step_definitions/alexandrie_steps.rb
-- features/step_definitions/billing_machine_id_cards_steps.rb
 - features/step_definitions/billing_machine_invoices_steps.rb
 - features/step_definitions/billing_machine_multiple_vat.rb
 - features/step_definitions/billing_machine_payment_terms_steps.rb
@@ -907,19 +899,7 @@ files:
 - features/step_definitions/flyboy_tasks_steps.rb
 - features/step_definitions/tasks_summary_steps.rb
 - features/step_definitions/users_management_step.rb
-- features/support/ajax.rb
-- features/support/database_cleaner.rb
 - features/support/env.rb
-- features/support/factory_girl.rb
-- features/support/fix_referrer.rb
-- features/support/message_delivery.rb
-- features/support/poltergeist.rb
-- features/support/rails.rb
-- features/support/rspec.rb
-- features/support/screenshots.rb
-- features/support/sign_in.rb
-- features/support/simplecov.rb
-- features/support/turbolinks.rb
 - features/users_management.feature
 - lib/dorsale.rb
 - lib/dorsale/engine.rb
@@ -939,7 +919,6 @@ files:
 - spec/controllers/dorsale/flyboy/tasks_controller_spec.rb
 - spec/factories/alexandrie_attachment_types.rb
 - spec/factories/alexandrie_attachments.rb
-- spec/factories/billing_machine_id_cards.rb
 - spec/factories/billing_machine_invoice_lines.rb
 - spec/factories/billing_machine_invoices.rb
 - spec/factories/billing_machine_payment_terms.rb
@@ -964,7 +943,6 @@ files:
 - spec/models/dorsale/address_spec.rb
 - spec/models/dorsale/alexandrie/attachment_spec.rb
 - spec/models/dorsale/alexandrie/attachment_type_spec.rb
-- spec/models/dorsale/billing_machine/id_card_spec.rb
 - spec/models/dorsale/billing_machine/invoice_line_spec.rb
 - spec/models/dorsale/billing_machine/invoice_spec.rb
 - spec/models/dorsale/billing_machine/quotation_line_spec.rb
@@ -1046,7 +1024,6 @@ test_files:
 - spec/controllers/dorsale/flyboy/tasks_controller_spec.rb
 - spec/factories/alexandrie_attachment_types.rb
 - spec/factories/alexandrie_attachments.rb
-- spec/factories/billing_machine_id_cards.rb
 - spec/factories/billing_machine_invoice_lines.rb
 - spec/factories/billing_machine_invoices.rb
 - spec/factories/billing_machine_payment_terms.rb
@@ -1071,7 +1048,6 @@ test_files:
 - spec/models/dorsale/address_spec.rb
 - spec/models/dorsale/alexandrie/attachment_spec.rb
 - spec/models/dorsale/alexandrie/attachment_type_spec.rb
-- spec/models/dorsale/billing_machine/id_card_spec.rb
 - spec/models/dorsale/billing_machine/invoice_line_spec.rb
 - spec/models/dorsale/billing_machine/invoice_spec.rb
 - spec/models/dorsale/billing_machine/quotation_line_spec.rb
@@ -1119,7 +1095,6 @@ test_files:
 - spec/support/devise.rb
 - spec/support/message_delivery.rb
 - features/access.feature
-- features/billing_machine_id_cards.feature
 - features/billing_machine_invoices.feature
 - features/billing_machine_multiple_vat.feature
 - features/billing_machine_payment_terms.feature
@@ -1141,7 +1116,6 @@ test_files:
 - features/flyboy_tasks_summary.feature
 - features/step_definitions/access_steps.rb
 - features/step_definitions/alexandrie_steps.rb
-- features/step_definitions/billing_machine_id_cards_steps.rb
 - features/step_definitions/billing_machine_invoices_steps.rb
 - features/step_definitions/billing_machine_multiple_vat.rb
 - features/step_definitions/billing_machine_payment_terms_steps.rb
@@ -1163,17 +1137,5 @@ test_files:
 - features/step_definitions/flyboy_tasks_steps.rb
 - features/step_definitions/tasks_summary_steps.rb
 - features/step_definitions/users_management_step.rb
-- features/support/ajax.rb
-- features/support/database_cleaner.rb
 - features/support/env.rb
-- features/support/factory_girl.rb
-- features/support/fix_referrer.rb
-- features/support/message_delivery.rb
-- features/support/poltergeist.rb
-- features/support/rails.rb
-- features/support/rspec.rb
-- features/support/screenshots.rb
-- features/support/sign_in.rb
-- features/support/simplecov.rb
-- features/support/turbolinks.rb
 - features/users_management.feature