dorsale 3.14.9 → 3.14.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c02356f6d8c0cf4484b3c5bbf8ae14b4afb5807b79a836c3ac3def7fe4f0d795
-  data.tar.gz: 10e1416b942207884fc2a84665285e6a5ebb9d73fe5d65a69057f89d05ac75fa
+  metadata.gz: bed10bfd8955fa8dec1e5c01787b450201bfb08941099fbe6d2e413f8b679dd1
+  data.tar.gz: 7bdab067a557c8d7ceb4d660462be2452bb429cf6bdbd540c84b6b3dc5972446
 SHA512:
-  metadata.gz: ad1c5adb07688951372ec42e57c85f9487c06257827dcf0e712ab3a87794c9c9ac5e6fe6ba09115fe3813e55ceba36b56dc871729e5aead840b3815af4a8b3a8
-  data.tar.gz: 90da6df14ad83c78ea0abe031686ea1f9cbbdb3750005c669c19f89875b7ea77a9fce70c4bfbdc9dd7f28e28f95b954ef85395c8422b86148c9bbeefffeeed1d
+  metadata.gz: 83a3b664703cae40e41a194157e4369474d461b29042e48e13b4d259dd02f3db99e2835c885b73d83e1bc254e1d1a3c51ef7b4a025db86d45ab3653bb7da4fb0
+  data.tar.gz: '03826fb01f8843a16685a23d319611d393f988376b59418d37cbfa60fcc7e0f3baf44f518ed9a581d682615cce7061e5c35e805087eacf7dac3803edb19506ca'

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Next version
 
+## 3.14.10
+- Change BillingMachine PDF filenames
+- Fix CustomerVault layout
+
 ## 3.14.9
 - Create corporation from individual form
 - Quotations: add draft state

data/app/controllers/dorsale/customer_vault/events_controller.rb

@@ -1,8 +1,6 @@
 class Dorsale::CustomerVault::EventsController < ::Dorsale::CustomerVault::ApplicationController
   before_action :set_objects
 
-  layout -> { action_name == "index" ? nil : false }
-
   def index
     authorize model, :list?
 

data/app/models/dorsale/billing_machine/invoice.rb

@@ -22,6 +22,8 @@ class Dorsale::BillingMachine::Invoice < ::Dorsale::ApplicationRecord
     :invoice
   end
 
+  after_initialize :assign_default_dates
+  before_save :update_totals
   before_create :assign_unique_index
   before_create :assign_tracking_id
 
@@ -43,15 +45,11 @@ class Dorsale::BillingMachine::Invoice < ::Dorsale::ApplicationRecord
     assign_default :paid,                  false
   end
 
-  after_initialize :assign_default_dates
-
   def assign_default_dates
     assign_default :date,     Date.current
     assign_default :due_date, Date.current + 30.days
   end
 
-  before_save :update_totals
-
   def update_totals
     assign_default_values
     lines.each(&:update_total)

data/app/models/dorsale/billing_machine/quotation.rb

@@ -33,6 +33,7 @@ class Dorsale::BillingMachine::Quotation < ::Dorsale::ApplicationRecord
     :quotation
   end
 
+  before_save :update_totals
   before_create :assign_unique_index
   before_create :assign_tracking_id
 
@@ -55,8 +56,6 @@ class Dorsale::BillingMachine::Quotation < ::Dorsale::ApplicationRecord
     assign_default :total_excluding_taxes,  0
   end
 
-  before_save :update_totals
-
   def update_totals
     assign_default_values
     lines.each(&:update_total)

data/app/models/dorsale/customer_vault/person.rb

@@ -9,8 +9,6 @@ class Dorsale::CustomerVault::Person < ::Dorsale::ApplicationRecord
     Dorsale::CustomerVault::PersonPolicy
   end
 
-  after_initialize :verify_class
-
   def verify_class
     if self.class == ::Dorsale::CustomerVault::Person
       # self.abstract_class does not work with STI
@@ -30,6 +28,13 @@ class Dorsale::CustomerVault::Person < ::Dorsale::ApplicationRecord
   belongs_to :activity_type, class_name: "Dorsale::CustomerVault::ActivityType"
   belongs_to :origin, class_name: "Dorsale::CustomerVault::Origin"
 
+  validate :validate_taken_emails
+
+  after_initialize :verify_class
+  after_initialize  :build_address, if: proc { new_record? && address.nil? }
+
+  before_validation :build_address, if: proc { address.nil? }
+
   after_destroy :destroy_links
 
   default_scope -> {
@@ -50,9 +55,6 @@ class Dorsale::CustomerVault::Person < ::Dorsale::ApplicationRecord
 
   scope :having_email, -> (email) { where("email = :e OR :e = ANY (secondary_emails)", e: email) }
 
-  after_initialize  :build_address, if: proc { new_record? && address.nil? }
-  before_validation :build_address, if: proc { address.nil? }
-
   def taken_emails
     taken_emails = {}
     ([email] + secondary_emails).select(&:present?).each do |e|
@@ -62,8 +64,6 @@ class Dorsale::CustomerVault::Person < ::Dorsale::ApplicationRecord
     taken_emails
   end
 
-  validate :validate_taken_emails
-
   def validate_taken_emails
     return if taken_emails.empty?
 

data/app/pdfs/dorsale/billing_machine/invoice_single_vat_pdf.rb

@@ -177,11 +177,11 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
   end
 
   def has_advance
-    main_document.try(:advance) && main_document.advance != 0.0
+    main_document.try(:advance) && main_document.advance.to_d != 0.0.to_d
   end
 
   def has_discount
-    main_document.try(:commercial_discount) && main_document.commercial_discount != 0.0
+    main_document.try(:commercial_discount) && main_document.commercial_discount.to_d != 0.0.to_d
   end
 
   def build_table

data/app/policies/dorsale/application_policy.rb

@@ -19,6 +19,7 @@ class Dorsale::ApplicationPolicy
   end
 
   def self.inherited(klass)
+    super(klass)
     klass.define_subject_accessor!
   end
 

data/app/services/dorsale/billing_machine/invoice/copy.rb

@@ -2,6 +2,7 @@ class Dorsale::BillingMachine::Invoice::Copy < ::Dorsale::Service
   attr_accessor :invoice, :copy
 
   def initialize(invoice)
+    super()
     @invoice = invoice
   end
 

data/app/services/dorsale/billing_machine/pdf_file_generator.rb

@@ -2,6 +2,7 @@ class Dorsale::BillingMachine::PdfFileGenerator < Dorsale::Service
   attr_reader :document
 
   def initialize(document)
+    super()
     @document = document
 
     # I have no idea why I need to do that,

data/app/services/dorsale/billing_machine/quotation/copy.rb

@@ -2,6 +2,7 @@ class Dorsale::BillingMachine::Quotation::Copy < ::Dorsale::Service
   attr_accessor :quotation, :copy
 
   def initialize(quotation)
+    super()
     @quotation = quotation
   end
 

data/app/services/dorsale/billing_machine/quotation/to_invoice.rb

@@ -2,6 +2,7 @@ class Dorsale::BillingMachine::Quotation::ToInvoice < ::Dorsale::Service
   attr_accessor :quotation, :invoice
 
   def initialize(quotation)
+    super()
     @quotation = quotation
   end
 

data/app/services/dorsale/expense_gun/expense/copy.rb

@@ -2,6 +2,7 @@ class Dorsale::ExpenseGun::Expense::Copy < ::Dorsale::Service
   attr_accessor :expense, :copy
 
   def initialize(expense)
+    super()
     @expense = expense
   end
 

data/app/services/dorsale/flyboy/task/copy.rb

@@ -2,6 +2,7 @@ class Dorsale::Flyboy::Task::Copy < ::Dorsale::Service
   attr_accessor :task, :copy
 
   def initialize(task)
+    super()
     @task = task
   end
 

data/app/services/dorsale/flyboy/task/snoozer.rb

@@ -2,6 +2,7 @@ class Dorsale::Flyboy::Task::Snoozer < ::Dorsale::Service
   attr_reader :task
 
   def initialize(task)
+    super()
     @task = task
   end
 

data/app/services/dorsale/tag_list_for_model.rb

@@ -2,6 +2,7 @@ class Dorsale::TagListForModel < ::Dorsale::Service
   attr_reader :model
 
   def initialize(model)
+    super()
     @model = model
   end
 

data/app/views/dorsale/billing_machine/invoices/show.pdf.ruby

@@ -1,7 +1,7 @@
 filename = [
   @invoice.t.capitalize,
   @invoice.tracking_id,
-  @invoice.customer.try(:short_name),
+  @invoice.customer.to_s.tr(" ", "_"),
 ].join("_").concat(".pdf")
 
 response.headers["Content-Disposition"] = %(inline; filename="#{filename}")

data/app/views/dorsale/billing_machine/quotations/show.pdf.ruby

@@ -1,7 +1,7 @@
 filename = [
   @quotation.t.capitalize,
   @quotation.tracking_id,
-  @quotation.customer.try(:short_name),
+  @quotation.customer.to_s.tr(" ", "_"),
 ].join("_").concat(".pdf")
 
 response.headers["Content-Disposition"] = %(inline; filename="#{filename}")

data/features/step_definitions/billing_machine_payment_terms_steps.rb

@@ -28,7 +28,7 @@ When(/^the user edits the payment_term$/) do
   find(".link_update").click
 end
 
-Then(/^the current payment_term's label should be pre\-filled$/) do
+Then(/^the current payment_term's label should be pre-filled$/) do
   expect(page).to have_field("billing_machine_payment_term_label", with: @payment_term.label)
 end
 

data/features/step_definitions/billing_machine_quotations_steps.rb

@@ -58,7 +58,7 @@ When(/^the quotation line shows the right date$/) do
   expect(page).to have_selector ".date", text: I18n.l(@quotation.date)
 end
 
-When(/^the quotation line shows the right traking\-id$/) do
+When(/^the quotation line shows the right traking-id$/) do
   expect(page).to have_selector ".tracking_id", text: @quotation.tracking_id
 end
 

data/features/step_definitions/customer_vault_activity_types_steps.rb

@@ -28,7 +28,7 @@ When(/^I edit the activity type$/) do
   find(".link_update").click
 end
 
-Then(/^the current activity type's name should be pre\-filled$/) do
+Then(/^the current activity type's name should be pre-filled$/) do
   expect(page).to have_field("activity_type_name", with: @activity_type.name)
 end
 

data/features/step_definitions/customer_vault_origins_steps.rb

@@ -28,7 +28,7 @@ When(/^I edit the origin$/) do
   find(".link_update").click
 end
 
-Then(/^the current origin's name should be pre\-filled$/) do
+Then(/^the current origin's name should be pre-filled$/) do
   expect(page).to have_field("origin_name", with: @origin.name)
 end
 

data/features/step_definitions/customer_vault_search_steps.rb

@@ -1,48 +1,48 @@
-Lorsqu(/^he go to the people list$/) do
+When(/^he go to the people list$/) do
   visit dorsale.customer_vault_people_path
 end
 
-Etantdonné(/^existing individuals$/) do
+Given(/^existing individuals$/) do
   @individual1 = create(:customer_vault_individual, first_name: "Jean", last_name: "DUPONT")
   @individual2 = create(:customer_vault_individual, first_name: "Laurent", last_name: "DURAND")
 end
 
-Etantdonné(/^existing corporations$/) do
+Given(/^existing corporations$/) do
   @corporation1 = create(:customer_vault_corporation, name: "aaa", email: "contact@aaa.com")
   @corporation2 = create(:customer_vault_corporation, name: "zzz", email: "contact@zzz.com")
 end
 
-Lorsqu(/^he search an individual by first name$/) do
+When(/^he search an individual by first name$/) do
   fill_in "q", with: "Jean"
   find(".search-submit").click
 end
 
-Alors(/^this individual appear in search results$/) do
+Then(/^this individual appear in search results$/) do
   expect(page).to have_content "Jean"
   expect(page).to have_content "DUPONT"
 end
 
-Alors(/^other individuals do not appear in search results$/) do
+Then(/^other individuals do not appear in search results$/) do
   expect(page).to have_no_content "Laurent"
   expect(page).to have_no_content "DURAND"
 end
 
-Lorsqu(/^he search an individual by last name$/) do
+When(/^he search an individual by last name$/) do
   fill_in "q", with: "DUPONT"
   find(".search-submit").click
 end
 
-Lorsqu(/^he search a corporation by name$/) do
+When(/^he search a corporation by name$/) do
   fill_in "q", with: "aaa"
   find(".search-submit").click
 end
 
-Alors(/^this corporation appear in search results$/) do
+Then(/^this corporation appear in search results$/) do
   expect(page).to have_content "aaa"
   expect(page).to have_content "contact@aaa.com"
 end
 
-Alors(/^other corporations do not appear in search results$/) do
+Then(/^other corporations do not appear in search results$/) do
   expect(page).to have_no_content "zzz"
   expect(page).to have_no_content "contact@zzz.com"
 end

data/features/step_definitions/expense_gun_categories_steps.rb

@@ -28,7 +28,7 @@ When(/^I edit the expense category$/) do
   find(".link_update").click
 end
 
-Then(/^the current expense category's label should be pre\-filled$/) do
+Then(/^the current expense category's label should be pre-filled$/) do
   expect(page).to have_field("category_name", with: @category.name)
 end
 

data/lib/dorsale/version.rb

@@ -1,3 +1,3 @@
 module Dorsale
-  VERSION = "3.14.9"
+  VERSION = "3.14.10"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dorsale
 version: !ruby/object:Gem::Version
-  version: 3.14.9
+  version: 3.14.10
 platform: ruby
 authors:
 - agilidée
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-12 00:00:00.000000000 Z
+date: 2020-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails