dor-workflow-service 2.11.0 → 2.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8f863086a378b50a1d61a7a2defaa0c33731683b53c7082108438725a7d7ec1
-  data.tar.gz: b398505b2babc4b039678f3b17e06ccd120df459ec8ef38784994690fc0dbf19
+  metadata.gz: 2e6c5805e79584b2d589228b7aeb42594a4bc95574270780825c2895dad05ade
+  data.tar.gz: 7aca0e0086cdf447f8a04eec4ae74d12ef9bcaa7839b8553bc578447fdaf057d
 SHA512:
-  metadata.gz: 3e0bbcea11e6b9ba2070ff50a47145f9cdc6a8e9b2d9b59d8da5961bcf7683c80767ad39928f426358ec7e627b402c1e89846c329988fda417ada8267223c21d
-  data.tar.gz: 9b9006a691d3e89917442e9040bb1c3907c1789c472da4e399b9e5214fd46737455b28822fa2958e53f6c0c791b4947ec9549e04cce2b018ddd9a90ea149e1fa
+  metadata.gz: aac7c412e1f9514753cc5505206bb38f18887fb762507104407a7e60d0764946645800c87e0112d7ad66243fbfd60c0476df9d1cfc348537881c52fee02ae513
+  data.tar.gz: 249ce3b4527851fed63841e74def916ea7d5b04bbc49f368900b5c531a3ce6f5ea508df988ee1e8a1ba01efc21d53da43c4a8fe2916f431bcbdfd1b29e2ea798

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-04-03 11:51:29 -0500 using RuboCop version 0.63.1.
+# on 2019-04-04 15:30:18 -0500 using RuboCop version 0.63.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -23,7 +23,7 @@ Metrics/AbcSize:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 305
+  Max: 307
 
 # Offense count: 3
 # Configuration parameters: CountComments, ExcludedMethods.

data/lib/dor/services/workflow_service.rb

@@ -177,7 +177,7 @@ module Dor
       # @param [String] workflow_name The name of the workflow
       # @return [Workflow::Response::Workflow]
       def workflow(repo: 'dor', pid:, workflow_name:)
-        xml = get_workflow_xml(repo, pid, workflow_name)
+        xml = workflow_xml(repo, pid, workflow_name)
         Workflow::Response::Workflow.new(xml: xml)
       end
 
@@ -390,6 +390,8 @@ module Dor
       #
       # @return [Integer] Number of objects with this repository:workflow:step that have a status of 'error'
       def count_errored_for_workstep(workflow, step, repository = 'dor')
+        Deprecation.warn(self, 'count_errored_for_workstep is deprecated and will be removed in dor-workflow-service version 3. Use count_objects_in_step instead.')
+
         count_objects_in_step(workflow, step, 'error', repository)
       end
 
@@ -401,6 +403,8 @@ module Dor
       #
       # @return [Integer] Number of objects with this repository:workflow:step that have a status of 'queued'
       def count_queued_for_workstep(workflow, step, repository = 'dor')
+        Deprecation.warn(self, 'count_queued_for_workstep is deprecated and will be removed in dor-workflow-service version 3. Use count_objects_in_step instead.')
+
         count_objects_in_step(workflow, step, 'queued', repository)
       end
 

data/lib/dor/workflow_version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Workflow
     module Service
-      VERSION = '2.11.0'
+      VERSION = '2.12.0'
     end
   end
 end

data/spec/workflow_service_spec.rb

@@ -584,6 +584,7 @@ RSpec.describe Dor::WorkflowService do
 
     describe 'count_errored_for_workstep' do
       it 'counts how many steps are errored out' do
+        expect(Deprecation).to receive(:warn)
         expect(described_class.count_errored_for_workstep(@workflow, @step, @repository)).to eq(1)
       end
     end
@@ -609,6 +610,7 @@ RSpec.describe Dor::WorkflowService do
     end
 
     it 'counts how many steps are errored out' do
+      expect(Deprecation).to receive(:warn)
       expect(described_class.count_queued_for_workstep(@workflow, @step, @repository)).to eq(1)
     end
   end
@@ -724,7 +726,7 @@ RSpec.describe Dor::WorkflowService do
       XML
     end
     before do
-      allow(described_class).to receive(:get_workflow_xml) { xml }
+      allow(described_class).to receive(:workflow_xml) { xml }
     end
 
     it 'it returns a workflow' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dor-workflow-service
 version: !ruby/object:Gem::Version
-  version: 2.11.0
+  version: 2.12.0
 platform: ruby
 authors:
 - Willy Mene
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-03 00:00:00.000000000 Z
+date: 2019-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport