dor-workflow-client 4.0.0 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ebdb5efb62a6eaede5600c160ced195692290cc059666345c4ea7e21b9ffee33
-  data.tar.gz: da11701acceca8acc9ed30719e034bfe5eb9350394f90d10b9babdad92600c46
+  metadata.gz: c58569c11d2c599671ecf4fef09158bdf37191c93c4193d96d2e6be614d9eeaa
+  data.tar.gz: ce8f53542aede57b9386ec769673fac4af7a92d9bb32b2c9a00ba9fe59ae6754
 SHA512:
-  metadata.gz: 027c3795481fb428df972a4cd420a281e39226acffb2bf067769de10580fa42d7c64f826c168c1a009f0cef825acb34f027202b95d19ba9098f92333232fcb46
-  data.tar.gz: 82cc4205238d2fbe04c75903dd99ad214579becf8326f6ca46dc459e3a962ca05d38fca587cb42b1c5ea4fe030ff1a61b95f5983828081f24d9fae123123b07d
+  metadata.gz: e09e2e40204d869c31ce832509ccf4582d98823cd767348966789a5961bfb2ae3b67b148a35a41f734fb782100bef10619e36a1f44e244a70685d3a1d6613f90
+  data.tar.gz: 2ddd5435a3f7738a48800182c46e1d243bf9bdaf457d367f7f26d0a7868c61005f853850a18aba61c97475c74bf297b08060fc7a51fdadd76161d90b4287cebc

data/.circleci/config.yml

@@ -1,6 +1,6 @@
 version: 2.1
 orbs:
-  ruby-rails: sul-dlss/ruby-rails@2.0.0
+  ruby-rails: sul-dlss/ruby-rails@3.1.2
 workflows:
   build:
     jobs:

data/.github/pull_request_template.md

@@ -1,12 +1,10 @@
-## Why was this change made?
+## Why was this change made? 🤔
 
 
 
-## How was this change tested?
+## How was this change tested? 🤨
 
-
-
-## Which documentation and/or configurations were updated?
+⚡ ⚠ If this change affects the API or other fundamentals of this service, ***run [integration tests](https://github.com/sul-dlss/infrastructure-integration-test)*** that exercise this service and/or test in [stage|qa] environment, in addition to specs. ⚡
 
 
 

data/.gitignore

@@ -4,7 +4,6 @@
 .config
 .yardoc
 .rvmrc
-Gemfile.lock
 InstalledFiles
 _yardoc
 coverage
@@ -18,4 +17,3 @@ test/version_tmp
 tmp
 .ruby-version
 .ruby-gemset
-

data/.rubocop.yml

@@ -10,7 +10,10 @@ Metrics/BlockLength:
   Exclude:
     - spec/**/*_spec.rb
 
-Gemspec/DateAssignment: # new in 1.10
+Lint/UnusedBlockArgument:
+  AllowUnusedKeywordArguments: true
+
+Gemspec/DeprecatedAttributeAssignment: # new in 1.10
   Enabled: true
 Gemspec/RequireMFA: # new in 1.23
   Enabled: true
@@ -112,3 +115,32 @@ Style/StringChars: # new in 1.12
   Enabled: true
 Style/SwapValues: # new in 1.1
   Enabled: true
+
+Layout/LineContinuationLeadingSpace: # new in 1.31
+  Enabled: true
+Layout/LineContinuationSpacing: # new in 1.31
+  Enabled: true
+Lint/ConstantOverwrittenInRescue: # new in 1.31
+  Enabled: true
+Lint/NonAtomicFileOperation: # new in 1.31
+  Enabled: true
+Lint/RefinementImportMethods: # new in 1.27
+  Enabled: true
+Lint/RequireRangeParentheses: # new in 1.32
+  Enabled: true
+Security/CompoundHash: # new in 1.28
+  Enabled: true
+Style/EmptyHeredoc: # new in 1.32
+  Enabled: true
+Style/EnvHome: # new in 1.29
+  Enabled: true
+Style/FetchEnvVar: # new in 1.28
+  Enabled: true
+Style/MapCompactWithConditionalBlock: # new in 1.30
+  Enabled: true
+Style/NestedFileDirname: # new in 1.26
+  Enabled: true
+Style/ObjectThen: # new in 1.28
+  Enabled: true
+Style/RedundantInitialize: # new in 1.27
+  Enabled: true

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2022-01-14 04:19:32 UTC using RuboCop version 1.24.1.
+# on 2022-06-28 04:56:14 UTC using RuboCop version 1.31.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -27,23 +27,17 @@ Lint/NoReturnInBeginEndBlocks:
 # Offense count: 5
 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 24
-
-# Offense count: 1
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
-# IgnoredMethods: refine
-Metrics/BlockLength:
-  Max: 26
+  Max: 23
 
 # Offense count: 2
 # Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 8
 
-# Offense count: 1
+# Offense count: 2
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
-  Max: 13
+  Max: 19
 
 # Offense count: 3
 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
@@ -51,13 +45,13 @@ Metrics/ParameterLists:
   Max: 8
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Style/KeywordParametersOrder:
   Exclude:
     - 'lib/dor/workflow/client/workflow_routes.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowModifier.
 Style/SoleNestedConditional:
   Exclude:

data/Gemfile.lock

@@ -0,0 +1,123 @@
+PATH
+  remote: .
+  specs:
+    dor-workflow-client (5.1.0)
+      activesupport (>= 3.2.1, < 8)
+      deprecation (>= 0.99.0)
+      faraday (~> 2.0)
+      faraday-retry (~> 2.0)
+      nokogiri (~> 1.6)
+      zeitwerk (~> 2.1)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (7.0.3.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+    addressable (2.8.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.2)
+    byebug (11.1.3)
+    concurrent-ruby (1.1.10)
+    crack (0.4.5)
+      rexml
+    deprecation (1.1.0)
+      activesupport
+    diff-lcs (1.5.0)
+    docile (1.4.0)
+    faraday (2.4.0)
+      faraday-net_http (~> 2.0)
+      ruby2_keywords (>= 0.0.4)
+    faraday-net_http (2.1.0)
+    faraday-retry (2.0.0)
+      faraday (~> 2.0)
+    hashdiff (1.0.1)
+    i18n (1.12.0)
+      concurrent-ruby (~> 1.0)
+    json (2.6.2)
+    mini_portile2 (2.8.0)
+    minitest (5.16.2)
+    nokogiri (1.13.8)
+      mini_portile2 (~> 2.8.0)
+      racc (~> 1.4)
+    parallel (1.22.1)
+    parser (3.1.2.0)
+      ast (~> 2.4.1)
+    public_suffix (4.0.7)
+    racc (1.6.0)
+    rainbow (3.1.1)
+    rake (13.0.6)
+    regexp_parser (2.5.0)
+    rexml (3.2.5)
+    rspec (3.11.0)
+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.0)
+    rspec_junit_formatter (0.5.1)
+      rspec-core (>= 2, < 4, != 2.12.0)
+    rubocop (1.33.0)
+      json (~> 2.3)
+      parallel (~> 1.10)
+      parser (>= 3.1.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.19.1, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.19.1)
+      parser (>= 3.1.1.0)
+    rubocop-rake (0.6.0)
+      rubocop (~> 1.0)
+    rubocop-rspec (2.12.1)
+      rubocop (~> 1.31)
+    ruby-progressbar (1.11.0)
+    ruby2_keywords (0.0.5)
+    simplecov (0.21.2)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
+    tzinfo (2.0.5)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (2.2.0)
+    webmock (3.16.0)
+      addressable (>= 2.8.0)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
+    webrick (1.7.0)
+    yard (0.9.28)
+      webrick (~> 1.7.0)
+    zeitwerk (2.6.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  byebug
+  dor-workflow-client!
+  rake
+  rspec (~> 3.3)
+  rspec_junit_formatter
+  rubocop (~> 1.24)
+  rubocop-rake
+  rubocop-rspec (~> 2.1)
+  simplecov
+  webmock
+  yard
+
+BUNDLED WITH
+   2.3.17

data/dor-workflow-client.gemspec

@@ -14,14 +14,13 @@ Gem::Specification.new do |gem|
   gem.homepage      = 'https://consul.stanford.edu/display/DOR/DOR+services#DORservices-initializeworkflow'
 
   gem.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  gem.test_files    = gem.files.grep(%r{^(spec)/})
   gem.require_paths = ['lib']
   gem.required_ruby_version = '>= 2.7'
 
   gem.add_dependency 'activesupport', '>= 3.2.1', '< 8'
   gem.add_dependency 'deprecation', '>= 0.99.0'
   gem.add_dependency 'faraday', '~> 2.0'
-  gem.add_dependency 'faraday-retry'
+  gem.add_dependency 'faraday-retry', '~> 2.0'
 
   gem.add_dependency 'nokogiri', '~> 1.6'
   gem.add_dependency 'zeitwerk', '~> 2.1'

data/lib/dor/workflow/client/connection_factory.rb

@@ -15,7 +15,6 @@ module Dor
           @logger = logger
         end
 
-        # rubocop:disable Metrics/MethodLength
         def build_connection
           Faraday.new(url: url) do |faraday|
             faraday.use Faraday::Response::RaiseError # raise exceptions on 40x, 50x responses
@@ -37,7 +36,6 @@ module Dor
             faraday.adapter Faraday.default_adapter # Last middleware must be the adapter
           end
         end
-        # rubocop:enable Metrics/MethodLength
 
         def user_agent
           "dor-workflow-client #{VERSION}"
@@ -56,8 +54,8 @@ module Dor
         end
 
         def retry_block
-          lambda do |env, _opts, retries, exception|
-            logger.warn "retrying connection (#{retries} remaining) to #{env.url}: (#{exception.class}) " \
+          lambda do |env:, options:, retry_count:, exception:, will_retry_in:|
+            logger.warn "retrying connection (#{retry_count + 1}) to #{env.url}: (#{exception.class}) " \
                         "#{exception.message} #{env.status}"
           end
         end

data/lib/dor/workflow/client/lifecycle_routes.rb

@@ -14,39 +14,12 @@ module Dor
         # @param [String] repo The repository the object resides in. This parameter is deprecated
         # @param [String] druid object id
         # @param [String] milestone_name the name of the milestone being queried for
-        # @param [Number] version the version to query for
+        # @param [Number] version (nil) the version to query for
         # @param [Boolean] active_only (false) if true, return only lifecycle steps for versions that have all processes complete
         # @return [Time] when the milestone was achieved.  Returns nil if the milestone does not exist
-        #
-        # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-        def lifecycle(*args)
-          case args.size
-          when 4
-            Deprecation.warn(self, 'you provided 4 args, but lifecycle now takes kwargs')
-            (repo, druid, milestone_name) = args[0..2]
-            version = args[3][:version]
-            active_only = args[3][:active_only] || false
-          when 3
-            Deprecation.warn(self, 'you provided 3 args, but lifecycle now takes kwargs')
-            (repo, druid, milestone_name) = args
-            version = nil
-            active_only = false
-          when 1
-            opts = args.first
-            repo = opts[:repo]
-            druid = opts[:druid]
-            milestone_name = opts[:milestone_name]
-            version = opts[:version]
-            active_only = opts[:active_only] || false
-          else
-            raise ArgumentError, 'wrong number of arguments, must be 1, or 3-5'
-          end
-
-          Deprecation.warn(self, 'passing the repo parameter to lifecycle is no longer necessary. This will raise an error in dor-workflow-client version 4') if repo
-
+        def lifecycle(druid:, milestone_name:, version: nil, active_only: false)
           filter_milestone(query_lifecycle(druid, version: version, active_only: active_only), milestone_name)
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
         # Returns the Date for a requested milestone ONLY for the current version.
         # This is slow as the workflow server will query dor-services-app for the version.
@@ -55,57 +28,17 @@ module Dor
         # @param [String] milestone_name the name of the milestone being queried for
         # @param [Number] version the version to query for
         # @return [Time] when the milestone was achieved.  Returns nil if the milestone does not exis
-        #
-        # rubocop:disable Metrics/MethodLength
-        def active_lifecycle(*args)
-          case args.size
-          when 4
-            Deprecation.warn(self, 'you provided 4 args, but active_lifecycle now takes kwargs')
-            (repo, druid, milestone_name) = args[0..2]
-            version = args[3][:version]
-          when 3
-            Deprecation.warn(self, 'you provided 3 args, but active_lifecycle now takes kwargs')
-            (repo, druid, milestone_name) = args
-            version = nil
-          when 1
-            opts = args.first
-            repo = opts[:repo]
-            druid = opts[:druid]
-            milestone_name = opts[:milestone_name]
-            version = opts[:version]
-          else
-            raise ArgumentError, 'wrong number of arguments, must be 1, 3, or 4'
-          end
-
-          Deprecation.warn(self, 'passing the repo parameter to active_lifecycle is no longer necessary. This will raise an error in dor-workflow-client version 4') if repo
-
+        def active_lifecycle(druid:, milestone_name:, version:)
           lifecycle(druid: druid, milestone_name: milestone_name, version: version, active_only: true)
         end
-        # rubocop:enable Metrics/MethodLength
 
         # @return [Array<Hash>]
-        # rubocop:disable Metrics/MethodLength
-        def milestones(*args)
-          case args.size
-          when 2
-            Deprecation.warn(self, 'you provided 2 args, but active_lifecycle now takes kwargs')
-            (repo, druid) = args
-          when 1
-            opts = args.first
-            repo = opts[:repo]
-            druid = opts.fetch(:druid)
-          else
-            raise ArgumentError, 'wrong number of arguments, must be 1-2'
-          end
-
-          Deprecation.warn(self, 'passing the repo parameter to active_lifecycle is no longer necessary. This will raise an error in dor-workflow-client version 4') if repo
-
+        def milestones(druid:)
           doc = query_lifecycle(druid, active_only: false)
           doc.xpath('//lifecycle/milestone').collect do |node|
             { milestone: node.text, at: Time.parse(node['date']), version: node['version'] }
           end
         end
-        # rubocop:enable Metrics/MethodLength
 
         private
 

data/lib/dor/workflow/client/queues.rb

@@ -11,59 +11,35 @@ module Dor
 
         # Returns all the distinct laneIds for a given workflow step
         #
-        # @param [String] repo -- deprecated, ignored by workflow service
         # @param [String] workflow name
         # @param [String] process name
         # @return [Array<String>] all of the distinct laneIds.  Array will be empty if no lane ids were found
-        def lane_ids(*args)
-          if args.count == 3
-            Deprecation.warn(
-              self,
-              '`#lane_ids` only takes two args: workflow name, & process/step name. This will raise an exception in Dor::Workflow::Client 4.0.0'
-            )
-            args.shift # ditch the `repo` argument
-          end
-          uri = "workflow_queue/lane_ids?step=#{args.first}:#{args.second}"
+        def lane_ids(workflow, process)
+          uri = "workflow_queue/lane_ids?step=#{workflow}:#{process}"
           doc = Nokogiri::XML(requestor.request(uri))
           doc.xpath('/lanes/lane').map { |n| n['id'] }
         end
 
         # Gets all of the workflow steps that have a status of 'queued' that have a last-updated timestamp older than the number of hours passed in
         #   This will enable re-queueing of jobs that have been lost by the job manager
-        # @param [String] repository -- deprecated, ignored by workflow service
         # @param [Hash] opts optional values for query
         # @option opts [Integer] :hours_ago steps older than this value will be returned by the query.  If not passed in, the service defaults to 0 hours,
         #   meaning you will get all queued workflows
         # @option opts [Integer] :limit sets the maximum number of workflow steps that can be returned.  Defaults to no limit
         # @return [Array[Hash]] each Hash represents a workflow step.  It will have the following keys:
         #  :workflow, :step, :druid, :lane_id
-        def stale_queued_workflows(*args)
-          if args.count == 2
-            Deprecation.warn(
-              self,
-              '`#stale_queued_workflows` only takes one arg: a hash. This will raise an exception in Dor::Workflow::Client 4.0.0'
-            )
-            args.shift # ditch the `repo` argument
-          end
-          uri_string = build_queued_uri(args.first)
+        def stale_queued_workflows(opts)
+          uri_string = build_queued_uri(opts)
           parse_queued_workflows_response requestor.request(uri_string)
         end
 
         # Returns a count of workflow steps that have a status of 'queued' that have a last-updated timestamp older than the number of hours passed in
-        # @param [String] repository -- deprecated, ignored by workflow service
         # @param [Hash] opts optional values for query
         # @option opts [Integer] :hours_ago steps older than this value will be returned by the query.  If not passed in, the service defaults to 0 hours,
         #   meaning you will get all queued workflows
         # @return [Integer] number of stale, queued steps if the :count_only option was set to true
-        def count_stale_queued_workflows(*args)
-          if args.count == 2
-            Deprecation.warn(
-              self,
-              '`#count_stale_queued_workflows` only takes one arg: a hash. This will raise an exception in Dor::Workflow::Client 4.0.0'
-            )
-            args.shift # ditch the `repo` argument
-          end
-          uri_string = "#{build_queued_uri(args.first)}&count-only=true"
+        def count_stale_queued_workflows(opts)
+          uri_string = "#{build_queued_uri(opts)}&count-only=true"
           doc = Nokogiri::XML(requestor.request(uri_string))
           doc.at_xpath('/objects/@count').value.to_i
         end
@@ -102,7 +78,6 @@ module Dor
         #     }
         #
         def objects_for_workstep(completed, waiting, lane_id = 'default', options = {})
-          Deprecation.warn(self, 'the `:default_repository` option in `#objects_for_workstep` is unused and will go away in Dor::Workflow::Client 4.0.0. omit argument to silence.') if options[:default_repository]
           waiting_param = qualify_step(options[:default_workflow], waiting)
           uri_string = "workflow_queue?waiting=#{waiting_param}"
           if completed
@@ -133,15 +108,13 @@ module Dor
         #
         # @param [String] workflow name
         # @param [String] step name
-        # @param [String] repository -- deprecated, ignored by workflow service
         #
         # @return [Hash] hash of results, with key has a druid, and value as the error message
         # @example
         #     client.errored_objects_for_workstep('accessionWF','content-metadata')
         #     => {"druid:qd556jq0580"=>"druid:qd556jq0580 - Item error; caused by
-        #        #<Rubydora::FedoraInvalidRequest: Error modifying datastream contentMetadata for druid:qd556jq0580. See logger for details>"}
-        def errored_objects_for_workstep(workflow, step, repository = nil)
-          Deprecation.warn(self, 'the third argument to `#errored_objects_for_workstep` is unused and will go away in Dor::Workflow::Client 4.0.0. omit argument to silence.') unless repository.nil?
+        #        blah blah. See logger for details>"}
+        def errored_objects_for_workstep(workflow, step)
           resp = requestor.request "workflow_queue?workflow=#{workflow}&error=#{step}"
           Nokogiri::XML(resp).xpath('//object').to_h do |node|
             [node['id'], node['errorMessage']]
@@ -153,11 +126,9 @@ module Dor
         # @param [String] workflow name
         # @param [String] step name
         # @param [String] type
-        # @param [String] repo -- deprecated, ignored by workflow service
         #
         # @return [Hash] hash of results, with key has a druid, and value as the error message
-        def count_objects_in_step(workflow, step, type, repo = nil)
-          Deprecation.warn(self, 'the fourth argument to `#count_objects_in_step` is unused and will go away in Dor::Workflow::Client 4.0.0. omit argument to silence.') unless repo.nil?
+        def count_objects_in_step(workflow, step, type)
           resp = requestor.request "workflow_queue?workflow=#{workflow}&#{type}=#{step}"
           extract_object_count(resp)
         end
@@ -166,11 +137,9 @@ module Dor
         #
         # @param [String] workflow name
         # @param [String] step name
-        # @param [String] repository -- deprecated, ignored by workflow service
         #
         # @return [Integer] Number of objects with this repository:workflow:step that have a status of 'error'
-        def count_errored_for_workstep(workflow, step, repository = nil)
-          Deprecation.warn(self, 'the third argument to `#count_errored_for_workstep` is unused and will go away in Dor::Workflow::Client 4.0.0. omit argument to silence.') unless repository.nil?
+        def count_errored_for_workstep(workflow, step)
           count_objects_in_step(workflow, step, 'error')
         end
 
@@ -178,11 +147,9 @@ module Dor
         #
         # @param [String] workflow name
         # @param [String] step name
-        # @param [String] repository -- deprecated, ignored by workflow service
         #
         # @return [Integer] Number of objects with this repository:workflow:step that have a status of 'queued'
-        def count_queued_for_workstep(workflow, step, repository = nil)
-          Deprecation.warn(self, 'the third argument to `#count_queued_for_workstep` is unused and will go away in Dor::Workflow::Client 4.0.0. omit argument to silence.') unless repository.nil?
+        def count_queued_for_workstep(workflow, step)
           count_objects_in_step(workflow, step, 'queued')
         end
 

data/lib/dor/workflow/client/status.rb

@@ -42,7 +42,6 @@ module Dor
         end
 
         # @return [Hash{Symbol => Object}] including :status_code and :status_time
-        # rubocop:disable Metrics/MethodLength
         def info
           @info ||= begin
             # if we have an accessioned milestone, this is the last possible step and should be the status regardless of time stamp
@@ -64,7 +63,6 @@ module Dor
             { status_code: status_code, status_time: status_time }
           end
         end
-        # rubocop:enable Metrics/MethodLength
 
         def status_code
           info.fetch(:status_code)

data/lib/dor/workflow/client/version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Workflow
     class Client
-      VERSION = '4.0.0'
+      VERSION = '5.1.0'
     end
   end
 end

data/lib/dor/workflow/client/version_routes.rb

@@ -17,32 +17,10 @@ module Dor
         # @param [String] repo The repository the object resides in. This parameter is deprecated
         # @param [String] druid The id of the object to delete the workflow from
         # @param [Boolean] create_accession_wf Option to create accessionWF when closing a version.  Defaults to true
-        # rubocop:disable Metrics/MethodLength
-        def close_version(*args)
-          case args.size
-          when 3
-            Deprecation.warn(self, 'you provided 3 args, but close_version now takes kwargs')
-            (repo, druid, create_accession_wf) = args
-          when 2
-            Deprecation.warn(self, 'you provided 2 args, but close_version now takes kwargs')
-            (repo, druid) = args
-            create_accession_wf = true
-          when 1
-            opts = args.first
-            repo = opts[:repo]
-            druid = opts[:druid]
-            version = opts[:version]
-            create_accession_wf = opts.key?(:create_accession_wf) ? opts[:create_accession_wf] : true
-          else
-            raise ArgumentError, 'wrong number of arguments, must be 1-3'
-          end
-
-          Deprecation.warn(self, 'passing the repo parameter to close_version is no longer necessary. This will raise an error in dor-workflow-client version 4') if repo
-
+        def close_version(druid:, version:, create_accession_wf: true)
           requestor.request(construct_url(druid, version, create_accession_wf), 'post', '')
           true
         end
-        # rubocop:enable Metrics/MethodLength
 
         private