dor-workflow-client 3.20.1 → 3.21.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 72216d42c794ae36d6acd797dcdce2bb832c245073f1a2fcebc75d5783c53195
-  data.tar.gz: b93900aa5bb1f4f890d1ad65f6599588f4b63ed484c23bbd1803529ee4b1958c
+  metadata.gz: fa44370f3c08db522a5cfba8c511b44f096ea83cd6f3e55b209dc572a08b2922
+  data.tar.gz: 5d59452a5abf0f368f53ed48d78799726c8127795c724773e33d0a77f66ebaa9
 SHA512:
-  metadata.gz: 9b65608bf8ded1d8a117f1b1414870e91a07cf6f500558e302ffa5d1971a4f0bee0d6b372233c004c87777d181be12ff9a58c0ec7d4334c242f191c4c812e01b
-  data.tar.gz: 94efc4ba202e0ba928c52b182477f436da4cfb04aab810654f51968e34fc0f366dd81bce7eece93dfefb44414ab58f8017d7038304905d145c9498f793c0f6ef
+  metadata.gz: 1465b2aea82e56422aabb3193a0a9d70ae5d1cdd40d086d2369d73c67e477eb0cff7f6ffb92937d59dc5f123b0ad906e8c1ab5f95ff9ef3c9a41532e193797d1
+  data.tar.gz: '095ab0801c5fddda8c554d32f0a537b38bc04dca3c97e50ff1aa396770aee56f2140a9e97d0e1e584b9b5269535649357eeed8be4207d12d0087dced540a8f16'

data/.github/pull_request_template.md

@@ -0,0 +1,5 @@
+## Why was this change made?
+
+
+
+## Was the usage documentation (e.g. wiki, README) updated?

data/README.md

@@ -37,7 +37,7 @@ client.update_status(druid: 'druid:bc123df4567',
 
 Show "milestones" for an object
 ```ruby
-client.milestones('dor', 'druid:gv054hp4128')
+client.milestones(druid: 'druid:gv054hp4128')
 #=> [{version: '1', milestone: 'published'}]
 ```
 

data/lib/dor/workflow/client/lifecycle_routes.rb

@@ -10,37 +10,102 @@ module Dor
         end
 
         # Returns the Date for a requested milestone from workflow lifecycle
-        # @param [String] repo repository name
+        #
+        # @param [String] repo The repository the object resides in. This parameter is deprecated
         # @param [String] druid object id
         # @param [String] milestone_name the name of the milestone being queried for
         # @param [Number] version the version to query for
         # @param [Boolean] active_only (false) if true, return only lifecycle steps for versions that have all processes complete
         # @return [Time] when the milestone was achieved.  Returns nil if the milestone does not exist
         #
-        def lifecycle(repo, druid, milestone_name, version: nil, active_only: false)
-          filter_milestone(query_lifecycle(repo, druid, version: version, active_only: active_only), milestone_name)
+        # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+        def lifecycle(*args)
+          case args.size
+          when 4
+            Deprecation.warn(self, 'you provided 4 args, but lifecycle now takes kwargs')
+            (repo, druid, milestone_name) = args[0..2]
+            version = args[3][:version]
+            active_only = args[3][:active_only] || false
+          when 3
+            Deprecation.warn(self, 'you provided 3 args, but lifecycle now takes kwargs')
+            (repo, druid, milestone_name) = args
+            version = nil
+            active_only = false
+          when 1
+            opts = args.first
+            repo = opts[:repo]
+            druid = opts[:druid]
+            milestone_name = opts[:milestone_name]
+            version = opts[:version]
+            active_only = opts[:active_only] || false
+          else
+            raise ArgumentError, 'wrong number of arguments, must be 1, or 3-5'
+          end
+
+          Deprecation.warn(self, 'passing the repo parameter to lifecycle is no longer necessary. This will raise an error in dor-workflow-client version 4') if repo
+
+          filter_milestone(query_lifecycle(druid, version: version, active_only: active_only), milestone_name)
         end
+        # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
         # Returns the Date for a requested milestone ONLY for the current version.
         # This is slow as the workflow server will query dor-services-app for the version.
         # A better approach is #lifecycle with the version tag.
-        # @param [String] repo repository name
         # @param [String] druid object id
         # @param [String] milestone_name the name of the milestone being queried for
         # @param [Number] version the version to query for
         # @return [Time] when the milestone was achieved.  Returns nil if the milestone does not exis
         #
-        def active_lifecycle(repo, druid, milestone_name, version: nil)
-          lifecycle(repo, druid, milestone_name, version: version, active_only: true)
+        # rubocop:disable Metrics/MethodLength
+        def active_lifecycle(*args)
+          case args.size
+          when 4
+            Deprecation.warn(self, 'you provided 4 args, but active_lifecycle now takes kwargs')
+            (repo, druid, milestone_name) = args[0..2]
+            version = args[3][:version]
+          when 3
+            Deprecation.warn(self, 'you provided 3 args, but active_lifecycle now takes kwargs')
+            (repo, druid, milestone_name) = args
+            version = nil
+          when 1
+            opts = args.first
+            repo = opts[:repo]
+            druid = opts[:druid]
+            milestone_name = opts[:milestone_name]
+            version = opts[:version]
+          else
+            raise ArgumentError, 'wrong number of arguments, must be 1, 3, or 4'
+          end
+
+          Deprecation.warn(self, 'passing the repo parameter to active_lifecycle is no longer necessary. This will raise an error in dor-workflow-client version 4') if repo
+
+          lifecycle(druid: druid, milestone_name: milestone_name, version: version, active_only: true)
         end
+        # rubocop:enable Metrics/MethodLength
+
+        # @return [Array<Hash>]
+        # rubocop:disable Metrics/MethodLength
+        def milestones(*args)
+          case args.size
+          when 2
+            Deprecation.warn(self, 'you provided 2 args, but active_lifecycle now takes kwargs')
+            (repo, druid) = args
+          when 1
+            opts = args.first
+            repo = opts[:repo]
+            druid = opts.fetch(:druid)
+          else
+            raise ArgumentError, 'wrong number of arguments, must be 1-2'
+          end
+
+          Deprecation.warn(self, 'passing the repo parameter to active_lifecycle is no longer necessary. This will raise an error in dor-workflow-client version 4') if repo
 
-        # @return [Hash]
-        def milestones(repo, druid)
-          doc = query_lifecycle(repo, druid, active_only: false)
+          doc = query_lifecycle(druid, active_only: false)
           doc.xpath('//lifecycle/milestone').collect do |node|
             { milestone: node.text, at: Time.parse(node['date']), version: node['version'] }
           end
         end
+        # rubocop:enable Metrics/MethodLength
 
         private
 
@@ -51,7 +116,6 @@ module Dor
           Time.parse(milestone['date'])
         end
 
-        # @param [String] repo repository name
         # @param [String] druid object id
         # @param [Boolean] active_only (false) if true, return only lifecycle steps for versions that have all processes complete
         # @param [Number] version the version to query for
@@ -63,8 +127,8 @@ module Dor
         #     <milestone date="2010-06-15T16:08:58-0700">released</milestone>
         #   </lifecycle>
         #
-        def query_lifecycle(repo, druid, active_only:, version: nil)
-          req = "#{repo}/objects/#{druid}/lifecycle"
+        def query_lifecycle(druid, active_only:, version: nil)
+          req = "objects/#{druid}/lifecycle"
           params = []
           params << "version=#{version}" if version
           params << 'active-only=true' if active_only

data/lib/dor/workflow/client/queues.rb

@@ -11,39 +11,59 @@ module Dor
 
         # Returns all the distinct laneIds for a given workflow step
         #
-        # @param [String] repo The repository the object resides in.  The service recoginzes "dor" and "sdr" at the moment
+        # @param [String] repo -- deprecated, ignored by workflow service
         # @param [String] workflow name
         # @param [String] process name
         # @return [Array<String>] all of the distinct laneIds.  Array will be empty if no lane ids were found
-        def lane_ids(repo, workflow, process)
-          uri = "workflow_queue/lane_ids?step=#{repo}:#{workflow}:#{process}"
+        def lane_ids(*args)
+          if args.count == 3
+            Deprecation.warn(
+              self,
+              '`#lane_ids` only takes two args: workflow name, & process/step name. This will raise an exception in Dor::Workflow::Client 4.0.0'
+            )
+            args.shift # ditch the `repo` argument
+          end
+          uri = "workflow_queue/lane_ids?step=#{args.first}:#{args.second}"
           doc = Nokogiri::XML(requestor.request(uri))
-          nodes = doc.xpath('/lanes/lane')
-          nodes.map { |n| n['id'] }
+          doc.xpath('/lanes/lane').map { |n| n['id'] }
         end
 
         # Gets all of the workflow steps that have a status of 'queued' that have a last-updated timestamp older than the number of hours passed in
         #   This will enable re-queueing of jobs that have been lost by the job manager
-        # @param [String] repository name of the repository you want to query, like 'dor' or 'sdr'
+        # @param [String] repository -- deprecated, ignored by workflow service
         # @param [Hash] opts optional values for query
         # @option opts [Integer] :hours_ago steps older than this value will be returned by the query.  If not passed in, the service defaults to 0 hours,
         #   meaning you will get all queued workflows
         # @option opts [Integer] :limit sets the maximum number of workflow steps that can be returned.  Defaults to no limit
         # @return [Array[Hash]] each Hash represents a workflow step.  It will have the following keys:
         #  :workflow, :step, :druid, :lane_id
-        def stale_queued_workflows(repository, opts = {})
-          uri_string = build_queued_uri(repository, opts)
+        def stale_queued_workflows(*args)
+          if args.count == 2
+            Deprecation.warn(
+              self,
+              '`#stale_queued_workflows` only takes one arg: a hash. This will raise an exception in Dor::Workflow::Client 4.0.0'
+            )
+            args.shift # ditch the `repo` argument
+          end
+          uri_string = build_queued_uri(args.first)
           parse_queued_workflows_response requestor.request(uri_string)
         end
 
         # Returns a count of workflow steps that have a status of 'queued' that have a last-updated timestamp older than the number of hours passed in
-        # @param [String] repository name of the repository you want to query, like 'dor' or 'sdr'
+        # @param [String] repository -- deprecated, ignored by workflow service
         # @param [Hash] opts optional values for query
         # @option opts [Integer] :hours_ago steps older than this value will be returned by the query.  If not passed in, the service defaults to 0 hours,
         #   meaning you will get all queued workflows
         # @return [Integer] number of stale, queued steps if the :count_only option was set to true
-        def count_stale_queued_workflows(repository, opts = {})
-          uri_string = build_queued_uri(repository, opts) + '&count-only=true'
+        def count_stale_queued_workflows(*args)
+          if args.count == 2
+            Deprecation.warn(
+              self,
+              '`#count_stale_queued_workflows` only takes one arg: a hash. This will raise an exception in Dor::Workflow::Client 4.0.0'
+            )
+            args.shift # ditch the `repo` argument
+          end
+          uri_string = build_queued_uri(args.first) + '&count-only=true'
           doc = Nokogiri::XML(requestor.request(uri_string))
           doc.at_xpath('/objects/@count').value.to_i
         end
@@ -51,13 +71,11 @@ module Dor
         # Returns a list of druids from the workflow service that meet the criteria
         # of the passed in completed and waiting params
         #
-        # @param [Array<String>, String] completed An array or single String of the completed steps, should use the qualified format: `repository:workflow:step-name`
+        # @param [Array<String>, String] completed An array or single String of the completed steps, should use the qualified format: `workflow:step-name`
         # @param [String] waiting name of the waiting step
-        # @param [String] repository default repository to use if it isn't passed in the qualified-step-name
         # @param [String] workflow default workflow to use if it isn't passed in the qualified-step-name
         # @param [String] lane_id issue a query for a specific lane_id for the waiting step
         # @param [Hash] options
-        # @param options  [String]  :default_repository repository to query for if not using the qualified format
         # @param options  [String]  :default_workflow workflow to query for if not using the qualified format
         # @option options [Integer] :limit maximum number of druids to return (nil for no limit)
         # @return [Array<String>]  Array of druids
@@ -84,11 +102,12 @@ module Dor
         #     }
         #
         def objects_for_workstep(completed, waiting, lane_id = 'default', options = {})
-          waiting_param = qualify_step(options[:default_repository], options[:default_workflow], waiting)
+          Deprecation.warn(self, 'the `:default_repository` option in `#objects_for_workstep` is unused and will go away in Dor::Workflow::Client 4.0.0. omit argument to silence.') if options[:default_repository]
+          waiting_param = qualify_step(options[:default_workflow], waiting)
           uri_string = "workflow_queue?waiting=#{waiting_param}"
           if completed
             Array(completed).each do |step|
-              completed_param = qualify_step(options[:default_repository], options[:default_workflow], step)
+              completed_param = qualify_step(options[:default_workflow], step)
               uri_string += "&completed=#{completed_param}"
             end
           end
@@ -107,33 +126,39 @@ module Dor
           # convert into:
           #   ['druid:ab123de4567', 'druid:ab123de9012']
           #
-          result = Nokogiri::XML(resp).xpath('//object[@id]')
-          result.map { |n| n[:id] }
+          Nokogiri::XML(resp).xpath('//object[@id]').map { |n| n[:id] }
         end
 
         # Get a list of druids that have errored out in a particular workflow and step
         #
         # @param [String] workflow name
         # @param [String] step name
-        # @param [String] repository -- optional, default=dor
+        # @param [String] repository -- deprecated, ignored by workflow service
         #
         # @return [Hash] hash of results, with key has a druid, and value as the error message
         # @example
         #     client.errored_objects_for_workstep('accessionWF','content-metadata')
         #     => {"druid:qd556jq0580"=>"druid:qd556jq0580 - Item error; caused by
         #        #<Rubydora::FedoraInvalidRequest: Error modifying datastream contentMetadata for druid:qd556jq0580. See logger for details>"}
-        def errored_objects_for_workstep(workflow, step, repository = 'dor')
-          resp = requestor.request "workflow_queue?repository=#{repository}&workflow=#{workflow}&error=#{step}"
-          result = {}
-          Nokogiri::XML(resp).xpath('//object').collect do |node|
-            result.merge!(node['id'] => node['errorMessage'])
-          end
-          result
+        def errored_objects_for_workstep(workflow, step, repository = nil)
+          Deprecation.warn(self, 'the third argument to `#errored_objects_for_workstep` is unused and will go away in Dor::Workflow::Client 4.0.0. omit argument to silence.') unless repository.nil?
+          resp = requestor.request "workflow_queue?workflow=#{workflow}&error=#{step}"
+          Nokogiri::XML(resp).xpath('//object').map do |node|
+            [node['id'], node['errorMessage']]
+          end.to_h
         end
 
         # Used by preservation robots stats reporter
-        def count_objects_in_step(workflow, step, type, repo)
-          resp = requestor.request "workflow_queue?repository=#{repo}&workflow=#{workflow}&#{type}=#{step}"
+        #
+        # @param [String] workflow name
+        # @param [String] step name
+        # @param [String] type
+        # @param [String] repo -- deprecated, ignored by workflow service
+        #
+        # @return [Hash] hash of results, with key has a druid, and value as the error message
+        def count_objects_in_step(workflow, step, type, repo = nil)
+          Deprecation.warn(self, 'the fourth argument to `#count_objects_in_step` is unused and will go away in Dor::Workflow::Client 4.0.0. omit argument to silence.') unless repo.nil?
+          resp = requestor.request "workflow_queue?workflow=#{workflow}&#{type}=#{step}"
           extract_object_count(resp)
         end
 
@@ -141,52 +166,50 @@ module Dor
         #
         # @param [String] workflow name
         # @param [String] step name
-        # @param [String] repository -- optional, default=dor
+        # @param [String] repository -- deprecated, ignored by workflow service
         #
         # @return [Integer] Number of objects with this repository:workflow:step that have a status of 'error'
-        def count_errored_for_workstep(workflow, step, repository = 'dor')
-          count_objects_in_step(workflow, step, 'error', repository)
+        def count_errored_for_workstep(workflow, step, repository = nil)
+          Deprecation.warn(self, 'the third argument to `#count_errored_for_workstep` is unused and will go away in Dor::Workflow::Client 4.0.0. omit argument to silence.') unless repository.nil?
+          count_objects_in_step(workflow, step, 'error')
         end
 
         # Returns the number of objects that have a status of 'queued' in a particular workflow and step
         #
         # @param [String] workflow name
         # @param [String] step name
-        # @param [String] repository -- optional, default=dor
+        # @param [String] repository -- deprecated, ignored by workflow service
         #
         # @return [Integer] Number of objects with this repository:workflow:step that have a status of 'queued'
-        def count_queued_for_workstep(workflow, step, repository = 'dor')
-          count_objects_in_step(workflow, step, 'queued', repository)
+        def count_queued_for_workstep(workflow, step, repository = nil)
+          Deprecation.warn(self, 'the third argument to `#count_queued_for_workstep` is unused and will go away in Dor::Workflow::Client 4.0.0. omit argument to silence.') unless repository.nil?
+          count_objects_in_step(workflow, step, 'queued')
         end
 
         private
 
         attr_reader :requestor
 
-        def build_queued_uri(repository, opts = {})
-          uri_string = "workflow_queue/all_queued?repository=#{repository}"
-          uri_string += "&hours-ago=#{opts[:hours_ago]}" if opts[:hours_ago]
-          uri_string += "&limit=#{opts[:limit]}"         if opts[:limit]
-          uri_string
+        def build_queued_uri(opts = {})
+          query_hash = opts.slice(:hours_ago, :limit).transform_keys { |key| key.to_s.tr('_', '-') }
+          query_string = URI.encode_www_form(query_hash)
+          "workflow_queue/all_queued?#{query_string}"
         end
 
-        # Converts repo-workflow-step into repo:workflow:step
-        # @param [String] default_repository
+        # Converts workflow-step into workflow:step
         # @param [String] default_workflow
         # @param [String] step if contains colon :, then the value for workflow and/or workflow/repository. For example: 'jp2-create', 'assemblyWF:jp2-create' or 'dor:assemblyWF:jp2-create'
-        # @return [String] repo:workflow:step
+        # @return [String] workflow:step
         # @example
-        #   dor:assemblyWF:jp2-create
-        def qualify_step(default_repository, default_workflow, step)
-          current = step.split(/:/, 3)
-          current.unshift(default_workflow)   if current.length < 3
-          current.unshift(default_repository) if current.length < 3
+        #   assemblyWF:jp2-create
+        def qualify_step(default_workflow, step)
+          current = step.split(':').last(2)
+          current.unshift(default_workflow) if current.length < 2
           current.join(':')
         end
 
         def parse_queued_workflows_response(xml)
-          doc = Nokogiri::XML(xml)
-          doc.xpath('/workflows/workflow').collect do |wf_node|
+          Nokogiri::XML(xml).xpath('/workflows/workflow').collect do |wf_node|
             {
               workflow: wf_node['name'],
               step: wf_node['process'],

data/lib/dor/workflow/client/status.rb

@@ -86,7 +86,7 @@ module Dor
         end
 
         def milestones
-          @milestones ||= lifecycle_routes.milestones('dor', druid)
+          @milestones ||= lifecycle_routes.milestones(druid: druid)
         end
 
         private

data/lib/dor/workflow/client/version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Workflow
     class Client
-      VERSION = '3.20.1'
+      VERSION = '3.21.0'
     end
   end
 end

data/lib/dor/workflow/client/workflow_routes.rb

@@ -274,7 +274,7 @@ module Dor
           workflow(pid: pid, workflow_name: workflow_name).process_for_recent_version(name: process)
         end
 
-        # Deletes a workflow from a particular repository and druid
+        # Deletes a workflow from a particular repository and druid. This is only used by Hydrus.
         # @param [String] repo The repository the object resides in.  The service recoginzes "dor" and "sdr" at the moment
         # @param [String] druid The id of the object to delete the workflow from
         # @param [String] workflow The name of the workflow to be deleted

data/spec/workflow/client/lifecycle_routes_spec.rb

@@ -6,6 +6,8 @@ RSpec.describe Dor::Workflow::Client::LifecycleRoutes do
   let(:requestor) { instance_double(Dor::Workflow::Client::Requestor, request: response) }
   let(:response) { '<xml />' }
   let(:routes) { described_class.new(requestor: requestor) }
+  let(:repo) { 'dor' }
+  let(:druid) { 'druid:gv054hp4128' }
 
   describe '#milestones' do
     let(:ng_xml) { Nokogiri::XML(xml) }
@@ -15,52 +17,177 @@ RSpec.describe Dor::Workflow::Client::LifecycleRoutes do
 
     before do
       allow(routes).to receive(:query_lifecycle).and_return(ng_xml)
+      allow(Deprecation).to receive(:warn)
     end
 
-    subject(:milestones) { routes.milestones('dor', 'druid:gv054hp4128') }
+    context 'with positional arguments' do
+      subject(:milestones) { routes.milestones(repo, druid) }
 
-    it 'includes the version in with the milestones' do
-      expect(milestones.first[:milestone]).to eq('published')
-      expect(milestones.first[:version]).to eq('2')
+      it 'includes the version in with the milestones' do
+        expect(milestones.first[:milestone]).to eq('published')
+        expect(milestones.first[:version]).to eq('2')
+        expect(Deprecation).to have_received(:warn).twice
+      end
+    end
+
+    context 'with kwargs' do
+      subject(:milestones) { routes.milestones(druid: druid) }
+
+      it 'includes the version in with the milestones' do
+        expect(milestones.first[:milestone]).to eq('published')
+        expect(milestones.first[:version]).to eq('2')
+      end
     end
   end
 
   describe '#lifecycle' do
-    context 'without version' do
-      subject(:lifecycle) { routes.lifecycle('dor', 'druid:gv054hp4128', 'submitted') }
+    context 'with positional arguments' do
+      before do
+        allow(Deprecation).to receive(:warn)
+      end
+
+      context 'without version' do
+        subject(:lifecycle) { routes.lifecycle(repo, druid, 'submitted') }
+
+        it 'make the request' do
+          lifecycle
+          expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle')
+          expect(Deprecation).to have_received(:warn).twice
+        end
+      end
 
-      it 'make the request' do
-        lifecycle
-        expect(requestor).to have_received(:request).with('dor/objects/druid:gv054hp4128/lifecycle')
+      context 'with version' do
+        subject(:lifecycle) { routes.lifecycle(repo, druid, 'submitted', version: 3) }
+
+        it 'makes the request with the version' do
+          lifecycle
+          expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle?version=3')
+          expect(Deprecation).to have_received(:warn).twice
+        end
       end
     end
 
-    context 'with version' do
-      subject(:lifecycle) { routes.lifecycle('dor', 'druid:gv054hp4128', 'submitted', version: 3) }
+    context 'with kwargs' do
+      before do
+        allow(Deprecation).to receive(:warn)
+      end
+
+      context 'with deprecated repo arg' do
+        context 'without version' do
+          subject(:lifecycle) { routes.lifecycle(repo: repo, druid: druid, milestone_name: 'submitted') }
+
+          it 'make the request' do
+            lifecycle
+            expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle')
+            expect(Deprecation).to have_received(:warn)
+          end
+        end
+
+        context 'with version' do
+          subject(:lifecycle) { routes.lifecycle(repo: repo, druid: druid, milestone_name: 'submitted', version: 3) }
 
-      it 'makes the request with the version' do
-        lifecycle
-        expect(requestor).to have_received(:request).with('dor/objects/druid:gv054hp4128/lifecycle?version=3')
+          it 'makes the request with the version' do
+            lifecycle
+            expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle?version=3')
+            expect(Deprecation).to have_received(:warn)
+          end
+        end
+      end
+
+      context 'without version' do
+        subject(:lifecycle) { routes.lifecycle(druid: druid, milestone_name: 'submitted') }
+
+        it 'make the request' do
+          lifecycle
+          expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle')
+          expect(Deprecation).not_to have_received(:warn)
+        end
+      end
+
+      context 'with version' do
+        subject(:lifecycle) { routes.lifecycle(druid: druid, milestone_name: 'submitted', version: 3) }
+
+        it 'makes the request with the version' do
+          lifecycle
+          expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle?version=3')
+          expect(Deprecation).not_to have_received(:warn)
+        end
       end
     end
   end
 
   describe '#active_lifecycle' do
-    context 'without version' do
-      subject(:active_lifecycle) { routes.active_lifecycle('dor', 'druid:gv054hp4128', 'submitted') }
+    context 'with positional arguments' do
+      before do
+        allow(Deprecation).to receive(:warn)
+      end
 
-      it 'make the request' do
-        active_lifecycle
-        expect(requestor).to have_received(:request).with('dor/objects/druid:gv054hp4128/lifecycle?active-only=true')
+      context 'without version' do
+        subject(:active_lifecycle) { routes.active_lifecycle(repo, druid, 'submitted') }
+
+        it 'make the request' do
+          active_lifecycle
+          expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle?active-only=true')
+          expect(Deprecation).to have_received(:warn).twice
+        end
+      end
+
+      context 'with version' do
+        subject(:active_lifecycle) { routes.active_lifecycle(repo, druid, 'submitted', version: 3) }
+
+        it 'makes the request with the version' do
+          active_lifecycle
+          expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle?version=3&active-only=true')
+          expect(Deprecation).to have_received(:warn).twice
+        end
       end
     end
 
-    context 'with version' do
-      subject(:active_lifecycle) { routes.active_lifecycle('dor', 'druid:gv054hp4128', 'submitted', version: 3) }
+    context 'with kwargs' do
+      before do
+        allow(Deprecation).to receive(:warn)
+      end
+
+      context 'with deprecated repo arg' do
+        context 'without version' do
+          subject(:active_lifecycle) { routes.active_lifecycle(repo: repo, druid: druid, milestone_name: 'submitted') }
+
+          it 'make the request' do
+            active_lifecycle
+            expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle?active-only=true')
+            expect(Deprecation).to have_received(:warn)
+          end
+        end
+
+        context 'with version' do
+          subject(:active_lifecycle) { routes.active_lifecycle(repo: repo, druid: druid, milestone_name: 'submitted', version: 3) }
+
+          it 'makes the request with the version' do
+            active_lifecycle
+            expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle?version=3&active-only=true')
+            expect(Deprecation).to have_received(:warn)
+          end
+        end
+      end
+
+      context 'without version' do
+        subject(:active_lifecycle) { routes.active_lifecycle(druid: druid, milestone_name: 'submitted') }
+
+        it 'make the request' do
+          active_lifecycle
+          expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle?active-only=true')
+          expect(Deprecation).not_to have_received(:warn)
+        end
+      end
+
+      context 'with version' do
+        subject(:active_lifecycle) { routes.active_lifecycle(druid: druid, milestone_name: 'submitted', version: 3) }
 
-      it 'makes the request with the version' do
-        active_lifecycle
-        expect(requestor).to have_received(:request).with('dor/objects/druid:gv054hp4128/lifecycle?version=3&active-only=true')
+        it 'makes the request with the version' do
+          active_lifecycle
+          expect(requestor).to have_received(:request).with('objects/druid:gv054hp4128/lifecycle?version=3&active-only=true')
+          expect(Deprecation).not_to have_received(:warn)
+        end
       end
     end
   end

data/spec/workflow/client_spec.rb

@@ -44,7 +44,6 @@ RSpec.describe Dor::Workflow::Client do
   let(:mock_logger) { double('Logger', info: true, debug: true, warn: true) }
 
   before do
-    @repo  = 'dor'
     @druid = 'druid:123'
   end
 
@@ -84,17 +83,17 @@ RSpec.describe Dor::Workflow::Client do
     end
 
     it 'requests the workflow by name and return the URL to the workflow' do
-      client.create_workflow(@repo, @druid, 'etdSubmitWF', wf_xml)
+      client.create_workflow(nil, @druid, 'etdSubmitWF', wf_xml)
       expect(Deprecation).to have_received(:warn).twice
     end
 
     it 'raises on an unexpected Exception' do
-      expect { client.create_workflow(@repo, @druid, 'raiseException', wf_xml) }.to raise_error(Exception, 'broken')
+      expect { client.create_workflow(nil, @druid, 'raiseException', wf_xml) }.to raise_error(Exception, 'broken')
       expect(Deprecation).to have_received(:warn).twice
     end
 
     it 'sets the lane_id param if provided in options hash' do
-      client.create_workflow(@repo, @druid, 'laneIdWF', wf_xml, lane_id: 'foo_lane')
+      client.create_workflow(nil, @druid, 'laneIdWF', wf_xml, lane_id: 'foo_lane')
       expect(Deprecation).to have_received(:warn).twice
     end
   end
@@ -153,16 +152,16 @@ RSpec.describe Dor::Workflow::Client do
   describe '#update_workflow_status' do
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.put("#{@repo}/objects/#{@druid}/workflows/etdSubmitWF/registrar-approval?current-status=queued") do |_env|
+        stub.put("objects/#{@druid}/workflows/etdSubmitWF/registrar-approval?current-status=queued") do |_env|
           [201, {}, '{"next_steps":["submit-marc"]}']
         end
 
-        stub.put("#{@repo}/objects/#{@druid}/workflows/etdSubmitWF/registrar-approval") do |env|
+        stub.put("objects/#{@druid}/workflows/etdSubmitWF/registrar-approval") do |env|
           expect(env.body).to eq "<?xml version=\"1.0\"?>\n<process name=\"registrar-approval\" status=\"completed\" elapsed=\"0\" note=\"annotation\" version=\"2\" laneId=\"lane2\"/>\n"
           [201, {}, '{"next_steps":["submit-marc"]}']
         end
 
-        stub.put("#{@repo}/objects/#{@druid}/workflows/errorWF/registrar-approval") do |_env|
+        stub.put("objects/#{@druid}/workflows/errorWF/registrar-approval") do |_env|
           [400, {}, '']
         end
       end
@@ -172,21 +171,21 @@ RSpec.describe Dor::Workflow::Client do
     end
 
     it 'should update workflow status and return true if successful' do
-      expect(client.update_workflow_status(@repo, @druid, 'etdSubmitWF', 'registrar-approval', 'completed', version: 2, note: 'annotation', lane_id: 'lane2')).to be_kind_of Dor::Workflow::Response::Update
+      expect(client.update_workflow_status(nil, @druid, 'etdSubmitWF', 'registrar-approval', 'completed', version: 2, note: 'annotation', lane_id: 'lane2')).to be_kind_of Dor::Workflow::Response::Update
     end
 
     it 'should return false if the PUT to the DOR workflow service throws an exception' do
-      expect { client.update_workflow_status(@repo, @druid, 'errorWF', 'registrar-approval', 'completed') }.to raise_error(Dor::WorkflowException, /status 400/)
+      expect { client.update_workflow_status(nil, @druid, 'errorWF', 'registrar-approval', 'completed') }.to raise_error(Dor::WorkflowException, /status 400/)
     end
 
     it 'performs a conditional update when current-status is passed as a parameter' do
-      expect(mock_http_connection).to receive(:put).with("#{@repo}/objects/#{@druid}/workflows/etdSubmitWF/registrar-approval?current-status=queued").and_call_original
+      expect(mock_http_connection).to receive(:put).with("/objects/#{@druid}/workflows/etdSubmitWF/registrar-approval?current-status=queued").and_call_original
 
-      expect(client.update_workflow_status(@repo, @druid, 'etdSubmitWF', 'registrar-approval', 'completed', version: 2, note: 'annotation', lane_id: 'lane1', current_status: 'queued')).to be_kind_of Dor::Workflow::Response::Update
+      expect(client.update_workflow_status(nil, @druid, 'etdSubmitWF', 'registrar-approval', 'completed', version: 2, note: 'annotation', lane_id: 'lane1', current_status: 'queued')).to be_kind_of Dor::Workflow::Response::Update
     end
 
     it 'should throw exception if invalid status provided' do
-      expect { client.update_workflow_status(@repo, @druid, 'accessionWF', 'publish', 'NOT_VALID_STATUS') }.to raise_error(ArgumentError)
+      expect { client.update_workflow_status(nil, @druid, 'accessionWF', 'publish', 'NOT_VALID_STATUS') }.to raise_error(ArgumentError)
     end
   end
 
@@ -209,10 +208,10 @@ RSpec.describe Dor::Workflow::Client do
     end
 
     it 'should update workflow status to error and return true if successful' do
-      client.update_workflow_error_status(@repo, @druid, 'etdSubmitWF', 'reader-approval', 'Some exception', error_text: 'The optional stacktrace')
+      client.update_workflow_error_status(nil, @druid, 'etdSubmitWF', 'reader-approval', 'Some exception', error_text: 'The optional stacktrace')
     end
     it 'should return false if the PUT to the DOR workflow service throws an exception' do
-      expect { client.update_workflow_error_status(@repo, @druid, 'errorWF', 'reader-approval', 'completed') }.to raise_error(Dor::WorkflowException, /status 400/)
+      expect { client.update_workflow_error_status(nil, @druid, 'errorWF', 'reader-approval', 'completed') }.to raise_error(Dor::WorkflowException, /status 400/)
     end
   end
 
@@ -255,7 +254,7 @@ RSpec.describe Dor::Workflow::Client do
   end
 
   describe '#workflow_status' do
-    let(:repo) { @repo }
+    let(:repo) { nil }
     let(:druid) { @druid }
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
@@ -401,6 +400,7 @@ RSpec.describe Dor::Workflow::Client do
     context 'with keyword args' do
       subject(:workflow_xml) { client.workflow_xml(druid: 'druid:123', workflow: workflow) }
 
+      # TODO: Remove this `context` block altogether when repos are wiped out for good
       context 'when a repo is provided' do
         subject(:workflow_xml) { client.workflow_xml(repo: 'dor', druid: 'druid:123', workflow: workflow) }
 
@@ -488,7 +488,7 @@ RSpec.describe Dor::Workflow::Client do
   describe '#lifecycle' do
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.get('dor/objects/druid:123/lifecycle') do |_env|
+        stub.get('objects/druid:123/lifecycle') do |_env|
           [200, {}, <<-EOXML]
             <lifecycle objectId="druid:ct011cv6501">
                 <milestone date="2010-04-27T11:34:17-0700">registered</milestone>
@@ -498,7 +498,7 @@ RSpec.describe Dor::Workflow::Client do
           EOXML
         end
 
-        stub.get('dor/objects/druid:abc/lifecycle') do |_env|
+        stub.get('objects/druid:abc/lifecycle') do |_env|
           [200, {}, <<-EOXML]
             <lifecycle />
           EOXML
@@ -507,18 +507,18 @@ RSpec.describe Dor::Workflow::Client do
     end
 
     it 'returns a Time object reprenting when the milestone was reached' do
-      expect(client.lifecycle('dor', 'druid:123', 'released').beginning_of_day).to eq(Time.parse('2010-06-15T16:08:58-0700').beginning_of_day)
+      expect(client.lifecycle(druid: 'druid:123', milestone_name: 'released').beginning_of_day).to eq(Time.parse('2010-06-15T16:08:58-0700').beginning_of_day)
     end
 
     it "returns nil if the milestone hasn't been reached yet" do
-      expect(client.lifecycle('dor', 'druid:abc', 'inprocess')).to be_nil
+      expect(client.lifecycle(druid: 'druid:abc', milestone_name: 'inprocess')).to be_nil
     end
   end
 
   describe '#active_lifecycle' do
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.get("dor/objects/#{@druid}/lifecycle") do |_env|
+        stub.get("objects/#{@druid}/lifecycle") do |_env|
           [200, {}, <<-EOXML]
             <lifecycle objectId="#{@druid}">
                 <milestone date="2010-04-27T11:34:17-0700">registered</milestone>
@@ -528,7 +528,7 @@ RSpec.describe Dor::Workflow::Client do
           EOXML
         end
 
-        stub.get("dor/objects/#{@druid}/lifecycle") do |_env|
+        stub.get("objects/#{@druid}/lifecycle") do |_env|
           [200, {}, <<-EOXML]
             <lifecycle />
           EOXML
@@ -537,17 +537,16 @@ RSpec.describe Dor::Workflow::Client do
     end
 
     it 'parses out the active lifecycle' do
-      expect(client.active_lifecycle('dor', @druid, 'released').beginning_of_day).to eq(Time.parse('2010-06-15T16:08:58-0700').beginning_of_day)
+      expect(client.active_lifecycle(druid: @druid, milestone_name: 'released').beginning_of_day).to eq(Time.parse('2010-06-15T16:08:58-0700').beginning_of_day)
     end
 
     it 'handles missing lifecycle' do
-      expect(client.active_lifecycle('dor', @druid, 'NOT_FOUND')).to be_nil
+      expect(client.active_lifecycle(druid: @druid, milestone_name: 'NOT_FOUND')).to be_nil
     end
   end
 
   context '#objects_for_workstep' do
     before(:all) do
-      @repository = 'dor'
       @workflow   = 'googleScannedBookWF'
       @completed  = 'google-download'
       @waiting    = 'process-content'
@@ -555,7 +554,7 @@ RSpec.describe Dor::Workflow::Client do
 
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.get("workflow_queue?waiting=#{@repository}:#{@workflow}:#{@waiting}&completed=#{@repository}:#{@workflow}:#{@completed}&lane-id=default") do |_env|
+        stub.get("workflow_queue?waiting=#{@workflow}:#{@waiting}&completed=#{@workflow}:#{@completed}&lane-id=default") do |_env|
           [200, {}, '<objects count="1"><object id="druid:ab123de4567"/><object id="druid:ab123de9012"/></objects>']
         end
       end
@@ -563,7 +562,7 @@ RSpec.describe Dor::Workflow::Client do
 
     describe 'a query with one step completed and one waiting' do
       it 'creates the URI string with only the one completed step' do
-        expect(client.objects_for_workstep(@completed, @waiting, 'default', default_repository: @repository, default_workflow: @workflow)).to eq(['druid:ab123de4567', 'druid:ab123de9012'])
+        expect(client.objects_for_workstep(@completed, @waiting, 'default', default_workflow: @workflow)).to eq(['druid:ab123de4567', 'druid:ab123de9012'])
       end
     end
 
@@ -571,21 +570,21 @@ RSpec.describe Dor::Workflow::Client do
       it 'creates the URI string with the two completed steps correctly' do
         second_completed = 'google-convert'
         xml = %(<objects count="1"><object id="druid:ab123de4567"/><object id="druid:ab123de9012"/></objects>)
-        allow(mock_http_connection).to receive(:get).with("workflow_queue?waiting=#{@repository}:#{@workflow}:#{@waiting}&completed=#{@repository}:#{@workflow}:#{@completed}&completed=#{@repository}:#{@workflow}:#{second_completed}&lane-id=default").and_return(double(Faraday::Response, body: xml))
-        expect(client.objects_for_workstep([@completed, second_completed], @waiting, 'default', default_repository: @repository, default_workflow: @workflow)).to eq(['druid:ab123de4567', 'druid:ab123de9012'])
+        allow(mock_http_connection).to receive(:get).with("workflow_queue?waiting=#{@workflow}:#{@waiting}&completed=#{@workflow}:#{@completed}&completed=#{@workflow}:#{second_completed}&lane-id=default").and_return(double(Faraday::Response, body: xml))
+        expect(client.objects_for_workstep([@completed, second_completed], @waiting, 'default', default_workflow: @workflow)).to eq(['druid:ab123de4567', 'druid:ab123de9012'])
       end
     end
 
     context 'a query using qualified workflow names for completed and waiting' do
       before :each do
-        @qualified_waiting   = "#{@repository}:#{@workflow}:#{@waiting}"
-        @qualified_completed = "#{@repository}:#{@workflow}:#{@completed}"
+        @qualified_waiting   = "#{@workflow}:#{@waiting}"
+        @qualified_completed = "#{@workflow}:#{@completed}"
       end
 
       RSpec.shared_examples 'lane-aware' do
         it 'creates the URI string with the two completed steps across repositories correctly' do
-          qualified_completed2 = 'sdr:sdrIngestWF:complete-deposit'
-          qualified_completed3 = 'sdr:sdrIngestWF:ingest-transfer'
+          qualified_completed2 = 'sdrIngestWF:complete-deposit'
+          qualified_completed3 = 'sdrIngestWF:ingest-transfer'
           xml = %(<objects count="2"><object id="druid:ab123de4567"/><object id="druid:ab123de9012"/></objects>)
           allow(mock_http_connection).to receive(:get).with("workflow_queue?waiting=#{@qualified_waiting}&completed=#{@qualified_completed}&completed=#{qualified_completed2}&completed=#{qualified_completed3}&lane-id=#{laneid}").and_return(double(Faraday::Response, body: xml))
           args = [[@qualified_completed, qualified_completed2, qualified_completed3], @qualified_waiting]
@@ -627,7 +626,6 @@ RSpec.describe Dor::Workflow::Client do
 
   context 'get empty workflow queue' do
     before(:all) do
-      @repository = 'dor'
       @workflow   = 'googleScannedBookWF'
       @completed  = 'google-download'
       @waiting    = 'process-content'
@@ -635,27 +633,26 @@ RSpec.describe Dor::Workflow::Client do
 
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.get("workflow_queue?waiting=#{@repository}:#{@workflow}:#{@waiting}&completed=#{@repository}:#{@workflow}:#{@completed}&lane-id=default") do |_env|
+        stub.get("workflow_queue?waiting=#{@workflow}:#{@waiting}&completed=#{@workflow}:#{@completed}&lane-id=default") do |_env|
           [200, {}, '<objects count="0"/>']
         end
       end
     end
 
     it 'returns an empty list if it encounters an empty workflow queue' do
-      expect(client.objects_for_workstep(@completed, @waiting, 'default', default_repository: @repository, default_workflow: @workflow)).to eq([])
+      expect(client.objects_for_workstep(@completed, @waiting, 'default', default_workflow: @workflow)).to eq([])
     end
   end
 
   context 'get errored workflow steps' do
     before(:all) do
-      @repository = 'dor'
       @workflow   = 'accessionWF'
       @step       = 'publish'
     end
 
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.get("/workflow_queue?error=#{@step}&repository=#{@repository}&workflow=#{@workflow}") do |_env|
+        stub.get("/workflow_queue?error=#{@step}&workflow=#{@workflow}") do |_env|
           [200, {}, <<-EOXML]
             <objects count="1">
                <object id="druid:ab123cd4567" errorMessage="This is an error message"/>
@@ -667,27 +664,26 @@ RSpec.describe Dor::Workflow::Client do
 
     describe 'errored_objects_for_workstep' do
       it 'returns error messages for errored objects' do
-        expect(client.errored_objects_for_workstep(@workflow, @step, @repository)).to eq('druid:ab123cd4567' => 'This is an error message')
+        expect(client.errored_objects_for_workstep(@workflow, @step)).to eq('druid:ab123cd4567' => 'This is an error message')
       end
     end
 
     describe 'count_errored_for_workstep' do
       it 'counts how many steps are errored out' do
-        expect(client.count_errored_for_workstep(@workflow, @step, @repository)).to eq(1)
+        expect(client.count_errored_for_workstep(@workflow, @step)).to eq(1)
       end
     end
   end
 
   describe '#count_queued_for_workstep' do
     before(:all) do
-      @repository = 'dor'
       @workflow   = 'accessionWF'
       @step       = 'publish'
     end
 
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.get("/workflow_queue?queued=#{@step}&repository=#{@repository}&workflow=#{@workflow}") do |_env|
+        stub.get("/workflow_queue?queued=#{@step}&workflow=#{@workflow}") do |_env|
           [200, {}, <<-EOXML]
             <objects count="1">
                <object id="druid:ab123cd4567"/>
@@ -698,7 +694,7 @@ RSpec.describe Dor::Workflow::Client do
     end
 
     it 'counts how many steps are errored out' do
-      expect(client.count_queued_for_workstep(@workflow, @step, @repository)).to eq(1)
+      expect(client.count_queued_for_workstep(@workflow, @step)).to eq(1)
     end
   end
 
@@ -707,12 +703,11 @@ RSpec.describe Dor::Workflow::Client do
       @workflow   = 'sdrIngestWF'
       @step       = 'start-ingest'
       @type       = 'waiting'
-      @repository = 'sdr'
     end
 
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.get("/workflow_queue?repository=#{@repository}&workflow=#{@workflow}&#{@type}=#{@step}") do |_env|
+        stub.get("/workflow_queue?workflow=#{@workflow}&#{@type}=#{@step}") do |_env|
           [200, {}, <<-EOXML]
             <objects count="1">
               <object id="druid:oo000ra0001" url="null/fedora/objects/druid:oo000ra0001"/>
@@ -723,12 +718,12 @@ RSpec.describe Dor::Workflow::Client do
     end
 
     it 'counts how many objects are at the type of step' do
-      expect(client.count_objects_in_step(@workflow, @step, @type, @repository)).to eq(1)
+      expect(client.count_objects_in_step(@workflow, @step, @type)).to eq(1)
     end
   end
 
   describe '#delete_workflow' do
-    let(:url) { "#{@repo}/objects/#{@druid}/workflows/accessionWF" }
+    let(:url) { "/objects/#{@druid}/workflows/accessionWF" }
 
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
@@ -738,14 +733,18 @@ RSpec.describe Dor::Workflow::Client do
 
     it 'sends a delete request to the workflow service' do
       expect(mock_http_connection).to receive(:delete).with(url).and_call_original
-      client.delete_workflow(@repo, @druid, 'accessionWF')
+      client.delete_workflow(nil, @druid, 'accessionWF')
     end
   end
 
   describe '.stale_queued_workflows' do
+    before do
+      allow(Deprecation).to receive(:warn)
+    end
+
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.get('workflow_queue/all_queued?repository=dor&hours-ago=24&limit=100') do |_env|
+        stub.get('workflow_queue/all_queued?hours-ago=24&limit=100') do |_env|
           [200, {}, <<-XML]
           <workflows>
               <workflow laneId="lane1" note="annotation" lifecycle="in-process" errorText="stacktrace" errorMessage="NullPointerException" elapsed="1.173" repository="dor" attempts="0" datetime="2008-11-15T13:30:00-0800" status="waiting" process="content-metadata" name="accessionWF" druid="dr:123"/>
@@ -758,6 +757,7 @@ RSpec.describe Dor::Workflow::Client do
 
     it 'returns an Array of Hashes containing each workflow step' do
       ah = client.stale_queued_workflows 'dor', hours_ago: 24, limit: 100
+      expect(Deprecation).to have_received(:warn).once
       expected = [
         { workflow: 'accessionWF', step: 'content-metadata', druid: 'dr:123', lane_id: 'lane1' },
         { workflow: 'assemblyWF',  step: 'jp2-create',       druid: 'dr:456', lane_id: 'lane2' }
@@ -767,9 +767,13 @@ RSpec.describe Dor::Workflow::Client do
   end
 
   describe '.count_stale_queued_workflows' do
+    before do
+      allow(Deprecation).to receive(:warn)
+    end
+
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.get('workflow_queue/all_queued?repository=dor&hours-ago=48&count-only=true') do |_env|
+        stub.get('workflow_queue/all_queued?hours-ago=48&count-only=true') do |_env|
           [200, {}, '<objects count="10"/>']
         end
       end
@@ -777,10 +781,15 @@ RSpec.describe Dor::Workflow::Client do
 
     it 'returns the number of queued workflow steps' do
       expect(client.count_stale_queued_workflows('dor', hours_ago: 48)).to eq(10)
+      expect(Deprecation).to have_received(:warn).once
     end
   end
 
   describe '.lane_ids' do
+    before do
+      allow(Deprecation).to receive(:warn)
+    end
+
     let(:stubs) do
       Faraday::Adapter::Test::Stubs.new do |stub|
         stub.get('workflow_queue/lane_ids?lane_ids?step=dor:accessionWF:shelve') do |_env|
@@ -796,6 +805,7 @@ RSpec.describe Dor::Workflow::Client do
 
     it 'returns the lane ids for a given workflow step' do
       expect(client.lane_ids('dor', 'accessionWF', 'shelve')).to eq(%w[lane1 lane2])
+      expect(Deprecation).to have_received(:warn).once
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dor-workflow-client
 version: !ruby/object:Gem::Version
-  version: 3.20.1
+  version: 3.21.0
 platform: ruby
 authors:
 - Willy Mene
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-03 00:00:00.000000000 Z
+date: 2020-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -198,6 +198,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/pull_request_template.md"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -255,7 +256,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Provides convenience methods to work with the DOR Workflow Service