dor-services-client 15.16.0 → 15.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab50c5a851df383096d632a859cbac9a0afcdbbb54f95910ab31a266b044e6f4
-  data.tar.gz: 233523b1995ef21dadb3aba64708bc1b8512650c18b33a1500602340a73a0638
+  metadata.gz: 2eae21e0d4d23ae9cfb36da7241b8426ee6cb4c4091495596388303501294541
+  data.tar.gz: 95e2a5bd0bc3d6b6888ba6d7f5248e81a0f9d652453adda2306e1b084238f4b6
 SHA512:
-  metadata.gz: 81ebf90e472f4a6548df3a8282a9a95de3c4177508cab234b31cbf8c66eed9c9af9d2ccc889e6e12a743f8bb92a14d3f4ddf68d43cee24645b65e08fb46b7494
-  data.tar.gz: e5e4a931b65ecd85a4421f9df55b96a2511ba620088642462c455dcae872d9ba427d4e03f9016ad10d52936aad1efce7c32ac73187b4ed8594c02c0d064bb079
+  metadata.gz: a5894ff807874edfe03c547bab604e1e6176fc9020e5204eabf6a8da0686f919f2fe453046005b4e9087e209687add460ff949d948973ed1766b4cbed6d519e0
+  data.tar.gz: a62b6f56f78065b9f153b9aeb76f957be2104711d6a8642ed06dd18ec45899bbfcd28b353ed014a70fee79b13385795643e1cff7a17ff2dc5a39c4749f6f06c2

data/.rubocop_todo.yml

@@ -1,14 +1,14 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude`
-# on 2025-03-10 18:20:28 UTC using RuboCop version 1.73.2.
+# on 2025-07-14 17:04:55 UTC using RuboCop version 1.78.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 56
+# Offense count: 66
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
+# Configuration parameters: AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
 Layout/LineLength:
   Max: 174
@@ -18,13 +18,23 @@ Lint/UselessConstantScoping:
   Exclude:
     - 'lib/dor/services/client/object.rb'
 
+# Offense count: 5
+# Configuration parameters: EnforcedStyle, AllowedPatterns, ForbiddenIdentifiers, ForbiddenPatterns.
+# SupportedStyles: snake_case, camelCase
+# ForbiddenIdentifiers: __id__, __send__
+Naming/MethodName:
+  Exclude:
+    - 'lib/dor/services/client/members.rb'
+    - 'lib/dor/services/client/object_version.rb'
+    - 'lib/dor/services/client/user_version.rb'
+
 # Offense count: 3
 RSpec/AnyInstance:
   Exclude:
     - 'spec/dor/services/client/async_result_spec.rb'
     - 'spec/dor/services/client/object_version_spec.rb'
 
-# Offense count: 5
+# Offense count: 6
 RSpec/IdenticalEqualityAssertion:
   Exclude:
     - 'spec/dor/services/client_spec.rb'
@@ -52,14 +62,14 @@ Style/Documentation:
     - 'test/**/*'
     - 'lib/dor/services/client.rb'
 
-# Offense count: 2
+# Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
   Exclude:
     - 'lib/dor/services/client.rb'
     - 'lib/dor/services/client/object.rb'
 
-# Offense count: 1
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 Style/KeywordArgumentsMerging:
   Exclude:

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    dor-services-client (15.16.0)
+    dor-services-client (15.18.0)
       activesupport (>= 7.0.0)
-      cocina-models (~> 0.104.1)
+      cocina-models (~> 0.105.0)
       deprecation
       faraday (~> 2.0)
       faraday-retry
@@ -34,7 +34,7 @@ GEM
     benchmark (0.4.1)
     bigdecimal (3.2.2)
     byebug (12.0.0)
-    cocina-models (0.104.1)
+    cocina-models (0.105.0)
       activesupport
       deprecation
       dry-struct (~> 1.0)
@@ -103,7 +103,7 @@ GEM
     lint_roller (1.1.0)
     logger (1.7.0)
     minitest (5.25.5)
-    multi_json (1.15.0)
+    multi_json (1.16.0)
     net-http (0.6.0)
       uri
     nokogiri (1.18.8-arm64-darwin)
@@ -140,7 +140,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.4)
-    rubocop (1.77.0)
+    rubocop (1.78.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)

data/dor-services-client.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 3.0', '< 4'
 
   spec.add_dependency 'activesupport', '>= 7.0.0'
-  spec.add_dependency 'cocina-models', '~> 0.104.1'
+  spec.add_dependency 'cocina-models', '~> 0.105.0'
   spec.add_dependency 'deprecation', '>= 0'
   spec.add_dependency 'faraday', '~> 2.0'
   spec.add_dependency 'faraday-retry'

data/lib/dor/services/client/version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Services
     class Client
-      VERSION = '15.16.0'
+      VERSION = '15.18.0'
     end
   end
 end

data/lib/dor/services/response/workflow.rb

@@ -24,7 +24,12 @@ module Dor
           result ? true : false
         end
 
-        # Returns the process, for the most recent version that matches the given name:
+        def error_count
+          process_names.map { |process_name| process_for_recent_version(name: process_name) }
+                       .count { |process| process.status == 'error' }
+        end
+
+        # Returns the process for the most recent version that matches the given name:
         def process_for_recent_version(name:)
           nodes = process_nodes_for(name: name)
           node = nodes.max { |a, b| a.attr('version').to_i <=> b.attr('version').to_i }
@@ -38,12 +43,11 @@ module Dor
         # Check if all processes are skipped or complete for the provided version.
         # @param [Integer] version the version we are checking for.
         def complete_for?(version:)
-          # ng_xml.xpath("/workflow/process[@version=#{version}]/@status").map(&:value).all? { |p| %w[skipped completed].include?(p) }
           incomplete_processes_for(version: version).empty?
         end
 
         def complete?
-          complete_for?(version: version)
+          complete_for?(version: latest_version)
         end
 
         def incomplete_processes_for(version:)
@@ -53,15 +57,15 @@ module Dor
         end
 
         def incomplete_processes
-          incomplete_processes_for(version: version)
+          incomplete_processes_for(version: latest_version)
         end
 
         attr_reader :xml
 
         private
 
-        # Return the max version in this workflow document
-        def version
+        # Return the latest version in this workflow document
+        def latest_version
           ng_xml.xpath('/workflow/process/@version').map { |attr| attr.value.to_i }.max
         end
 
@@ -81,6 +85,10 @@ module Dor
           attributes = node ? node.attributes.to_h { |k, v| [k.to_sym, v.value] } : {}
           Process.new(parent: self, **attributes)
         end
+
+        def process_names(version: latest_version)
+          ng_xml.xpath("/workflow/process[@version=#{version}]").map { |process| process['name'] }
+        end
       end
     end
   end

data/lib/dor/services/response/workflows.rb

@@ -5,32 +5,26 @@ module Dor
     module Response
       # The response from asking the server about all workflows for an item
       class Workflows
+        attr_reader :xml
+
+        # @param [Nokogiri::XML] xml Nokogiri XML document showing all workflows
         def initialize(xml:)
           @xml = xml
         end
 
         def pid
-          ng_xml.at_xpath('/workflows/@objectId').text
+          xml.at_xpath('/workflows/@objectId').text
         end
 
         def workflows
-          @workflows ||= ng_xml.xpath('/workflows/workflow').map do |node|
+          @workflows ||= xml.xpath('/workflows/workflow').map do |node|
             Workflow.new(xml: node.to_xml)
           end
         end
 
-        # @return [Array<String>] returns a list of errors for any process for the current version
+        # @return [Array<String>] returns a list of errors for any process for the specified version
         def errors_for(version:)
-          ng_xml.xpath("//workflow/process[@version='#{version}' and @status='error']/@errorMessage")
-                .map(&:text)
-        end
-
-        attr_reader :xml
-
-        private
-
-        def ng_xml
-          @ng_xml ||= Nokogiri::XML(@xml)
+          xml.xpath("//workflow/process[@version='#{version}' and @status='error']/@errorMessage").map(&:text)
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dor-services-client
 version: !ruby/object:Gem::Version
-  version: 15.16.0
+  version: 15.18.0
 platform: ruby
 authors:
 - Justin Coyne
 - Michael Giarlo
 bindir: exe
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2025-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.104.1
+        version: 0.105.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.104.1
+        version: 0.105.0
 - !ruby/object:Gem::Dependency
   name: deprecation
   requirement: !ruby/object:Gem::Requirement
@@ -292,7 +292,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.6.2
 specification_version: 4
 summary: A client for dor-services-app
 test_files: []