dor-services-client 15.16.0 → 15.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab50c5a851df383096d632a859cbac9a0afcdbbb54f95910ab31a266b044e6f4
-  data.tar.gz: 233523b1995ef21dadb3aba64708bc1b8512650c18b33a1500602340a73a0638
+  metadata.gz: '08d442e83ffd620ca6ce507912bfad7ece5ce2e303c05dbfa09753828b348f17'
+  data.tar.gz: 7da84b625648e7dfaef778ece349cea18d5e25b5ebd49163e33aa223920d81ba
 SHA512:
-  metadata.gz: 81ebf90e472f4a6548df3a8282a9a95de3c4177508cab234b31cbf8c66eed9c9af9d2ccc889e6e12a743f8bb92a14d3f4ddf68d43cee24645b65e08fb46b7494
-  data.tar.gz: e5e4a931b65ecd85a4421f9df55b96a2511ba620088642462c455dcae872d9ba427d4e03f9016ad10d52936aad1efce7c32ac73187b4ed8594c02c0d064bb079
+  metadata.gz: 957c36d544c0708e407885b10f5eb2d5c82dff88a4635800d90ad1d3371563d6b63147f2674c9678d2d6049d3289046632c631d337eab04e3b6e427e4b381f53
+  data.tar.gz: ba46d21dda5de8a2a614c014fc26ad7287e6de283c5285ffbec4661090c529c3df9cb4333ba22e7ae5188b9360b2d68f5255f1d50524ce9e62019bab5a6800b1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    dor-services-client (15.16.0)
+    dor-services-client (15.17.0)
       activesupport (>= 7.0.0)
       cocina-models (~> 0.104.1)
       deprecation

data/lib/dor/services/client/version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Services
     class Client
-      VERSION = '15.16.0'
+      VERSION = '15.17.0'
     end
   end
 end

data/lib/dor/services/response/workflow.rb

@@ -24,7 +24,12 @@ module Dor
           result ? true : false
         end
 
-        # Returns the process, for the most recent version that matches the given name:
+        def error_count
+          process_names.map { |process_name| process_for_recent_version(name: process_name) }
+                       .count { |process| process.status == 'error' }
+        end
+
+        # Returns the process for the most recent version that matches the given name:
         def process_for_recent_version(name:)
           nodes = process_nodes_for(name: name)
           node = nodes.max { |a, b| a.attr('version').to_i <=> b.attr('version').to_i }
@@ -38,12 +43,11 @@ module Dor
         # Check if all processes are skipped or complete for the provided version.
         # @param [Integer] version the version we are checking for.
         def complete_for?(version:)
-          # ng_xml.xpath("/workflow/process[@version=#{version}]/@status").map(&:value).all? { |p| %w[skipped completed].include?(p) }
           incomplete_processes_for(version: version).empty?
         end
 
         def complete?
-          complete_for?(version: version)
+          complete_for?(version: latest_version)
         end
 
         def incomplete_processes_for(version:)
@@ -53,15 +57,15 @@ module Dor
         end
 
         def incomplete_processes
-          incomplete_processes_for(version: version)
+          incomplete_processes_for(version: latest_version)
         end
 
         attr_reader :xml
 
         private
 
-        # Return the max version in this workflow document
-        def version
+        # Return the latest version in this workflow document
+        def latest_version
           ng_xml.xpath('/workflow/process/@version').map { |attr| attr.value.to_i }.max
         end
 
@@ -81,6 +85,10 @@ module Dor
           attributes = node ? node.attributes.to_h { |k, v| [k.to_sym, v.value] } : {}
           Process.new(parent: self, **attributes)
         end
+
+        def process_names(version: latest_version)
+          ng_xml.xpath("/workflow/process[@version=#{version}]").map { |process| process['name'] }
+        end
       end
     end
   end

data/lib/dor/services/response/workflows.rb

@@ -5,32 +5,26 @@ module Dor
     module Response
       # The response from asking the server about all workflows for an item
       class Workflows
+        attr_reader :xml
+
+        # @param [Nokogiri::XML] xml Nokogiri XML document showing all workflows
         def initialize(xml:)
           @xml = xml
         end
 
         def pid
-          ng_xml.at_xpath('/workflows/@objectId').text
+          xml.at_xpath('/workflows/@objectId').text
         end
 
         def workflows
-          @workflows ||= ng_xml.xpath('/workflows/workflow').map do |node|
+          @workflows ||= xml.xpath('/workflows/workflow').map do |node|
             Workflow.new(xml: node.to_xml)
           end
         end
 
-        # @return [Array<String>] returns a list of errors for any process for the current version
+        # @return [Array<String>] returns a list of errors for any process for the specified version
         def errors_for(version:)
-          ng_xml.xpath("//workflow/process[@version='#{version}' and @status='error']/@errorMessage")
-                .map(&:text)
-        end
-
-        attr_reader :xml
-
-        private
-
-        def ng_xml
-          @ng_xml ||= Nokogiri::XML(@xml)
+          xml.xpath("//workflow/process[@version='#{version}' and @status='error']/@errorMessage").map(&:text)
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dor-services-client
 version: !ruby/object:Gem::Version
-  version: 15.16.0
+  version: 15.17.0
 platform: ruby
 authors:
 - Justin Coyne