dor-services-client 12.13.1 → 12.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b8de200f6193d8e744f8cab4930cad5159b4281fbc3fd4429633b9c948c5d5d
-  data.tar.gz: 73358f87f3c44e26c139af90707c1f85717eafcb5dd67701f1895d7c4e6682ba
+  metadata.gz: 4fe87932d48e8a6840dff66151357c8fc8e9c86c0e0265a55bd023f941d070ac
+  data.tar.gz: e9a45ea67d9e74b2078330905fdb880af3520284a45745a71580a312a49d576b
 SHA512:
-  metadata.gz: 66d744fe7122da02402ae97240fb4cfdba9a1622537c8266f558040ff01eefe78db76394ee7556787f5ca8e6e20a6719d2fed37b68edcd745fe0970c0514b3fa
-  data.tar.gz: 46de253f11dcb355a66d25e0d1bcda06ecc66d7f10870da3e4e8b123ddb57cd03c74af76ea46f381088d009aec1e864771816a249a7fcde14acfe3186ac23a89
+  metadata.gz: bcda85a815b2f7934b925c9e6e90f5afc41f0d14e9c8186112cc2543d67c6505f616d361d05e91ac4639e2e2ce5437e79c09a5677ebaa94376caa08d750ad1a3
+  data.tar.gz: b771139f84a28dfe35094f9ad4105ec2048243d8369eb60935083d6618a31c1f05d76df93dd7f0748f56bba2323a202e092f7dfe7b4ae60e76b0cadbd51b03ae

data/.circleci/config.yml

@@ -1,6 +1,6 @@
 version: 2.1
 orbs:
-  ruby-rails: sul-dlss/ruby-rails@3.2.0
+  ruby-rails: sul-dlss/ruby-rails@4.0.0
 workflows:
   build:
     jobs:

data/.rubocop.yml

@@ -133,7 +133,7 @@ RSpec/IdenticalEqualityAssertion: # new in 2.4
   Enabled: true
 RSpec/SubjectDeclaration: # new in 2.5
   Enabled: true
-RSpec/FactoryBot/SyntaxMethods: # new in 2.7
+FactoryBot/SyntaxMethods: # new in 2.7
   Enabled: true
 RSpec/Rails/AvoidSetupHook: # new in 2.4
   Enabled: true
@@ -177,7 +177,7 @@ Style/MapCompactWithConditionalBlock: # new in 1.30
   Enabled: true
 RSpec/ChangeByZero: # new in 2.11.0
   Enabled: true
-RSpec/Capybara/SpecificMatcher: # new in 2.12
+Capybara/SpecificMatcher: # new in 2.12
   Enabled: false
 RSpec/Rails/HaveHttpStatus: # new in 2.12
   Enabled: false
@@ -186,5 +186,94 @@ RSpec/ClassCheck: # new in 2.13
   Enabled: true
 RSpec/NoExpectationExample: # new in 2.13
   Enabled: true
-RSpec/Capybara/SpecificFinders: # new in 2.13
+Capybara/SpecificFinders: # new in 2.13
+  Enabled: true
+
+Gemspec/DevelopmentDependencies: # new in 1.44
+  Enabled: false
+Lint/DuplicateMagicComment: # new in 1.37
+  Enabled: true
+Lint/DuplicateMatchPattern: # new in 1.50
+  Enabled: true
+Lint/UselessRescue: # new in 1.43
+  Enabled: true
+Metrics/CollectionLiteralLength: # new in 1.47
+  Enabled: true
+Style/ArrayIntersect: # new in 1.40
+  Enabled: true
+Style/ComparableClamp: # new in 1.44
+  Enabled: true
+Style/ConcatArrayLiterals: # new in 1.41
+  Enabled: true
+Style/DataInheritance: # new in 1.49
+  Enabled: true
+Style/DirEmpty: # new in 1.48
+  Enabled: true
+Style/ExactRegexpMatch: # new in 1.51
+  Enabled: true
+Style/FileEmpty: # new in 1.48
+  Enabled: true
+Style/MapToSet: # new in 1.42
+  Enabled: true
+Style/MinMaxComparison: # new in 1.42
+  Enabled: true
+Style/OperatorMethodCall: # new in 1.37
+  Enabled: true
+Style/RedundantArrayConstructor: # new in 1.52
+  Enabled: true
+Style/RedundantConstantBase: # new in 1.40
+  Enabled: true
+Style/RedundantDoubleSplatHashBraces: # new in 1.41
+  Enabled: true
+Style/RedundantEach: # new in 1.38
+  Enabled: true
+Style/RedundantFilterChain: # new in 1.52
+  Enabled: true
+Style/RedundantHeredocDelimiterQuotes: # new in 1.45
+  Enabled: true
+Style/RedundantLineContinuation: # new in 1.49
+  Enabled: true
+Style/RedundantRegexpConstructor: # new in 1.52
+  Enabled: true
+Style/RedundantStringEscape: # new in 1.37
+  Enabled: true
+Capybara/MatchStyle: # new in 2.17
+  Enabled: true
+Capybara/NegationMatcher: # new in 2.14
+  Enabled: true
+Capybara/SpecificActions: # new in 2.14
+  Enabled: true
+FactoryBot/AssociationStyle: # new in 2.23
+  Enabled: true
+FactoryBot/ConsistentParenthesesStyle: # new in 2.14
+  Enabled: true
+FactoryBot/FactoryAssociationWithStrategy: # new in 2.23
+  Enabled: true
+FactoryBot/FactoryNameStyle: # new in 2.16
+  Enabled: true
+FactoryBot/RedundantFactoryOption: # new in 2.23
+  Enabled: true
+RSpec/BeEmpty: # new in 2.20
+  Enabled: true
+RSpec/ContainExactly: # new in 2.19
+  Enabled: true
+RSpec/DuplicatedMetadata: # new in 2.16
+  Enabled: true
+RSpec/IndexedLet: # new in 2.20
+  Enabled: true
+RSpec/MatchArray: # new in 2.19
+  Enabled: true
+RSpec/PendingWithoutReason: # new in 2.16
+  Enabled: true
+RSpec/RedundantAround: # new in 2.19
+  Enabled: true
+RSpec/SkipBlockInsideExample: # new in 2.19
+  Enabled: true
+RSpec/SortMetadata: # new in 2.14
+  Enabled: true
+RSpec/Rails/InferredSpecType: # new in 2.14
+  Enabled: true
+RSpec/Rails/MinitestAssertions: # new in 2.17
+  Enabled: true
+RSpec/Rails/TravelAround: # new in 2.19
   Enabled: true

data/.rubocop_todo.yml

@@ -1,28 +1,27 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude`
-# on 2022-01-14 01:12:44 UTC using RuboCop version 1.24.1.
+# on 2023-06-20 05:36:17 UTC using RuboCop version 1.52.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-# Configuration parameters: IgnoredMethods, CountRepeatedAttributes, Max.
+# Offense count: 1
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Exclude:
     - 'lib/dor/services/client/marcxml.rb'
 
 # Offense count: 1
-# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods.
+# Configuration parameters: CountComments, Max, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Exclude:
     - 'lib/dor/services/client/transfer.rb'
 
-# Offense count: 4
+# Offense count: 3
 RSpec/AnyInstance:
   Exclude:
     - 'spec/dor/services/client/async_result_spec.rb'
-    - 'spec/dor/services/client/metadata_spec.rb'
     - 'spec/dor/services/client/object_version_spec.rb'
 
 # Offense count: 6
@@ -31,18 +30,17 @@ RSpec/IdenticalEqualityAssertion:
     - 'spec/dor/services/client_spec.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 RSpec/MultipleSubjects:
   Exclude:
     - 'spec/dor/services/client/object_spec.rb'
 
-# Offense count: 13
-# Configuration parameters: Max.
+# Offense count: 9
+# Configuration parameters: Max, AllowedGroups.
 RSpec/NestedGroups:
   Exclude:
     - 'spec/dor/services/client/accession_spec.rb'
     - 'spec/dor/services/client/background_job_results_spec.rb'
-    - 'spec/dor/services/client/metadata_spec.rb'
     - 'spec/dor/services/client/objects_spec.rb'
     - 'spec/dor/services/client_spec.rb'
 
@@ -65,9 +63,9 @@ Style/Documentation:
     - 'test/**/*'
     - 'lib/dor/services/client.rb'
 
-# Offense count: 77
-# Cop supports --auto-correct.
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Offense count: 47
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https
 Layout/LineLength:
   Max: 164

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    dor-services-client (12.13.1)
+    dor-services-client (12.15.0)
       activesupport (>= 4.2, < 8)
-      cocina-models (~> 0.89.0)
+      cocina-models (~> 0.90.0)
       deprecation
       faraday (~> 2.0)
       faraday-retry
@@ -12,17 +12,17 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.4.2)
+    activesupport (7.0.6)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-    addressable (2.8.1)
+    addressable (2.8.4)
       public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
     attr_extras (7.1.0)
     byebug (11.1.3)
-    cocina-models (0.89.1)
+    cocina-models (0.90.0)
       activesupport
       deprecation
       dry-struct (~> 1.0)
@@ -37,7 +37,7 @@ GEM
       super_diff
       thor
       zeitwerk (~> 2.1)
-    commonmarker (0.23.8)
+    commonmarker (0.23.9)
     concurrent-ruby (1.2.2)
     crack (0.4.5)
       rexml
@@ -68,72 +68,78 @@ GEM
       activesupport (>= 3.0, < 8.0)
     equivalent-xml (0.6.0)
       nokogiri (>= 1.4.3)
-    faraday (2.7.4)
+    faraday (2.7.10)
       faraday-net_http (>= 2.0, < 3.1)
       ruby2_keywords (>= 0.0.4)
     faraday-net_http (3.0.2)
-    faraday-retry (2.1.0)
+    faraday-retry (2.2.0)
       faraday (~> 2.0)
     hashdiff (1.0.1)
-    i18n (1.12.0)
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     ice_nine (0.11.2)
     json (2.6.3)
-    jsonpath (1.1.2)
+    jsonpath (1.1.3)
       multi_json
-    minitest (5.18.0)
+    language_server-protocol (3.17.0.3)
+    minitest (5.18.1)
     multi_json (1.15.0)
-    nokogiri (1.14.2-x86_64-darwin)
+    nokogiri (1.15.3-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.14.2-x86_64-linux)
+    nokogiri (1.15.3-x86_64-linux)
       racc (~> 1.4)
     openapi3_parser (0.9.2)
       commonmarker (~> 0.17)
     openapi_parser (0.15.0)
     optimist (3.0.1)
-    parallel (1.22.1)
-    parser (3.2.1.0)
+    parallel (1.23.0)
+    parser (3.2.2.3)
       ast (~> 2.4.1)
+      racc
     patience_diff (1.2.0)
       optimist (~> 3.0)
     public_suffix (5.0.1)
-    racc (1.6.2)
+    racc (1.7.1)
     rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.7.0)
+    regexp_parser (2.8.1)
     rexml (3.2.5)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
       rspec-expectations (~> 3.12.0)
       rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.1)
+    rspec-core (3.12.2)
       rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.2)
+    rspec-expectations (3.12.3)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.3)
+    rspec-mocks (3.12.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
-    rspec-support (3.12.0)
+    rspec-support (3.12.1)
     rss (0.2.9)
       rexml
-    rubocop (1.48.0)
+    rubocop (1.54.1)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.26.0, < 2.0)
+      rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.27.0)
+    rubocop-ast (1.29.0)
       parser (>= 3.2.1.0)
-    rubocop-capybara (2.17.1)
+    rubocop-capybara (2.18.0)
       rubocop (~> 1.41)
-    rubocop-rspec (2.18.1)
+    rubocop-factory_bot (2.23.1)
+      rubocop (~> 1.33)
+    rubocop-rspec (2.22.0)
       rubocop (~> 1.33)
       rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
     simplecov (0.22.0)
@@ -142,11 +148,11 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.4)
-    super_diff (0.9.0)
+    super_diff (0.10.0)
       attr_extras (>= 6.2.4)
       diff-lcs
       patience_diff
-    thor (1.2.1)
+    thor (1.2.2)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.4.2)
@@ -154,12 +160,13 @@ GEM
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    zeitwerk (2.6.7)
+    zeitwerk (2.6.8)
 
 PLATFORMS
   x86_64-darwin-19
   x86_64-darwin-20
   x86_64-darwin-21
+  x86_64-darwin-22
   x86_64-linux
 
 DEPENDENCIES
@@ -174,4 +181,4 @@ DEPENDENCIES
   webmock
 
 BUNDLED WITH
-   2.4.6
+   2.4.13

data/README.md

@@ -114,6 +114,12 @@ object_client.preserve(lane_id: 'low')
 # Update the MARC record (used in the releaseWF)
 object_client.update_marc_record
 
+# Update the DOI metadata (used by robot)
+object_client.update_doi_metadata
+
+# Update the Orcid work (used by robot)
+object_client.update_orcid_work
+
 # Copy metadata from Symphony into descMetadata
 object_client.refresh_descriptive_metadata_from_ils
 
@@ -132,15 +138,6 @@ object_client.version.open(description: 'Changed title', significance: 'minor')
 # see dor-services-app openapi.yml for optional params
 object_client.version.close
 
-# Get the Dublin Core XML representation
-object_client.metadata.dublin_core
-
-# Get the public descriptive XML representation
-object_client.metadata.descriptive
-
-# Get the public XML representation
-object_client.metadata.public_xml
-
 # Return the Cocina metadata
 object_client.find
 

data/dor-services-client.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 3.0', '< 4'
 
   spec.add_dependency 'activesupport', '>= 4.2', '< 8'
-  spec.add_dependency 'cocina-models', '~> 0.89.0'
+  spec.add_dependency 'cocina-models', '~> 0.90.0'
   spec.add_dependency 'deprecation', '>= 0'
   spec.add_dependency 'faraday', '~> 2.0'
   spec.add_dependency 'faraday-retry'

data/lib/dor/services/client/object.rb

@@ -18,10 +18,6 @@ module Dor
           @object_identifier = object_identifier
         end
 
-        def metadata
-          @metadata ||= Metadata.new(**parent_params)
-        end
-
         def events
           @events ||= Events.new(**parent_params)
         end
@@ -110,6 +106,18 @@ module Dor
           raise_exception_based_on_response!(resp)
         end
 
+        # Update the ORCID Work
+        # @raise [NotFoundResponse] when the response is a 404 (object not found)
+        # @return [Boolean] true on success
+        def update_orcid_work
+          resp = connection.post do |req|
+            req.url "#{object_path}/update_orcid_work"
+          end
+          return true if resp.success?
+
+          raise_exception_based_on_response!(resp)
+        end
+
         # Notify the external Goobi system for a new object that was registered in DOR
         # @raise [NotFoundResponse] when the response is a 404 (object not found)
         # @raise [UnexpectedResponse] when the response is not successful.

data/lib/dor/services/client/version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Services
     class Client
-      VERSION = '12.13.1'
+      VERSION = '12.15.0'
     end
   end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: dor-services-client
 version: !ruby/object:Gem::Version
-  version: 12.13.1
+  version: 12.15.0
 platform: ruby
 authors:
 - Justin Coyne
 - Michael Giarlo
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-03-07 00:00:00.000000000 Z
+date: 2023-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -37,14 +37,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.89.0
+        version: 0.90.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.89.0
+        version: 0.90.0
 - !ruby/object:Gem::Dependency
   name: deprecation
   requirement: !ruby/object:Gem::Requirement
@@ -213,7 +213,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - jcoyne@justincoyne.com
 - leftwing@alumni.rutgers.edu
@@ -247,7 +247,6 @@ files:
 - lib/dor/services/client/events.rb
 - lib/dor/services/client/marcxml.rb
 - lib/dor/services/client/members.rb
-- lib/dor/services/client/metadata.rb
 - lib/dor/services/client/mutate.rb
 - lib/dor/services/client/object.rb
 - lib/dor/services/client/object_version.rb
@@ -262,7 +261,7 @@ homepage: https://github.com/sul-dlss/dor-services-client
 licenses: []
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -280,8 +279,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: A client for dor-services-app
 test_files: []

data/lib/dor/services/client/metadata.rb

@@ -1,74 +0,0 @@
-# frozen_string_literal: true
-
-require 'active_support/json' # required for serializing time as iso8601
-
-module Dor
-  module Services
-    class Client
-      # API calls that are about retrieving metadata
-      class Metadata < VersionedService
-        # @param object_identifier [String] the pid for the object
-        def initialize(connection:, version:, object_identifier:)
-          super(connection: connection, version: version)
-          @object_identifier = object_identifier
-        end
-
-        # @return [String, NilClass] The Dublin Core XML representation of the object or nil if response is 404
-        # @raise [UnexpectedResponse] on an unsuccessful response from the server
-        def dublin_core
-          resp = connection.get do |req|
-            req.url "#{base_path}/dublin_core"
-          end
-          return resp.body if resp.success?
-          return if resp.status == 404
-
-          raise_exception_based_on_response!(resp, object_identifier)
-        end
-
-        # @return [String, NilClass] The public descriptive metadata XML representation of the object or nil if response is 404
-        # @raise [UnexpectedResponse] on an unsuccessful response from the server
-        def descriptive
-          resp = connection.get do |req|
-            req.url "#{base_path}/descriptive"
-          end
-          return resp.body if resp.success?
-          return if resp.status == 404
-
-          raise_exception_based_on_response!(resp, object_identifier)
-        end
-
-        # @return [String, NilClass] The public XML representation of the object or nil if response is 404
-        # @raise [UnexpectedResponse] on an unsuccessful response from the server
-        def public_xml
-          resp = connection.get do |req|
-            req.url "#{base_path}/public_xml"
-          end
-          return resp.body if resp.success?
-          return if resp.status == 404
-
-          raise_exception_based_on_response!(resp, object_identifier)
-        end
-
-        # @return [String, NilClass] the dor object's source MODS XML or nil if response is 404
-        # @raise [UnexpectedResponse] on an unsuccessful response from the server
-        def mods
-          resp = connection.get do |req|
-            req.url "#{base_path}/mods"
-          end
-          return resp.body if resp.success?
-          return if resp.status == 404
-
-          raise_exception_based_on_response!(resp, object_identifier)
-        end
-
-        private
-
-        attr_reader :object_identifier
-
-        def base_path
-          "#{api_version}/objects/#{object_identifier}/metadata"
-        end
-      end
-    end
-  end
-end