dop_common 0.13.0 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3101843e67bfd39402248c6690b277251588340a
-  data.tar.gz: 9c633c5f114fc5488f701c99a1fdbfd209476ef9
+  metadata.gz: c15d0fe20ed0740ebe9d3b1debfe09ef0945c2e6
+  data.tar.gz: ccc70b223bfa575dd4368cf27a3c7baaa0c07d89
 SHA512:
-  metadata.gz: 67b40c4e3dbb0b59325d9af71adb5ae7fd52fcc68dc114fae952954e3ed7764f3a047d0f582cb6d6118f918b5c28bb8979b37ceb820aaeb19cd32a2ec6ca8401
-  data.tar.gz: c56ea64374f39925c35e0fbe4c78acba7c54e7f7a6a53aa473ae5f363213392116c02fd46acd2922015670ae1eb74ba589048383570a8d5b2f6c830a0710cd4d
+  metadata.gz: 7c4c0719e3f0860ceba109103b458d8199d5bd703d730b6b2ab190687e99bafeca9782c2a1e39a7bc6e24135bcd81df7ea5160706f0e0aebabaf04d3b105a939
+  data.tar.gz: c2cf097514d33f5fc44726616487cf61b9d74c1fe527cc52485771fc411e90ed7d54f94fed99858fc314010f0fb01ff75f29127c704401a41186e288078bd197

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Change Log
 All notable changes to dop_common will be documented in this file.
 
+## [0.14.0] - 2017-04-24
+### Added
+- Add node property thin_clone for vmware
+
 ## [0.13.0] - 2017-03-28
 ### Added
 - Moved thread context logger from dopi to dop_common and reworked it so it is

data/doc/plan_format_v0.0.1.md

@@ -548,6 +548,14 @@ a property name is actually a keyword of a node hash.
      1. __*name_servers*__ - a list of valid IP addresses.
      2. __*search_domains*__ - a list of valid domains.
 
+ 17. __*thin_clone*__ - an optional, VSphere-specific boolean property that instructs the VSphere provider:
+     1. To transform all disks from a template as thin provision (sparse) if set to `true`.
+     2. To transform all disks from a template as thick provision (flat) if set to `false`.
+
+     The default (unset) leaves disks as defined in given template (no explicit transformation).
+
+     __IMPORTANT__: Do not use this property for other cloud provider types than VSphere.
+
 The example bellow shows a specification for a database backend and a web node:
 ```yaml
 nodes:

data/lib/dop_common/node.rb

@@ -66,6 +66,7 @@ module DopCommon
       log_validation_method('infrastructure_properties_valid?')
       log_validation_method('image_valid?')
       log_validation_method('full_clone_valid?')
+      log_validation_method('thin_clone_valid?')
       log_validation_method('interfaces_valid?')
       log_validation_method('flavor_valid?')
       log_validation_method('cores_valid?')
@@ -140,6 +141,11 @@ module DopCommon
     end
     alias_method :full_clone, :full_clone?
 
+    def thin_clone?
+      @thin_clone ||= thin_clone_valid? ? @hash[:thin_clone] : nil
+    end
+    alias_method :thin_clone, :thin_clone?
+
     def interfaces
       @interfaces ||= interfaces_valid? ? create_interfaces : []
     end
@@ -261,6 +267,15 @@ module DopCommon
       true
     end
 
+    def thin_clone_valid?
+      return false if @hash[:thin_clone].nil?
+      raise PlanParsingError, "Node #{@node}: The 'thin_clone' can be used only for VSphere provider" unless
+        (infrastructure.provides?(:vsphere) || infrastructure.provides?(:vmware))
+      raise PlanParsingError, "Node #{@node}: The 'thin_clone', if defined, must be true or false" unless
+        @hash.has_key?(:thin_clone) && (@hash[:thin_clone].kind_of?(TrueClass) || @hash[:thin_clone].kind_of?(FalseClass))
+      true
+    end
+
     def interfaces_valid?
       return false if @hash[:interfaces].nil?
       @hash[:interfaces].kind_of?(Hash) or

data/lib/dop_common/version.rb

@@ -1,3 +1,3 @@
 module DopCommon
-  VERSION = "0.13.0"
+  VERSION = '0.14.0'
 end

data/spec/dop_common/node_spec.rb

@@ -213,6 +213,56 @@ describe DopCommon::Node do
     end
   end
 
+  describe '#thin_clone' do
+    it 'will return nil for VSphere provider if unspecified' do
+      node = DopCommon::Node.new(
+        'dummy',
+        {'infrastructure' => 'vsphere'},
+        {:parsed_infrastructures => @infrastructures}
+      )
+      expect(node.thin_clone).to be_nil
+    end
+    it 'will return a boolean value if specified properly' do
+      node = DopCommon::Node.new(
+        'dummy',
+        {'infrastructure' => 'vsphere', 'thin_clone' => true},
+        {:parsed_infrastructures => @infrastructures}
+      )
+      expect(node.thin_clone).to be true
+      node = DopCommon::Node.new(
+        'dummy',
+        {'infrastructure' => 'vsphere', 'thin_clone' => false},
+        {:parsed_infrastructures => @infrastructures}
+      )
+      expect(node.thin_clone).to be false
+    end
+    it 'will raise an error if "thin_clone" is of invalid type' do
+      node = DopCommon::Node.new(
+        'dummy',
+        {'infrastructure' => 'vsphere', 'thin_clone' => :invalid},
+        {:parsed_infrastructures => @infrastructures}
+      )
+      expect{node.thin_clone}.to raise_error DopCommon::PlanParsingError
+    end
+
+    it 'will return nil in case of invalid provider type' do
+      node = DopCommon::Node.new(
+        'dummy',
+        {'infrastructure' => 'rhev'},
+        {:parsed_infrastructures => @infrastructures}
+      )
+      expect(node.thin_clone).to be_nil
+    end
+    it 'will raise an error if "thin_clone" specified in case of invalid provider type' do
+      node = DopCommon::Node.new(
+        'dummy',
+        {'infrastructure' => 'rhev', 'thin_clone' => false},
+        {:parsed_infrastructures => @infrastructures}
+      )
+      expect{node.thin_clone}.to raise_error DopCommon::PlanParsingError
+    end
+  end
+
   describe '#interfaces' do
     it 'will return an array of interfaces if specified correctly' do
       node = DopCommon::Node.new(

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dop_common
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.14.0
 platform: ruby
 authors:
 - Andreas Zuber
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-28 00:00:00.000000000 Z
+date: 2017-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashdiff