doorkeeper 5.3.3 → 5.4.0

data/spec/controllers/tokens_controller_spec.rb

@@ -1,498 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-describe Doorkeeper::TokensController do
-  let(:client) { FactoryBot.create :application }
-  let!(:user)  { User.create!(name: "Joe", password: "sekret") }
-
-  before do
-    Doorkeeper.configure do
-      resource_owner_from_credentials do
-        User.first
-      end
-    end
-
-    allow(Doorkeeper.configuration).to receive(:grant_flows).and_return(["password"])
-  end
-
-  subject { JSON.parse(response.body) }
-
-  describe "POST #create" do
-    before do
-      post :create, params: {
-        client_id: client.uid,
-        client_secret: client.secret,
-        grant_type: "password",
-      }
-    end
-
-    it "responds after authorization" do
-      expect(response).to be_successful
-    end
-
-    it "includes access token in response" do
-      expect(subject["access_token"]).to eq(Doorkeeper::AccessToken.first.token)
-    end
-
-    it "includes token type in response" do
-      expect(subject["token_type"]).to eq("Bearer")
-    end
-
-    it "includes token expiration in response" do
-      expect(subject["expires_in"].to_i).to eq(Doorkeeper.configuration.access_token_expires_in)
-    end
-
-    it "issues the token for the current client" do
-      expect(Doorkeeper::AccessToken.first.application_id).to eq(client.id)
-    end
-
-    it "issues the token for the current resource owner" do
-      expect(Doorkeeper::AccessToken.first.resource_owner_id).to eq(user.id)
-    end
-  end
-
-  describe "POST #create with errors" do
-    before do
-      post :create, params: {
-        client_id: client.uid,
-        client_secret: "invalid",
-        grant_type: "password",
-      }
-    end
-
-    it "responds after authorization" do
-      expect(response).to be_unauthorized
-    end
-
-    it "include error in response" do
-      expect(subject["error"]).to eq("invalid_client")
-    end
-
-    it "include error_description in response" do
-      expect(subject["error_description"]).to be
-    end
-
-    it "does not include access token in response" do
-      expect(subject["access_token"]).to be_nil
-    end
-
-    it "does not include token type in response" do
-      expect(subject["token_type"]).to be_nil
-    end
-
-    it "does not include token expiration in response" do
-      expect(subject["expires_in"]).to be_nil
-    end
-
-    it "does not issue any access token" do
-      expect(Doorkeeper::AccessToken.all).to be_empty
-    end
-  end
-
-  describe "POST #create with callbacks" do
-    after do
-      client.update_attribute :redirect_uri, "urn:ietf:wg:oauth:2.0:oob"
-    end
-
-    describe "when successful" do
-      after do
-        post :create, params: {
-          client_id: client.uid,
-          client_secret: client.secret,
-          grant_type: "password",
-        }
-      end
-
-      it "should call :before_successful_authorization callback" do
-        expect(Doorkeeper.configuration)
-          .to receive_message_chain(:before_successful_authorization, :call).with(instance_of(described_class))
-      end
-
-      it "should call :after_successful_authorization callback" do
-        expect(Doorkeeper.configuration)
-          .to receive_message_chain(:after_successful_authorization, :call).with(instance_of(described_class))
-      end
-    end
-
-    describe "with errors" do
-      after do
-        post :create, params: {
-          client_id: client.uid,
-          client_secret: "invalid",
-          grant_type: "password",
-        }
-      end
-
-      it "should call :before_successful_authorization callback" do
-        expect(Doorkeeper.configuration)
-          .to receive_message_chain(:before_successful_authorization, :call).with(instance_of(described_class))
-      end
-
-      it "should not call :after_successful_authorization callback" do
-        expect(Doorkeeper.configuration).not_to receive(:after_successful_authorization)
-      end
-    end
-  end
-
-  describe "POST #create with custom error" do
-    it "returns the error response with a custom message" do
-      # I18n looks for `doorkeeper.errors.messages.custom_message` in locale files
-      custom_message = "my_message"
-      allow(I18n).to receive(:translate)
-        .with(
-          custom_message,
-          hash_including(scope: %i[doorkeeper errors messages]),
-        )
-        .and_return("Authorization custom message")
-
-      doorkeeper_error = Doorkeeper::Errors::DoorkeeperError.new(custom_message)
-
-      strategy = double(:strategy)
-      request = double(token_request: strategy)
-      allow(strategy).to receive(:authorize).and_raise(doorkeeper_error)
-      allow(controller).to receive(:server).and_return(request)
-
-      post :create
-
-      expected_response_body = {
-        "error" => custom_message,
-        "error_description" => "Authorization custom message",
-      }
-      expect(response.status).to eq 400
-      expect(response.headers["WWW-Authenticate"]).to match(/Bearer/)
-      expect(JSON.parse(response.body)).to eq expected_response_body
-    end
-  end
-
-  # http://tools.ietf.org/html/rfc7009#section-2.2
-  describe "POST #revoke" do
-    let(:client) { FactoryBot.create(:application) }
-    let(:access_token) { FactoryBot.create(:access_token, application: client) }
-
-    context "when associated app is public" do
-      let(:client) { FactoryBot.create(:application, confidential: false) }
-
-      it "returns 200" do
-        post :revoke, params: { token: access_token.token }
-
-        expect(response.status).to eq 200
-      end
-
-      it "revokes the access token" do
-        post :revoke, params: { token: access_token.token }
-
-        expect(access_token.reload).to have_attributes(revoked?: true)
-      end
-    end
-
-    context "when associated app is confidential" do
-      let(:client) { FactoryBot.create(:application, confidential: true) }
-      let(:oauth_client) { Doorkeeper::OAuth::Client.new(client) }
-
-      before(:each) do
-        allow_any_instance_of(Doorkeeper::Server).to receive(:client) { oauth_client }
-      end
-
-      it "returns 200" do
-        post :revoke, params: { token: access_token.token }
-
-        expect(response.status).to eq 200
-      end
-
-      it "revokes the access token" do
-        post :revoke, params: { token: access_token.token }
-
-        expect(access_token.reload).to have_attributes(revoked?: true)
-      end
-
-      context "when authorization fails" do
-        let(:some_other_client) { FactoryBot.create(:application, confidential: true) }
-        let(:oauth_client) { Doorkeeper::OAuth::Client.new(some_other_client) }
-
-        it "returns 403" do
-          post :revoke, params: { token: access_token.token }
-
-          expect(response.status).to eq 403
-        end
-
-        it "does not revoke the access token" do
-          post :revoke, params: { token: access_token.token }
-
-          expect(access_token.reload).to have_attributes(revoked?: false)
-        end
-      end
-    end
-  end
-
-  describe "POST #introspect" do
-    let(:client) { FactoryBot.create(:application) }
-    let(:access_token) { FactoryBot.create(:access_token, application: client) }
-    let(:token_for_introspection) { FactoryBot.create(:access_token, application: client) }
-
-    context "authorized using valid Bearer token" do
-      it "responds with full token introspection" do
-        request.headers["Authorization"] = "Bearer #{access_token.token}"
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        should_have_json "active", true
-        expect(json_response).to include("client_id", "token_type", "exp", "iat")
-      end
-    end
-
-    context "authorized using Client Credentials of the client that token is issued to" do
-      it "responds with full token introspection" do
-        request.headers["Authorization"] = basic_auth_header_for_client(client)
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        should_have_json "active", true
-        expect(json_response).to include("client_id", "token_type", "exp", "iat")
-        should_have_json "client_id", client.uid
-      end
-    end
-
-    context "configured token introspection disabled" do
-      before do
-        Doorkeeper.configure do
-          orm DOORKEEPER_ORM
-          allow_token_introspection false
-        end
-      end
-
-      it "responds with invalid_token error" do
-        request.headers["Authorization"] = "Bearer #{access_token.token}"
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        response_status_should_be 401
-
-        should_not_have_json "active"
-        should_have_json "error", "invalid_token"
-      end
-    end
-
-    context "using custom introspection response" do
-      before do
-        Doorkeeper.configure do
-          orm DOORKEEPER_ORM
-          custom_introspection_response do |_token, _context|
-            {
-              sub: "Z5O3upPC88QrAjx00dis",
-              aud: "https://protected.example.net/resource",
-            }
-          end
-        end
-      end
-
-      it "responds with full token introspection" do
-        request.headers["Authorization"] = "Bearer #{access_token.token}"
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        expect(json_response).to include("client_id", "token_type", "exp", "iat", "sub", "aud")
-        should_have_json "sub", "Z5O3upPC88QrAjx00dis"
-        should_have_json "aud", "https://protected.example.net/resource"
-      end
-    end
-
-    context "public access token" do
-      let(:token_for_introspection) { FactoryBot.create(:access_token, application: nil) }
-
-      it "responds with full token introspection" do
-        request.headers["Authorization"] = basic_auth_header_for_client(client)
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        should_have_json "active", true
-        expect(json_response).to include("client_id", "token_type", "exp", "iat")
-        should_have_json "client_id", nil
-      end
-    end
-
-    context "token was issued to a different client than is making this request" do
-      let(:different_client) { FactoryBot.create(:application) }
-
-      it "responds with only active state" do
-        request.headers["Authorization"] = basic_auth_header_for_client(different_client)
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        expect(response).to be_successful
-
-        should_have_json "active", false
-        expect(json_response).not_to include("client_id", "token_type", "exp", "iat")
-      end
-    end
-
-    context "introspection request authorized by a client and allow_token_introspection is true" do
-      let(:different_client) { FactoryBot.create(:application) }
-
-      before do
-        allow(Doorkeeper.configuration).to receive(:allow_token_introspection).and_return(proc do
-          true
-        end)
-      end
-
-      it "responds with full token introspection" do
-        request.headers["Authorization"] = basic_auth_header_for_client(different_client)
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        should_have_json "active", true
-        expect(json_response).to include("client_id", "token_type", "exp", "iat")
-        should_have_json "client_id", client.uid
-      end
-    end
-
-    context "allow_token_introspection requires authorized token with special scope" do
-      let(:access_token) { FactoryBot.create(:access_token, scopes: "introspection") }
-
-      before do
-        allow(Doorkeeper.configuration).to receive(:allow_token_introspection).and_return(proc do |_token, _client, authorized_token|
-          authorized_token.scopes.include?("introspection")
-        end)
-      end
-
-      it "responds with full token introspection if authorized token has introspection scope" do
-        request.headers["Authorization"] = "Bearer #{access_token.token}"
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        should_have_json "active", true
-        expect(json_response).to include("client_id", "token_type", "exp", "iat")
-      end
-
-      it "responds with invalid_token error if authorized token doesn't have introspection scope" do
-        access_token.update(scopes: "read write")
-
-        request.headers["Authorization"] = "Bearer #{access_token.token}"
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        response_status_should_be 401
-
-        should_not_have_json "active"
-        should_have_json "error", "invalid_token"
-      end
-    end
-
-    context "authorized using invalid Bearer token" do
-      let(:access_token) do
-        FactoryBot.create(:access_token, application: client, revoked_at: 1.day.ago)
-      end
-
-      it "responds with invalid_token error" do
-        request.headers["Authorization"] = "Bearer #{access_token.token}"
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        response_status_should_be 401
-
-        should_not_have_json "active"
-        should_have_json "error", "invalid_token"
-      end
-    end
-
-    context "authorized using the Bearer token that need to be introspected" do
-      it "responds with invalid token error" do
-        request.headers["Authorization"] = "Bearer #{access_token.token}"
-
-        post :introspect, params: { token: access_token.token }
-
-        response_status_should_be 401
-
-        should_not_have_json "active"
-        should_have_json "error", "invalid_token"
-      end
-    end
-
-    context "using invalid credentials to authorize" do
-      let(:client) { double(uid: "123123", secret: "666999") }
-      let(:access_token) { FactoryBot.create(:access_token) }
-
-      it "responds with invalid_client error" do
-        request.headers["Authorization"] = basic_auth_header_for_client(client)
-
-        post :introspect, params: { token: access_token.token }
-
-        expect(response).not_to be_successful
-        response_status_should_be 401
-
-        should_not_have_json "active"
-        should_have_json "error", "invalid_client"
-      end
-    end
-
-    context "using wrong token value" do
-      context "authorized using client credentials" do
-        it "responds with only active state" do
-          request.headers["Authorization"] = basic_auth_header_for_client(client)
-
-          post :introspect, params: { token: SecureRandom.hex(16) }
-
-          should_have_json "active", false
-          expect(json_response).not_to include("client_id", "token_type", "exp", "iat")
-        end
-      end
-
-      context "authorized using valid Bearer token" do
-        it "responds with invalid_token error" do
-          request.headers["Authorization"] = "Bearer #{access_token.token}"
-
-          post :introspect, params: { token: SecureRandom.hex(16) }
-
-          response_status_should_be 401
-
-          should_not_have_json "active"
-          should_have_json "error", "invalid_token"
-        end
-      end
-    end
-
-    context "when requested access token expired" do
-      let(:token_for_introspection) do
-        FactoryBot.create(:access_token, application: client, created_at: 1.year.ago)
-      end
-
-      it "responds with only active state" do
-        request.headers["Authorization"] = basic_auth_header_for_client(client)
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        should_have_json "active", false
-        expect(json_response).not_to include("client_id", "token_type", "exp", "iat")
-      end
-    end
-
-    context "when requested Access Token revoked" do
-      let(:token_for_introspection) do
-        FactoryBot.create(:access_token, application: client, revoked_at: 1.year.ago)
-      end
-
-      it "responds with only active state" do
-        request.headers["Authorization"] = basic_auth_header_for_client(client)
-
-        post :introspect, params: { token: token_for_introspection.token }
-
-        should_have_json "active", false
-        expect(json_response).not_to include("client_id", "token_type", "exp", "iat")
-      end
-    end
-
-    context "unauthorized (no bearer token or client credentials)" do
-      let(:token_for_introspection) { FactoryBot.create(:access_token) }
-
-      it "responds with invalid_request error" do
-        post :introspect, params: { token: token_for_introspection.token }
-
-        expect(response).not_to be_successful
-        response_status_should_be 400
-
-        should_not_have_json "active"
-        should_have_json "error", "invalid_request"
-      end
-    end
-  end
-end

data/spec/dummy/Rakefile

@@ -1,9 +0,0 @@
-#!/usr/bin/env rake
-# frozen_string_literal: true
-
-# Add your own tasks in files placed in lib/tasks ending in .rake,
-# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
-
-require File.expand_path("config/application", __dir__)
-
-Dummy::Application.load_tasks

data/spec/dummy/app/assets/config/manifest.js

@@ -1,2 +0,0 @@
-// JS and CSS bundles
-//

data/spec/dummy/app/controllers/application_controller.rb

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-
-class ApplicationController < ActionController::Base
-  protect_from_forgery with: :exception
-end

data/spec/dummy/app/controllers/custom_authorizations_controller.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-class CustomAuthorizationsController < ::ApplicationController
-  %w[index show new create edit update destroy].each do |action|
-    define_method action do
-      render nothing: true
-    end
-  end
-end

data/spec/dummy/app/controllers/full_protected_resources_controller.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-class FullProtectedResourcesController < ApplicationController
-  before_action -> { doorkeeper_authorize! :write, :admin }, only: :show
-  before_action :doorkeeper_authorize!, only: :index
-
-  def index
-    render plain: "index"
-  end
-
-  def show
-    render plain: "show"
-  end
-end

data/spec/dummy/app/controllers/home_controller.rb

@@ -1,18 +0,0 @@
-# frozen_string_literal: true
-
-class HomeController < ApplicationController
-  def index; end
-
-  def sign_in
-    session[:user_id] = if Rails.env.development?
-                          User.first || User.create!(name: "Joe", password: "sekret")
-                        else
-                          User.first
-                        end
-    redirect_to "/"
-  end
-
-  def callback
-    render plain: "ok"
-  end
-end

data/spec/dummy/app/controllers/metal_controller.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-class MetalController < ActionController::Metal
-  include AbstractController::Callbacks
-  include ActionController::Head
-  include Doorkeeper::Rails::Helpers
-
-  before_action :doorkeeper_authorize!
-
-  def index
-    self.response_body = { ok: true }.to_json
-  end
-end

data/spec/dummy/app/controllers/semi_protected_resources_controller.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-class SemiProtectedResourcesController < ApplicationController
-  before_action :doorkeeper_authorize!, only: :index
-
-  def index
-    render plain: "protected index"
-  end
-
-  def show
-    render plain: "non protected show"
-  end
-end

data/spec/dummy/app/helpers/application_helper.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-module ApplicationHelper
-  def current_user
-    @current_user ||= User.find_by_id(session[:user_id])
-  end
-end

data/spec/dummy/app/models/user.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-class User < ActiveRecord::Base
-  def self.authenticate!(name, password)
-    User.where(name: name, password: password).first
-  end
-end

data/spec/dummy/app/views/layouts/application.html.erb

@@ -1,14 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-  <title>Dummy</title>
-  <%= csrf_meta_tags %>
-</head>
-<body>
-
-<%= link_to "Sign in", '/sign_in' %>
-
-<%= yield %>
-
-</body>
-</html>

data/spec/dummy/config/application.rb

@@ -1,49 +0,0 @@
-require File.expand_path('boot', __dir__)
-
-require "rails"
-
-%w[
-  action_controller/railtie
-  action_view/railtie
-  action_cable/engine
-  sprockets/railtie
-].each do |railtie|
-  begin
-    require railtie
-  rescue LoadError => e
-    puts "Error loading '#{railtie}' (#{e.message})"
-  end
-end
-
-Bundler.require(*Rails.groups)
-
-require 'yaml'
-
-orm = if DOORKEEPER_ORM =~ /mongoid/
-        Mongoid.load!(File.join(File.dirname(File.expand_path(__FILE__)), "#{DOORKEEPER_ORM}.yml"))
-        :mongoid
-      else
-        DOORKEEPER_ORM
-      end
-require "#{orm}/railtie"
-
-module Dummy
-  class Application < Rails::Application
-    if Rails.gem_version < Gem::Version.new('5.1')
-      config.action_controller.per_form_csrf_tokens = true
-      config.action_controller.forgery_protection_origin_check = true
-
-      ActiveSupport.to_time_preserves_timezone = true
-
-      config.active_record.belongs_to_required_by_default = true
-
-      config.ssl_options = { hsts: { subdomains: true } }
-    else
-      config.load_defaults "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}"
-    end
-
-    # Settings in config/environments/* take precedence over those specified here.
-    # Application configuration should go into files in config/initializers
-    # -- all .rb files in that directory are automatically loaded.
-  end
-end

data/spec/dummy/config/boot.rb

@@ -1,7 +0,0 @@
-require 'rubygems'
-require 'bundler/setup'
-
-orm = ENV['BUNDLE_GEMFILE'].match(/Gemfile\.(.+)\.rb/)
-DOORKEEPER_ORM = (orm && orm[1]) || :active_record unless defined?(DOORKEEPER_ORM)
-
-$LOAD_PATH.unshift File.expand_path('../../../lib', __dir__)