doorkeeper 5.3.0 → 5.4.0

data/Rakefile

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-require "bundler/setup"
-require "rspec/core/rake_task"
-
-desc "Default: run specs."
-task default: :spec
-
-desc "Run all specs"
-RSpec::Core::RakeTask.new(:spec) do |config|
-  config.verbose = false
-end
-
-namespace :doorkeeper do
-  desc "Install doorkeeper in dummy app"
-  task :install do
-    cd "spec/dummy"
-    system "bundle exec rails g doorkeeper:install --force"
-  end
-
-  desc "Runs local test server"
-  task :server do
-    cd "spec/dummy"
-    system "bundle exec rails server"
-  end
-end
-
-Bundler::GemHelper.install_tasks

data/SECURITY.md

@@ -1,15 +0,0 @@
-# Reporting security issues in Doorkeeper
-
-Hello! Thank you for wanting to disclose a possible security
-vulnerability within the Doorkeeper gem! Please follow our disclosure
-policy as outlined below:
-
-1. Do NOT open up a GitHub issue with your report. Security reports
-   should be kept private until a possible fix is determined.
-2. Send an email to Nikita Bulai at bulaj.nikita AT gmail.com or one of
-   the others Doorkeeper maintainers listed in gemspec. You should receive
-   a prompt response.
-3. Be patient. Since Doorkeeper is in a stable maintenance phase, we want to
-   do as little as possible to rock the boat of the project.
-
-Thank you very much for adhering for these policies!

data/UPGRADE.md

@@ -1,2 +0,0 @@
-See [Upgrade Guides](https://github.com/doorkeeper-gem/doorkeeper/wiki/Migration-from-old-versions)
-in the project Wiki.

data/bin/console

@@ -1,16 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-require "bundler/setup"
-require "rails/all"
-require "doorkeeper"
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "irb"
-IRB.start(__FILE__)

data/doorkeeper.gemspec

@@ -1,42 +0,0 @@
-# frozen_string_literal: true
-
-$LOAD_PATH.push File.expand_path("lib", __dir__)
-
-require "doorkeeper/version"
-
-Gem::Specification.new do |gem|
-  gem.name        = "doorkeeper"
-  gem.version     = Doorkeeper.gem_version
-  gem.authors     = ["Felipe Elias Philipp", "Tute Costa", "Jon Moss", "Nikita Bulai"]
-  gem.email       = %w[bulaj.nikita@gmail.com]
-  gem.homepage    = "https://github.com/doorkeeper-gem/doorkeeper"
-  gem.summary     = "OAuth 2 provider for Rails and Grape"
-  gem.description = "Doorkeeper is an OAuth 2 provider for Rails and Grape."
-  gem.license     = "MIT"
-
-  gem.files         = `git ls-files`.split("\n").reject { |file| file.start_with?(".") }
-  gem.test_files    = `git ls-files -- spec/*`.split("\n")
-  gem.require_paths = ["lib"]
-
-  gem.metadata = {
-    "homepage_uri" => "https://github.com/doorkeeper-gem/doorkeeper",
-    "changelog_uri" => "https://github.com/doorkeeper-gem/doorkeeper/blob/master/CHANGELOG.md",
-    "source_code_uri" => "https://github.com/doorkeeper-gem/doorkeeper",
-    "bug_tracker_uri" => "https://github.com/doorkeeper-gem/doorkeeper/issues",
-    "documentation_uri" => "https://doorkeeper.gitbook.io/guides/",
-  }
-
-  gem.add_dependency "railties", ">= 5"
-  gem.required_ruby_version = ">= 2.4"
-
-  gem.add_development_dependency "appraisal"
-  gem.add_development_dependency "capybara"
-  gem.add_development_dependency "coveralls"
-  gem.add_development_dependency "danger", "~> 6.0"
-  gem.add_development_dependency "database_cleaner", "~> 1.6"
-  gem.add_development_dependency "factory_bot", "~> 5.0"
-  gem.add_development_dependency "generator_spec", "~> 0.9.3"
-  gem.add_development_dependency "grape"
-  gem.add_development_dependency "rake", ">= 11.3.0"
-  gem.add_development_dependency "rspec-rails"
-end

data/gemfiles/rails_5_0.gemfile

@@ -1,18 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", "~> 5.0.0"
-gem "rspec-core", git: "https://github.com/rspec/rspec-core.git"
-gem "rspec-expectations", git: "https://github.com/rspec/rspec-expectations.git"
-gem "rspec-mocks", git: "https://github.com/rspec/rspec-mocks.git"
-gem "rspec-rails", "4.0.0.beta3"
-gem "rspec-support", git: "https://github.com/rspec/rspec-support.git"
-gem "rubocop", "~> 0.75"
-gem "rubocop-performance"
-gem "bcrypt", "~> 3.1", require: false
-gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
-gem "sqlite3", "~> 1.3", "< 1.4", platform: [:ruby, :mswin, :mingw, :x64_mingw]
-gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw]
-
-gemspec path: "../"

data/gemfiles/rails_5_1.gemfile

@@ -1,18 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", "~> 5.1.0"
-gem "rspec-core", git: "https://github.com/rspec/rspec-core.git"
-gem "rspec-expectations", git: "https://github.com/rspec/rspec-expectations.git"
-gem "rspec-mocks", git: "https://github.com/rspec/rspec-mocks.git"
-gem "rspec-rails", "4.0.0.beta3"
-gem "rspec-support", git: "https://github.com/rspec/rspec-support.git"
-gem "rubocop", "~> 0.75"
-gem "rubocop-performance"
-gem "bcrypt", "~> 3.1", require: false
-gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
-gem "sqlite3", "~> 1.3", "< 1.4", platform: [:ruby, :mswin, :mingw, :x64_mingw]
-gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw]
-
-gemspec path: "../"

data/gemfiles/rails_5_2.gemfile

@@ -1,18 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", "~> 5.2.0"
-gem "rspec-core", git: "https://github.com/rspec/rspec-core.git"
-gem "rspec-expectations", git: "https://github.com/rspec/rspec-expectations.git"
-gem "rspec-mocks", git: "https://github.com/rspec/rspec-mocks.git"
-gem "rspec-rails", "4.0.0.beta3"
-gem "rspec-support", git: "https://github.com/rspec/rspec-support.git"
-gem "rubocop", "~> 0.75"
-gem "rubocop-performance"
-gem "bcrypt", "~> 3.1", require: false
-gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
-gem "sqlite3", "~> 1.3", "< 1.4", platform: [:ruby, :mswin, :mingw, :x64_mingw]
-gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw]
-
-gemspec path: "../"

data/gemfiles/rails_6_0.gemfile

@@ -1,18 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", "~> 6.0.0"
-gem "rspec-core", git: "https://github.com/rspec/rspec-core.git"
-gem "rspec-expectations", git: "https://github.com/rspec/rspec-expectations.git"
-gem "rspec-mocks", git: "https://github.com/rspec/rspec-mocks.git"
-gem "rspec-rails", "4.0.0.beta3"
-gem "rspec-support", git: "https://github.com/rspec/rspec-support.git"
-gem "rubocop", "~> 0.75"
-gem "rubocop-performance"
-gem "bcrypt", "~> 3.1", require: false
-gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
-gem "sqlite3", "~> 1.4", platform: [:ruby, :mswin, :mingw, :x64_mingw]
-gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw]
-
-gemspec path: "../"

data/gemfiles/rails_master.gemfile

@@ -1,18 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", git: "https://github.com/rails/rails"
-gem "rspec-core", git: "https://github.com/rspec/rspec-core.git"
-gem "rspec-expectations", git: "https://github.com/rspec/rspec-expectations.git"
-gem "rspec-mocks", git: "https://github.com/rspec/rspec-mocks.git"
-gem "rspec-rails", "4.0.0.beta3"
-gem "rspec-support", git: "https://github.com/rspec/rspec-support.git"
-gem "rubocop", "~> 0.75"
-gem "rubocop-performance"
-gem "bcrypt", "~> 3.1", require: false
-gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
-gem "sqlite3", "~> 1.4", platform: [:ruby, :mswin, :mingw, :x64_mingw]
-gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw]
-
-gemspec path: "../"

data/spec/controllers/application_metal_controller_spec.rb

@@ -1,64 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper_integration"
-
-describe Doorkeeper::ApplicationMetalController do
-  controller(Doorkeeper::ApplicationMetalController) do
-    def index
-      render json: {}, status: 200
-    end
-
-    def create
-      render json: {}, status: 200
-    end
-  end
-
-  it "lazy run hooks" do
-    i = 0
-    ActiveSupport.on_load(:doorkeeper_metal_controller) { i += 1 }
-
-    expect(i).to eq 1
-  end
-
-  describe "enforce_content_type" do
-    before { allow(Doorkeeper.config).to receive(:enforce_content_type).and_return(flag) }
-
-    context "enabled" do
-      let(:flag) { true }
-
-      it "returns a 200 for the requests without body" do
-        get :index, params: {}
-        expect(response).to have_http_status 200
-      end
-
-      it "returns a 200 for the requests with body and correct media type" do
-        post :create, params: {}, as: :url_encoded_form
-        expect(response).to have_http_status 200
-      end
-
-      it "returns a 415 for the requests with body and incorrect media type" do
-        post :create, params: {}, as: :json
-        expect(response).to have_http_status 415
-      end
-    end
-
-    context "disabled" do
-      let(:flag) { false }
-
-      it "returns a 200 for the correct media type" do
-        get :index, as: :url_encoded_form
-        expect(response).to have_http_status 200
-      end
-
-      it "returns a 200 for an incorrect media type" do
-        get :index, as: :json
-        expect(response).to have_http_status 200
-      end
-
-      it "returns a 200 for the requests with body and incorrect media type" do
-        post :create, params: {}, as: :json
-        expect(response).to have_http_status 200
-      end
-    end
-  end
-end

data/spec/controllers/applications_controller_spec.rb

@@ -1,274 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-module Doorkeeper
-  describe ApplicationsController do
-    context "JSON API" do
-      render_views
-
-      before do
-        allow(Doorkeeper.configuration).to receive(:api_only).and_return(true)
-        allow(Doorkeeper.configuration).to receive(:authenticate_admin).and_return(->(*) { true })
-      end
-
-      it "creates an application" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-              redirect_uri: "https://example.com",
-            }, format: :json,
-          }
-        end.to(change { Doorkeeper::Application.count })
-
-        expect(response).to be_successful
-
-        expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-
-        application = Application.last
-        secret_from_response = json_response["secret"]
-        expect(application.secret_matches?(secret_from_response)).to be_truthy
-
-        expect(json_response["name"]).to eq("Example")
-        expect(json_response["redirect_uri"]).to eq("https://example.com")
-      end
-
-      it "returns validation errors on wrong create params" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-            }, format: :json,
-          }
-        end.not_to(change { Doorkeeper::Application.count })
-
-        expect(response).to have_http_status(422)
-
-        expect(json_response).to include("errors")
-      end
-
-      it "returns validations on wrong create params (unspecified scheme)" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-              redirect_uri: "app.com:80",
-            }, format: :json,
-          }
-        end.not_to(change { Doorkeeper::Application.count })
-
-        expect(response).to have_http_status(422)
-
-        expect(json_response).to include("errors")
-      end
-
-      it "returns application info" do
-        application = FactoryBot.create(:application, name: "Change me")
-
-        get :show, params: { id: application.id, format: :json }
-
-        expect(response).to be_successful
-
-        expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-      end
-
-      it "updates application" do
-        application = FactoryBot.create(:application, name: "Change me")
-
-        put :update, params: {
-          id: application.id,
-          doorkeeper_application: {
-            name: "Example App",
-            redirect_uri: "https://example.com",
-          }, format: :json,
-        }
-
-        expect(application.reload.name).to eq "Example App"
-
-        expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-      end
-
-      it "returns validation errors on wrong update params" do
-        application = FactoryBot.create(:application, name: "Change me")
-
-        put :update, params: {
-          id: application.id,
-          doorkeeper_application: {
-            name: "Example App",
-            redirect_uri: "localhost:3000",
-          }, format: :json,
-        }
-
-        expect(response).to have_http_status(422)
-
-        expect(json_response).to include("errors")
-      end
-
-      it "destroys an application" do
-        application = FactoryBot.create(:application)
-
-        delete :destroy, params: { id: application.id, format: :json }
-
-        expect(response).to have_http_status(204)
-        expect(Application.count).to be_zero
-      end
-    end
-
-    context "when admin is not authenticated" do
-      before do
-        allow(Doorkeeper.config).to receive(:authenticate_admin).and_return(proc do
-          redirect_to main_app.root_url
-        end)
-      end
-
-      it "redirects as set in Doorkeeper.authenticate_admin" do
-        get :index
-        expect(response).to redirect_to(controller.main_app.root_url)
-      end
-
-      it "does not create application" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-              redirect_uri: "https://example.com",
-            },
-          }
-        end.not_to(change { Doorkeeper::Application.count })
-      end
-    end
-
-    context "when admin is authenticated" do
-      context "when application secrets are hashed" do
-        before do
-          allow(Doorkeeper.configuration)
-            .to receive(:application_secret_strategy).and_return(Doorkeeper::SecretStoring::Sha256Hash)
-        end
-
-        it "shows the application secret after creating a new application" do
-          expect do
-            post :create, params: {
-              doorkeeper_application: {
-                name: "Example",
-                redirect_uri: "https://example.com",
-              },
-            }
-          end.to change { Doorkeeper::Application.count }.by(1)
-
-          application = Application.last
-
-          secret_from_flash = flash[:application_secret]
-          expect(secret_from_flash).not_to be_empty
-          expect(application.secret_matches?(secret_from_flash)).to be_truthy
-          expect(response).to redirect_to(controller.main_app.oauth_application_url(application.id))
-
-          get :show, params: { id: application.id, format: :html }
-
-          # We don't know the application secret here (because its hashed) so we can not assert its text on the page
-          # Instead, we read it from the page and then check if it matches the application secret
-          code_element = %r{<code.*id="secret".*>(.*)<\/code>}.match(response.body)
-          secret_from_page = code_element[1]
-
-          expect(response.body).to have_selector("code#application_id", text: application.uid)
-          expect(response.body).to have_selector("code#secret")
-          expect(secret_from_page).not_to be_empty
-          expect(application.secret_matches?(secret_from_page)).to be_truthy
-        end
-
-        it "does not show an application secret when application did already exist" do
-          application = FactoryBot.create(:application)
-          get :show, params: { id: application.id, format: :html }
-
-          expect(response.body).to have_selector("code#application_id", text: application.uid)
-          expect(response.body).to have_selector("code#secret", text: "")
-        end
-
-        it "returns the application details in a json response" do
-          expect do
-            post :create, params: {
-              doorkeeper_application: {
-                name: "Example",
-                redirect_uri: "https://example.com",
-              }, format: :json,
-            }
-          end.to(change { Doorkeeper::Application.count })
-
-          expect(response).to be_successful
-
-          expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-
-          application = Application.last
-          secret_from_response = json_response["secret"]
-          expect(application.secret_matches?(secret_from_response)).to be_truthy
-
-          expect(json_response["name"]).to eq("Example")
-          expect(json_response["redirect_uri"]).to eq("https://example.com")
-        end
-      end
-
-      render_views
-
-      before do
-        allow(Doorkeeper.configuration).to receive(:authenticate_admin).and_return(->(*) { true })
-      end
-
-      it "sorts applications by created_at" do
-        first_application = FactoryBot.create(:application)
-        second_application = FactoryBot.create(:application)
-        expect(Doorkeeper::Application).to receive(:ordered_by).and_call_original
-
-        get :index
-
-        expect(response.body).to have_selector("tbody tr:first-child#application_#{first_application.id}")
-        expect(response.body).to have_selector("tbody tr:last-child#application_#{second_application.id}")
-      end
-
-      it "creates application" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-              redirect_uri: "https://example.com",
-            },
-          }
-        end.to change { Doorkeeper::Application.count }.by(1)
-
-        expect(response).to be_redirect
-      end
-
-      it "shows application details" do
-        application = FactoryBot.create(:application)
-        get :show, params: { id: application.id, format: :html }
-
-        expect(response.body).to have_selector("code#application_id", text: application.uid)
-        expect(response.body).to have_selector("code#secret", text: application.plaintext_secret)
-      end
-
-      it "does not allow mass assignment of uid or secret" do
-        application = FactoryBot.create(:application)
-        put :update, params: {
-          id: application.id,
-          doorkeeper_application: {
-            uid: "1A2B3C4D",
-            secret: "1A2B3C4D",
-          },
-        }
-
-        expect(application.reload.uid).not_to eq "1A2B3C4D"
-      end
-
-      it "updates application" do
-        application = FactoryBot.create(:application)
-        put :update, params: {
-          id: application.id, doorkeeper_application: {
-            name: "Example",
-            redirect_uri: "https://example.com",
-          },
-        }
-
-        expect(application.reload.name).to eq "Example"
-      end
-    end
-  end
-end