doorkeeper 5.1.2 → 5.2.0.rc1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of doorkeeper might be problematic. Click here for more details.

Files changed (66) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +812 -0
  3. data/CONTRIBUTING.md +4 -9
  4. data/Dangerfile +1 -1
  5. data/Gemfile +2 -1
  6. data/NEWS.md +1 -819
  7. data/README.md +2 -2
  8. data/RELEASING.md +6 -5
  9. data/app/controllers/doorkeeper/applications_controller.rb +5 -3
  10. data/app/controllers/doorkeeper/authorized_applications_controller.rb +1 -1
  11. data/app/controllers/doorkeeper/tokens_controller.rb +18 -8
  12. data/app/validators/redirect_uri_validator.rb +19 -9
  13. data/app/views/doorkeeper/applications/_form.html.erb +0 -6
  14. data/app/views/doorkeeper/applications/show.html.erb +1 -1
  15. data/config/locales/en.yml +3 -1
  16. data/doorkeeper.gemspec +1 -1
  17. data/gemfiles/rails_5_0.gemfile +1 -0
  18. data/gemfiles/rails_5_1.gemfile +1 -0
  19. data/gemfiles/rails_5_2.gemfile +1 -0
  20. data/gemfiles/rails_6_0.gemfile +2 -1
  21. data/gemfiles/rails_master.gemfile +1 -0
  22. data/lib/doorkeeper.rb +3 -0
  23. data/lib/doorkeeper/config.rb +30 -3
  24. data/lib/doorkeeper/config/option.rb +13 -7
  25. data/lib/doorkeeper/grape/helpers.rb +5 -1
  26. data/lib/doorkeeper/helpers/controller.rb +16 -3
  27. data/lib/doorkeeper/oauth/authorization/code.rb +10 -8
  28. data/lib/doorkeeper/oauth/authorization/token.rb +1 -1
  29. data/lib/doorkeeper/oauth/code_response.rb +2 -2
  30. data/lib/doorkeeper/oauth/error_response.rb +1 -1
  31. data/lib/doorkeeper/oauth/helpers/uri_checker.rb +18 -4
  32. data/lib/doorkeeper/oauth/nonstandard.rb +39 -0
  33. data/lib/doorkeeper/oauth/refresh_token_request.rb +8 -8
  34. data/lib/doorkeeper/oauth/token_introspection.rb +13 -12
  35. data/lib/doorkeeper/orm/active_record.rb +17 -1
  36. data/lib/doorkeeper/orm/active_record/access_grant.rb +1 -1
  37. data/lib/doorkeeper/orm/active_record/access_token.rb +2 -2
  38. data/lib/doorkeeper/orm/active_record/application.rb +5 -65
  39. data/lib/doorkeeper/stale_records_cleaner.rb +6 -2
  40. data/lib/doorkeeper/version.rb +3 -3
  41. data/lib/generators/doorkeeper/previous_refresh_token_generator.rb +6 -6
  42. data/lib/generators/doorkeeper/templates/initializer.rb +41 -9
  43. data/lib/generators/doorkeeper/templates/migration.rb.erb +3 -0
  44. data/spec/controllers/applications_controller_spec.rb +93 -0
  45. data/spec/controllers/protected_resources_controller_spec.rb +3 -3
  46. data/spec/controllers/tokens_controller_spec.rb +71 -3
  47. data/spec/dummy/config/application.rb +3 -1
  48. data/spec/dummy/config/initializers/doorkeeper.rb +27 -9
  49. data/spec/lib/config_spec.rb +11 -0
  50. data/spec/lib/oauth/helpers/uri_checker_spec.rb +17 -2
  51. data/spec/lib/oauth/pre_authorization_spec.rb +0 -15
  52. data/spec/models/doorkeeper/application_spec.rb +268 -373
  53. data/spec/requests/flows/authorization_code_spec.rb +16 -4
  54. data/spec/requests/flows/revoke_token_spec.rb +19 -11
  55. data/spec/support/doorkeeper_rspec.rb +1 -1
  56. data/spec/validators/redirect_uri_validator_spec.rb +39 -14
  57. metadata +7 -15
  58. data/.coveralls.yml +0 -1
  59. data/.github/ISSUE_TEMPLATE.md +0 -25
  60. data/.github/PULL_REQUEST_TEMPLATE.md +0 -17
  61. data/.gitignore +0 -20
  62. data/.gitlab-ci.yml +0 -16
  63. data/.hound.yml +0 -3
  64. data/.rspec +0 -1
  65. data/.rubocop.yml +0 -50
  66. data/.travis.yml +0 -35
@@ -1,9 +1,7 @@
1
1
  # Contributing
2
2
 
3
3
  We love pull requests from everyone. By participating in this project, you agree
4
- to abide by the thoughtbot [code of conduct].
5
-
6
- [code of conduct]: https://thoughtbot.com/open-source-code-of-conduct
4
+ to abide by the [code of conduct](CODE_OF_CONDUCT.md).
7
5
 
8
6
  Fork, then clone the repo:
9
7
 
@@ -19,14 +17,12 @@ Make sure the tests pass:
19
17
 
20
18
  Make your change.
21
19
  Write tests.
22
- Follow our [style guide][style].
20
+ Follow our [style guide](.rubocop.yml).
23
21
  Make the tests pass:
24
22
 
25
- [style]: https://github.com/thoughtbot/guides/tree/master/style
26
-
27
23
  rake
28
24
 
29
- Add notes on your change to the `NEWS.md` file.
25
+ Add notes on your change to the `CHANGELOG.md` file.
30
26
 
31
27
  Write a [good commit message][commit].
32
28
  Push to your fork.
@@ -35,8 +31,7 @@ Push to your fork.
35
31
  [commit]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
36
32
  [pr]: https://github.com/doorkeeper-gem/doorkeeper/compare/
37
33
 
38
- If [Hound] catches style violations,
39
- fix them.
34
+ If [Hound] catches style violations, fix them.
40
35
 
41
36
  [hound]: https://houndci.com
42
37
 
data/Dangerfile CHANGED
@@ -1,4 +1,4 @@
1
- CHANGELOG_FILE = 'NEWS.md'
1
+ CHANGELOG_FILE = 'CHANGELOG.md'
2
2
  GITHUB_REPO = 'https://github.com/doorkeeper-gem/doorkeeper'
3
3
 
4
4
  def changelog_changed?
data/Gemfile CHANGED
@@ -5,7 +5,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
5
5
 
6
6
  gemspec
7
7
 
8
- gem "rails", "~> 6.0.0.beta3"
8
+ gem "rails", "~> 6.0.0.rc1"
9
9
 
10
10
  # TODO: Remove when rspec-rails 4.0 released
11
11
  gem "rspec-core", github: "rspec/rspec-core"
@@ -15,6 +15,7 @@ gem "rspec-rails", github: "rspec/rspec-rails", branch: "4-0-dev"
15
15
  gem "rspec-support", github: "rspec/rspec-support"
16
16
 
17
17
  gem "rubocop", "~> 0.66"
18
+ gem "rubocop-performance"
18
19
 
19
20
  gem "bcrypt", "~> 3.1", require: false
20
21
 
data/NEWS.md CHANGED
@@ -1,819 +1 @@
1
- # News
2
-
3
- See https://github.com/doorkeeper-gem/doorkeeper/wiki/Migration-from-old-versions for
4
- upgrade guides.
5
-
6
- User-visible changes worth mentioning.
7
-
8
- ## 5.2.2
9
-
10
- - [#1404] Backport: Make `Doorkeeper::Application#read_attribute_for_serialization` public.
11
-
12
- ## 5.1.1
13
-
14
- [#1371] Backport: add #as_json method and attributes serialization restriction for Application model.
15
- Fixes information disclosure vulnerability (CVE-2020-10187).
16
-
17
- ## 5.1.0
18
-
19
- - [#1243]: Add nil check operator in token checking at token introspection.
20
- - [#1241] Explaining foreign key options for resource owner in a single place
21
- - [#1237] Allow to set blank redirect URI if Doorkeeper configured to use redirect URI-less grant flows.
22
- - [#1234] Fix `StaleRecordsCleaner` to properly work with big amount of records.
23
- - [#1228] Allow to explicitly set non-expiring tokens in `custom_access_token_expires_in` configuration
24
- option using `Float::INIFINITY` return value.
25
- - [#1224] Do not try to store token if not found by fallback hashing strategy.
26
- - [#1223] Update Hound/Rubocop rules, correct Doorkeeper codebase to follow style-guides.
27
- - [#1220] Drop Rails 4.2 & Ruby < 2.4 support.
28
-
29
- ## 5.1.0.rc2
30
-
31
- - [#1208] Unify hashing implementation into secret storing strategies
32
-
33
- **[IMPORTANT]**: If you have been using the master branch of doorkeeper with bcrypt in your Gemfile.lock,
34
- your application secrets have been hashed using BCrypt. To restore this behavior, use the initializer option
35
- `use_application_hashing using: 'Doorkeeper::SecretStoring::BCrypt`.
36
-
37
- - [#1216] Add nil check to `expires_at` method.
38
- - [#1215] Fix deprecates for Rails 6.
39
- - [#1214] Scopes field accepts array.
40
- - [#1209] Fix tokens validation for Token Introspection request.
41
- - [#1202] Use correct HTTP status codes for error responses.
42
-
43
- **[IMPORTANT]**: this change might break your application if you were relying on the previous
44
- 401 status codes, this is now a 400 by default, or a 401 for `invalid_client` and `invalid_token` errors.
45
-
46
- - [#1201] Fix custom TTL block `client` parameter to always be an `Doorkeeper::Application` instance.
47
-
48
- **[IMPORTANT]**: those who defined `custom_access_token_expires_in` configuration option need to check
49
- their block implementation: if you are using `oauth_client.application` to get `Doorkeeper::Application`
50
- instance, then you need to replace it with just `oauth_client`.
51
-
52
- - [#1200] Increase default Doorkeeper access token value complexity (`urlsafe_base64` instead of just `hex`)
53
- matching RFC6749/RFC6750.
54
-
55
- **[IMPORTANT]**: this change have possible side-effects in case you have custom database constraints for
56
- access token value, application secrets, refresh tokens or you patched Doorkeeper models and introduced
57
- token value validations, or you are using database with case-insensitive WHERE clause like MySQL
58
- (you can face some collisions). Before this change access token value matched `[a-f0-9]` regex, and now
59
- it matches `[a-zA-Z0-9\-_]`. In case you have such restrictions and your don't use custom token generator
60
- please change configuration option `default_generator_method ` to `:hex`.
61
-
62
- - [#1195] Allow to customize Token Introspection response (fixes #1194).
63
- - [#1189] Option to set `token_reuse_limit`.
64
- - [#1191] Try to load bcrypt for hashing of application secrets, but add fallback.
65
-
66
- ## 5.1.0.rc1
67
-
68
- - [#1188] Use `params` instead of `request.POST` in tokens controller (fixes #1183).
69
- - [#1182] Fix loopback IP redirect URIs to conform with RFC8252, p. 7.3 (fixes #1170).
70
- - [#1179] Authorization Code Grant Flow without client id returns invalid_client error.
71
- - [#1177] Allow to limit `scopes` for certain `grant_types`
72
- - [#1176] Fix test factory support for `factory_bot_rails`
73
- - [#1175] Internal refactor: use `scopes_string` inside `scopes`.
74
- - [#1168] Allow optional hashing of tokens and secrets.
75
- - [#1164] Fix error when `root_path` is not defined.
76
- - [#1162] Fix `enforce_content_type` for requests without body.
77
-
78
- ## 5.0.2
79
-
80
- - [#1158] Fix initializer template: change `handle_auth_errors` option
81
- - [#1157] Remove redundant index from migration template.
82
-
83
- ## 5.0.1
84
-
85
- - [#1154] Refactor `StaleRecordsCleaner` to be ORM agnostic.
86
- - [#1152] Fix migration template: change resource owner data type from integer to Rails generic `references`
87
- - [#1151] Fix Refresh Token strategy: add proper validation of client credentials both for Public & Private clients.
88
- - [#1149] Fix for `URIChecker#valid_for_authorization?` false negative when query is blank, but `?` present.
89
- - [#1140] Allow rendering custom errors from exceptions (issue #844). Originally opened as [#944].
90
- - [#1138] Revert regression bug (check for token expiration in Authorizations controller so authorization
91
- triggers every time)
92
-
93
- ## 5.0.0
94
-
95
- - [#1127] Change the token_type initials of the Banner Token to uppercase to comply with the RFC6750 specification.
96
-
97
- ## 5.0.0.rc2
98
-
99
- - [#1122] Fix AuthorizationsController#new error response to be in JSON format
100
- - [#1119] Fix token revocation for OAuth apps using "implicit" grant flow
101
- - [#1116] `AccessGrant`s will now be revoked along with `AccessToken`s when
102
- hitting the `AuthorizedApplicationController#destroy` route.
103
- - [#1114] Make token info endpoint's attributes consistent with token creation
104
- - [#1108] Simple formating of callback URLs when listing oauth applications
105
- - [#1106] Restrict access to AdminController with 'Forbidden 403' if admin_authenticator is not
106
- configured by developers.
107
-
108
- ## 5.0.0.rc1
109
-
110
- - [#1103] Allow customizing use_refresh_token
111
- - [#1089] Removed enable_pkce_without_secret configuration option
112
- - [#1102] Expiration time based on scopes
113
- - [#1099] All the configuration variables in `Doorkeeper.configuration` now
114
- always return a non-nil value (`true` or `false`)
115
- - [#1099] ORM / Query optimization: Do not revoke the refresh token if it is not enabled
116
- in `doorkeeper.rb`
117
- - [#996] Expiration Time Base On Grant Type
118
- - [#997] Allow PKCE authorization_code flow as specified in RFC7636
119
- - [#907] Fix lookup for matching tokens in certain edge-cases
120
- - [#992] Add API option to use Doorkeeper without management views for API only
121
- Rails applications (`api_only`)
122
- - [#1045] Validate redirect_uri as the native URI when making authorization code requests
123
- - [#1048] Remove deprecated `Doorkeeper#configured?`, `Doorkeeper#database_installed?`, and
124
- `Doorkeeper#installed?` method
125
- - [#1031] Allow public clients to authenticate without `client_secret`. Define an app as
126
- either public or private/confidential
127
-
128
- **[IMPORTANT]**: all the applications (clients) now are considered as private by default.
129
- You need to manually change `confidential` column to `false` if you are using public clients,
130
- in other case your mobile (or other) applications will not be able to authorize.
131
- See [#1142](https://github.com/doorkeeper-gem/doorkeeper/issues/1142) for more details.
132
-
133
- - [#1010] Add configuration to enforce configured scopes (`default_scopes` and
134
- `optional_scopes`) for applications
135
- - [#1060] Ensure that the native redirect_uri parameter matches with redirect_uri of the client
136
- - [#1064] Add :before_successful_authorization and :after_successful_authorization hooks
137
- - [#1069] Upgrade Bootstrap to 4 for Admin
138
- - [#1068] Add rake task to cleanup databases that can become large over time
139
- - [#1072] AuthorizationsController: Memoize strategy.authorize_response result to enable
140
- subclasses to use the response object.
141
- - [#1075] Call `before_successful_authorization` and `after_successful_authorization` hooks
142
- on `create` action as well as `new`
143
- - [#1082] Fix #916: remember routes mapping and use it required places (fix error with
144
- customized Token Info route).
145
- - [#1086, #1088] Fix bug with receiving default scopes in the token even if they are
146
- not present in the application scopes (use scopes intersection).
147
- - [#1076] Add config to enforce content type to application/x-www-form-urlencoded
148
- - Fix bug with `force_ssl_in_redirect_uri` when it breaks existing applications with an
149
- SSL redirect_uri.
150
-
151
- ## 4.4.3
152
-
153
- - [#1143] Adds a config option `opt_out_native_route_change` to opt out of the breaking api
154
- changed introduced in https://github.com/doorkeeper-gem/doorkeeper/pull/1003
155
-
156
-
157
- ## 4.4.2
158
-
159
- - [#1130] Backport fix for native redirect_uri from 5.x.
160
-
161
- ## 4.4.1
162
-
163
- - [#1127] Backport token type to comply with the RFC6750 specification.
164
- - [#1125] Backport Quote surround I18n yes/no keys
165
-
166
- ## 4.4.0
167
-
168
- - [#1120] Backport security fix from 5.x for token revocation when using public clients
169
-
170
- **[IMPORTANT]**: all the applications (clients) now are considered as private by default.
171
- You need to manually change `confidential` column to `false` if you are using public clients,
172
- in other case your mobile (or other) applications will not be able to authorize.
173
- See [#1142](https://github.com/doorkeeper-gem/doorkeeper/issues/1142) for more details.
174
-
175
- ## 4.3.2
176
-
177
- - [#1053] Support authorizing with query params in the request `redirect_uri` if explicitly present in app's `Application#redirect_uri`
178
-
179
- ## 4.3.1
180
-
181
- - Remove `BaseRecord` and introduce additional concern for ordering methods to fix
182
- braking changes for Doorkeeper models.
183
- - [#1032] Refactor BaseRequest callbacks into configurable lambdas
184
- - [#1040] Clear mixins from ActiveRecord DSL and save only overridable API. It
185
- allows to use this mixins in Doorkeeper ORM extensions with minimum code boilerplate.
186
-
187
- ## 4.3.0
188
-
189
- - [#976] Fix to invalidate the second redirect URI when the first URI is the native URI
190
- - [#1035] Allow `Application#redirect_uri=` to handle array of URIs.
191
- - [#1036] Allow to forbid Application redirect URI's with specific rules.
192
- - [#1029] Deprecate `order_method` and introduce `ordered_by`. Sort applications
193
- by `created_at` in index action.
194
- - [#1033] Allow Doorkeeper configuration option #force_ssl_in_redirect_uri to be a callable object.
195
- - Fix Grape integration & add specs for it
196
- - [#913] Deferred ORM (ActiveRecord) models loading
197
- - [#943] Fix Access Token token generation when certain errors occur in custom token generators
198
- - [#1026] Implement RFC7662 - OAuth 2.0 Token Introspection
199
- - [#985] Generate valid migration files for Rails >= 5
200
- - [#972] Replace Struct subclassing with block-form initialization
201
- - [#1003] Use URL query param to pass through native redirect auth code so automated apps can find it.
202
-
203
- **[IMPORTANT]**: Previously authorization code response route was `/oauth/authorize/<code>`,
204
- now it is `oauth/authorize/native?code=<code>` (in order to help applications to automatically find the code value).
205
-
206
- - [#868] `Scopes#&` and `Scopes#+` now take an array or any other enumerable
207
- object.
208
- - [#1019] Remove translation not in use: `invalid_resource_owner`.
209
- - Use Ruby 2 hash style syntax (min required Ruby version = 2.1)
210
- - [#948] Make Scopes.<=> work with any "other" value.
211
- - [#974] Redirect URI is checked without query params within AuthorizationCodeRequest.
212
- - [#1004] More explicit help text for `native_redirect_uri`.
213
- - [#1023] Update Ruby versions and test against 2.5.0 on Travis CI.
214
- - [#1024] Migrate from FactoryGirl to FactoryBot.
215
- - [#1025] Improve documentation for adding foreign keys
216
- - [#1028] Make it possible to have composite strategy names.
217
-
218
- ## 4.2.6
219
-
220
- - [#970] Escape certain attributes in authorization forms.
221
-
222
- ## 4.2.5
223
-
224
- - [#936] Deprecate `Doorkeeper#configured?`, `Doorkeeper#database_installed?`, and
225
- `Doorkeeper#installed?`
226
- - [#909] Add `InvalidTokenResponse#reason` reader method to allow read the kind
227
- of invalid token error.
228
- - [#928] Test against more recent Ruby versions
229
- - Small refactorings within the codebase
230
- - [#921] Switch to Appraisal, and test against Rails master
231
- - [#892] Add minimum Ruby version requirement
232
-
233
- ## 4.2.0
234
-
235
- - Security fix: Address CVE-2016-6582, implement token revocation according to
236
- spec (tokens might not be revoked if client follows the spec).
237
- - [#873] Add hooks to Doorkeeper::ApplicationMetalController
238
- - [#871] Allow downstream users to better utilize doorkeeper spec factories by
239
- eliminating name conflict on `:user` factory.
240
-
241
- ## 4.1.0
242
-
243
- - [#845] Allow customising the `Doorkeeper::ApplicationController` base
244
- controller
245
-
246
- ## 4.0.0
247
-
248
- - [#834] Fix AssetNotPrecompiled error with Sprockets 4
249
- - [#843] Revert "Fix validation error messages"
250
- - [#847] Specify Null option to timestamps
251
-
252
- ## 4.0.0.rc4
253
-
254
- - [#777] Add support for public client in password grant flow
255
- - [#823] Make configuration and specs ORM independent
256
- - [#745] Add created_at timestamp to token generation options
257
- - [#838] Drop `Application#scopes` generator and warning, introduced for
258
- upgrading doorkeeper from v2 to v3.
259
- - [#801] Fix Rails 5 warning messages
260
- - Test against Rails 5 RC1
261
-
262
- ## 4.0.0.rc3
263
-
264
- - [#769] Revoke refresh token on access token use. To make use of the new config
265
- add `previous_refresh_token` column to `oauth_access_tokens`:
266
-
267
- ```
268
- rails generate doorkeeper:previous_refresh_token
269
- ```
270
- - [#811] Toughen parameters filter with exact match
271
- - [#813] Applications admin bugfix
272
- - [#799] Fix Ruby Warnings
273
- - Drop `attr_accessible` from models
274
-
275
- ### Backward incompatible changes
276
-
277
- - [#730] Force all timezones to use UTC to prevent comparison issues.
278
- - [#802] Remove `config.i18n.fallbacks` from engine
279
-
280
- ## 4.0.0.rc2
281
-
282
- - Fix optional belongs_to for Rails 5
283
- - Fix Ruby warnings
284
-
285
- ## 4.0.0.rc1
286
-
287
- ### Backward incompatible changes
288
-
289
- - Drops support for Rails 4.1 and earlier
290
- - Drops support for Ruby 2.0
291
- - [#778] Bug fix: use the remaining time that a token is still valid when
292
- building the redirect URI for the implicit grant flow
293
-
294
- ### Other changes
295
-
296
- - [#771] Validation error messages fixes
297
- - Adds foreign key constraints in generated migrations between tokens and
298
- grants, and applications
299
- - Support Rails 5
300
-
301
- ## 3.1.0
302
-
303
- - [#736] Existing valid tokens are now reused in client_credentials flow
304
- - [#749] Allow user to raise authorization error with custom messages.
305
- Under `resource_owner_authenticator` block a user can
306
- `raise Doorkeeper::Errors::DoorkeeperError.new('custom_message')`
307
- - [#762] Check doesn’t abort the actual migration, so it runs
308
- - [#722] `doorkeeper_forbidden_render_options` now supports returning a 404 by
309
- specifying `respond_not_found_when_forbidden: true` in the
310
- `doorkeeper_forbidden_render_options` method.
311
- - [#734] Simplify and remove duplication in request strategy classes
312
-
313
- ## 3.0.1
314
-
315
- - [#712] Wrap exchange of grant token for access token and access token refresh
316
- in transactions
317
- - [#704] Allow applications scopes to be mass assigned
318
- - [#707] Fixed order of Mixin inclusion and table_name configuration in models
319
- - [#712] Wrap access token and refresh grants in transactions
320
- - Adds JRuby support
321
- - Specs, views and documentation adjustments
322
-
323
- ## 3.0.0
324
-
325
- ### Other changes
326
-
327
- - [#693] Updates `en.yml`.
328
-
329
- ## 3.0.0 (rc2)
330
-
331
- ### Backward incompatible changes
332
-
333
- - [#678] Change application-specific scopes to take precedence over server-wide
334
- scopes. This removes the previous behavior where the intersection between
335
- application and server scopes was used.
336
-
337
- ### Other changes
338
-
339
- - [#671] Fixes `NoMethodError - undefined method 'getlocal'` when calling
340
- the /oauth/token path. Switch from using a DateTime object to update
341
- AR to using a Time object. (Issue #668)
342
- - [#677] Support editing application-specific scopes via the standard forms
343
- - [#682] Pass error hash to Grape `error!`
344
- - [#683] Generate application secret/UID if fields are blank strings
345
-
346
- ## 3.0.0 (rc1)
347
-
348
- ### Backward incompatible changes
349
-
350
- - [#648] Extracts mongodb ORMs to
351
- https://github.com/doorkeeper-gem/doorkeeper-mongodb. If you use ActiveRecord
352
- you don’t need to do any change, otherwise you will need to install the new
353
- plugin.
354
- - [#665] `doorkeeper_unauthorized_render_options(error:)` and
355
- `doorkeeper_forbidden_render_options(error:)` now accept `error` keyword
356
- argument.
357
-
358
- ### Removed deprecations
359
-
360
- - Removes `doorkeeper_for` deprecation notice.
361
- - Remove `applications.scopes` upgrade notice.
362
-
363
-
364
- ## 2.2.2
365
-
366
- - [#541] Fixed `undefined method attr_accessible` problem on Rails 4
367
- (happens only when ProtectedAttributes gem is used) in #599
368
-
369
- ## 2.2.1
370
-
371
- - [#636] `custom_access_token_expires_in` bugfixes
372
- - [#641] syntax error fix (Issue #612)
373
- - [#633] Send extra details to Custom Token Generator
374
- - [#628] Refactor: improve orm adapters to ease extension
375
- - [#637] Upgrade to rspec to 3.2
376
-
377
- ## 2.2.0 - 2015-04-19
378
-
379
- - [#611] Allow custom access token generators to be used
380
- - [#632] Properly fallback to `default_scopes` when no scope is specified
381
- - [#622] Clarify that there is a logical OR between scopes for authorizing
382
- - [#635] Upgrade to rspec 3
383
- - [#627] i18n fallbacks to english
384
- - Moved CHANGELOG to NEWS.md
385
-
386
-
387
- ## 2.1.4 - 2015-03-27
388
-
389
- - [#595] HTTP spec: Add `scope` for refresh token scope param
390
- - [#596] Limit scopes in app scopes for client credentials
391
- - [#567] Add Grape helpers for easier integration with Grape framework
392
- - [#606] Add custom access token expiration support for Client Credentials flow
393
-
394
-
395
- ## 2.1.3 - 2015-03-01
396
-
397
- - [#588] Fixes scopes_match? bug that skipped authorization form in some cases
398
-
399
-
400
- ## 2.1.2 - 2015-02-25
401
-
402
- - [#574] Remove unused update authorization route.
403
- - [#576] Filter out sensitive parameters from logs.
404
- - [#582] The Authorization HTTP header fields are now case insensitive.
405
- - [#583] Database connection bugfix in certain scenarios.
406
- - Testing improvements
407
-
408
-
409
- ## 2.1.1 - 2015-02-06
410
-
411
- - Remove `wildcard_redirect_url` option
412
- - [#481] Customize token flow OAuth expirations with a config lambda
413
- - [#568] TokensController: Memoize strategy.authorize_response result to enable
414
- subclasses to use the response object.
415
- - [#571] Fix database initialization issues in some configurations.
416
- - Documentation improvements
417
-
418
-
419
- ## 2.1.0 - 2015-01-13
420
-
421
- - [#540] Include `created_at` in response.
422
- - [#538] Check application-level scopes in client_credentials and password flow.
423
- - [5596227] Check application scopes in AccessToken when present. Fixes a bug in
424
- doorkeeper 2.0.0 and 2.0.1 referring to application specific scopes.
425
- - [#534] Internationalizes doorkeeper views.
426
- - [#545] Ensure there is a connection to the database before checking for
427
- missing columns
428
- - [#546] Use `Doorkeeper::` prefix when referencing `Application` to avoid
429
- possible application model name conflict.
430
- - [#538] Test with Rails ~> 4.2.
431
-
432
- ### Potentially backward incompatible changes
433
-
434
- - Enable by default `authorization_code` and `client_credentials` grant flows.
435
- Disables implicit and password grant flows by default.
436
- - [#510, #544, 722113f] Revoked refresh token response bugfix.
437
-
438
-
439
- ## 2.0.1 - 2014-12-17
440
-
441
- - [#525, #526, #527] Fix `ActiveRecord::NoDatabaseError` on gem load.
442
-
443
-
444
- ## 2.0.0 - 2014-12-16
445
-
446
- ### Backward incompatible changes
447
-
448
- - [#448] Removes `doorkeeper_for` helper. Now we use
449
- `before_action :doorkeeper_authorize!`.
450
- - [#469] Allow client applications to restrict the set of allowable scopes.
451
- Fixes #317. `oauth_applications` relation needs a new `scopes` string column,
452
- non nullable, which defaults to an empty string. To add the column run:
453
-
454
- ```
455
- rails generate doorkeeper:application_scopes
456
- ```
457
-
458
- If you’d rather do it by hand, your ActiveRecord migration should contain:
459
-
460
- ```ruby
461
- add_column :oauth_applications, :scopes, :string, null: false, default: ‘’
462
- ```
463
-
464
- ### Removed deprecations
465
-
466
- - Removes `test_redirect_uri` option. It is now called `native_redirect_uri`.
467
- - [#446] Removes `mount Doorkeeper::Engine`. Now we use `use_doorkeeper`.
468
-
469
- ### Others
470
-
471
- - [#484] Performance improvement - avoid performing order_by when not required.
472
- - [#450] When password is invalid in Password Credentials Grant, Doorkeeper
473
- returned 'invalid_resource_owner' instead of 'invalid_grant', as the spec
474
- declares. Fixes #444.
475
- - [#452] Allows `revoked_at` to be set in the future, for future expiry.
476
- Rationale: https://github.com/doorkeeper-gem/doorkeeper/pull/452#issuecomment-51431459
477
- - [#480] For Implicit grant flow, access tokens can now be reused. Fixes #421.
478
- - [#491] Reworks of @jasl's #454 and #478. ORM refactor that allows doorkeeper
479
- to be extended more easily with unsupported ORMs. It also marks the boundaries
480
- between shared model code and ORM specifics inside of the gem.
481
- - [#496] Tests with Rails 4.2.
482
- - [#489] Adds `force_ssl_in_redirect_uri` to force the usage of the HTTPS
483
- protocol in non-native redirect uris.
484
- - [#516] SECURITY: Adds `protect_from_forgery` to `Doorkeeper::ApplicationController`
485
- - [#518] Fix random failures in mongodb.
486
-
487
- ---
488
-
489
- ## 1.4.2 - 2015-03-02
490
-
491
- - [#576] Filter out sensitive parameters from logs
492
-
493
- ## 1.4.1 - 2014-12-17
494
-
495
- - [#516] SECURITY: Adds `protect_from_forgery` to `Doorkeeper::ApplicationController`
496
-
497
- ## 1.4.0 - 2014-07-31
498
-
499
- - internals
500
- - [#427] Adds specs expectations.
501
- - [#428] Error response refactor.
502
- - [#417] Moves token validation into Access Token class.
503
- - [#439] Removes redundant module includes.
504
- - [#443] TokensController and TokenInfoController inherit from ActionController::Metal
505
- - bug
506
- - [#418] fixes #243, requests with insufficient scope now respond 403 instead
507
- of 401. (API change)
508
- - [#438] fixes #398, native redirect for implicit token grant bug.
509
- - [#440] namespace fixes
510
- - enhancements
511
- - [#432] Keeps query parameters
512
-
513
- ## 1.3.1 - 2014-07-06
514
-
515
- - enhancements
516
- - [#405] Adds facade to more easily get the token from a request in a route
517
- constraint.
518
- - [#415] Extend Doorkeeper TokenResponse with an `after_successful_response`
519
- callback that allows handling of `response` object.
520
- - internals
521
- - [#409] Deprecates `test_redirect_uri` in favor of `native_redirect_uri`.
522
- See discussion in: [#351].
523
- - [#411] Clean rspec deprecations. General test improvements.
524
- - [#412] rspec line width can go longer than 80 (hound CI config).
525
- - bug
526
- - [#413] fixes #340, routing scope is now taken into account in redirect.
527
- - [#401] and [#425] application is not required any longer for access_token.
528
-
529
- ## 1.3.0 - 2014-05-23
530
-
531
- - enhancements
532
- - [#387] Adds reuse_access_token configuration option.
533
-
534
- ## 1.2.0 - 2014-05-02
535
-
536
- - enhancements
537
- - [#376] Allow users to enable basic header authorization for access tokens.
538
- - [#374] Token revocation implementation [RFC 7009]
539
- - [#295] Only enable specific grant flows.
540
- - internals
541
- - [#381] Locale source fix.
542
- - [#380] Renames `errors_for` to `doorkeeper_errors_for`.
543
- - [#390] Style adjustments in accordance with Ruby Style Guide form
544
- Thoughtbot.
545
-
546
- ## 1.1.0 - 2014-03-29
547
-
548
- - enhancements
549
- - [#336] mongoid4 support.
550
- - [#372] Allow users to set ActiveRecord table_name_prefix/suffix options
551
- - internals
552
- - [#343] separate OAuth's admin and user end-point to different layouts, upgrade theme to Bootstrap 3.1.
553
- - [#348] Move render_options in filter after `@error` has been set
554
-
555
- ## 1.0.0 - 2014-01-13
556
-
557
- - bug (spec)
558
- - [#228] token response `expires_in` value is now in seconds, relative to
559
- request time
560
- - [#296] client is optional for password grant type.
561
- - [#319] If client credentials are present on password grant type they are validated
562
- - [#326] If client credentials are present in refresh token they are validated
563
- - [#326] If authenticated client does not match original client that
564
- obtained a refresh token it responds `invalid_grant` instead of
565
- `invalid_client`. Previous usage was invalid according to Section 5.2 of
566
- the spec.
567
- - [#329] access tokens' `scopes` string wa being compared against
568
- `default_scopes` symbols, always unauthorizing.
569
- - [#318] Include "WWW-Authenticate" header with Unauthorized responses
570
- - enhancements
571
- - [#293] Adds ActionController::Instrumentation in TokensController
572
- - [#298] Support for multiple redirect_uris added.
573
- - [#313] `AccessToken.revoke_all_for` actually revokes all non-revoked
574
- tokens for an application/owner instead of deleting them.
575
- - [#333] Rails 4.1 support
576
- - internals
577
- - Removes jQuery dependency [fixes #300] [PR #312 is related]
578
- - [#294] Client uid and secret will be generated only if not present.
579
- - [#316] Test warnings addressed.
580
- - [#338] Rspec 3 syntax.
581
-
582
- ---
583
-
584
- ## 0.7.4 - 2013-12-01
585
-
586
- - bug
587
- - Symbols instead of strings for user input.
588
-
589
- ## 0.7.3 - 2013-10-04
590
-
591
- - enhancements
592
- - [#204] Allow to overwrite scope in routes
593
- - internals
594
- - Returns only present keys in Token Response (may imply a backwards
595
- incompatible change). https://github.com/doorkeeper-gem/doorkeeper/issues/220
596
- - bug
597
- - [#290] Support for Rails 4 when 'protected_attributes' gem is present.
598
-
599
- ## 0.7.2 - 2013-09-11
600
-
601
- - enhancements
602
- - [#272] Allow issuing multiple access_tokens for one user/application for multiple devices
603
- - [#170] Increase length of allowed redirect URIs
604
- - [#239] Do not try to load unavailable Request class for the current phase.
605
- - [#273] Relax jquery-rails gem dependency
606
-
607
- ## 0.7.1 - 2013-08-30
608
-
609
- - bug
610
- - [#269] Rails 3.2 raised `ActiveModel::MassAssignmentSecurity::Error`.
611
-
612
- ## 0.7.0 - 2013-08-21
613
-
614
- - enhancements
615
- - [#229] Rails 4!
616
- - internals
617
- - [#203] Changing table name to be specific in column_names_with_table
618
- - [#215] README update
619
- - [#227] Use Rails.config.paths["config/routes"] instead of assuming "config/routes.rb" exists
620
- - [#262] Add jquery as gem dependency
621
- - [#263] Add a configuration for ActiveRecord.establish_connection
622
- - Deprecation and Ruby warnings (PRs merged outside of GitHub).
623
-
624
- ## 0.6.7 - 2013-01-13
625
-
626
- - internals
627
- - [#188] Add IDs to the show views for integration testing [@egtann](https://github.com/egtann)
628
-
629
- ## 0.6.6 - 2013-01-04
630
-
631
- - enhancements
632
- - [#187] Raise error if configuration is not set
633
-
634
- ## 0.6.5 - 2012-12-26
635
-
636
- - enhancements
637
- - [#184] Vendor the Bootstrap CSS [@tylerhunt](https://github.com/tylerhunt)
638
-
639
- ## 0.6.4 - 2012-12-15
640
-
641
- - bug
642
- - [#180] Add localization to authorized_applications destroy notice [@aalvarado](https://github.com/aalvarado)
643
-
644
- ## 0.6.3 - 2012-12-07
645
-
646
- - bugfixes
647
- - [#163] Error response content-type header should be application/json [@ggayan](https://github.com/ggayan)
648
- - [#175] Make token.expires_in_seconds return nil when expires_in is nil [@miyagawa](https://github.com/miyagawa)
649
- - enhancements
650
- - [#166, #172, #174] Behavior to automatically authorize based on a configured proc
651
- - internals
652
- - [#168] Using expectation syntax for controller specs [@rdsoze](https://github.com/rdsoze)
653
-
654
- ## 0.6.2 - 2012-11-10
655
-
656
- - bugfixes
657
- - [#162] Remove ownership columns from base migration template [@rdsoze](https://github.com/rdsoze)
658
-
659
- ## 0.6.1 - 2012-11-07
660
-
661
- - bugfixes
662
- - [#160] Removed |routes| argument from initializer authenticator blocks
663
- - documentation
664
- - [#160] Fixed description of context of authenticator blocks
665
-
666
- ## 0.6.0 - 2012-11-05
667
-
668
- - enhancements
669
- - Mongoid `orm` configuration accepts only :mongoid2 or :mongoid3
670
- - Authorization endpoint does not redirect in #new action anymore. It wasn't specified by OAuth spec
671
- - TokensController now inherits from ActionController::Metal. There might be performance upgrades
672
- - Add link to authorization in Applications scaffold
673
- - [#116] MongoMapper support [@carols10cents](https://github.com/carols10cents)
674
- - [#122] Mongoid3 support [@petergoldstein](https://github.com/petergoldstein)
675
- - [#150] Introduce test redirect uri for applications
676
- - bugfixes
677
- - [#157] Response token status should be `:ok`, not `:success` [@theycallmeswift](https://github.com/theycallmeswift)
678
- - [#159] Remove ActionView::Base.field_error_proc override (fixes #145)
679
- - internals
680
- - Update development dependencies
681
- - Several refactorings
682
- - Rails/ORM are easily swichable with env vars (rails and orm)
683
- - Travis now tests against Mongoid v2
684
-
685
- ## 0.5.0 - 2012-10-20
686
-
687
- Official support for rubinius was removed.
688
-
689
- - enhancements
690
- - Configure the way access token is retrieved from request (default to bearer header)
691
- - Authorization Code expiration time is now configurable
692
- - Add support for mongoid
693
- - [#78, #128, #137, #138] Application Ownership
694
- - [#92] Allow users to skip controllers
695
- - [#99] Remove deprecated warnings for data-* attributes [@towerhe](https://github.com/towerhe)
696
- - [#101] Return existing access_token for PasswordAccessTokenRequest [@benoist](https://github.com/benoist)
697
- - [#104] Changed access token scopes example code to default_scopes and optional_scopes [@amkirwan](https://github.com/amkirwan)
698
- - [#107] Fix typos in initializer
699
- - [#123] i18n for validator, flash messages [@petergoldstein](https://github.com/petergoldstein)
700
- - [#140] ActiveRecord is the default value for the ORM [@petergoldstein](https://github.com/petergoldstein)
701
- - internals
702
- - [#112, #120] Replacing update_attribute with update_column to eliminate deprecation warnings [@rmoriz](https://github.com/rmoriz), [@petergoldstein](https://github.com/petergoldstein)
703
- - [#121] Updating all development dependencies to recent versions. [@petergoldstein](https://github.com/petergoldstein)
704
- - [#144] Adding MongoDB dependency to .travis.yml [@petergoldstein](https://github.com/petergoldstein)
705
- - [#143] Displays errors for unconfigured error messages [@timgaleckas](https://github.com/timgaleckas)
706
- - bugfixes
707
- - [#102] Not returning 401 when access token generation fails [@cslew](https://github.com/cslew)
708
- - [#125] Doorkeeper is using ActiveRecord version of as_json in ORM agnostic code [@petergoldstein](https://github.com/petergoldstein)
709
- - [#142] Prevent double submission of password based authentication [@bdurand](https://github.com/bdurand)
710
- - documentation
711
- - [#141] Add rack-cors middleware to readme [@gottfrois](https://github.com/gottfrois)
712
-
713
- ## 0.4.2 - 2012-06-05
714
-
715
- - bugfixes:
716
- - [#94] Uninitialized Constant in Password Flow
717
-
718
- ## 0.4.1 - 2012-06-02
719
-
720
- - enhancements:
721
- - Backport: Move doorkeeper_for extension to Filter helper
722
-
723
- ## 0.4.0 - 2012-05-26
724
-
725
- - deprecation
726
- - Deprecate authorization_scopes
727
- - database changes
728
- - AccessToken#resource_owner_id is not nullable
729
- - enhancements
730
- - [#83] Add Resource Owner Password Credentials flow [@jaimeiniesta](https://github.com/jaimeiniesta)
731
- - [#76] Allow token expiration to be disabled [@mattgreen](https://github.com/mattgreen)
732
- - [#89] Configure the way client credentials are retrieved from request
733
- - [#b6470a] Add Client Credentials flow
734
- - internals
735
- - [#2ece8d, #f93778] Introduce Client and ErrorResponse classes
736
-
737
- ## 0.3.4 - 2012-05-24
738
-
739
- - Fix attr_accessible for rails 3.2.x
740
-
741
- ## 0.3.3 - 2012-05-07
742
-
743
- - [#86] shrink gem package size
744
-
745
- ## 0.3.2 - 2012-04-29
746
-
747
- - enhancements
748
- - [#54] Ignore Authorization: headers that are not Bearer [@miyagawa](https://github.com/miyagawa)
749
- - [#58, #64] Add destroy action to applications endpoint [@jaimeiniesta](https://github.com/jaimeiniesta), [@davidfrey](https://github.com/davidfrey)
750
- - [#63] TokensController responds with `401 unauthorized` [@jaimeiniesta](https://github.com/jaimeiniesta)
751
- - [#67, #72] Fix for mass-assignment [@cicloid](https://github.com/cicloid)
752
- - internals
753
- - [#49] Add Gemnasium status image to README [@laserlemon](https://github.com/laserlemon)
754
- - [#50] Fix typos [@tomekw](https://github.com/tomekw)
755
- - [#51] Updated the factory_girl_rails dependency, fix expires_in response which returned a float number instead of integer [@antekpiechnik](https://github.com/antekpiechnik)
756
- - [#62] Typos, .gitignore [@jaimeiniesta](https://github.com/jaimeiniesta)
757
- - [#65] Change _path redirections to _url redirections [@jaimeiniesta](https://github.com/jaimeiniesta)
758
- - [#75] Fix unknown method #authenticate_admin! [@mattgreen](https://github.com/mattgreen)
759
- - Remove application link in authorized app view
760
-
761
- ## 0.3.1 - 2012-02-17
762
-
763
- - enhancements
764
- - [#48] Add if, else options to doorkeeper_for
765
- - Add views generator
766
- - internals
767
- - Namespace models
768
-
769
- ## 0.3.0 - 2012-02-11
770
-
771
- - enhancements
772
- - [#17, #31] Add support for client credentials in basic auth header [@GoldsteinTechPartners](https://github.com/GoldsteinTechPartners)
773
- - [#28] Add indices to migration [@GoldsteinTechPartners](https://github.com/GoldsteinTechPartners)
774
- - [#29] Allow doorkeeper to run with rails 3.2 [@john-griffin](https://github.com/john-griffin)
775
- - [#30] Improve client's redirect uri validation [@GoldsteinTechPartners](https://github.com/GoldsteinTechPartners)
776
- - [#32] Add token (implicit grant) flow [@GoldsteinTechPartners](https://github.com/GoldsteinTechPartners)
777
- - [#34] Add support for custom unathorized responses [@GoldsteinTechPartners](https://github.com/GoldsteinTechPartners)
778
- - [#36] Remove repetitions from the Authorised Applications view [@carvil](https://github.com/carvil)
779
- - When user revoke an application, all tokens for that application are revoked
780
- - Error messages now can be translated
781
- - Install generator copies the error messages localization file
782
- - internals
783
- - Fix deprecation warnings in ActiveSupport::Base64
784
- - Remove deprecation in doorkeeper_for that handles hash arguments
785
- - Depends on railties instead of whole rails framework
786
- - CI now integrates with rails 3.1 and 3.2
787
-
788
- ## 0.2.0 - 2011-12-17
789
-
790
- - enhancements
791
- - [#4] Add authorized applications endpoint
792
- - [#5, #11] Add access token scopes
793
- - [#10] Add access token expiration by default
794
- - [#9, #12] Add refresh token flow
795
- - internals
796
- - [#7] Improve configuration options with :default
797
- - Improve configuration options with :builder
798
- - Refactor config class
799
- - Improve coverage of authorization request integration
800
- - bug fixes
801
- - [#6, #20] Fix access token response headers
802
- - Fix issue with state parameter
803
- - deprecation
804
- - deprecate :only and :except options in doorkeeper_for
805
-
806
- ## 0.1.1 - 2011-11-30
807
-
808
- - enhancements
809
- - [#3] Authorization code must be short lived and single use
810
- - [#2] Improve views provided by doorkeeper
811
- - [#1] Skips authorization form if the client has been authorized by the resource owner
812
- - Improve readme
813
- - bugfixes
814
- - Fix issue when creating the access token (wrong client id)
815
-
816
- ## 0.1.0 - 2011-11-25
817
-
818
- - Authorization Code flow
819
- - OAuth applications endpoint
1
+ Document moved [here](CHANGELOG.md)