doorkeeper 5.1.0 → 5.5.0

data/spec/controllers/applications_controller_spec.rb

@@ -1,180 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-module Doorkeeper
-  describe ApplicationsController do
-    context "JSON API" do
-      render_views
-
-      before do
-        allow(Doorkeeper.configuration).to receive(:api_only).and_return(true)
-        allow(Doorkeeper.configuration).to receive(:authenticate_admin).and_return(->(*) { true })
-      end
-
-      it "creates an application" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-              redirect_uri: "https://example.com",
-            }, format: :json,
-          }
-        end.to(change { Doorkeeper::Application.count })
-
-        expect(response).to be_successful
-
-        expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-
-        expect(json_response["name"]).to eq("Example")
-        expect(json_response["redirect_uri"]).to eq("https://example.com")
-      end
-
-      it "returns validation errors on wrong create params" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-            }, format: :json,
-          }
-        end.not_to(change { Doorkeeper::Application.count })
-
-        expect(response).to have_http_status(422)
-
-        expect(json_response).to include("errors")
-      end
-
-      it "returns application info" do
-        application = FactoryBot.create(:application, name: "Change me")
-
-        get :show, params: { id: application.id, format: :json }
-
-        expect(response).to be_successful
-
-        expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-      end
-
-      it "updates application" do
-        application = FactoryBot.create(:application, name: "Change me")
-
-        put :update, params: {
-          id: application.id,
-          doorkeeper_application: {
-            name: "Example App",
-            redirect_uri: "https://example.com",
-          }, format: :json,
-        }
-
-        expect(application.reload.name).to eq "Example App"
-
-        expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-      end
-
-      it "returns validation errors on wrong update params" do
-        application = FactoryBot.create(:application, name: "Change me")
-
-        put :update, params: {
-          id: application.id,
-          doorkeeper_application: {
-            name: "Example App",
-            redirect_uri: "localhost:3000",
-          }, format: :json,
-        }
-
-        expect(response).to have_http_status(422)
-
-        expect(json_response).to include("errors")
-      end
-
-      it "destroys an application" do
-        application = FactoryBot.create(:application)
-
-        delete :destroy, params: { id: application.id, format: :json }
-
-        expect(response).to have_http_status(204)
-        expect(Application.count).to be_zero
-      end
-    end
-
-    context "when admin is not authenticated" do
-      before do
-        allow(Doorkeeper.configuration).to receive(:authenticate_admin).and_return(proc do
-          redirect_to main_app.root_url
-        end)
-      end
-
-      it "redirects as set in Doorkeeper.authenticate_admin" do
-        get :index
-        expect(response).to redirect_to(controller.main_app.root_url)
-      end
-
-      it "does not create application" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-              redirect_uri: "https://example.com",
-            },
-          }
-        end.not_to(change { Doorkeeper::Application.count })
-      end
-    end
-
-    context "when admin is authenticated" do
-      render_views
-
-      before do
-        allow(Doorkeeper.configuration).to receive(:authenticate_admin).and_return(->(*) { true })
-      end
-
-      it "sorts applications by created_at" do
-        first_application = FactoryBot.create(:application)
-        second_application = FactoryBot.create(:application)
-        expect(Doorkeeper::Application).to receive(:ordered_by).and_call_original
-
-        get :index
-
-        expect(response.body).to have_selector("tbody tr:first-child#application_#{first_application.id}")
-        expect(response.body).to have_selector("tbody tr:last-child#application_#{second_application.id}")
-      end
-
-      it "creates application" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-              redirect_uri: "https://example.com",
-            },
-          }
-        end.to change { Doorkeeper::Application.count }.by(1)
-
-        expect(response).to be_redirect
-      end
-
-      it "does not allow mass assignment of uid or secret" do
-        application = FactoryBot.create(:application)
-        put :update, params: {
-          id: application.id,
-          doorkeeper_application: {
-            uid: "1A2B3C4D",
-            secret: "1A2B3C4D",
-          },
-        }
-
-        expect(application.reload.uid).not_to eq "1A2B3C4D"
-      end
-
-      it "updates application" do
-        application = FactoryBot.create(:application)
-        put :update, params: {
-          id: application.id, doorkeeper_application: {
-            name: "Example",
-            redirect_uri: "https://example.com",
-          },
-        }
-
-        expect(application.reload.name).to eq "Example"
-      end
-    end
-  end
-end

data/spec/controllers/authorizations_controller_spec.rb

@@ -1,527 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
-  include AuthorizationRequestHelper
-
-  class ActionDispatch::TestResponse
-    def query_params
-      @query_params ||= begin
-        fragment = URI.parse(location).fragment
-        Rack::Utils.parse_query(fragment)
-      end
-    end
-  end
-
-  def translated_error_message(key)
-    I18n.translate key, scope: %i[doorkeeper errors messages]
-  end
-
-  let(:client)        { FactoryBot.create :application }
-  let(:user)          { User.create!(name: "Joe", password: "sekret") }
-  let(:access_token)  { FactoryBot.build :access_token, resource_owner_id: user.id, application_id: client.id }
-
-  before do
-    Doorkeeper.configure do
-      custom_access_token_expires_in(lambda do |context|
-        context.grant_type == Doorkeeper::OAuth::IMPLICIT ? 1234 : nil
-      end)
-    end
-
-    allow(Doorkeeper.configuration).to receive(:grant_flows).and_return(["implicit"])
-    allow(controller).to receive(:current_resource_owner).and_return(user)
-  end
-
-  describe "POST #create" do
-    before do
-      post :create, params: { client_id: client.uid, response_type: "token", redirect_uri: client.redirect_uri }
-    end
-
-    it "redirects after authorization" do
-      expect(response).to be_redirect
-    end
-
-    it "redirects to client redirect uri" do
-      expect(response.location).to match(/^#{client.redirect_uri}/)
-    end
-
-    it "includes access token in fragment" do
-      expect(response.query_params["access_token"]).to eq(Doorkeeper::AccessToken.first.token)
-    end
-
-    it "includes token type in fragment" do
-      expect(response.query_params["token_type"]).to eq("Bearer")
-    end
-
-    it "includes token expiration in fragment" do
-      expect(response.query_params["expires_in"].to_i).to eq(1234)
-    end
-
-    it "issues the token for the current client" do
-      expect(Doorkeeper::AccessToken.first.application_id).to eq(client.id)
-    end
-
-    it "issues the token for the current resource owner" do
-      expect(Doorkeeper::AccessToken.first.resource_owner_id).to eq(user.id)
-    end
-  end
-
-  describe "POST #create in API mode" do
-    before do
-      allow(Doorkeeper.configuration).to receive(:api_only).and_return(true)
-      post :create, params: { client_id: client.uid, response_type: "token", redirect_uri: client.redirect_uri }
-    end
-
-    let(:response_json_body) { JSON.parse(response.body) }
-    let(:redirect_uri) { response_json_body["redirect_uri"] }
-
-    it "renders success after authorization" do
-      expect(response).to be_successful
-    end
-
-    it "renders correct redirect uri" do
-      expect(redirect_uri).to match(/^#{client.redirect_uri}/)
-    end
-
-    it "includes access token in fragment" do
-      expect(redirect_uri.match(/access_token=([a-zA-Z0-9\-_]+)&?/)[1]).to eq(Doorkeeper::AccessToken.first.token)
-    end
-
-    it "includes token type in fragment" do
-      expect(redirect_uri.match(/token_type=(\w+)&?/)[1]).to eq "Bearer"
-    end
-
-    it "includes token expiration in fragment" do
-      expect(redirect_uri.match(/expires_in=(\d+)&?/)[1].to_i).to eq 1234
-    end
-
-    it "issues the token for the current client" do
-      expect(Doorkeeper::AccessToken.first.application_id).to eq(client.id)
-    end
-
-    it "issues the token for the current resource owner" do
-      expect(Doorkeeper::AccessToken.first.resource_owner_id).to eq(user.id)
-    end
-  end
-
-  describe "POST #create with errors" do
-    before do
-      default_scopes_exist :public
-
-      post :create, params: {
-        client_id: client.uid,
-        response_type: "token",
-        scope: "invalid",
-        redirect_uri: client.redirect_uri,
-      }
-    end
-
-    it "redirects after authorization" do
-      expect(response).to be_redirect
-    end
-
-    it "redirects to client redirect uri" do
-      expect(response.location).to match(/^#{client.redirect_uri}/)
-    end
-
-    it "does not include access token in fragment" do
-      expect(response.query_params["access_token"]).to be_nil
-    end
-
-    it "includes error in fragment" do
-      expect(response.query_params["error"]).to eq("invalid_scope")
-    end
-
-    it "includes error description in fragment" do
-      expect(response.query_params["error_description"]).to eq(translated_error_message(:invalid_scope))
-    end
-
-    it "does not issue any access token" do
-      expect(Doorkeeper::AccessToken.all).to be_empty
-    end
-  end
-
-  describe "POST #create in API mode with errors" do
-    before do
-      allow(Doorkeeper.configuration).to receive(:api_only).and_return(true)
-      default_scopes_exist :public
-
-      post :create, params: {
-        client_id: client.uid,
-        response_type: "token",
-        scope: "invalid",
-        redirect_uri: client.redirect_uri,
-      }
-    end
-
-    let(:response_json_body) { JSON.parse(response.body) }
-    let(:redirect_uri) { response_json_body["redirect_uri"] }
-
-    it "renders 400 error" do
-      expect(response.status).to eq 400
-    end
-
-    it "includes correct redirect URI" do
-      expect(redirect_uri).to match(/^#{client.redirect_uri}/)
-    end
-
-    it "does not include access token in fragment" do
-      expect(redirect_uri.match(/access_token=([a-f0-9]+)&?/)).to be_nil
-    end
-
-    it "includes error in redirect uri" do
-      expect(redirect_uri.match(/error=([a-z_]+)&?/)[1]).to eq "invalid_scope"
-    end
-
-    it "includes error description in redirect uri" do
-      expect(redirect_uri.match(/error_description=(.+)&?/)[1]).to_not be_nil
-    end
-
-    it "does not issue any access token" do
-      expect(Doorkeeper::AccessToken.all).to be_empty
-    end
-  end
-
-  describe "POST #create with application already authorized" do
-    before do
-      allow(Doorkeeper.configuration).to receive(:reuse_access_token).and_return(true)
-
-      access_token.save!
-
-      post :create, params: {
-        client_id: client.uid,
-        response_type: "token",
-        redirect_uri: client.redirect_uri,
-      }
-    end
-
-    it "returns the existing access token in a fragment" do
-      expect(response.query_params["access_token"]).to eq(access_token.token)
-    end
-
-    it "does not creates a new access token" do
-      expect(Doorkeeper::AccessToken.count).to eq(1)
-    end
-  end
-
-  describe "POST #create with callbacks" do
-    after do
-      client.update_attribute :redirect_uri, "urn:ietf:wg:oauth:2.0:oob"
-    end
-
-    describe "when successful" do
-      after do
-        post :create, params: {
-          client_id: client.uid,
-          response_type: "token",
-          redirect_uri: client.redirect_uri,
-        }
-      end
-
-      it "should call :before_successful_authorization callback" do
-        expect(Doorkeeper.configuration)
-          .to receive_message_chain(:before_successful_authorization, :call).with(instance_of(described_class))
-      end
-
-      it "should call :after_successful_authorization callback" do
-        expect(Doorkeeper.configuration)
-          .to receive_message_chain(:after_successful_authorization, :call).with(instance_of(described_class))
-      end
-    end
-
-    describe "with errors" do
-      after do
-        post :create, params: { client_id: client.uid, response_type: "token", redirect_uri: "bad_uri" }
-      end
-
-      it "should not call :before_successful_authorization callback" do
-        expect(Doorkeeper.configuration).not_to receive(:before_successful_authorization)
-      end
-
-      it "should not call :after_successful_authorization callback" do
-        expect(Doorkeeper.configuration).not_to receive(:after_successful_authorization)
-      end
-    end
-  end
-
-  describe "GET #new token request with native url and skip_authorization true" do
-    before do
-      allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc do
-        true
-      end)
-
-      client.update_attribute :redirect_uri, "urn:ietf:wg:oauth:2.0:oob"
-
-      get :new, params: {
-        client_id: client.uid,
-        response_type: "token",
-        redirect_uri: client.redirect_uri,
-      }
-    end
-
-    it "should redirect immediately" do
-      expect(response).to be_redirect
-      expect(response.location).to match(%r{/oauth/token/info\?access_token=})
-    end
-
-    it "should not issue a grant" do
-      expect(Doorkeeper::AccessGrant.count).to be 0
-    end
-
-    it "should issue a token" do
-      expect(Doorkeeper::AccessToken.count).to be 1
-    end
-  end
-
-  describe "GET #new code request with native url and skip_authorization true" do
-    before do
-      allow(Doorkeeper.configuration).to receive(:grant_flows).and_return(%w[authorization_code])
-      allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc do
-        true
-      end)
-
-      client.update_attribute :redirect_uri, "urn:ietf:wg:oauth:2.0:oob"
-
-      get :new, params: {
-        client_id: client.uid,
-        response_type: "code",
-        redirect_uri: client.redirect_uri,
-      }
-    end
-
-    it "should redirect immediately" do
-      expect(response).to be_redirect
-      expect(response.location)
-        .to match(%r{/oauth/authorize/native\?code=#{Doorkeeper::AccessGrant.first.token}})
-    end
-
-    it "should issue a grant" do
-      expect(Doorkeeper::AccessGrant.count).to be 1
-    end
-
-    it "should not issue a token" do
-      expect(Doorkeeper::AccessToken.count).to be 0
-    end
-  end
-
-  describe "GET #new with skip_authorization true" do
-    before do
-      allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc do
-        true
-      end)
-
-      get :new, params: {
-        client_id: client.uid,
-        response_type: "token",
-        redirect_uri: client.redirect_uri,
-      }
-    end
-
-    it "should redirect immediately" do
-      expect(response).to be_redirect
-      expect(response.location).to match(/^#{client.redirect_uri}/)
-    end
-
-    it "should issue a token" do
-      expect(Doorkeeper::AccessToken.count).to be 1
-    end
-
-    it "includes token type in fragment" do
-      expect(response.query_params["token_type"]).to eq("Bearer")
-    end
-
-    it "includes token expiration in fragment" do
-      expect(response.query_params["expires_in"].to_i).to eq(1234)
-    end
-
-    it "issues the token for the current client" do
-      expect(Doorkeeper::AccessToken.first.application_id).to eq(client.id)
-    end
-
-    it "issues the token for the current resource owner" do
-      expect(Doorkeeper::AccessToken.first.resource_owner_id).to eq(user.id)
-    end
-  end
-
-  describe "GET #new in API mode" do
-    before do
-      allow(Doorkeeper.configuration).to receive(:api_only).and_return(true)
-
-      get :new, params: {
-        client_id: client.uid,
-        response_type: "token",
-        redirect_uri: client.redirect_uri,
-      }
-    end
-
-    it "should render success" do
-      expect(response).to be_successful
-    end
-
-    it "sets status to pre-authorization" do
-      expect(json_response["status"]).to eq(I18n.t("doorkeeper.pre_authorization.status"))
-    end
-
-    it "sets correct values" do
-      expect(json_response["client_id"]).to eq(client.uid)
-      expect(json_response["redirect_uri"]).to eq(client.redirect_uri)
-      expect(json_response["state"]).to be_nil
-      expect(json_response["response_type"]).to eq("token")
-      expect(json_response["scope"]).to eq("")
-    end
-  end
-
-  describe "GET #new in API mode with skip_authorization true" do
-    before do
-      allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc { true })
-      allow(Doorkeeper.configuration).to receive(:api_only).and_return(true)
-
-      get :new, params: {
-        client_id: client.uid,
-        response_type: "token",
-        redirect_uri: client.redirect_uri,
-      }
-    end
-
-    it "should render success" do
-      expect(response).to be_successful
-    end
-
-    it "should issue a token" do
-      expect(Doorkeeper::AccessToken.count).to be 1
-    end
-
-    it "sets status to redirect" do
-      expect(JSON.parse(response.body)["status"]).to eq("redirect")
-    end
-
-    it "sets redirect_uri to correct value" do
-      redirect_uri = JSON.parse(response.body)["redirect_uri"]
-      expect(redirect_uri).to_not be_nil
-      expect(redirect_uri.match(/token_type=(\w+)&?/)[1]).to eq "Bearer"
-      expect(redirect_uri.match(/expires_in=(\d+)&?/)[1].to_i).to eq 1234
-      expect(
-        redirect_uri.match(/access_token=([a-zA-Z0-9\-_]+)&?/)[1]
-      ).to eq Doorkeeper::AccessToken.first.token
-    end
-
-    it "issues the token for the current client" do
-      expect(Doorkeeper::AccessToken.first.application_id).to eq(client.id)
-    end
-
-    it "issues the token for the current resource owner" do
-      expect(Doorkeeper::AccessToken.first.resource_owner_id).to eq(user.id)
-    end
-  end
-
-  describe "GET #new with errors" do
-    before do
-      default_scopes_exist :public
-      get :new, params: { an_invalid: "request" }
-    end
-
-    it "does not redirect" do
-      expect(response).to_not be_redirect
-    end
-
-    it "does not issue any token" do
-      expect(Doorkeeper::AccessGrant.count).to eq 0
-      expect(Doorkeeper::AccessToken.count).to eq 0
-    end
-  end
-
-  describe "GET #new in API mode with errors" do
-    let(:response_json_body) { JSON.parse(response.body) }
-
-    before do
-      default_scopes_exist :public
-      allow(Doorkeeper.configuration).to receive(:api_only).and_return(true)
-      get :new, params: { an_invalid: "request" }
-    end
-
-    it "should render bad request" do
-      expect(response).to have_http_status(:bad_request)
-    end
-
-    it "includes error in body" do
-      expect(response_json_body["error"]).to eq("unsupported_response_type")
-    end
-
-    it "includes error description in body" do
-      expect(response_json_body["error_description"])
-        .to eq(translated_error_message(:unsupported_response_type))
-    end
-
-    it "does not issue any token" do
-      expect(Doorkeeper::AccessGrant.count).to eq 0
-      expect(Doorkeeper::AccessToken.count).to eq 0
-    end
-  end
-
-  describe "GET #new with callbacks" do
-    after do
-      client.update_attribute :redirect_uri, "urn:ietf:wg:oauth:2.0:oob"
-      get :new, params: { client_id: client.uid, response_type: "token", redirect_uri: client.redirect_uri }
-    end
-
-    describe "when authorizing" do
-      before do
-        allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc { true })
-      end
-
-      it "should call :before_successful_authorization callback" do
-        expect(Doorkeeper.configuration)
-          .to receive_message_chain(:before_successful_authorization, :call).with(instance_of(described_class))
-      end
-
-      it "should call :after_successful_authorization callback" do
-        expect(Doorkeeper.configuration)
-          .to receive_message_chain(:after_successful_authorization, :call).with(instance_of(described_class))
-      end
-    end
-
-    describe "when not authorizing" do
-      before do
-        allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc { false })
-      end
-
-      it "should not call :before_successful_authorization callback" do
-        expect(Doorkeeper.configuration).not_to receive(:before_successful_authorization)
-      end
-
-      it "should not call :after_successful_authorization callback" do
-        expect(Doorkeeper.configuration).not_to receive(:after_successful_authorization)
-      end
-    end
-
-    describe "when not authorizing in api mode" do
-      before do
-        allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc { false })
-        allow(Doorkeeper.configuration).to receive(:api_only).and_return(true)
-      end
-
-      it "should not call :before_successful_authorization callback" do
-        expect(Doorkeeper.configuration).not_to receive(:before_successful_authorization)
-      end
-
-      it "should not call :after_successful_authorization callback" do
-        expect(Doorkeeper.configuration).not_to receive(:after_successful_authorization)
-      end
-    end
-  end
-
-  describe "authorize response memoization" do
-    it "memoizes the result of the authorization" do
-      strategy = double(:strategy, authorize: true)
-      expect(strategy).to receive(:authorize).once
-      allow(controller).to receive(:strategy) { strategy }
-      allow(controller).to receive(:create) do
-        2.times { controller.send :authorize_response }
-        controller.render json: {}, status: :ok
-      end
-
-      post :create
-    end
-  end
-end