doorkeeper 4.4.3 → 5.5.2

data/spec/requests/flows/password_spec.rb

@@ -1,197 +0,0 @@
-require 'spec_helper_integration'
-
-describe 'Resource Owner Password Credentials Flow not set up' do
-  before do
-    client_exists
-    create_resource_owner
-  end
-
-  context 'with valid user credentials' do
-    it 'doesn\'t issue new token' do
-      expect do
-        post password_token_endpoint_url(client: @client, resource_owner: @resource_owner)
-      end.to_not(change { Doorkeeper::AccessToken.count })
-    end
-  end
-end
-
-describe 'Resource Owner Password Credentials Flow' do
-  let(:client_attributes) { {} }
-
-  before do
-    config_is_set(:grant_flows, ["password"])
-    config_is_set(:resource_owner_from_credentials) { User.authenticate! params[:username], params[:password] }
-    client_exists(client_attributes)
-    create_resource_owner
-  end
-
-  context 'with valid user credentials' do
-    context "with non-confidential/public client" do
-      let(:client_attributes) { { confidential: false } }
-
-      context "when client_secret absent" do
-        it "should issue new token" do
-          expect do
-            post password_token_endpoint_url(client_id: @client.uid, resource_owner: @resource_owner)
-          end.to change { Doorkeeper::AccessToken.count }.by(1)
-
-          token = Doorkeeper::AccessToken.first
-
-          expect(token.application_id).to eq @client.id
-          should_have_json 'access_token', token.token
-        end
-      end
-
-      context "when client_secret present" do
-        it "should issue new token" do
-          expect do
-            post password_token_endpoint_url(client: @client, resource_owner: @resource_owner)
-          end.to change { Doorkeeper::AccessToken.count }.by(1)
-
-          token = Doorkeeper::AccessToken.first
-
-          expect(token.application_id).to eq @client.id
-          should_have_json 'access_token', token.token
-        end
-
-        context "when client_secret incorrect" do
-          it "should not issue new token" do
-            expect do
-              post password_token_endpoint_url(client_id: @client.uid, client_secret: 'foobar', resource_owner: @resource_owner)
-            end.not_to(change { Doorkeeper::AccessToken.count })
-
-            expect(response).not_to be_ok
-          end
-        end
-      end
-    end
-
-    context "with confidential/private client" do
-      it "should issue new token" do
-        expect do
-          post password_token_endpoint_url(client: @client, resource_owner: @resource_owner)
-        end.to change { Doorkeeper::AccessToken.count }.by(1)
-
-        token = Doorkeeper::AccessToken.first
-
-        expect(token.application_id).to eq @client.id
-        should_have_json 'access_token', token.token
-      end
-
-      context "when client_secret absent" do
-        it "should not issue new token" do
-          expect do
-            post password_token_endpoint_url(client_id: @client.uid, resource_owner: @resource_owner)
-          end.not_to(change { Doorkeeper::AccessToken.count })
-
-          expect(response).not_to be_ok
-        end
-      end
-    end
-
-    it 'should issue new token without client credentials' do
-      expect do
-        post password_token_endpoint_url(resource_owner: @resource_owner)
-      end.to(change { Doorkeeper::AccessToken.count }.by(1))
-
-      token = Doorkeeper::AccessToken.first
-
-      expect(token.application_id).to be_nil
-      should_have_json 'access_token', token.token
-    end
-
-    it 'should issue a refresh token if enabled' do
-      config_is_set(:refresh_token_enabled, true)
-
-      post password_token_endpoint_url(client: @client, resource_owner: @resource_owner)
-
-      token = Doorkeeper::AccessToken.first
-
-      should_have_json 'refresh_token', token.refresh_token
-    end
-
-    it 'should return the same token if it is still accessible' do
-      allow(Doorkeeper.configuration).to receive(:reuse_access_token).and_return(true)
-
-      client_is_authorized(@client, @resource_owner)
-
-      post password_token_endpoint_url(client: @client, resource_owner: @resource_owner)
-
-      expect(Doorkeeper::AccessToken.count).to be(1)
-      should_have_json 'access_token', Doorkeeper::AccessToken.first.token
-    end
-
-    context 'with valid, default scope' do
-      before do
-        default_scopes_exist :public
-      end
-
-      it 'should issue new token' do
-        expect do
-          post password_token_endpoint_url(client: @client, resource_owner: @resource_owner, scope: 'public')
-        end.to change { Doorkeeper::AccessToken.count }.by(1)
-
-        token = Doorkeeper::AccessToken.first
-
-        expect(token.application_id).to eq @client.id
-        should_have_json 'access_token', token.token
-        should_have_json 'scope', 'public'
-      end
-    end
-  end
-
-  context 'with invalid scopes' do
-    subject do
-      post password_token_endpoint_url(client: @client,
-                                       resource_owner: @resource_owner,
-                                       scope: 'random')
-    end
-
-    it 'should not issue new token' do
-      expect { subject }.to_not(change { Doorkeeper::AccessToken.count })
-    end
-
-    it 'should return invalid_scope error' do
-      subject
-      should_have_json 'error', 'invalid_scope'
-      should_have_json 'error_description', translated_error_message(:invalid_scope)
-      should_not_have_json 'access_token'
-
-      expect(response.status).to eq(401)
-    end
-  end
-
-  context 'with invalid user credentials' do
-    it 'should not issue new token with bad password' do
-      expect do
-        post password_token_endpoint_url(client: @client,
-                                         resource_owner_username: @resource_owner.name,
-                                         resource_owner_password: 'wrongpassword')
-      end.to_not(change { Doorkeeper::AccessToken.count })
-    end
-
-    it 'should not issue new token without credentials' do
-      expect do
-        post password_token_endpoint_url(client: @client)
-      end.to_not(change { Doorkeeper::AccessToken.count })
-    end
-  end
-
-  context 'with invalid confidential client credentials' do
-    it 'should not issue new token with bad client credentials' do
-      expect do
-        post password_token_endpoint_url(client_id: @client.uid,
-                                         client_secret: 'bad_secret',
-                                         resource_owner: @resource_owner)
-      end.to_not(change { Doorkeeper::AccessToken.count })
-    end
-  end
-
-  context 'with invalid public client id' do
-    it 'should not issue new token with bad client id' do
-      expect do
-        post password_token_endpoint_url(client_id: 'bad_id', resource_owner: @resource_owner)
-      end.to_not(change { Doorkeeper::AccessToken.count })
-    end
-  end
-end

data/spec/requests/flows/refresh_token_spec.rb

@@ -1,174 +0,0 @@
-require 'spec_helper_integration'
-
-describe 'Refresh Token Flow' do
-  before do
-    Doorkeeper.configure do
-      orm DOORKEEPER_ORM
-      use_refresh_token
-    end
-    client_exists
-  end
-
-  context 'issuing a refresh token' do
-    before do
-      authorization_code_exists application: @client
-    end
-
-    it 'client gets the refresh token and refreshses it' do
-      post token_endpoint_url(code: @authorization.token, client: @client)
-
-      token = Doorkeeper::AccessToken.first
-
-      should_have_json 'access_token',  token.token
-      should_have_json 'refresh_token', token.refresh_token
-
-      expect(@authorization.reload).to be_revoked
-
-      post refresh_token_endpoint_url(client: @client, refresh_token: token.refresh_token)
-
-      new_token = Doorkeeper::AccessToken.last
-      should_have_json 'access_token',  new_token.token
-      should_have_json 'refresh_token', new_token.refresh_token
-
-      expect(token.token).not_to         eq(new_token.token)
-      expect(token.refresh_token).not_to eq(new_token.refresh_token)
-    end
-  end
-
-  context 'refreshing the token' do
-    before do
-      @token = FactoryBot.create(
-        :access_token,
-        application: @client,
-        resource_owner_id: 1,
-        use_refresh_token: true
-      )
-    end
-
-    context "refresh_token revoked on use" do
-      it 'client request a token with refresh token' do
-        post refresh_token_endpoint_url(
-          client: @client, refresh_token: @token.refresh_token
-        )
-        should_have_json(
-          'refresh_token', Doorkeeper::AccessToken.last.refresh_token
-        )
-        expect(@token.reload).not_to be_revoked
-      end
-
-      it 'client request a token with expired access token' do
-        @token.update_attribute :expires_in, -100
-        post refresh_token_endpoint_url(
-          client: @client, refresh_token: @token.refresh_token
-        )
-        should_have_json(
-          'refresh_token', Doorkeeper::AccessToken.last.refresh_token
-        )
-        expect(@token.reload).not_to be_revoked
-      end
-    end
-
-    context "refresh_token revoked on refresh_token request" do
-      before do
-        allow(Doorkeeper::AccessToken).to receive(:refresh_token_revoked_on_use?).and_return(false)
-      end
-
-      it 'client request a token with refresh token' do
-        post refresh_token_endpoint_url(
-          client: @client, refresh_token: @token.refresh_token
-        )
-        should_have_json(
-          'refresh_token', Doorkeeper::AccessToken.last.refresh_token
-        )
-        expect(@token.reload).to be_revoked
-      end
-
-      it 'client request a token with expired access token' do
-        @token.update_attribute :expires_in, -100
-        post refresh_token_endpoint_url(
-          client: @client, refresh_token: @token.refresh_token
-        )
-        should_have_json(
-          'refresh_token', Doorkeeper::AccessToken.last.refresh_token
-        )
-        expect(@token.reload).to be_revoked
-      end
-    end
-
-    it 'client gets an error for invalid refresh token' do
-      post refresh_token_endpoint_url(client: @client, refresh_token: 'invalid')
-      should_not_have_json 'refresh_token'
-      should_have_json 'error', 'invalid_grant'
-    end
-
-    it 'client gets an error for revoked access token' do
-      @token.revoke
-      post refresh_token_endpoint_url(client: @client, refresh_token: @token.refresh_token)
-      should_not_have_json 'refresh_token'
-      should_have_json 'error', 'invalid_grant'
-    end
-
-    it 'second of simultaneous client requests get an error for revoked access token' do
-      allow_any_instance_of(Doorkeeper::AccessToken).to receive(:revoked?).and_return(false, true)
-      post refresh_token_endpoint_url(client: @client, refresh_token: @token.refresh_token)
-
-      should_not_have_json 'refresh_token'
-      should_have_json 'error', 'invalid_request'
-    end
-  end
-
-  context 'refreshing the token with multiple sessions (devices)' do
-    before do
-      # enable password auth to simulate other devices
-      config_is_set(:grant_flows, ["password"])
-      config_is_set(:resource_owner_from_credentials) do
-        User.authenticate! params[:username], params[:password]
-      end
-      create_resource_owner
-      _another_token = post password_token_endpoint_url(
-        client: @client, resource_owner: @resource_owner
-      )
-      last_token.update_attribute :created_at, 5.seconds.ago
-
-      @token = FactoryBot.create(
-        :access_token,
-        application: @client,
-        resource_owner_id: @resource_owner.id,
-        use_refresh_token: true
-      )
-      @token.update_attribute :expires_in, -100
-    end
-
-    context "refresh_token revoked on use" do
-      it 'client request a token after creating another token with the same user' do
-        post refresh_token_endpoint_url(
-          client: @client, refresh_token: @token.refresh_token
-        )
-
-        should_have_json 'refresh_token', last_token.refresh_token
-        expect(@token.reload).not_to be_revoked
-      end
-    end
-
-    context "refresh_token revoked on refresh_token request" do
-      before do
-        allow(Doorkeeper::AccessToken).to receive(:refresh_token_revoked_on_use?).and_return(false)
-      end
-
-      it 'client request a token after creating another token with the same user' do
-        post refresh_token_endpoint_url(
-          client: @client, refresh_token: @token.refresh_token
-        )
-
-        should_have_json 'refresh_token', last_token.refresh_token
-        expect(@token.reload).to be_revoked
-      end
-    end
-
-    def last_token
-      Doorkeeper::AccessToken.last_authorized_token_for(
-        @client.id, @resource_owner.id
-      )
-    end
-  end
-end

data/spec/requests/flows/revoke_token_spec.rb

@@ -1,157 +0,0 @@
-require 'spec_helper_integration'
-
-describe 'Revoke Token Flow' do
-  before do
-    Doorkeeper.configure { orm DOORKEEPER_ORM }
-  end
-
-  context 'with default parameters' do
-    let(:client_application) { FactoryBot.create :application }
-    let(:resource_owner) { User.create!(name: 'John', password: 'sekret') }
-    let(:access_token) do
-      FactoryBot.create(:access_token,
-                         application: client_application,
-                         resource_owner_id: resource_owner.id,
-                         use_refresh_token: true)
-    end
-
-    context 'with authenticated, confidential OAuth 2.0 client/application' do
-      let(:headers) do
-        client_id = client_application.uid
-        client_secret = client_application.secret
-        credentials = Base64.encode64("#{client_id}:#{client_secret}")
-        { 'HTTP_AUTHORIZATION' => "Basic #{credentials}" }
-      end
-
-      it 'should revoke the access token provided' do
-        post revocation_token_endpoint_url, { token: access_token.token }, headers
-
-        access_token.reload
-
-        expect(response).to be_successful
-        expect(access_token.revoked?).to be_truthy
-      end
-
-      it 'should revoke the refresh token provided' do
-        post revocation_token_endpoint_url, { token: access_token.refresh_token }, headers
-
-        access_token.reload
-
-        expect(response).to be_successful
-        expect(access_token.revoked?).to be_truthy
-      end
-
-      context 'with invalid token to revoke' do
-        it 'should not revoke any tokens and respond successfully' do
-          num_prev_revoked_tokens = Doorkeeper::AccessToken.where(revoked_at: nil).count
-          post revocation_token_endpoint_url, { token: 'I_AM_AN_INVALID_TOKEN' }, headers
-
-          # The authorization server responds with HTTP status code 200 even if
-          # token is invalid
-          expect(response).to be_successful
-          expect(Doorkeeper::AccessToken.where(revoked_at: nil).count).to eq(num_prev_revoked_tokens)
-        end
-      end
-
-      context 'with bad credentials and a valid token' do
-        let(:headers) do
-          client_id = client_application.uid
-          credentials = Base64.encode64("#{client_id}:poop")
-          { 'HTTP_AUTHORIZATION' => "Basic #{credentials}" }
-        end
-        it 'should not revoke any tokens and respond successfully' do
-          post revocation_token_endpoint_url, { token: access_token.token }, headers
-
-          access_token.reload
-
-          expect(response).to be_successful
-          expect(access_token.revoked?).to be_falsey
-        end
-      end
-
-      context 'with no credentials and a valid token' do
-        it 'should not revoke any tokens and respond successfully' do
-          post revocation_token_endpoint_url, { token: access_token.token }
-
-          access_token.reload
-
-          expect(response).to be_successful
-          expect(access_token.revoked?).to be_falsey
-        end
-      end
-
-      context 'with valid token for another client application' do
-        let(:other_client_application) { FactoryBot.create :application }
-        let(:headers) do
-          client_id = other_client_application.uid
-          client_secret = other_client_application.secret
-          credentials = Base64.encode64("#{client_id}:#{client_secret}")
-          { 'HTTP_AUTHORIZATION' => "Basic #{credentials}" }
-        end
-
-        it 'should not revoke the token as its unauthorized' do
-          post revocation_token_endpoint_url, { token: access_token.token }, headers
-
-          access_token.reload
-
-          expect(response).to be_successful
-          expect(access_token.revoked?).to be_falsey
-        end
-      end
-    end
-
-    context 'with public OAuth 2.0 client/application' do
-      let(:access_token) do
-        FactoryBot.create(:access_token,
-                           application: nil,
-                           resource_owner_id: resource_owner.id,
-                           use_refresh_token: true)
-      end
-
-      it 'should revoke the access token provided' do
-        post revocation_token_endpoint_url, { token: access_token.token }
-
-        access_token.reload
-
-        expect(response).to be_successful
-        expect(access_token.revoked?).to be_truthy
-      end
-
-      it 'should revoke the refresh token provided' do
-        post revocation_token_endpoint_url, { token: access_token.refresh_token }
-
-        access_token.reload
-
-        expect(response).to be_successful
-        expect(access_token.revoked?).to be_truthy
-      end
-
-      context 'with a valid token issued for a confidential client' do
-        let(:access_token) do
-          FactoryBot.create(:access_token,
-                             application: client_application,
-                             resource_owner_id: resource_owner.id,
-                             use_refresh_token: true)
-        end
-
-        it 'should not revoke the access token provided' do
-          post revocation_token_endpoint_url, { token: access_token.token }
-
-          access_token.reload
-
-          expect(response).to be_successful
-          expect(access_token.revoked?).to be_falsey
-        end
-
-        it 'should not revoke the refresh token provided' do
-          post revocation_token_endpoint_url, { token: access_token.token }
-
-          access_token.reload
-
-          expect(response).to be_successful
-          expect(access_token.revoked?).to be_falsey
-        end
-      end
-    end
-  end
-end