doorkeeper 4.2.6 → 5.5.4

data/app/validators/redirect_uri_validator.rb

@@ -1,34 +0,0 @@
-require 'uri'
-
-class RedirectUriValidator < ActiveModel::EachValidator
-  def self.native_redirect_uri
-    Doorkeeper.configuration.native_redirect_uri
-  end
-
-  def validate_each(record, attribute, value)
-    if value.blank?
-      record.errors.add(attribute, :blank)
-    else
-      value.split.each do |val|
-        uri = ::URI.parse(val)
-        return if native_redirect_uri?(uri)
-        record.errors.add(attribute, :fragment_present) unless uri.fragment.nil?
-        record.errors.add(attribute, :relative_uri) if uri.scheme.nil? || uri.host.nil?
-        record.errors.add(attribute, :secured_uri) if invalid_ssl_uri?(uri)
-      end
-    end
-  rescue URI::InvalidURIError
-    record.errors.add(attribute, :invalid_uri)
-  end
-
-  private
-
-  def native_redirect_uri?(uri)
-    self.class.native_redirect_uri.present? && uri.to_s == self.class.native_redirect_uri.to_s
-  end
-
-  def invalid_ssl_uri?(uri)
-    forces_ssl = Doorkeeper.configuration.force_ssl_in_redirect_uri
-    forces_ssl && uri.try(:scheme) == 'http'
-  end
-end

data/doorkeeper.gemspec

@@ -1,29 +0,0 @@
-$LOAD_PATH.push File.expand_path("../lib", __FILE__)
-
-require "doorkeeper/version"
-
-Gem::Specification.new do |s|
-  s.name        = "doorkeeper"
-  s.version     = Doorkeeper::VERSION
-  s.authors     = ["Felipe Elias Philipp", "Tute Costa", "Jon Moss"]
-  s.email       = %w(me@jonathanmoss.me)
-  s.homepage    = "https://github.com/doorkeeper-gem/doorkeeper"
-  s.summary     = "OAuth 2 provider for Rails and Grape"
-  s.description = "Doorkeeper is an OAuth 2 provider for Rails and Grape."
-  s.license     = 'MIT'
-
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- spec/*`.split("\n")
-  s.require_paths = ["lib"]
-
-  s.add_dependency "railties", ">= 4.2"
-  s.required_ruby_version = ">= 2.1"
-
-  s.add_development_dependency "capybara"
-  s.add_development_dependency "coveralls"
-  s.add_development_dependency "database_cleaner", "~> 1.5.3"
-  s.add_development_dependency "factory_girl", "~> 4.7.0"
-  s.add_development_dependency "generator_spec", "~> 0.9.3"
-  s.add_development_dependency "rake", ">= 11.3.0"
-  s.add_development_dependency "rspec-rails"
-end

data/gemfiles/rails_4_2.gemfile

@@ -1,11 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", "~> 4.2.0"
-gem "appraisal"
-gem "activerecord-jdbcsqlite3-adapter", :platform => :jruby
-gem "sqlite3", :platform => [:ruby, :mswin, :mingw, :x64_mingw]
-gem "tzinfo-data", :platforms => [:mingw, :mswin, :x64_mingw]
-
-gemspec :path => "../"

data/gemfiles/rails_5_0.gemfile

@@ -1,12 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", "~> 5.0.0"
-gem "appraisal"
-gem "activerecord-jdbcsqlite3-adapter", :platform => :jruby
-gem "sqlite3", :platform => [:ruby, :mswin, :mingw, :x64_mingw]
-gem "tzinfo-data", :platforms => [:mingw, :mswin, :x64_mingw]
-gem "rspec-rails", "~> 3.5"
-
-gemspec :path => "../"

data/gemfiles/rails_5_1.gemfile

@@ -1,13 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", :github => "rails/rails"
-gem "appraisal"
-gem "activerecord-jdbcsqlite3-adapter", :platform => :jruby
-gem "sqlite3", :platform => [:ruby, :mswin, :mingw, :x64_mingw]
-gem "tzinfo-data", :platforms => [:mingw, :mswin, :x64_mingw]
-gem "arel", :github => "rails/arel"
-gem "rspec-rails", "~> 3.5"
-
-gemspec :path => "../"

data/lib/doorkeeper/oauth/client_credentials/validation.rb

@@ -1,45 +0,0 @@
-require 'doorkeeper/validations'
-require 'doorkeeper/oauth/scopes'
-require 'doorkeeper/oauth/helpers/scope_checker'
-
-module Doorkeeper
-  module OAuth
-    class ClientCredentialsRequest < BaseRequest
-      class Validation
-        include Validations
-        include OAuth::Helpers
-
-        validate :client, error: :invalid_client
-        validate :scopes, error: :invalid_scope
-
-        def initialize(server, request)
-          @server, @request, @client = server, request, request.client
-
-          validate
-        end
-
-        private
-
-        def validate_client
-          @client.present?
-        end
-
-        def validate_scopes
-          return true unless @request.scopes.present?
-
-          application_scopes = if @client.present?
-                                 @client.application.scopes
-                               else
-                                 ''
-                               end
-
-          ScopeChecker.valid?(
-            @request.scopes.to_s,
-            @server.scopes,
-            application_scopes
-          )
-        end
-      end
-    end
-  end
-end

data/lib/generators/doorkeeper/templates/add_owner_to_application_migration.rb

@@ -1,7 +0,0 @@
-class AddOwnerToApplication < ActiveRecord::Migration
-  def change
-    add_column :oauth_applications, :owner_id, :integer, null: true
-    add_column :oauth_applications, :owner_type, :string, null: true
-    add_index :oauth_applications, [:owner_id, :owner_type]
-  end
-end

data/lib/generators/doorkeeper/templates/add_previous_refresh_token_to_access_tokens.rb

@@ -1,11 +0,0 @@
-class AddPreviousRefreshTokenToAccessTokens < ActiveRecord::Migration
-  def change
-    add_column(
-      :oauth_access_tokens,
-      :previous_refresh_token,
-      :string,
-      default: "",
-      null: false
-    )
-  end
-end

data/lib/generators/doorkeeper/templates/migration.rb

@@ -1,68 +0,0 @@
-class CreateDoorkeeperTables < ActiveRecord::Migration
-  def change
-    create_table :oauth_applications do |t|
-      t.string  :name,         null: false
-      t.string  :uid,          null: false
-      t.string  :secret,       null: false
-      t.text    :redirect_uri, null: false
-      t.string  :scopes,       null: false, default: ''
-      t.timestamps             null: false
-    end
-
-    add_index :oauth_applications, :uid, unique: true
-
-    create_table :oauth_access_grants do |t|
-      t.integer  :resource_owner_id, null: false
-      t.references :application,     null: false
-      t.string   :token,             null: false
-      t.integer  :expires_in,        null: false
-      t.text     :redirect_uri,      null: false
-      t.datetime :created_at,        null: false
-      t.datetime :revoked_at
-      t.string   :scopes
-    end
-
-    add_index :oauth_access_grants, :token, unique: true
-    add_foreign_key(
-      :oauth_access_grants,
-      :oauth_applications,
-      column: :application_id
-    )
-
-    create_table :oauth_access_tokens do |t|
-      t.integer  :resource_owner_id
-      t.references :application
-
-      # If you use a custom token generator you may need to change this column
-      # from string to text, so that it accepts tokens larger than 255
-      # characters. More info on custom token generators in:
-      # https://github.com/doorkeeper-gem/doorkeeper/tree/v3.0.0.rc1#custom-access-token-generator
-      #
-      # t.text     :token,             null: false
-      t.string   :token,                  null: false
-
-      t.string   :refresh_token
-      t.integer  :expires_in
-      t.datetime :revoked_at
-      t.datetime :created_at,             null: false
-      t.string   :scopes
-
-      # If there is a previous_refresh_token column,
-      # refresh tokens will be revoked after a related access token is used.
-      # If there is no previous_refresh_token column,
-      # previous tokens are revoked as soon as a new access token is created.
-      # Comment out this line if you'd rather have refresh tokens
-      # instantly revoked.
-      t.string   :previous_refresh_token, null: false, default: ""
-    end
-
-    add_index :oauth_access_tokens, :token, unique: true
-    add_index :oauth_access_tokens, :resource_owner_id
-    add_index :oauth_access_tokens, :refresh_token, unique: true
-    add_foreign_key(
-      :oauth_access_tokens,
-      :oauth_applications,
-      column: :application_id
-    )
-  end
-end

data/spec/controllers/application_metal_controller.rb

@@ -1,10 +0,0 @@
-require "spec_helper_integration"
-
-describe Doorkeeper::ApplicationMetalController do
-  it "lazy run hooks" do
-    i = 0
-    ActiveSupport.on_load(:doorkeeper_metal_controller) { i += 1 }
-
-    expect(i).to eq 1
-  end
-end

data/spec/controllers/applications_controller_spec.rb

@@ -1,58 +0,0 @@
-require 'spec_helper_integration'
-
-module Doorkeeper
-  describe ApplicationsController do
-    context 'when admin is not authenticated' do
-      before do
-        allow(Doorkeeper.configuration).to receive(:authenticate_admin).and_return(proc do
-          redirect_to main_app.root_url
-        end)
-      end
-
-      it 'redirects as set in Doorkeeper.authenticate_admin' do
-        get :index
-        expect(response).to redirect_to(controller.main_app.root_url)
-      end
-
-      it 'does not create application' do
-        expect do
-          post :create, doorkeeper_application: {
-            name: 'Example',
-            redirect_uri: 'https://example.com' }
-        end.to_not change { Doorkeeper::Application.count }
-      end
-    end
-
-    context 'when admin is authenticated' do
-      before do
-        allow(Doorkeeper.configuration).to receive(:authenticate_admin).and_return(->(arg) { true })
-      end
-
-      it 'creates application' do
-        expect do
-          post :create, doorkeeper_application: {
-            name: 'Example',
-            redirect_uri: 'https://example.com' }
-        end.to change { Doorkeeper::Application.count }.by(1)
-        expect(response).to be_redirect
-      end
-
-      it 'does not allow mass assignment of uid or secret' do
-        application = FactoryGirl.create(:application)
-        put :update, id: application.id, doorkeeper_application: {
-          uid: '1A2B3C4D',
-          secret: '1A2B3C4D' }
-
-        expect(application.reload.uid).not_to eq '1A2B3C4D'
-      end
-
-      it 'updates application' do
-        application = FactoryGirl.create(:application)
-        put :update, id: application.id, doorkeeper_application: {
-          name: 'Example',
-          redirect_uri: 'https://example.com' }
-        expect(application.reload.name).to eq 'Example'
-      end
-    end
-  end
-end

data/spec/controllers/authorizations_controller_spec.rb

@@ -1,218 +0,0 @@
-require 'spec_helper_integration'
-
-describe Doorkeeper::AuthorizationsController, 'implicit grant flow' do
-  include AuthorizationRequestHelper
-
-  if Rails::VERSION::MAJOR == 5
-    class ActionDispatch::TestResponse
-      def query_params
-        @_query_params ||= begin
-          fragment = URI.parse(location).fragment
-          Rack::Utils.parse_query(fragment)
-        end
-      end
-    end
-  else
-    class ActionController::TestResponse
-      def query_params
-        @_query_params ||= begin
-          fragment = URI.parse(location).fragment
-          Rack::Utils.parse_query(fragment)
-        end
-      end
-    end
-  end
-
-  def translated_error_message(key)
-    I18n.translate key, scope: [:doorkeeper, :errors, :messages]
-  end
-
-  let(:client)        { FactoryGirl.create :application }
-  let(:user)          { User.create!(name: 'Joe', password: 'sekret') }
-  let(:access_token)  { FactoryGirl.build :access_token, resource_owner_id: user.id, application_id: client.id }
-
-  before do
-    allow(Doorkeeper.configuration).to receive(:grant_flows).and_return(["implicit"])
-    allow(controller).to receive(:current_resource_owner).and_return(user)
-  end
-
-  describe 'POST #create' do
-    before do
-      post :create, client_id: client.uid, response_type: 'token', redirect_uri: client.redirect_uri
-    end
-
-    it 'redirects after authorization' do
-      expect(response).to be_redirect
-    end
-
-    it 'redirects to client redirect uri' do
-      expect(response.location).to match(%r{^#{client.redirect_uri}})
-    end
-
-    it 'includes access token in fragment' do
-      expect(response.query_params['access_token']).to eq(Doorkeeper::AccessToken.first.token)
-    end
-
-    it 'includes token type in fragment' do
-      expect(response.query_params['token_type']).to eq('bearer')
-    end
-
-    it 'includes token expiration in fragment' do
-      expect(response.query_params['expires_in'].to_i).to eq(2.hours.to_i)
-    end
-
-    it 'issues the token for the current client' do
-      expect(Doorkeeper::AccessToken.first.application_id).to eq(client.id)
-    end
-
-    it 'issues the token for the current resource owner' do
-      expect(Doorkeeper::AccessToken.first.resource_owner_id).to eq(user.id)
-    end
-  end
-
-  describe 'POST #create with errors' do
-    before do
-      default_scopes_exist :public
-      post :create, client_id: client.uid, response_type: 'token', scope: 'invalid', redirect_uri: client.redirect_uri
-    end
-
-    it 'redirects after authorization' do
-      expect(response).to be_redirect
-    end
-
-    it 'redirects to client redirect uri' do
-      expect(response.location).to match(%r{^#{client.redirect_uri}})
-    end
-
-    it 'does not include access token in fragment' do
-      expect(response.query_params['access_token']).to be_nil
-    end
-
-    it 'includes error in fragment' do
-      expect(response.query_params['error']).to eq('invalid_scope')
-    end
-
-    it 'includes error description in fragment' do
-      expect(response.query_params['error_description']).to eq(translated_error_message(:invalid_scope))
-    end
-
-    it 'does not issue any access token' do
-      expect(Doorkeeper::AccessToken.all).to be_empty
-    end
-  end
-
-  describe 'POST #create with application already authorized' do
-    before do
-      allow(Doorkeeper.configuration).to receive(:reuse_access_token).and_return(true)
-
-      access_token.save!
-      post :create, client_id: client.uid, response_type: 'token', redirect_uri: client.redirect_uri
-    end
-
-    it 'returns the existing access token in a fragment' do
-      expect(response.query_params['access_token']).to eq(access_token.token)
-    end
-
-    it 'does not creates a new access token' do
-      expect(Doorkeeper::AccessToken.count).to eq(1)
-    end
-  end
-
-  describe 'GET #new token request with native url and skip_authorization true' do
-    before do
-      allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc do
-        true
-      end)
-      client.update_attribute :redirect_uri, 'urn:ietf:wg:oauth:2.0:oob'
-      get :new, client_id: client.uid, response_type: 'token', redirect_uri: client.redirect_uri
-    end
-
-    it 'should redirect immediately' do
-      expect(response).to be_redirect
-      expect(response.location).to match(/oauth\/token\/info\?access_token=/)
-    end
-
-    it 'should not issue a grant' do
-      expect(Doorkeeper::AccessGrant.count).to be 0
-    end
-
-    it 'should issue a token' do
-      expect(Doorkeeper::AccessToken.count).to be 1
-    end
-  end
-
-  describe 'GET #new code request with native url and skip_authorization true' do
-    before do
-      allow(Doorkeeper.configuration).to receive(:grant_flows).
-        and_return(%w(authorization_code))
-      allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc do
-        true
-      end)
-      client.update_attribute :redirect_uri, 'urn:ietf:wg:oauth:2.0:oob'
-      get :new, client_id: client.uid, response_type: 'code', redirect_uri: client.redirect_uri
-    end
-
-    it 'should redirect immediately' do
-      expect(response).to be_redirect
-      expect(response.location).to match(/oauth\/authorize\//)
-    end
-
-    it 'should issue a grant' do
-      expect(Doorkeeper::AccessGrant.count).to be 1
-    end
-
-    it 'should not issue a token' do
-      expect(Doorkeeper::AccessToken.count).to be 0
-    end
-  end
-
-  describe 'GET #new with skip_authorization true' do
-    before do
-      allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc do
-        true
-      end)
-      get :new, client_id: client.uid, response_type: 'token', redirect_uri: client.redirect_uri
-    end
-
-    it 'should redirect immediately' do
-      expect(response).to be_redirect
-      expect(response.location).to match(%r{^#{client.redirect_uri}})
-    end
-
-    it 'should issue a token' do
-      expect(Doorkeeper::AccessToken.count).to be 1
-    end
-
-    it 'includes token type in fragment' do
-      expect(response.query_params['token_type']).to eq('bearer')
-    end
-
-    it 'includes token expiration in fragment' do
-      expect(response.query_params['expires_in'].to_i).to eq(2.hours.to_i)
-    end
-
-    it 'issues the token for the current client' do
-      expect(Doorkeeper::AccessToken.first.application_id).to eq(client.id)
-    end
-
-    it 'issues the token for the current resource owner' do
-      expect(Doorkeeper::AccessToken.first.resource_owner_id).to eq(user.id)
-    end
-  end
-
-  describe 'GET #new with errors' do
-    before do
-      default_scopes_exist :public
-      get :new, an_invalid: 'request'
-    end
-
-    it 'does not redirect' do
-      expect(response).to_not be_redirect
-    end
-
-    it 'does not issue any token' do
-      expect(Doorkeeper::AccessGrant.count).to eq 0
-      expect(Doorkeeper::AccessToken.count).to eq 0
-    end
-  end
-end