doorkeeper-mongodb 5.2.3 → 5.4.0

data/spec/controllers/applications_controller_spec.rb

@@ -1,270 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-RSpec.describe Doorkeeper::ApplicationsController do
-  render_views
-
-  context "when JSON API used" do
-    before do
-      allow(Doorkeeper.configuration).to receive(:api_only).and_return(true)
-      allow(Doorkeeper.configuration).to receive(:authenticate_admin).and_return(->(*) { true })
-    end
-
-    it "creates an application" do
-      expect do
-        post :create, params: {
-          doorkeeper_application: {
-            name: "Example",
-            redirect_uri: "https://example.com",
-          }, format: :json,
-        }
-      end.to(change { Doorkeeper::Application.count })
-
-      expect(response).to be_successful
-
-      expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-
-      application = Doorkeeper::Application.last
-      secret_from_response = json_response["secret"]
-      expect(application).to be_secret_matches(secret_from_response)
-
-      expect(json_response["name"]).to eq("Example")
-      expect(json_response["redirect_uri"]).to eq("https://example.com")
-    end
-
-    it "returns validation errors on wrong create params" do
-      expect do
-        post :create, params: {
-          doorkeeper_application: {
-            name: "Example",
-          }, format: :json,
-        }
-      end.not_to(change { Doorkeeper::Application.count })
-
-      expect(response).to have_http_status(422)
-
-      expect(json_response).to include("errors")
-    end
-
-    it "returns validations on wrong create params (unspecified scheme)" do
-      expect do
-        post :create, params: {
-          doorkeeper_application: {
-            name: "Example",
-            redirect_uri: "app.com:80",
-          }, format: :json,
-        }
-      end.not_to(change { Doorkeeper::Application.count })
-
-      expect(response).to have_http_status(422)
-
-      expect(json_response).to include("errors")
-    end
-
-    it "returns application info" do
-      application = FactoryBot.create(:application, name: "Change me")
-
-      get :show, params: { id: application.id, format: :json }
-
-      expect(response).to be_successful
-
-      expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-    end
-
-    it "updates application" do
-      application = FactoryBot.create(:application, name: "Change me")
-
-      put :update, params: {
-        id: application.id,
-        doorkeeper_application: {
-          name: "Example App",
-          redirect_uri: "https://example.com",
-        }, format: :json,
-      }
-
-      expect(application.reload.name).to eq "Example App"
-
-      expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-    end
-
-    it "returns validation errors on wrong update params" do
-      application = FactoryBot.create(:application, name: "Change me")
-
-      put :update, params: {
-        id: application.id,
-        doorkeeper_application: {
-          name: "Example App",
-          redirect_uri: "localhost:3000",
-        }, format: :json,
-      }
-
-      expect(response).to have_http_status(422)
-
-      expect(json_response).to include("errors")
-    end
-
-    it "destroys an application" do
-      application = FactoryBot.create(:application)
-
-      delete :destroy, params: { id: application.id, format: :json }
-
-      expect(response).to have_http_status(204)
-      expect(Doorkeeper::Application.count).to be_zero
-    end
-  end
-
-  context "when admin is not authenticated" do
-    before do
-      allow(Doorkeeper.config).to receive(:authenticate_admin).and_return(proc do
-        redirect_to main_app.root_url
-      end)
-    end
-
-    it "redirects as set in Doorkeeper.authenticate_admin" do
-      get :index
-      expect(response).to redirect_to(controller.main_app.root_url)
-    end
-
-    it "does not create application" do
-      expect do
-        post :create, params: {
-          doorkeeper_application: {
-            name: "Example",
-            redirect_uri: "https://example.com",
-          },
-        }
-      end.not_to(change { Doorkeeper::Application.count })
-    end
-  end
-
-  context "when admin is authenticated" do
-    before do
-      allow(Doorkeeper.configuration).to receive(:authenticate_admin).and_return(->(*) { true })
-    end
-
-    context "when application secrets are hashed" do
-      before do
-        allow(Doorkeeper.configuration)
-          .to receive(:application_secret_strategy).and_return(Doorkeeper::SecretStoring::Sha256Hash)
-      end
-
-      it "shows the application secret after creating a new application" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-              redirect_uri: "https://example.com",
-            },
-          }
-        end.to change { Doorkeeper::Application.count }.by(1)
-
-        application = Doorkeeper::Application.last
-
-        secret_from_flash = flash[:application_secret]
-        expect(secret_from_flash).not_to be_empty
-        expect(application).to be_secret_matches(secret_from_flash)
-        expect(response).to redirect_to(controller.main_app.oauth_application_url(application.id))
-
-        get :show, params: { id: application.id, format: :html }
-
-        # We don't know the application secret here (because its hashed) so we can not assert its text on the page
-        # Instead, we read it from the page and then check if it matches the application secret
-        code_element = /code.*id="secret">\s*\K([^<]*)/m.match(response.body)
-        secret_from_page = code_element[1].strip
-
-        expect(response.body).to have_selector("code#application_id", text: application.uid)
-        expect(response.body).to have_selector("code#secret")
-        expect(secret_from_page).not_to be_empty
-        expect(application).to be_secret_matches(secret_from_page)
-      end
-
-      it "does not show an application secret when application did already exist" do
-        application = FactoryBot.create(:application)
-        get :show, params: { id: application.id, format: :html }
-
-        expect(response.body).to have_selector("code#application_id", text: application.uid)
-        expect(response.body).to have_selector("code#secret", text: "")
-      end
-
-      it "returns the application details in a json response" do
-        expect do
-          post :create, params: {
-            doorkeeper_application: {
-              name: "Example",
-              redirect_uri: "https://example.com",
-            }, format: :json,
-          }
-        end.to(change { Doorkeeper::Application.count })
-
-        expect(response).to be_successful
-
-        expect(json_response).to include("id", "name", "uid", "secret", "redirect_uri", "scopes")
-
-        application = Doorkeeper::Application.last
-        secret_from_response = json_response["secret"]
-        expect(application).to be_secret_matches(secret_from_response)
-
-        expect(json_response["name"]).to eq("Example")
-        expect(json_response["redirect_uri"]).to eq("https://example.com")
-      end
-    end
-
-    it "sorts applications by created_at" do
-      first_application = FactoryBot.create(:application)
-      second_application = FactoryBot.create(:application)
-      expect(Doorkeeper::Application).to receive(:ordered_by).and_call_original
-
-      get :index
-
-      expect(response.body).to have_selector("tbody tr:first-child#application_#{first_application.id}")
-      expect(response.body).to have_selector("tbody tr:last-child#application_#{second_application.id}")
-    end
-
-    it "creates application" do
-      expect do
-        post :create, params: {
-          doorkeeper_application: {
-            name: "Example",
-            redirect_uri: "https://example.com",
-          },
-        }
-      end.to change { Doorkeeper::Application.count }.by(1)
-
-      expect(response).to be_redirect
-    end
-
-    it "shows application details" do
-      application = FactoryBot.create(:application)
-      get :show, params: { id: application.id, format: :html }
-
-      expect(response.body).to have_selector("code#application_id", text: application.uid)
-      expect(response.body).to have_selector("code#secret", text: application.plaintext_secret)
-    end
-
-    it "does not allow mass assignment of uid or secret" do
-      application = FactoryBot.create(:application)
-      put :update, params: {
-        id: application.id,
-        doorkeeper_application: {
-          uid: "1A2B3C4D",
-          secret: "1A2B3C4D",
-        },
-      }
-
-      expect(application.reload.uid).not_to eq "1A2B3C4D"
-    end
-
-    it "updates application" do
-      application = FactoryBot.create(:application)
-      put :update, params: {
-        id: application.id, doorkeeper_application: {
-          name: "Example",
-          redirect_uri: "https://example.com",
-        },
-      }
-
-      expect(application.reload.name).to eq "Example"
-    end
-  end
-end