doorkeeper-mongodb 5.2.1 → 5.2.3

data/spec/controllers/authorizations_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
+RSpec.describe Doorkeeper::AuthorizationsController do
   include AuthorizationRequestHelper
 
   class ActionDispatch::TestResponse
@@ -14,8 +14,8 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
     end
   end
 
-  let(:client)        { FactoryBot.create :application }
-  let(:user)          { User.create!(name: "Joe", password: "sekret") }
+  let(:client) { FactoryBot.create :application }
+  let(:user) { User.create!(name: "Joe", password: "sekret") }
 
   let(:access_token) do
     FactoryBot.build :access_token,
@@ -27,6 +27,7 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
 
   before do
     Doorkeeper.configure do
+      orm DOORKEEPER_ORM
       default_scopes :default
 
       custom_access_token_expires_in(lambda do |context|
@@ -37,7 +38,6 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
     allow(Doorkeeper.config).to receive(:grant_flows).and_return(["implicit"])
     allow(Doorkeeper.config).to receive(:authenticate_resource_owner).and_return(->(_) { authenticator_method })
     allow(controller).to receive(:authenticator_method).and_return(user)
-    expect(controller).to receive(:authenticator_method).at_most(:once)
   end
 
   describe "POST #create" do
@@ -47,6 +47,7 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
 
     it "redirects after authorization" do
       expect(response).to be_redirect
+      expect(controller).to receive(:authenticator_method).at_most(:once)
     end
 
     it "redirects to client redirect uri" do
@@ -311,7 +312,7 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
       end
 
       it "includes error description in redirect uri" do
-        expect(redirect_uri.match(/error_description=(.+)&?/)[1]).to_not be_nil
+        expect(redirect_uri.match(/error_description=(.+)&?/)[1]).not_to be_nil
       end
 
       it "does not issue any access token" do
@@ -356,13 +357,13 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
         }
       end
 
-      it "should call :before_successful_authorization callback" do
+      it "calls :before_successful_authorization callback" do
         expect(Doorkeeper.config)
           .to receive_message_chain(:before_successful_authorization, :call)
           .with(instance_of(described_class), instance_of(Doorkeeper::OAuth::Hooks::Context))
       end
 
-      it "should call :after_successful_authorization callback" do
+      it "calls :after_successful_authorization callback" do
         expect(Doorkeeper.config)
           .to receive_message_chain(:after_successful_authorization, :call)
           .with(instance_of(described_class), instance_of(Doorkeeper::OAuth::Hooks::Context))
@@ -374,11 +375,11 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
         post :create, params: { client_id: client.uid, response_type: "token", redirect_uri: "bad_uri" }
       end
 
-      it "should not call :before_successful_authorization callback" do
+      it "does not call :before_successful_authorization callback" do
         expect(Doorkeeper.config).not_to receive(:before_successful_authorization)
       end
 
-      it "should not call :after_successful_authorization callback" do
+      it "does not call :after_successful_authorization callback" do
         expect(Doorkeeper.config).not_to receive(:after_successful_authorization)
       end
     end
@@ -399,16 +400,16 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
       }
     end
 
-    it "should redirect immediately" do
+    it "redirects immediately" do
       expect(response).to be_redirect
       expect(response.location).to match(%r{/oauth/token/info\?access_token=})
     end
 
-    it "should not issue a grant" do
+    it "does not issue a grant" do
       expect(Doorkeeper::AccessGrant.count).to be 0
     end
 
-    it "should issue a token" do
+    it "issues a token" do
       expect(Doorkeeper::AccessToken.count).to be 1
     end
   end
@@ -429,17 +430,17 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
       }
     end
 
-    it "should redirect immediately" do
+    it "redirects immediately" do
       expect(response).to be_redirect
       expect(response.location)
         .to match(%r{/oauth/authorize/native\?code=#{Doorkeeper::AccessGrant.first.token}})
     end
 
-    it "should issue a grant" do
+    it "issues a grant" do
       expect(Doorkeeper::AccessGrant.count).to be 1
     end
 
-    it "should not issue a token" do
+    it "does not issue a token" do
       expect(Doorkeeper::AccessToken.count).to be 0
     end
   end
@@ -457,12 +458,12 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
       }
     end
 
-    it "should redirect immediately" do
+    it "redirects immediately" do
       expect(response).to be_redirect
       expect(response.location).to match(/^#{client.redirect_uri}/)
     end
 
-    it "should issue a token" do
+    it "issues a token" do
       expect(Doorkeeper::AccessToken.count).to be 1
     end
 
@@ -494,7 +495,7 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
       }
     end
 
-    it "should render success" do
+    it "renders success" do
       expect(response).to be_successful
     end
 
@@ -523,11 +524,11 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
       }
     end
 
-    it "should render success" do
+    it "renders success" do
       expect(response).to be_successful
     end
 
-    it "should issue a token" do
+    it "issues a token" do
       expect(Doorkeeper::AccessToken.count).to be 1
     end
 
@@ -537,7 +538,7 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
 
     it "sets redirect_uri to correct value" do
       redirect_uri = JSON.parse(response.body)["redirect_uri"]
-      expect(redirect_uri).to_not be_nil
+      expect(redirect_uri).not_to be_nil
       expect(redirect_uri.match(/token_type=(\w+)&?/)[1]).to eq "Bearer"
       expect(redirect_uri.match(/expires_in=(\d+)&?/)[1].to_i).to eq 1234
       expect(
@@ -562,7 +563,7 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
       end
 
       it "does not redirect" do
-        expect(response).to_not be_redirect
+        expect(response).not_to be_redirect
       end
 
       it "does not issue any token" do
@@ -583,7 +584,7 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
       end
 
       it "does not redirect" do
-        expect(response).to_not be_redirect
+        expect(response).not_to be_redirect
       end
 
       it "does not issue any token" do
@@ -606,7 +607,7 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
 
       let(:response_json_body) { JSON.parse(response.body) }
 
-      it "should render bad request" do
+      it "renders bad request" do
         expect(response).to have_http_status(:bad_request)
       end
 
@@ -638,7 +639,7 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
 
       let(:response_json_body) { JSON.parse(response.body) }
 
-      it "should render bad request" do
+      it "renders bad request" do
         expect(response).to have_http_status(:bad_request)
       end
 
@@ -669,13 +670,13 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
         allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc { true })
       end
 
-      it "should call :before_successful_authorization callback" do
+      it "calls :before_successful_authorization callback" do
         expect(Doorkeeper.configuration)
           .to receive_message_chain(:before_successful_authorization, :call)
           .with(instance_of(described_class), instance_of(Doorkeeper::OAuth::Hooks::Context))
       end
 
-      it "should call :after_successful_authorization callback" do
+      it "calls :after_successful_authorization callback" do
         expect(Doorkeeper.configuration)
           .to receive_message_chain(:after_successful_authorization, :call)
           .with(instance_of(described_class), instance_of(Doorkeeper::OAuth::Hooks::Context))
@@ -687,11 +688,11 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
         allow(Doorkeeper.configuration).to receive(:skip_authorization).and_return(proc { false })
       end
 
-      it "should not call :before_successful_authorization callback" do
+      it "does not call :before_successful_authorization callback" do
         expect(Doorkeeper.configuration).not_to receive(:before_successful_authorization)
       end
 
-      it "should not call :after_successful_authorization callback" do
+      it "does not call :after_successful_authorization callback" do
         expect(Doorkeeper.configuration).not_to receive(:after_successful_authorization)
       end
     end
@@ -702,11 +703,11 @@ describe Doorkeeper::AuthorizationsController, "implicit grant flow" do
         allow(Doorkeeper.configuration).to receive(:api_only).and_return(true)
       end
 
-      it "should not call :before_successful_authorization callback" do
+      it "does not call :before_successful_authorization callback" do
         expect(Doorkeeper.configuration).not_to receive(:before_successful_authorization)
       end
 
-      it "should not call :after_successful_authorization callback" do
+      it "does not call :after_successful_authorization callback" do
         expect(Doorkeeper.configuration).not_to receive(:after_successful_authorization)
       end
     end

data/spec/controllers/protected_resources_controller_spec.rb

@@ -16,8 +16,8 @@ module ControllerActions
   def doorkeeper_forbidden_render_options(*); end
 end
 
-describe "doorkeeper authorize filter" do
-  context "accepts token code specified as" do
+RSpec.describe "doorkeeper authorize filter" do
+  context "when accepts token code specified as" do
     controller do
       before_action :doorkeeper_authorize!
 
@@ -58,7 +58,7 @@ describe "doorkeeper authorize filter" do
     end
 
     it "does not change Authorization header value" do
-      expect(Doorkeeper::AccessToken).to receive(:by_token).exactly(2).times.and_return(token)
+      expect(Doorkeeper::AccessToken).to receive(:by_token).twice.and_return(token)
       request.env["HTTP_AUTHORIZATION"] = "Bearer #{token_string}"
       get :index
       controller.send(:remove_instance_variable, :@doorkeeper_token)
@@ -66,7 +66,7 @@ describe "doorkeeper authorize filter" do
     end
   end
 
-  context "defined for all actions" do
+  context "when defined for all actions" do
     controller do
       before_action :doorkeeper_authorize!
 
@@ -100,7 +100,7 @@ describe "doorkeeper authorize filter" do
     end
   end
 
-  context "defined with scopes" do
+  context "when defined with scopes" do
     controller do
       before_action -> { doorkeeper_authorize! :write }
 
@@ -139,7 +139,7 @@ describe "doorkeeper authorize filter" do
 
       get :index, params: { access_token: token_string }
       expect(response.status).to eq 403
-      expect(response.header).to_not include("WWW-Authenticate")
+      expect(response.header).not_to include("WWW-Authenticate")
     end
   end
 
@@ -169,7 +169,7 @@ describe "doorkeeper authorize filter" do
         end
       end
 
-      it "it renders a custom JSON response", token: :invalid do
+      it "renders a custom JSON response", token: :invalid do
         get :index, params: { access_token: token_string }
         expect(response.status).to eq 401
         expect(response.content_type).to include("application/json")
@@ -199,7 +199,7 @@ describe "doorkeeper authorize filter" do
         end
       end
 
-      it "it renders a custom text response", token: :invalid do
+      it "renders a custom text response", token: :invalid do
         get :index, params: { access_token: token_string }
         expect(response.status).to eq 401
         expect(response.content_type).to include("text/plain")
@@ -253,7 +253,7 @@ describe "doorkeeper authorize filter" do
 
       it "renders a custom JSON response" do
         get :index, params: { access_token: token_string }
-        expect(response.header).to_not include("WWW-Authenticate")
+        expect(response.header).not_to include("WWW-Authenticate")
         expect(response.content_type).to include("application/json")
         expect(response.status).to eq 403
 
@@ -292,7 +292,7 @@ describe "doorkeeper authorize filter" do
 
       it "renders a custom status code and text response" do
         get :index, params: { access_token: token_string }
-        expect(response.header).to_not include("WWW-Authenticate")
+        expect(response.header).not_to include("WWW-Authenticate")
         expect(response.status).to eq 403
         expect(response.body).to eq("Forbidden")
       end

data/spec/controllers/token_info_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe Doorkeeper::TokenInfoController do
+RSpec.describe Doorkeeper::TokenInfoController do
   describe "when requesting token info with valid token" do
     let(:doorkeeper_token) { FactoryBot.create(:access_token) }