dommy-rails 0.11.0 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 50d6da0920fbd92140fcbba4bb15ca4a0b3290827746785c8d5c46e55caaab0c
-  data.tar.gz: d9788d25d33b9d74b7bc7ff5e06e15b754391d0ab841de86f870282ca22dd6cb
+  metadata.gz: decdc2f02ac2d15f9f1447da1f008fd9b406bb3c423f16c70f7d1c1251d25b45
+  data.tar.gz: 61baf3154db33257f6e508ccc15b21c3274708ad1444fb13495d6bfff2cc4a24
 SHA512:
-  metadata.gz: cbe6783f0111e3034bd2c26adb2a947f0b43337db68911679af0cdc7892a7a387a082f300c36fca0448b773b0b4cb509a77611fde462249207616c3d86985966
-  data.tar.gz: f52246bc241b4a4e67e1fc3ac0fa3cc194bf42895c484291e38f98aedb00fe17cc653aee5482b0470622b357102d9b7facc08de1b59414f75a5499a839756624
+  metadata.gz: 55439022b061482154d59c057654a8010edf7f7c1cf430cae0edfc4eb91e23822ea779d97acbe128820519642e699c4fd8fa2918e584d05503eae401fb66b3a2
+  data.tar.gz: 5f307f03a7c9b6e745486ca6ef23a882ce0af09abe6d387708b21de98409aae35f6dc8fc90f0074ab62ee2fc947fb9bf7579c6e734383cc81a86eb9fe5d12e3c

data/lib/dommy/rails/browser_spec.rb

@@ -75,8 +75,8 @@ module Dommy
           # Rails-internals spans (controller/SQL/render/job/mail) on every
           # traced request; idempotent, no-op without ActiveSupport.
           Dommy::Rails::TraceInstrumentation.install!
-          ::Dommy::Rack::Session.new(dommy_browser_app, javascript: true, trace: true, trace_dom: true,
-            trace_snapshots: true)
+          ::Dommy::Rack::Session.new(dommy_browser_app, javascript: true, strict_js_errors: true,
+            trace: true, trace_dom: true, trace_snapshots: true)
         end
       end
 
@@ -87,25 +87,24 @@ module Dommy
 
       # Suppress strict JS-error failure for errors raised inside the block (they
       # stay in `browser.js_errors`). For specs that intentionally trigger one.
-      def allow_js_errors
-        @dommy_allow_js_errors = true
-        yield
-      ensure
-        dommy_browser_ack_js_errors
+      # A page that handles its own errors needs nothing here: it never reaches
+      # the log, just as it never reaches a browser console.
+      def allow_js_errors(&block)
+        browser.allow_js_errors(&block)
       end
 
-      # Dispose the browser and fail if uncaught JS errors were collected. Call
-      # from a Minitest #teardown / RSpec after hook (the integration modules
-      # wire this automatically).
+      # Dispose the browser, which fails the spec if the page left JS errors
+      # unhandled and nobody reported them. Call from a Minitest #teardown /
+      # RSpec after hook (the integration modules wire this automatically).
+      #
+      # The session checks at every step too, so a failure normally surfaces on
+      # the line that caused it; this catches whatever the last step produced.
       def dommy_browser_teardown
         return unless browser_started?
 
-        pending = browser.js_errors[(@dommy_browser_acked || 0)..] || []
-        browser.dispose
+        browser_to_dispose = browser
         @dommy_browser = nil
-        return if @dommy_allow_js_errors || pending.empty?
-
-        raise dommy_browser_js_error(pending)
+        browser_to_dispose.dispose
       end
 
       private
@@ -146,15 +145,6 @@ module Dommy
         slug = label.to_s.strip.downcase.gsub(/[^a-z0-9]+/, "-").gsub(/\A-+|-+\z/, "")
         slug.empty? ? "example" : slug[0, 100]
       end
-
-      def dommy_browser_ack_js_errors
-        @dommy_browser_acked = browser_started? ? browser.js_errors.length : 0
-      end
-
-      def dommy_browser_js_error(errors)
-        lines = errors.map { |e| "  #{e.class}: #{e.message}" }
-        RuntimeError.new("#{errors.length} uncaught JS error(s) during the spec:\n#{lines.join("\n")}")
-      end
     end
   end
 end

data/lib/dommy/rails/version.rb

@@ -1,5 +1,5 @@
 module Dommy
   module Rails
-    VERSION = "0.11.0"
+    VERSION = "0.13.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dommy-rails
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.13.0
 platform: ruby
 authors:
 - takahashim
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.13.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.13.0
 description: Rails-specific matchers and assertions for Dommy, including form helper
   understanding, Turbo Stream support, Stimulus attribute checking, and HTML quality
   linting.