domino 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3059a81fc3233b83f748c35d895915d477778062
-  data.tar.gz: 5ba1c3b35b0b12919712ad789dd3a50d8b4d2fea
+  metadata.gz: ef317e23fa5c56cda925292542b5c21a9427da0f
+  data.tar.gz: 8569c3441566aa337bbf547f21e51f6b426c9fd1
 SHA512:
-  metadata.gz: 629bc9d4a700d9161ba1cc46953556fb42ad6d447a5d90ee64a5d410eb416a6095ef57c9a5bf94dd96ba664d335a4e095ee4e245fec6c69298aa4211672d0e84
-  data.tar.gz: 9edb66f4135a320f85836e9e2c04af3f8eee8245cf8ea6c040e96da86fdf1ac30139c27c61be933bdfe63b83467b15a160ddc538a189c133207cbe1e2cfbb104
+  metadata.gz: 221ce20550753d6e51b23785aa9bda36ff4ccb7cc6a6f800bdec24a021e0f820bcdc0cfeb4ab632722306c5fc75806d68e3cc115d0891b14ed0be56db9b9059c
+  data.tar.gz: 63ab29831e4b94ab7c8cf94356de7f4ff2ab58dde5e15fe2406a08eb853ef089c0cd7a2833609c8ae9fd1ca18dcf3b63310f4acfc761c15f21be1141daa2a6f0

data/README.md

@@ -168,6 +168,27 @@ end
 Provide your custom class using the `:as` option when defining your field,
 as shown in the example above.
 
+### Accessing the Attribute/Field Node
+
+The named accessor method for any field or attribute will yield the Capybara
+node of the attribute if you pass a block. You can use this to check
+certain properties of the node without having to break out of your Dominos.
+
+**Example:** Checking available options in a select field
+
+```ruby
+person = Dom::PersonForm.find!
+expected_options = ["- Select a Color -", "Red", "Blue", "Green"]
+assert_equal expected_options, person.favorite_color { |n| n.all('option').map(&:text) }
+```
+
+**Example:** Checking the tag of the node containing the attribute value
+
+```ruby
+person = Dom::Person.find_by!(uuid: "e94bb2d3-71d2-4efb-abd4-ebc0cb58d19f")
+assert_equal "h2", person.name { |n| n.tag_name }
+```
+
 ## Integration with capybara
 
 Domino uses capybara internally to search html for nodes and

data/domino.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |gem|
   gem.name = "domino"
-  gem.version = "0.9.0"
+  gem.version = "0.10.0"
   gem.platform = Gem::Platform::RUBY
   gem.authors = ["Nick Gauthier"]
   gem.email = ["ngauthier@gmail.com"]

data/lib/domino/attribute.rb

@@ -34,6 +34,14 @@ class Domino::Attribute
     value === value(node)
   end
 
+  def element(node)
+    if combinator?
+      node
+    else
+      node.find(selector)
+    end
+  end
+
   private
 
   def combinator?

data/lib/domino/form/field.rb

@@ -12,8 +12,7 @@ class Domino::Form::Field
   # Delete any options for your field type that shouldn't be passed to
   # the field locator.
   # Default: noop
-  def extract_field_options
-  end
+  def extract_field_options; end
 
   # Convert the value from `#read` via callback if provided.
   def value(node)

data/lib/domino/form/select_field.rb

@@ -2,7 +2,7 @@ class Domino::Form::SelectField < Domino::Form::Field
   # Returns the set of selected options that can be processed in the callback.
   def read(node)
     s = field(node)
-    selected = s.all("option[selected]")
+    selected = s.all('option[selected]')
     s.multiple? ? selected : selected.first
   end
 

data/lib/domino/form.rb

@@ -39,8 +39,12 @@ class Domino::Form < Domino
 
     field_definitions[attribute] = field_class.new(attribute, locator, options, &callback)
 
-    define_method :"#{attribute}" do
-      self.class.field_definitions[attribute].value(node)
+    define_method :"#{attribute}" do |&block|
+      if block.is_a?(Proc)
+        block.call(self.class.field_definitions[attribute].field(node))
+      else
+        self.class.field_definitions[attribute].value(node)
+      end
     end
 
     define_method :"#{attribute}=" do |value|

data/lib/domino.rb

@@ -138,8 +138,12 @@ class Domino
 
       attribute_definitions[attribute] = Attribute.new(attribute, selector, &callback)
 
-      define_method :"#{attribute}" do
-        self.class.attribute_definitions[attribute].value(node)
+      define_method :"#{attribute}" do |&block|
+        if block.is_a?(Proc)
+          block.call(self.class.attribute_definitions[attribute].element(node))
+        else
+          self.class.attribute_definitions[attribute].value(node)
+        end
       end
 
       define_singleton_method :"find_by_#{attribute}" do |value|

data/test/domino_form_test.rb

@@ -187,14 +187,14 @@ class DominoFormTest < Minitest::Test
   end
 
   def test_static_create_with_no_matches
-    visit "/"
+    visit '/'
     assert_raises Capybara::ElementNotFound do
       Dom::PersonForm.create name: 'Marie', last_name: 'Curie'
     end
   end
 
   def test_static_update_with_no_matches
-    visit "/"
+    visit '/'
     assert_raises Capybara::ElementNotFound do
       Dom::PersonForm.update name: 'Marie', last_name: 'Curie'
     end
@@ -203,4 +203,16 @@ class DominoFormTest < Minitest::Test
   def test_supports_normal_attributes
     assert_equal({ action: '/people/23', submit_method: 'post' }, Dom::PersonForm.find!.attributes)
   end
+
+  def test_named_field_method_yields_node
+    person = Dom::PersonForm.find!
+    name_field_node = page.find_field('First Name')
+    assert_equal(name_field_node, person.name { |node| node })
+    person.name { |node| node }
+  end
+
+  def test_named_field_yield_usefulness
+    person = Dom::PersonForm.find!
+    assert_equal ['- Select a Color -', 'Red', 'Blue', 'Green'], person.favorite_color { |n| n.all('option').map(&:text) }
+  end
 end

data/test/domino_test.rb

@@ -188,4 +188,21 @@ class DominoTest < Minitest::Test
       Dom::NoSelector.where(foo: 'bar')
     end
   end
+
+  def test_named_field_method_yields_node
+    person = Dom::Person.find_by!(uuid: 'e94bb2d3-71d2-4efb-abd4-ebc0cb58d19f')
+    name_node = page.find(".person[data-uuid='e94bb2d3-71d2-4efb-abd4-ebc0cb58d19f'] .name")
+    assert_equal(name_node, person.name { |node| node })
+  end
+
+  def test_named_field_method_yields_node_when_combinator
+    person = Dom::Person.find_by!(uuid: 'e94bb2d3-71d2-4efb-abd4-ebc0cb58d19f')
+    uuid_node = page.find(".person[data-uuid='e94bb2d3-71d2-4efb-abd4-ebc0cb58d19f']")
+    assert_equal(uuid_node, person.uuid { |node| node })
+  end
+
+  def test_named_field_yield_usefulness
+    person = Dom::Person.find_by!(uuid: 'e94bb2d3-71d2-4efb-abd4-ebc0cb58d19f')
+    assert_equal 'h2', person.name(&:tag_name)
+  end
 end

data/test/test_application.rb

@@ -22,7 +22,7 @@ class TestApplication
       edit params
     when '/people/23'
       params = Rack::Utils.parse_nested_query(env.fetch('rack.input').read)
-      edit params.merge(flash: "Person updated successfully.")
+      edit params.merge(flash: 'Person updated successfully.')
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: domino
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
 - Nick Gauthier