domain_validator 0.1.0 → 0.1.1

data/lib/domain_validator/validator.rb

@@ -8,7 +8,8 @@ module DomainValidator
 
     def validate_each(record, attr_name, value)
       validate_domain_format(record, attr_name, value)
-      validate_domain_dns(record, attr_name, value) if options[:verify_dns]
+      # Only waste time with DNS check if record is invalid?
+      validate_domain_dns(record, attr_name, value) if record.errors.empty? && options[:verify_dns]
     end
 
     def validate_domain_format(record, attr_name, value)

data/lib/domain_validator/version.rb

@@ -1,3 +1,3 @@
 module DomainValidator
-  VERSION = [0, 1, 0].join "."
+  VERSION = [0, 1, 1].join "."
 end

data/spec/domain_validator_spec.rb

@@ -85,6 +85,13 @@ describe DomainValidator do
   end
 
   describe "DNS check" do
+    describe "an invalid domain" do
+      it "should not perform a DNS check" do
+        DomainValidator::DnsCheck.any_instance.should_not_receive(:has_record?)
+        UserVerifyDNS.new(:domain => "notadomain").should_not be_valid
+      end
+    end
+
     describe "a domain with a DNS record" do
       it "should be valid when :verify_dns is true" do
         UserVerifyDNS.new(:domain => "example.com").should be_valid

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: domain_validator
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-11 00:00:00.000000000 Z
+date: 2013-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel