domain_neutral 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 783b0093f6eb8b04e3bfb15be2803569798d3f33
-  data.tar.gz: 05d42b2f362c0755862b03084a20853a0e1ce437
+  metadata.gz: 2868d506ab5999b3bdfb949b1486c1a8cef507a9
+  data.tar.gz: 9c48bcc5503051b3ace5e5e169ec26dd6fb19edc
 SHA512:
-  metadata.gz: 11c4fa755fc8b7815583afc578f3e67b8b4a2c0e12ef8ed7bcfe23d0501e9e0fb02921ed8519abc3937ae2d96660d26e9ebd15487337053ad4806d68bafcf8b6
-  data.tar.gz: eab4f299c5bd5f047038d0e067a46d415f9a359845560fb5685e8f3a6609bbebf9e2d89d034d490f39d4e35c19bf63be1108be8840058c6b65f0fb69a7ac13c5
+  metadata.gz: 28e382c272fc6fbc15b513d5eac723683d97a447405d5d0f64fa58f232b3cdcc92c01572c79b5533951525d737c37ca2e51433fb0ae58f321b7702e0b4722aa4
+  data.tar.gz: 244d3890989160739db9f88a809a5cb6076448d732d97d4fcc452196c318476e307fd759aeca8a810b67cc4ef2aa7b02df320d9be3fd62f4ec09a4b104a0d066

data/lib/domain_neutral/association.rb

@@ -9,7 +9,7 @@ module DomainNeutral
         r = reflect_on_association(name)
         class_eval <<-CODE, __FILE__, __LINE__
           def #{name}
-            #{r.klass}.find(#{r.foreign_key})
+            #{r.foreign_key} && #{r.klass}.find(#{r.foreign_key})
           end
         CODE
       end

data/lib/domain_neutral/version.rb

@@ -1,3 +1,3 @@
 module DomainNeutral
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/test/dummy/log/test.log

@@ -5131,3 +5131,127 @@ DomainNeutral::DescriptorTest: test_: descriptor validation should require name
 -------------------------------------------------------------------------------------------
   DomainNeutral::Descriptor Exists (0.1ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" IS NULL AND "descriptors"."type" = 'Bull') LIMIT 1
    (0.0ms)  rollback transaction
+  ActiveRecord::SchemaMigration Load (0.5ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (0.1ms)  begin transaction
+  Fixture Delete (1.7ms)  DELETE FROM "descriptors"
+  Fixture Insert (0.5ms)  INSERT INTO "descriptors" ("type", "symbol", "name", "description", "index", "value", "created_at", "updated_at", "id") VALUES ('Role', 'site_admin', 'Site admin', 'Site administrator', 1, 100, '2016-06-07 14:23:12', '2016-06-07 14:23:12', 206888308)
+  Fixture Insert (0.1ms)  INSERT INTO "descriptors" ("type", "symbol", "name", "description", "index", "value", "created_at", "updated_at", "id") VALUES ('Role', 'user_admin', 'User Administrator', 'Administers users and legal entities', 2, 200, '2016-06-07 14:23:12', '2016-06-07 14:23:12', 718075439)
+  Fixture Delete (0.9ms)  DELETE FROM "users"
+  Fixture Insert (0.1ms)  INSERT INTO "users" ("name", "created_at", "updated_at", "id", "role_id") VALUES ('Site boss', '2016-06-07 14:23:12', '2016-06-07 14:23:12', 980190962, 206888308)
+  Fixture Insert (0.1ms)  INSERT INTO "users" ("name", "created_at", "updated_at", "id", "role_id") VALUES ('User boss', '2016-06-07 14:23:12', '2016-06-07 14:23:12', 298486374, 718075439)
+   (2.3ms)  commit transaction
+   (0.0ms)  begin transaction
+---------------------------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: translation defined should work depending on current locale. 
+---------------------------------------------------------------------------------------------------
+  Role Load (0.2ms)  SELECT  "descriptors".* FROM "descriptors" WHERE "descriptors"."type" IN ('Role') AND "descriptors"."symbol" = ?  ORDER BY "descriptors"."id" ASC LIMIT 1  [["symbol", "user_admin"]]
+  Role Load (0.0ms)  SELECT  "descriptors".* FROM "descriptors" WHERE "descriptors"."type" IN ('Role') AND "descriptors"."symbol" = ?  ORDER BY "descriptors"."id" ASC LIMIT 1  [["symbol", "user_admin"]]
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+---------------------------------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: association should not try to find record when foreign key is nil. 
+---------------------------------------------------------------------------------------------------------
+  User Load (0.1ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT 1  [["id", 980190962]]
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+-------------------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: descriptor validation should require name to be set. 
+-------------------------------------------------------------------------------------------
+  DomainNeutral::Descriptor Exists (0.2ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" IS NULL AND "descriptors"."type" = 'Bull') LIMIT 1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+------------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: association should override reader with find. 
+------------------------------------------------------------------------------------
+  User Load (0.1ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT 1  [["id", 980190962]]
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+-----------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: compareable should compare greater on index. 
+-----------------------------------------------------------------------------------
+   (0.0ms)  rollback transaction
+   (0.1ms)  begin transaction
+---------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: compareable should compare lower on index. 
+---------------------------------------------------------------------------------
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+----------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: compareable should compare equals on index. 
+----------------------------------------------------------------------------------
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+------------------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: reference as id should support typecast to integer. 
+------------------------------------------------------------------------------------------
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+----------------------------------------------------------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: descriptor validation should require case sensitive unique value for symbol scoped to type. 
+----------------------------------------------------------------------------------------------------------------------------------
+  Bull Load (0.1ms)  SELECT  "descriptors".* FROM "descriptors" WHERE "descriptors"."type" IN ('Bull')  ORDER BY "descriptors"."id" ASC LIMIT 1
+   (0.0ms)  SAVEPOINT active_record_1
+  SQL (0.3ms)  INSERT INTO "descriptors" ("type", "symbol", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["type", "Bull"], ["symbol", "a"], ["created_at", "2016-06-07 14:23:12.678743"], ["updated_at", "2016-06-07 14:23:12.678743"]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+  DomainNeutral::Descriptor Exists (0.1ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" = 'a' AND "descriptors"."type" = 'Bull') LIMIT 1
+  Bull Load (0.1ms)  SELECT "descriptors".* FROM "descriptors" WHERE "descriptors"."type" IN ('Bull')
+  DomainNeutral::Descriptor Exists (0.1ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" = 'a' AND "descriptors"."type" = 'Bulm') LIMIT 1
+   (0.4ms)  rollback transaction
+   (0.0ms)  begin transaction
+----------------------------------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: translation undefined should fall back to entity properties itself. 
+----------------------------------------------------------------------------------------------------------
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+---------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: relationship should expose children. 
+---------------------------------------------------------------------------
+   (0.0ms)  SAVEPOINT active_record_1
+  DomainNeutral::Descriptor Exists (0.1ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" = 'cow' AND "descriptors"."type" = 'Bull') LIMIT 1
+  SQL (0.2ms)  INSERT INTO "descriptors" ("type", "symbol", "name", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?)  [["type", "Bull"], ["symbol", "cow"], ["name", "Cow"], ["created_at", "2016-06-07 14:23:12.688356"], ["updated_at", "2016-06-07 14:23:12.688356"]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+   (0.1ms)  SAVEPOINT active_record_1
+  DomainNeutral::Descriptor Exists (0.1ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" = 'calf' AND "descriptors"."type" = 'Bull') LIMIT 1
+  SQL (0.4ms)  INSERT INTO "descriptors" ("type", "parent_id", "parent_type", "symbol", "name", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?, ?, ?)  [["type", "Bull"], ["parent_id", 718075440], ["parent_type", "DomainNeutral::Descriptor"], ["symbol", "calf"], ["name", "Calf"], ["created_at", "2016-06-07 14:23:12.695941"], ["updated_at", "2016-06-07 14:23:12.695941"]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+   (0.2ms)  SELECT COUNT(*) FROM "descriptors" WHERE "descriptors"."type" IN ('Bull') AND "descriptors"."parent_id" = ? AND "descriptors"."parent_type" = ?  [["parent_id", 718075440], ["parent_type", "DomainNeutral::Descriptor"]]
+  Bull Load (0.1ms)  SELECT  "descriptors".* FROM "descriptors" WHERE "descriptors"."type" IN ('Bull') AND "descriptors"."parent_id" = ? AND "descriptors"."parent_type" = ?  ORDER BY "descriptors"."id" ASC LIMIT 1  [["parent_id", 718075440], ["parent_type", "DomainNeutral::Descriptor"]]
+   (0.8ms)  rollback transaction
+   (0.0ms)  begin transaction
+-------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: relationship should expose parent. 
+-------------------------------------------------------------------------
+   (0.0ms)  SAVEPOINT active_record_1
+  DomainNeutral::Descriptor Exists (0.1ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" = 'cow' AND "descriptors"."type" = 'Bull') LIMIT 1
+  SQL (0.2ms)  INSERT INTO "descriptors" ("type", "symbol", "name", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?)  [["type", "Bull"], ["symbol", "cow"], ["name", "Cow"], ["created_at", "2016-06-07 14:23:12.710311"], ["updated_at", "2016-06-07 14:23:12.710311"]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+   (0.0ms)  SAVEPOINT active_record_1
+  DomainNeutral::Descriptor Exists (0.1ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" = 'calf' AND "descriptors"."type" = 'Bull') LIMIT 1
+  SQL (0.3ms)  INSERT INTO "descriptors" ("type", "parent_id", "parent_type", "symbol", "name", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?, ?, ?)  [["type", "Bull"], ["parent_id", 718075440], ["parent_type", "DomainNeutral::Descriptor"], ["symbol", "calf"], ["name", "Calf"], ["created_at", "2016-06-07 14:23:12.712449"], ["updated_at", "2016-06-07 14:23:12.712449"]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+   (0.6ms)  rollback transaction
+   (0.0ms)  begin transaction
+---------------------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: descriptor validation should require symbol to be set. 
+---------------------------------------------------------------------------------------------
+  DomainNeutral::Descriptor Exists (0.1ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" = '' AND "descriptors"."type" = 'Bull') LIMIT 1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+----------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: class methods should include symbols. 
+----------------------------------------------------------------------------
+  Role Load (0.1ms)  SELECT "descriptors".* FROM "descriptors" WHERE "descriptors"."type" IN ('Role')
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+--------------------------------------------------------------------------------------
+DomainNeutral::DescriptorTest: test_: relationship should return hash for to_heading. 
+--------------------------------------------------------------------------------------
+   (0.0ms)  SAVEPOINT active_record_1
+  DomainNeutral::Descriptor Exists (0.1ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" = 'cow' AND "descriptors"."type" = 'Bull') LIMIT 1
+  SQL (0.2ms)  INSERT INTO "descriptors" ("type", "symbol", "name", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?)  [["type", "Bull"], ["symbol", "cow"], ["name", "Cow"], ["created_at", "2016-06-07 14:23:12.720890"], ["updated_at", "2016-06-07 14:23:12.720890"]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+   (0.0ms)  SAVEPOINT active_record_1
+  DomainNeutral::Descriptor Exists (0.1ms)  SELECT  1 AS one FROM "descriptors" WHERE ("descriptors"."symbol" = 'calf' AND "descriptors"."type" = 'Bull') LIMIT 1
+  SQL (0.3ms)  INSERT INTO "descriptors" ("type", "parent_id", "parent_type", "symbol", "name", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?, ?, ?)  [["type", "Bull"], ["parent_id", 718075440], ["parent_type", "DomainNeutral::Descriptor"], ["symbol", "calf"], ["name", "Calf"], ["created_at", "2016-06-07 14:23:12.722873"], ["updated_at", "2016-06-07 14:23:12.722873"]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+   (0.7ms)  rollback transaction

data/test/models/domain_neutral/descriptor_test.rb

@@ -102,10 +102,15 @@ module DomainNeutral
       setup do
         @user = users(:one)
       end
-      should 'override reader' do
+      should 'override reader with find' do
         Role.expects(:find).with(@user.role_id)
         @user.role
       end
+      should 'not try to find record when foreign key is nil' do
+        @user.role_id = nil
+        Role.expects(:find).never
+        @user.role
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: domain_neutral
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Knut I. Stenmark