RubyGems - dom_for - Versions diffs - 1.0.2 → 1.0.3 - Mend

dom_for 1.0.2 → 1.0.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (62) hide show

checksums.yaml +7 -0
data/.ruby-version +1 -0
data/.travis.yml +5 -5
data/README.md +19 -10
data/Rakefile +4 -5
data/lib/dom_for/railtie.rb +9 -0
data/lib/dom_for/version.rb +1 -1
data/lib/dom_for.rb +3 -1
data/spec/dummy/.rspec +1 -1
data/spec/dummy/README.rdoc +15 -248
data/spec/dummy/Rakefile +1 -2
data/spec/dummy/app/assets/javascripts/application.js +4 -6
data/spec/dummy/app/assets/stylesheets/application.css +6 -4
data/spec/dummy/app/controllers/application_controller.rb +3 -1
data/spec/dummy/app/models/concerns/.keep +0 -0
data/spec/dummy/app/models/user.rb +0 -1
data/spec/dummy/app/views/layouts/application.html.erb +2 -2
data/spec/dummy/bin/bundle +3 -0
data/spec/dummy/bin/rails +4 -0
data/spec/dummy/bin/rake +4 -0
data/spec/dummy/bin/setup +29 -0
data/spec/dummy/config/application.rb +3 -36
data/spec/dummy/config/boot.rb +4 -9
data/spec/dummy/config/database.yml +8 -8
data/spec/dummy/config/environment.rb +3 -3
data/spec/dummy/config/environments/development.rb +22 -18
data/spec/dummy/config/environments/production.rb +46 -34
data/spec/dummy/config/environments/test.rb +19 -14
data/spec/dummy/config/initializers/assets.rb +11 -0
data/spec/dummy/config/initializers/cookies_serializer.rb +3 -0
data/spec/dummy/config/initializers/filter_parameter_logging.rb +4 -0
data/spec/dummy/config/initializers/inflections.rb +6 -5
data/spec/dummy/config/initializers/mime_types.rb +0 -1
data/spec/dummy/config/initializers/session_store.rb +1 -6
data/spec/dummy/config/initializers/wrap_parameters.rb +6 -6
data/spec/dummy/config/locales/en.yml +20 -2
data/spec/dummy/config/routes.rb +22 -27
data/spec/dummy/config/secrets.yml +22 -0
data/spec/dummy/config.ru +2 -2
data/spec/dummy/db/migrate/20140316142523_create_users.rb +1 -1
data/spec/dummy/db/schema.rb +5 -5
data/spec/dummy/lib/assets/.keep +0 -0
data/spec/dummy/log/.keep +0 -0
data/spec/dummy/public/404.html +54 -13
data/spec/dummy/public/422.html +54 -13
data/spec/dummy/public/500.html +53 -12
data/spec/helpers/dom_for_model_spec.rb +14 -14
data/spec/helpers/dom_for_record_spec.rb +6 -6
data/spec/helpers/dom_for_spec.rb +10 -4
data/spec/rails_helper.rb +53 -0
data/spec/spec_helper.rb +76 -37
metadata +54 -55
data/spec/dummy/app/assets/javascripts/users.js +0 -2
data/spec/dummy/app/assets/stylesheets/scaffold.css +0 -56
data/spec/dummy/app/assets/stylesheets/users.css +0 -4
data/spec/dummy/app/helpers/users_helper.rb +0 -2
data/spec/dummy/config/initializers/secret_token.rb +0 -7
data/spec/dummy/script/rails +0 -6
/data/spec/dummy/app/{mailers/.gitkeep → assets/images/.keep} +0 -0
/data/spec/dummy/app/{models/.gitkeep → controllers/concerns/.keep} +0 -0
/data/spec/dummy/{lib/assets/.gitkeep → app/mailers/.keep} +0 -0
/data/spec/dummy/{log/.gitkeep → app/models/.keep} +0 -0

data/spec/dummy/public/404.html CHANGED Viewed

@@ -2,25 +2,66 @@
 <html>
 <head>
   <title>The page you were looking for doesn't exist (404)</title>
-  <style type="text/css">
-    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
-    div.dialog {
-      width: 25em;
-      padding: 0 4em;
-      margin: 4em auto 0 auto;
-      border: 1px solid #ccc;
-      border-right-color: #999;
-      border-bottom-color: #999;
-    }
-    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  <meta name="viewport" content="width=device-width,initial-scale=1">
+  <style>
+  body {
+    background-color: #EFEFEF;
+    color: #2E2F30;
+    text-align: center;
+    font-family: arial, sans-serif;
+    margin: 0;
+  }
+  div.dialog {
+    width: 95%;
+    max-width: 33em;
+    margin: 4em auto 0;
+  }
+  div.dialog > div {
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #BBB;
+    border-top: #B00100 solid 4px;
+    border-top-left-radius: 9px;
+    border-top-right-radius: 9px;
+    background-color: white;
+    padding: 7px 12% 0;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
+  h1 {
+    font-size: 100%;
+    color: #730E15;
+    line-height: 1.5em;
+  }
+  div.dialog > p {
+    margin: 0 0 1em;
+    padding: 1em;
+    background-color: #F7F7F7;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #999;
+    border-bottom-left-radius: 4px;
+    border-bottom-right-radius: 4px;
+    border-top-color: #DADADA;
+    color: #666;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
   </style>
 </head>
 <body>
   <!-- This file lives in public/404.html -->
   <div class="dialog">
-    <h1>The page you were looking for doesn't exist.</h1>
-    <p>You may have mistyped the address or the page may have moved.</p>
+    <div>
+      <h1>The page you were looking for doesn't exist.</h1>
+      <p>You may have mistyped the address or the page may have moved.</p>
+    </div>
+    <p>If you are the application owner check the logs for more information.</p>
   </div>
 </body>
 </html>

data/spec/dummy/public/422.html CHANGED Viewed

@@ -2,25 +2,66 @@
 <html>
 <head>
   <title>The change you wanted was rejected (422)</title>
-  <style type="text/css">
-    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
-    div.dialog {
-      width: 25em;
-      padding: 0 4em;
-      margin: 4em auto 0 auto;
-      border: 1px solid #ccc;
-      border-right-color: #999;
-      border-bottom-color: #999;
-    }
-    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  <meta name="viewport" content="width=device-width,initial-scale=1">
+  <style>
+  body {
+    background-color: #EFEFEF;
+    color: #2E2F30;
+    text-align: center;
+    font-family: arial, sans-serif;
+    margin: 0;
+  }
+  div.dialog {
+    width: 95%;
+    max-width: 33em;
+    margin: 4em auto 0;
+  }
+  div.dialog > div {
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #BBB;
+    border-top: #B00100 solid 4px;
+    border-top-left-radius: 9px;
+    border-top-right-radius: 9px;
+    background-color: white;
+    padding: 7px 12% 0;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
+  h1 {
+    font-size: 100%;
+    color: #730E15;
+    line-height: 1.5em;
+  }
+  div.dialog > p {
+    margin: 0 0 1em;
+    padding: 1em;
+    background-color: #F7F7F7;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #999;
+    border-bottom-left-radius: 4px;
+    border-bottom-right-radius: 4px;
+    border-top-color: #DADADA;
+    color: #666;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
   </style>
 </head>
 <body>
   <!-- This file lives in public/422.html -->
   <div class="dialog">
-    <h1>The change you wanted was rejected.</h1>
-    <p>Maybe you tried to change something you didn't have access to.</p>
+    <div>
+      <h1>The change you wanted was rejected.</h1>
+      <p>Maybe you tried to change something you didn't have access to.</p>
+    </div>
+    <p>If you are the application owner check the logs for more information.</p>
   </div>
 </body>
 </html>

data/spec/dummy/public/500.html CHANGED Viewed

@@ -2,24 +2,65 @@
 <html>
 <head>
   <title>We're sorry, but something went wrong (500)</title>
-  <style type="text/css">
-    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
-    div.dialog {
-      width: 25em;
-      padding: 0 4em;
-      margin: 4em auto 0 auto;
-      border: 1px solid #ccc;
-      border-right-color: #999;
-      border-bottom-color: #999;
-    }
-    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  <meta name="viewport" content="width=device-width,initial-scale=1">
+  <style>
+  body {
+    background-color: #EFEFEF;
+    color: #2E2F30;
+    text-align: center;
+    font-family: arial, sans-serif;
+    margin: 0;
+  }
+  div.dialog {
+    width: 95%;
+    max-width: 33em;
+    margin: 4em auto 0;
+  }
+  div.dialog > div {
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #BBB;
+    border-top: #B00100 solid 4px;
+    border-top-left-radius: 9px;
+    border-top-right-radius: 9px;
+    background-color: white;
+    padding: 7px 12% 0;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
+  h1 {
+    font-size: 100%;
+    color: #730E15;
+    line-height: 1.5em;
+  }
+  div.dialog > p {
+    margin: 0 0 1em;
+    padding: 1em;
+    background-color: #F7F7F7;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #999;
+    border-bottom-left-radius: 4px;
+    border-bottom-right-radius: 4px;
+    border-top-color: #DADADA;
+    color: #666;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
   </style>
 </head>
 <body>
   <!-- This file lives in public/500.html -->
   <div class="dialog">
-    <h1>We're sorry, but something went wrong.</h1>
+    <div>
+      <h1>We're sorry, but something went wrong.</h1>
+    </div>
+    <p>If you are the application owner check the logs for more information.</p>
   </div>
 </body>
 </html>

data/spec/helpers/dom_for_model_spec.rb CHANGED Viewed

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 describe DomFor::Model do
@@ -8,50 +8,50 @@ describe DomFor::Model do
     end
     it 'returns div without nested tags' do
-      expect(helper.dom_for_model(User)).to eq '<div class="users" id="users" />'
+      expect(helper.dom_for_model(User)).to eq '<div id="users" class="users" />'
     end
     it 'returns div with data-action attribute' do
-      helper.request.stub(:path_parameters).and_return({ action: 'show' })
+      expect(helper.request).to receive(:path_parameters).and_return({ action: 'show' })
-      expect(helper.dom_for_model(User)).to eq '<div class="users" data-action="show" id="users" />'
+      expect(helper.dom_for_model(User)).to eq '<div id="users" class="users" data-action="show" />'
     end
     it 'returns div for the new user' do
       @user = User.new(name: 'test')
-      helper.request.stub(:path_parameters).and_return({ action: 'new' })
+      expect(helper.request).to receive(:path_parameters).and_return({ action: 'new' })
-      expect(helper.dom_for_model(User)).to eq '<div class="user new_user" data-action="new" id="new_user" />'
+      expect(helper.dom_for_model(User)).to eq '<div id="new_user" class="user new_user" data-action="new" />'
     end
     it 'returns div for the new user without request' do
       @user = User.new(name: 'test')
-      expect(helper.dom_for_model(User)).to eq '<div class="user" id="new_user" />'
+      expect(helper.dom_for_model(User)).to eq '<div id="new_user" class="user" />'
     end
     it 'returns div for the saved user' do
       @user = User.create(name: 'test')
-      helper.request.stub(:path_parameters).and_return({ action: 'show' })
+      expect(helper.request).to receive(:path_parameters).and_return({ action: 'show' })
-      expect(helper.dom_for_model(User)).to eq '<div class="user show_user" data-action="show" data-object-id="1" data-object="users" id="user_1" />'
+      expect(helper.dom_for_model(User)).to eq '<div id="user_1" class="user show_user" data-action="show" data-object-id="1" data-object="users" />'
     end
     it 'returns div with the additional data-attributes' do
       @user = User.create(name: 'test')
-      helper.request.stub(:path_parameters).and_return({ action: 'show' })
+      expect(helper.request).to receive(:path_parameters).and_return({ action: 'show' })
-      expect(helper.dom_for_model(User, admin: true)).to eq '<div class="user show_user" data-action="show" data-admin="true" data-object-id="1" data-object="users" id="user_1" />'
+      expect(helper.dom_for_model(User, admin: true)).to eq '<div id="user_1" class="user show_user" data-admin="true" data-action="show" data-object-id="1" data-object="users" />'
     end
     it 'returns div with nested tags' do
       @user = User.create(name: 'test')
-      helper.request.stub(:path_parameters).and_return({ action: 'show' })
+      expect(helper.request).to receive(:path_parameters).and_return({ action: 'show' })
       expect(
         helper.dom_for_model(User, admin: true) { helper.tag(:span) }
-      ).to eq '<div class="user show_user" data-action="show" data-admin="true" data-object-id="1" data-object="users" id="user_1"><span /></div>'
+      ).to eq '<div id="user_1" class="user show_user" data-admin="true" data-action="show" data-object-id="1" data-object="users"><span /></div>'
     end
   end
-end
+end

data/spec/helpers/dom_for_record_spec.rb CHANGED Viewed

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 describe DomFor::Record do
@@ -8,13 +8,13 @@ describe DomFor::Record do
     end
     it 'returns div for the new user' do
-      expect(helper.dom_for_record(User.new)).to eq '<div class="user" id="new_user" />'
+      expect(helper.dom_for_record(User.new)).to eq '<div id="new_user" class="user" />'
     end
     it 'returns div without nested tags' do
       user = User.create(name: 'test')
-      expect(helper.dom_for_record(user)).to eq '<div class="user" data-object-id="1" id="user_1" />'
+      expect(helper.dom_for_record(user)).to eq '<div id="user_1" class="user" data-object-id="1" />'
     end
     it 'returns div with nested tags' do
@@ -22,7 +22,7 @@ describe DomFor::Record do
       expect(
         helper.dom_for_record(user) { helper.tag(:span) }
-      ).to eq '<div class="user" data-object-id="1" id="user_1"><span /></div>'
+      ).to eq '<div id="user_1" class="user" data-object-id="1"><span /></div>'
     end
     it 'returns div with the additional data-attributes' do
@@ -30,8 +30,8 @@ describe DomFor::Record do
       expect(
           helper.dom_for_record(user, admin: true) { helper.tag(:span) }
-      ).to eq '<div class="user" data-admin="true" data-object-id="1" id="user_1"><span /></div>'
+      ).to eq '<div id="user_1" class="user" data-admin="true" data-object-id="1"><span /></div>'
     end
   end
-end
+end

data/spec/helpers/dom_for_spec.rb CHANGED Viewed

@@ -1,15 +1,21 @@
-require 'spec_helper'
+require 'rails_helper'
 describe DomFor do
+  it 'includes in ActiveView::Base' do
+    expect(ActionView::Base.ancestors).to include(DomFor)
+    expect(ActionView::Base.ancestors).to include(DomFor::Model)
+    expect(ActionView::Base.ancestors).to include(DomFor::Record)
+  end
   context '#dom_for' do
     it 'invokes #dom_for_model' do
-      expect(helper.dom_for(User)).to eq '<div class="users" id="users" />'
+      expect(helper.dom_for(User)).to eq '<div id="users" class="users" />'
     end
     it 'invokes #dom_for_record' do
-      expect(helper.dom_for(User.new)).to eq '<div class="user" id="new_user" />'
+      expect(helper.dom_for(User.new)).to eq '<div id="new_user" class="user" />'
     end
   end
-end
+end

data/spec/rails_helper.rb ADDED Viewed

@@ -0,0 +1,53 @@
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+ENV['RAILS_ENV'] ||= 'test'
+require 'spec_helper'
+require File.expand_path('../dummy/config/environment', __FILE__)
+require 'rspec/rails'
+# Add additional requires below this line. Rails is not loaded until this point!
+require 'coveralls'
+Coveralls.wear!
+# Requires supporting ruby files with custom matchers and macros, etc, in
+# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+# run as spec files by default. This means that files in spec/support that end
+# in _spec.rb will both be required and run as specs, causing the specs to be
+# run twice. It is recommended that you do not name files matching this glob to
+# end with _spec.rb. You can configure this pattern with the --pattern
+# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
+#
+# The following line is provided for convenience purposes. It has the downside
+# of increasing the boot-up time by auto-requiring all files in the support
+# directory. Alternatively, in the individual `*_spec.rb` files, manually
+# require only the support files necessary.
+#
+# Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }
+# Checks for pending migrations before tests are run.
+# If you are not using ActiveRecord, you can remove this line.
+ActiveRecord::Migration.maintain_test_schema!
+RSpec.configure do |config|
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = true
+  # RSpec Rails can automatically mix in different behaviours to your tests
+  # based on their file location, for example enabling you to call `get` and
+  # `post` in specs under `spec/controllers`.
+  #
+  # You can disable this behaviour by removing the line below, and instead
+  # explicitly tag your specs with their type, e.g.:
+  #
+  #     RSpec.describe UsersController, :type => :controller do
+  #       # ...
+  #     end
+  #
+  # The different available types are documented in the features, such as in
+  # https://relishapp.com/rspec/rspec-rails/docs
+  config.infer_spec_type_from_file_location!
+end

data/spec/spec_helper.rb CHANGED Viewed

@@ -1,48 +1,87 @@
-# This file is copied to spec/ when you run 'rails generate rspec:install'
-ENV['RAILS_ENV'] ||= 'test'
-require File.expand_path('../dummy/config/environment', __FILE__)
-require 'rspec/rails'
-require 'rspec/autorun'
-require 'coveralls'
-Coveralls.wear!
-# Requires supporting ruby files with custom matchers and macros, etc,
-# in spec/support/ and its subdirectories.
-Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }
+# This file was generated by the `rails generate rspec:install` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  # ## Mock Framework
-  #
-  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
-  #
-  # config.mock_with :mocha
-  # config.mock_with :flexmock
-  # config.mock_with :rr
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
-  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
-  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
-  # If you're not using ActiveRecord, or you'd prefer not to run each of your
-  # examples within a transaction, remove the following line or assign false
-  # instead of true.
-  config.use_transactional_fixtures = true
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
-  # If true, the base class of anonymous controllers will be inferred
-  # automatically. This will be the default behavior in future versions of
-  # rspec-rails.
-  config.infer_base_class_for_anonymous_controllers = false
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
+  config.disable_monkey_patching!
-  config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.run_all_when_everything_filtered = true
-  config.filter_run :focus
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
-  config.fail_fast = true
-  config.color_enabled = true
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = 'random'
-end
+  config.order = :random
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
+end