dolarblue 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8da81e799823976c526474269b44fcd2e35bcf26
-  data.tar.gz: 852536ad4e2e7f309fddf1d294e3ab2e0a267d0d
+  metadata.gz: 1cbb622c30b3231b15718679c1a52cb01a218ef2
+  data.tar.gz: 3a53a71be05412121055ea332c969c71129e5b20
 SHA512:
-  metadata.gz: 596dc122f503f536a36df0a072c9dbe73100cbd9e9279d1937ae5ec71c95acbd7c5c83df42dcf6bcdd8bb4790c2afc6f104cb70e7a1e902ce2e6ad7503d2a989
-  data.tar.gz: c9edd133e76cd181f60e9a7d4018a9a038cb2dafcdc6ac0d1881487fa152f7562256b3d1feae72212c171126e9f9611e9839ea3b75c6ebeb272874d01ba471f0
+  metadata.gz: b5857781bc52a75bf4bb5f087a5c609e28cb5c8fe2d1d0f78c998f0ce8e5f57ecc13ec629022c4e181ef76f60ba0c1411232f3c640dec85c61370bef077ac234
+  data.tar.gz: 384d51da5d47da674b16f0c8f66d13346a3d5457f5affbc81d44697991befccbeb5fda1bd05d54ff47085fd8b15fa64776ea0d3439e36c184310ae00b42703bf

data/.gitignore

@@ -3,11 +3,9 @@
 .bundle
 .config
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
 coverage
-doc/
 lib/bundler/man
 pkg
 rdoc
@@ -15,3 +13,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+spec/cassettes/Dolarblue

data/.rspec

@@ -1,4 +1,4 @@
 --format documentation
 --color
 --order random
-
+--fail-fast

data/.ruby-gemset

@@ -0,0 +1,2 @@
+dolarblue
+

data/.ruby-version

@@ -1 +1 @@
-1.9.2-p320
+2.0.0

data/.travis.yml

@@ -1,8 +1,13 @@
 language: ruby
-before_install:
-  - gem --version
+
 rvm:
-  - 1.9.2
   - 1.9.3
   - 2.0.0
-script: 'bundle exec rake'
+  - jruby-1.7.9
+  - rbx-2.2.1
+
+install:
+  - travis_retry bundle install
+
+script:
+  - bundle exec rake

data/CHANGELOG.md

@@ -1,13 +1,18 @@
-## [In git](https://github.com/elgalu/dolarblue/compare/v0.3.0...HEAD)
+## [In git](https://github.com/elgalu/dolarblue/compare/v0.4.0...HEAD)
 
-### New Features
 * n/a
 
+## [v0.4.0](https://github.com/elgalu/dolarblue/tree/v0.4.0)
+
+### New Features
+* Changed information source from twitter to ambito.com. (Leo Gallucci)
+
 ### Bug Fixes
-* n/a
+* Twitter anonymous access was discontinued so to avoid the user having to install their API token i moved to web-scraping. (Leo Gallucci)
 
 ### Chores
-* n/a
+* Complete refactor of the app. (Leo Gallucci)
+* Updated RSpec to use new syntax `expect` and remove `should` [expectation syntax](http://goo.gl/BGxqP). (Leo Gallucci)
 
 ## [v0.3.0](https://github.com/elgalu/dolarblue/tree/v0.3.0)
 

data/Gemfile

@@ -2,3 +2,23 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in dolarblue.gemspec
 gemspec
+
+group :development do
+  gem 'pry'     # core replacement for irb
+  gem 'pry-doc' # gives MRI core documentation and source code
+end
+
+unless %w(jruby rbx).include? RUBY_ENGINE
+  group :test do
+    # Coverage reports only for MRI
+    gem 'simplecov', '>= 0.8.2'
+    gem 'coveralls', '>= 0.7.0'
+  end
+
+  group :development do
+    gem 'redcarpet', '>= 3'  # redcarpet doesn't currently works with jruby nor rbx. kramdown is a possible alternative
+    gem 'yard', '>= 0.8.7.3' # no need to generate yard docs from jruby nor rbx
+    gem 'pry-stack_explorer' # adds command `show-stack`
+    gem 'pry-debugger'       # adds commands `continue, step, next, finish`
+  end
+end

data/Gemfile.lock

@@ -0,0 +1,110 @@
+PATH
+  remote: .
+  specs:
+    dolarblue (0.4.0)
+      configatron (>= 3.0.0.rc2)
+      nokogiri (>= 1.6.1)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    addressable (2.3.5)
+    binding_of_caller (0.7.2)
+      debug_inspector (>= 0.0.1)
+    coderay (1.1.0)
+    columnize (0.3.6)
+    configatron (3.0.0.rc2)
+    coveralls (0.7.0)
+      multi_json (~> 1.3)
+      rest-client
+      simplecov (>= 0.7)
+      term-ansicolor
+      thor
+    crack (0.4.1)
+      safe_yaml (~> 0.9.0)
+    debug_inspector (0.0.2)
+    debugger (1.6.3)
+      columnize (>= 0.3.1)
+      debugger-linecache (~> 1.2.0)
+      debugger-ruby_core_source (~> 1.2.4)
+    debugger-linecache (1.2.0)
+    debugger-ruby_core_source (1.2.4)
+    diff-lcs (1.2.5)
+    docile (1.1.1)
+    ffi (1.9.3-java)
+    method_source (0.8.2)
+    mime-types (2.0)
+    mini_portile (0.5.2)
+    multi_json (1.8.2)
+    nokogiri (1.6.1)
+      mini_portile (~> 0.5.0)
+    pry (0.9.12.4)
+      coderay (~> 1.0)
+      method_source (~> 0.8)
+      slop (~> 3.4)
+    pry (0.9.12.4-java)
+      coderay (~> 1.0)
+      method_source (~> 0.8)
+      slop (~> 3.4)
+      spoon (~> 0.0)
+    pry-debugger (0.2.2)
+      debugger (~> 1.3)
+      pry (~> 0.9.10)
+    pry-doc (0.4.6)
+      pry (>= 0.9)
+      yard (>= 0.8)
+    pry-stack_explorer (0.4.9.1)
+      binding_of_caller (>= 0.7)
+      pry (>= 0.9.11)
+    rake (10.1.0)
+    redcarpet (3.0.0)
+    rest-client (1.6.7)
+      mime-types (>= 1.16)
+    rspec (2.14.1)
+      rspec-core (~> 2.14.0)
+      rspec-expectations (~> 2.14.0)
+      rspec-mocks (~> 2.14.0)
+    rspec-core (2.14.7)
+    rspec-expectations (2.14.4)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.14.4)
+    rubygems-tasks (0.2.4)
+    safe_yaml (0.9.7)
+    simplecov (0.8.2)
+      docile (~> 1.1.0)
+      multi_json
+      simplecov-html (~> 0.8.0)
+    simplecov-html (0.8.0)
+    slop (3.4.7)
+    spoon (0.0.4)
+      ffi
+    term-ansicolor (1.2.2)
+      tins (~> 0.8)
+    thor (0.18.1)
+    tins (0.13.1)
+    vcr (2.8.0)
+    webmock (1.16.1)
+      addressable (>= 2.2.7)
+      crack (>= 0.3.2)
+    yard (0.8.7.3)
+
+PLATFORMS
+  java
+  ruby
+
+DEPENDENCIES
+  bundler (>= 1.3.5)
+  coveralls (>= 0.7.0)
+  dolarblue!
+  pry
+  pry-debugger
+  pry-doc
+  pry-stack_explorer
+  rake
+  redcarpet (>= 3)
+  rspec (~> 2.14, >= 2.14.1)
+  rubygems-tasks (~> 0.2, >= 0.2.4)
+  simplecov (>= 0.8.2)
+  vcr (~> 2.8, >= 2.8.0)
+  webmock (~> 1.16, >= 1.16.1)
+  yard (>= 0.8.7.3)

data/README.md

@@ -5,6 +5,7 @@
 [![Dependency Status][DS img]][Dependency Status]
 [![Code Climate][CC img]][Code Climate]
 [![Coverage Status][CS img]][Coverage Status]
+[![githalytics.com alpha](https://cruel-carlota.pagodabox.com/4a6a5549e2d3b59f3b59b12ab0ab70e9 "githalytics.com")](http://githalytics.com/elgalu/dolarblue)
 
 ## Description
 
@@ -26,18 +27,18 @@ Query latest values
 
 Sample result:
 
-    Obtaining latest AR$ vs US$ exchange values...Done.
+    Obtaining latest AR$ vs US$ exchange values...Parsing values...
+    Done: 2013-12-15 19:20:41 -0300
 
-    - Official.......: 5.02 / 5.10  (Updated 2 hours ago)
-    - Dolar "Tarjeta":  n/a / 6.12  (Updated 2 hours ago)
-    - Blue...........: 8.44 / 8.75  (Updated 2 hours and 33 minutes ago)
-    - Gap "tarjeta"..: 43%
-    - Gap (official).: 72%
+    - Dollar Official....:  6.25 /  6.30
+    - Dollar Card........:   n/a /  8.50
+    - Dollar Blue........:  9.55 /  9.60
 
-    Information sources:
-    Official.......: https://twitter.com/cotizacionhoyar/status/314454371796660225
-    Blue...........: https://twitter.com/DolarBlue/status/314445874556190720
+    - Gap card.......blue: 13%
+    - Gap official...blue: 52%
 
+    Information source:
+    http://ambito.com/economia/mercados/monedas/dolar/
 
 ## Contributing
 
@@ -57,8 +58,8 @@ Released under the MIT License. See the [LICENSE][] file for further details.
 [RubyGems][] | [Documentation][] | [Source][] | [Bugtracker][] | [Build Status][] | [Dependency Status][] | [Code Climate][]
 
 
-[bundle install]: http://gembundler.com/man/bundle-install.1.html
-[Gemfile]: http://gembundler.com/man/gemfile.5.html
+[bundle install]: http://gembundler.com/v1.3/man/bundle-install.1.html
+[Gemfile]: http://gembundler.com/v1.3/gemfile.html
 [LICENSE]: LICENSE.md
 [Change Log]: CHANGELOG.md
 

data/Rakefile

@@ -1,6 +1,7 @@
-require "bundler/gem_tasks"
-require 'rspec/core/rake_task'
+require 'rubygems/tasks'
+Gem::Tasks.new
 
+require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
 
 task :default => :spec

data/config/xpaths.yml

@@ -0,0 +1,17 @@
+base_url: 'http://ambito.com/economia/mercados/monedas/dolar/'
+
+blue:
+  buy:
+    xpath: '//*[@id="contenido"]/div[1]/div[2]/div/div/div[2]/big'
+  sell:
+    xpath: '//*[@id="contenido"]/div[1]/div[2]/div/div/div[3]/big'
+
+official:
+  buy:
+    xpath: '//*[@id="contenido"]/div[1]/div[1]/div/div/div[2]/big'
+  sell:
+    xpath: '//*[@id="contenido"]/div[1]/div[1]/div/div/div[3]/big'
+
+card:
+  sell:
+    xpath: '//*[@id="contenido"]/div[4]/div/div/div[2]/big'

data/dolarblue.gemspec

@@ -5,34 +5,38 @@ require 'dolarblue/version'
 Gem::Specification.new do |spec|
 
   spec.platform      = Gem::Platform::RUBY
-  spec.name          = "dolarblue"
+  spec.name          = 'dolarblue'
   spec.version       = Dolarblue::VERSION
   spec.summary       = %q{Query Argentine Peso vs US$ exchange values with particular interest in official vs. street (blue) reference prices.}
   spec.description   = spec.summary
 
-  spec.required_ruby_version     = '>= 1.9.2'
-  spec.required_rubygems_version = '>= 1.3.6'
+  spec.required_ruby_version     = '>= 1.9.3'
+  spec.required_rubygems_version = '>= 1.8.25'
 
   spec.license       = 'MIT'
 
-  spec.authors       = ["Leo Gallucci"]
-  spec.email         = ["elgalu3@gmail.com"]
-  spec.homepage      = "https://github.com/elgalu/dolarblue"
+  spec.authors       = ['Leo Gallucci']
+  spec.email         = ['elgalu3@gmail.com']
+  spec.homepage      = 'https://github.com/elgalu/dolarblue'
 
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
 
-  spec.add_runtime_dependency "twitter_anonymous_client", ">= 1.0.2.0"
-  spec.add_runtime_dependency "time_ago_in_words", ">= 0.1.0"
+  spec.add_runtime_dependency 'configatron',   '>= 3.0.0.rc2'
+  spec.add_runtime_dependency 'nokogiri',      '>= 1.6.1'
 
-  spec.add_development_dependency "bundler", ">= 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 2.13"
-  spec.add_development_dependency "redcarpet", ">= 2.2.2"
-  spec.add_development_dependency "yard", ">= 0.8.5.2"
-  spec.add_development_dependency "simplecov", ">= 0.7.1"
-  spec.add_development_dependency 'coveralls', '>= 0.6.2'
+  if RUBY_ENGINE == 'rbx'
+    spec.add_runtime_dependency 'rubysl'
+    spec.add_runtime_dependency 'racc' # Solves https://github.com/rubinius/rubinius/issues/2632#issuecomment-26954565
+  end
+
+  spec.add_development_dependency 'bundler', '>= 1.3.5'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec', '~> 2.14', '>= 2.14.1'
+  spec.add_development_dependency 'vcr', '~> 2.8', '>= 2.8.0'
+  spec.add_development_dependency 'webmock', '~> 1.16', '>= 1.16.1'
+  spec.add_development_dependency 'rubygems-tasks', '~> 0.2', '>= 0.2.4'
 
 end

data/lib/dolarblue.rb

@@ -1,11 +1,16 @@
 require 'dolarblue/version'
 require 'dolarblue/configuration'
-require 'dolarblue/class_methods'
 require 'dolarblue/instance_methods'
-require 'dolarblue/exchange'
 
 # Main class used as builder and also as Dolarblue namespace
 class Dolarblue
-  extend ClassMethods
-  include InstanceMethods
+  class << self
+    # Returns all the dollar exchange 'Blue' vs 'Official' values and percentiles
+    #   suitable for user printing
+    #
+    # @return [String] with all dollar exchange 'Blue' vs 'Official' values
+    def get_output
+      new.update!.output
+    end
+  end
 end

data/lib/dolarblue/blue.rb

@@ -0,0 +1,7 @@
+require 'dolarblue/xchange'
+
+class Dolarblue
+  # Class used to hold sell/buy values functionality for dollar "Blue"
+  class Blue < XChange
+  end
+end

data/lib/dolarblue/card.rb

@@ -0,0 +1,20 @@
+require 'dolarblue/xchange'
+
+class Dolarblue
+  # Class used to hold sell/buy values functionality for dollar "Official"
+  class Card < XChange
+    # Override extract_values since dollar "tarjeta" only has a sell value
+    #
+    # @param doc [Nokogiri::HTML] the html document to extract values from
+    def extract_values(doc)
+      @sell = extract_val(doc, 'sell')
+    end
+
+    # Override buy_output since dollar "tarjeta" only has a sell value
+    #
+    # @return [String] formatted output buy exchange value, in this case n/a for not available
+    def buy_output
+      'n/a'
+    end
+  end
+end

data/lib/dolarblue/configuration.rb

@@ -1,4 +1,6 @@
-require 'singleton'
+require 'configatron/core' # gem 'configatron'
+require 'singleton'        # stdlib
+require 'yaml'             # stdlib
 
 class Dolarblue
 
@@ -6,57 +8,24 @@ class Dolarblue
   class Configuration
     include Singleton
 
-    # Default gap factor between the official sale value vs. the buy value
-    # Usually 1.5%
+    # Give memoized defaults for locked configuration options found in /config/xpaths.yml file
     #
-    # @return [Float] the percentile between 0..1
-    def buy_sell_official_factor
-      Float(0.985)
-    end
-
-    # Default gap factor between the blue sale value vs. the buy value
-    # Usually 4.5%
-    #
-    # @return [Float] the percentile between 0..1
-    def buy_sell_blue_factor
-      Float(0.965)
-    end
-
-    # Twitter screen name for the `blue` dollar value
+    # @example Usage
+    #   conf = Configuration.instance.defaults
+    #   conf.base_url       #=> "http://ambito.com/economia/mercados/monedas/dolar/"
+    #   conf.blue.buy.xpath #=> "//*[@id=\"contenido\"]/div[1]/div[2]/div/div/div[2]/big"
     #
-    # @return [String] the twitter screen name for the `blue` dollar value
-    def blue_screen_name
-      'DolarBlue'
-    end
+    # @return [Configatron::Store] the magic configuration instance with hash and dot '.' indifferent access
+    def defaults
+      return @config if @config
 
-    # Regular expression to be used to match the Tweet text for `blue` value
-    # In order to extract the integer value from $1 and the decimal value from $2
-    #
-    # @return [Regexp] the regular expression to be used to match the Tweet text for `blue` value
-    def blue_regexp
-      /\$(\d+)[\.,](\d+)/
-    end
+      @config = Configatron::Store.new
+      file_path   = File.expand_path('../../../config/xpaths.yml', __FILE__)
+      hash_config = YAML::load_file(file_path)
 
-    # Twitter screen name for the official (legal) dollar value
-    #
-    # @return [String] the twitter screen name for the official (legal) dollar value
-    def official_screen_name
-      'cotizacionhoyar'
-    end
-
-    # Regular expression to be used to match the Tweet text for official value
-    # In order to extract the integer value from $1 and the decimal value from $2
-    #
-    # @return [Regexp] the regular expression to be used to match the Tweet text for official value
-    def official_regexp
-      /[Dd]olar: (\d+)[\.,](\d+)/
-    end
-
-    # Dollar "tarjeta" AR fee on top of official value
-    #
-    # @return [Float] the dollar "tarjeta" AR fee to be applied, e.g. 1.2 for an extra 20% charge
-    def card_fee
-      1.2
+      @config.configure_from_hash(hash_config)
+      @config.lock!
+      @config
     end
   end