dolar-bna 1.0.5 → 1.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa4f36b6b0ffe105487c7fe8f37383fca3ab0f8ff052673d7585617f33d84aca
-  data.tar.gz: e164fe66fcaa11cd706951dd5285dfb05e296b31a972f91e37b048a696c618c3
+  metadata.gz: 3108e2c21aa48d68b93712bea13b69e2cf1cc4d31bc33632cbb172713f4f4d23
+  data.tar.gz: 0e22b4646b52d28a067c6748240c27325ec0c5035fcf252f15f3f4ca5617c395
 SHA512:
-  metadata.gz: ed3dc0e601b29285560fe6015a57dc49ba42b32286f7b5fc395c8561d945a72492067e3b04a8c0ac9aba060df0ce2989be966d733f3d0a8ca76ab50696a38648
-  data.tar.gz: bbe33bb268d58065603daeae9baaad9b864d46a6028e05fca14f3fdc805cd4b19b1020d9ea731799efd78b7c81bf5da9b209187bd3c22c09c8d0c7ff003da185
+  metadata.gz: dda16f2ff47129ea8a519dc056dbbf4713aa63c0431985e2dcba9cf290a6d8a0478291ca5d1cdfe6f8ba2d28c4cc2000f8eae9c9d6a31fc4095df2542e5e1d41
+  data.tar.gz: 1aa79fb3641655306efaaab1c0ea3cd9cfce63f779b8e94c839d29c64427a48d4341e83b2679e7186d6c26ab65e51de910534493967bd2e5a5a72829bfaa83d4

data/lib/dolar/app/models/dolar_cotization.rb

@@ -6,6 +6,8 @@ module Dolar
       validates_presence_of :dolar_type, message: 'Indicar tipo de cotizacion'
       validates_presence_of :dolar_buy, message: 'Indicar cotizacion de compra'
       validates_presence_of :dolar_sell, message: 'Indicar cotizacion de venta'
+      validates_numericality_of :dolar_buy, greater_than: 0, message: 'La cotizacion debe ser mayor a 0'
+      validates_numericality_of :dolar_sell, greater_than: 0, message: 'La cotizacion debe ser mayor a 0'
       validates_uniqueness_of :date, scope: :dolar_type, message: 'Ya existe una cotización de ese tipo para la fecha ingresada'
       DOLAR_TYPES = ["Divisa", "Billete"]
 

data/lib/dolar/bna/exchange.rb

@@ -7,26 +7,47 @@ module Dolar
       end
 
       def perform_bna_billete
-        data = check_cotization("Billete", @fecha)
-        save_in_db(data, "Billete") unless data.blank?
-        return data
+        begin
+          Timeout.timeout(15) do
+            data = check_cotization("Billete", @fecha)
+            save_in_db(data, "Billete") unless data.blank?
+            return data
+          end
+        rescue => ex
+          pp ex.message
+          return nil
+        end
       end
 
       def perform_bna_divisa
-        data = check_cotization("Divisa", @fecha)
-        save_in_db(data, "Divisa") unless data.blank?
-        return data
+        begin
+          Timeout.timeout(15) do
+            data = check_cotization("Divisa", @fecha)
+            save_in_db(data, "Divisa") unless data.blank?
+            return data
+          end
+        rescue => ex
+          pp ex.message
+          return nil
+        end
       end
 
       def variation_billete
-        today_dolar = check_cotization("Billete", @fecha)
-        yesterday_dolar = check_cotization("Divisa", (@fecha - 1.days))
-        unless (today_dolar.nil? || yesterday_dolar.nil?)
-          porcentual_variation = (today_dolar[:venta] - yesterday_dolar[:venta]) / (yesterday_dolar[:venta])
-          porcentual_variation = "#{porcentual_variation * 100}%"
-          return porcentual_variation
-        else
-          return "0%"
+        begin
+          Timeout.timeout(15) do
+            today_dolar = check_cotization("Billete", @fecha)
+            yesterday_dolar = check_cotization("Billete", (@fecha - 1.days))
+            unless (today_dolar.nil? || yesterday_dolar.nil?)
+              porcentual_variation = ((today_dolar[:venta] - yesterday_dolar[:venta]) / (yesterday_dolar[:venta]))
+              porcentual_variation = "#{(porcentual_variation * 100).round(2)}%"
+              return porcentual_variation
+            else
+              return "0%"
+            end
+          end
+        rescue => ex
+          pp ex.message
+          return nil
         end
       end
 
@@ -53,7 +74,7 @@ module Dolar
         mechanize = Mechanize.new
         mechanize.user_agent_alias = "Android"
         begin
-          Timeout.timeout(20) do
+          Timeout.timeout(15) do
             url = "http://www.bna.com.ar/Cotizador/HistoricoPrincipales?id=billetes&fecha=#{@fecha.day}%2F#{@fecha.month}%2F#{@fecha.year}&filtroEuro=0&filtroDolar=1"
             value = obtain_dolar_from_html(url, mechanize, data)
             return value
@@ -70,7 +91,7 @@ module Dolar
         mechanize = Mechanize.new
         mechanize.user_agent_alias = "Android"
         begin
-          Timeout.timeout(20) do
+          Timeout.timeout(15) do
             url = "http://www.bna.com.ar/Cotizador/MonedasHistorico"
             value = obtain_dolar_from_html(url, mechanize, data)
             return value

data/lib/dolar/bna/version.rb

@@ -1,5 +1,5 @@
 module Dolar
   module Bna
-    VERSION = "1.0.5"
+    VERSION = "1.0.8"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dolar-bna
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.8
 platform: ruby
 authors:
 - LITECODE
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-08-16 00:00:00.000000000 Z
+date: 2019-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: factory_bot
@@ -92,8 +92,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-description: 'Gema para obtener cotización de dolar divisa y dolar billete desde el
-  sitio web del Banco Nación de Argentina '
+description: Gema para obtener cotización de dolar divisa y dolar billete, obtener
+  variaciones respecto al día anterior y realizar conversiones. Valores obtenidos
+  del sitio web del Banco Nación Argentina
 email:
 - lorenzoezequiel30@gmail.com
 executables: []
@@ -108,12 +109,12 @@ files:
 - lib/dolar/bna/version.rb
 - lib/generators/dolar/bna/install/install_generator.rb
 - lib/generators/dolar/bna/install/templates/create_dolar_cotizations.rb
-homepage: http://litecode.com.ar/
+homepage: https://github.com/elorenzo368/dolar-bna
 licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-  homepage_uri: http://litecode.com.ar/
+  homepage_uri: https://github.com/elorenzo368/dolar-bna
 post_install_message: 
 rdoc_options: []
 require_paths: