doing 2.1.42 → 2.1.45

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8021e76952eb60e4eb68c5aa013f558e7e9e5db454bad792c1ae7e5cc495e24c
-  data.tar.gz: 5eda874992b4f9648c421afdc4429963f2614d08aabba8fb338d4d27c353e258
+  metadata.gz: e59c924734be0039ff00042d055094036f77cd0389b3c5bd9fa219df8d18138a
+  data.tar.gz: 65000a9977a118261abcda154b1f8af44cca2de16fd5244b54e67aca10d5e90c
 SHA512:
-  metadata.gz: 37ce93cc4868cbb5565f18b8cd2a77d61099f9692c5b6bcaacdf9329876faa4bc9ff240adc29ea2f8e4cff76adbadc697f583131dfcdb61379dc998a91d40de4
-  data.tar.gz: 06d59cd04607005a65f166701873107a8d4817986007940489dfda3247d97d567a4072d62eb05687f50e1ba93eb6341f1db8f5a317df948836fa56945270a8fa
+  metadata.gz: 6a13c4113ec1ca306bb51da1f3e7585bfebdb7d7c1623bf60d51fe82f202b301623658cd5a4c9ecdf5ae01aca5b1c7bdd305803c9994cf7d3968fb426c6026c6
+  data.tar.gz: 60ad5f63ce19e57a2b15c051a02c0c0f9afc349db11aa726337dd33c919e59cfc28401c0b59f97692d6b90e85c0b5a3f9592c2a24733f52c2d53b327203b0df4

data/CHANGELOG.md

@@ -1,3 +1,56 @@
+### 2.1.45
+
+2022-03-22 08:57
+
+#### FIXED
+
+- Specifying '12am' as a start time filter resulted in a Nil error
+
+### 2.1.44
+
+2022-03-21 07:46
+
+#### NEW
+
+- `doing views --remove NAME` to delete a view
+- Deleting all view content in editor (`doing views -e`) deletes the view
+
+#### IMPROVED
+
+- When saving a view, ignore keys that are the same as the default template
+- Commands accepting `--save` also accept `--title TITLE`
+
+#### FIXED
+
+- When saving a view, store original date string instead of chronified result
+- Error when testing for valid date
+
+### 2.1.43
+
+2022-03-20 12:44
+
+#### NEW
+
+- 'parent' key in view config allows inheritance
+- Use `--save NAME` with view commands to store command line options as a view in config
+- Views function as commands, so you can run `doing custom` and get `doing view custom` if 'custom' is not a recognized command
+- Breaking change - boolean switches on the command line no longer override views
+- Add an argument to `doing views` to dump the YAML for a single view
+- Use `doing views NAME --editor` to open the YAML for a single view in the default editor, saving the result to main config
+- Use `doing views [-e] -o json NAME` to dump or edit a view as json instead of YAML
+
+#### IMPROVED
+
+- `doing changes --only [changed,new,improved,fixed]` to only show changes of a type
+- Allow all show options in view config
+- Disable autocorrect for command names so custom views can better override similarly-spelled commands
+- `doing changes --prefix` will output each change with a type prefix
+- Include -F switch in `less` when paging to avoid pager if less than one screen
+
+#### FIXED
+
+- `doing templates --list` returning error
+
 ### 2.1.42
 
 2022-03-17 09:38

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    doing (2.1.42)
+    doing (2.1.45)
       chronic (~> 0.10, >= 0.10.2)
       deep_merge (~> 1.2, >= 1.2.1)
       gli (~> 2.20, >= 2.20.1)
@@ -22,11 +22,11 @@ GEM
     chronic (0.10.2)
     deep_merge (1.2.2)
     github-markup (4.0.0)
-    gli (2.20.1)
+    gli (2.21.0)
     haml (5.0.4)
       temple (>= 0.8.0)
       tilt
-    kramdown (2.3.1)
+    kramdown (2.3.2)
       rexml
     parallel (1.21.0)
     parallel_tests (3.7.3)
@@ -40,7 +40,7 @@ GEM
     rdoc (6.3.3)
     redcarpet (3.5.1)
     rexml (3.2.5)
-    rouge (3.27.0)
+    rouge (3.28.0)
     safe_yaml (1.0.5)
     strings (0.2.1)
       strings-ansi (~> 0.2)

data/README.md

@@ -8,7 +8,7 @@ _If you're one of the rare people like me who find this useful, feel free to
 
 <!--README-->
 
-The current version of `doing` is <!--VER-->2.1.41<!--END VER-->.
+The current version of `doing` is <!--VER-->2.1.44<!--END VER-->.
 
 Find all of the documentation in the [doing wiki][wiki].
 

data/bin/commands/changes.rb

@@ -40,6 +40,13 @@ module Doing
       cmd.desc 'Only output changes, no version numbers, headers, or dates'
       cmd.switch %i[C changes], default_value: false, negatable: false
 
+      cmd.desc 'Include (CHANGE|NEW|IMPROVED|FIXED) prefix on each line'
+      cmd.switch %i[p prefix]
+
+      cmd.desc 'Only show changes of type(s), comma-separated'
+      cmd.arg_name 'TYPES'
+      cmd.flag %i[only], default_value: 'changed,new,improved,fixed'
+
       cmd.desc 'Output raw Markdown'
       cmd.switch %i[m md markdown], default_value: false, negatable: false
 
@@ -72,10 +79,13 @@ command %i[changes changelog] do |c|
   cmd.add_examples(c)
 
   c.action do |_global_options, options, _args|
+    only = options[:only].split(/ *, */).map(&:normalize_change_type)
     cl = Doing::Changes.new(lookup: options[:lookup],
                             search: options[:search],
                             changes: options[:changes],
-                            sort: options[:sort])
+                            prefix: options[:prefix],
+                            sort: options[:sort],
+                            only: only)
 
     if options[:interactive]
       cl.interactive

data/bin/commands/flag.rb

@@ -8,7 +8,7 @@ command %i[mark flag] do |c|
   c.example 'doing flag --tag project1 --count 2', desc: 'Add @flagged to the last 2 entries tagged @project1'
   c.example 'doing flag --interactive --search "/(develop|cod)ing/"',
             desc: 'Find entries matching regular expression and create a menu allowing multiple selections,
-                   selected items will be @flagged'
+                  selected items will be @flagged'
 
   c.desc 'Section'
   c.arg_name 'SECTION_NAME'

data/bin/commands/grep.rb

@@ -25,7 +25,7 @@ command %i[grep search] do |c|
   c.desc 'Case sensitivity for search string matching [(c)ase-sensitive, (i)gnore, (s)mart]'
   c.arg_name 'TYPE'
   c.flag [:case], must_match: REGEX_CASE,
-                  default_value: Doing.settings.dig('search', 'case').normalize_case,
+                  default_value: Doing.setting('search.case', :smart).normalize_case,
                   type: CaseSymbol
 
   c.desc "Highlight search matches in output. Only affects command line output"
@@ -44,11 +44,15 @@ command %i[grep search] do |c|
   add_options(:tag_filter, c)
   add_options(:date_filter, c)
   add_options(:time_display, c)
+  add_options(:save, c)
 
   c.action do |_global_options, options, args|
     options[:fuzzy] = false
 
-    raise InvalidPlugin.new('output', options[:output]) if options[:output] && options[:output] !~ Doing::Plugins.plugin_regex(type: :export)
+    if options[:output] && options[:output] !~ Doing::Plugins.plugin_regex(type: :export)
+      raise InvalidPlugin.new('output', options[:output])
+
+    end
 
     template = Doing.setting(['templates', options[:config_template]]).deep_merge(Doing.settings)
     tags_color = template.key?('tags_color') ? template['tags_color'] : nil
@@ -66,5 +70,11 @@ command %i[grep search] do |c|
     options[:tags_color] = tags_color
 
     Doing::Pager.page @wwid.list_section(options)
+    if options[:save]
+      options[:before] = Doing.original_options[:date_begin] if Doing.original_options[:date_begin].good?
+      options[:after] = Doing.original_options[:date_end] if Doing.original_options[:date_end].good?
+      options[:from] = Doing.original_options[:date_range] if Doing.original_options[:date_range].good?
+      Doing.config.save_view(options.to_view, options[:save].downcase)
+   end
   end
 end

data/bin/commands/last.rb

@@ -30,6 +30,7 @@ command :last do |c|
   add_options(:output_template, c, default_template: 'last')
   add_options(:search, c)
   add_options(:tag_filter, c)
+  add_options(:save, c)
 
   c.action do |global_options, options, _args|
     options[:fuzzy] = false
@@ -70,6 +71,7 @@ command :last do |c|
                         val: options[:val]
                       })
       Doing::Pager::page last.strip if last
+      Doing.config.save_view(options.to_view, options[:save].downcase) if options[:save]
     end
   end
 end

data/bin/commands/on.rb

@@ -20,6 +20,7 @@ command :on do |c|
   add_options(:search, c)
   add_options(:tag_filter, c)
   add_options(:time_filter, c)
+  add_options(:save, c)
 
   c.action do |_global_options, options, args|
     if options[:output] && options[:output] !~ Doing::Plugins.plugin_regex(type: :export)
@@ -43,6 +44,17 @@ command :on do |c|
     options[:times] = true if options[:totals]
     options[:sort_tags] = options[:tag_sort]
 
-    Doing::Pager.page @wwid.list_date([start, finish], options[:section], options[:times], options[:output], options).chomp
+    Doing::Pager.page @wwid.list_date([start, finish],
+                                      options[:section],
+                                      options[:times],
+                                      options[:output],
+                                      options).chomp
+
+    if options[:save]
+      options[:before] = Doing.original_options[:date_end] if Doing.original_options[:date_end].good?
+      options[:after] = Doing.original_options[:date_begin] if Doing.original_options[:date_begin].good?
+      options[:from] = Doing.original_options[:date_range] if Doing.original_options[:date_range].good?
+      Doing.config.save_view(options.to_view, options[:save].downcase)
+    end
   end
 end

data/bin/commands/recent.rb

@@ -17,6 +17,7 @@ command :recent do |c|
 
   add_options(:output_template, c, default_template: 'recent')
   add_options(:time_display, c)
+  add_options(:save, c)
 
   c.action do |global_options, options, args|
     section = @wwid.guess_section(options[:section]) || options[:section].cap_first
@@ -53,7 +54,9 @@ command :recent do |c|
       }
 
       Doing::Pager::page @wwid.recent(count, section.cap_first, opts)
-
+      opts[:count] = count
+      opts[:title] = options[:title]
+      Doing.config.save_view(opts.to_view, options[:save].downcase) if options[:save]
     end
   end
 end

data/bin/commands/show.rb

@@ -47,6 +47,7 @@ command :show do |c|
   add_options(:search, c)
   add_options(:tag_filter, c)
   add_options(:date_filter, c)
+  add_options(:save, c)
 
   c.action do |global_options, options, args|
     options[:fuzzy] = false
@@ -153,5 +154,12 @@ command :show do |c|
     opt[:tags_color] = template['tags_color']
 
     Doing::Pager.page @wwid.list_section(opt, items: items)
+
+    if options[:save]
+      opt[:before] = Doing.original_options[:date_begin] if Doing.original_options[:date_begin].good?
+      opt[:after] = Doing.original_options[:date_end] if Doing.original_options[:date_end].good?
+      opt[:from] = Doing.original_options[:date_range] if Doing.original_options[:date_range].good?
+      Doing.config.save_view(opt.to_view, options[:save].downcase)
+    end
   end
 end

data/bin/commands/since.rb

@@ -15,7 +15,7 @@ command :since do |c|
   add_options(:time_display, c)
   add_options(:tag_filter, c)
   add_options(:search, c)
-
+  add_options(:save, c)
   c.action do |_global_options, options, args|
     raise DoingRuntimeError, %(Invalid output type "#{options[:output]}") if options[:output] && options[:output] !~ Doing::Plugins.plugin_regex(type: :export)
 
@@ -25,7 +25,7 @@ command :since do |c|
 
     date_string.sub!(/(day) (\d)/, '\1 at \2')
     date_string.sub!(/(\d+)d( ago)?/, '\1 days ago')
-
+    Doing.original_options[:date_begin] = date_string
     start = date_string.chronify(guess: :begin)
     finish = Time.now
 
@@ -37,5 +37,9 @@ command :since do |c|
     options[:sort_tags] = options[:tag_sort]
 
     Doing::Pager.page @wwid.list_date([start, finish], options[:section], options[:times], options[:output], options).chomp
+    if options[:save]
+      options[:after] = Doing.original_options[:date_begin] if Doing.original_options[:date_begin].good?
+      Doing.config.save_view(options.to_view, options[:save].downcase)
+    end
   end
 end

data/bin/commands/template.rb

@@ -28,34 +28,23 @@ command :template do |c|
       else
         $stdout.puts "Available templates: #{Doing::Plugins.plugin_templates.join(', ')}"
       end
-      return
-    end
-
-    if args.empty?
-      type = Doing::Prompt.choose_from(Doing::Plugins.plugin_templates, sorted: false, prompt: 'Select template type > ')
-      type.sub!(/ \(.*?\)$/, '').strip!
-      options[:save] = Doing::Prompt.yn("Save to #{options[:path]}? (No outputs to STDOUT)", default_response: false)
     else
-      type = args[0]
-    end
 
-    raise InvalidPluginType, "No type specified, use `doing template [#{Doing::Plugins.plugin_templates.join('|')}]`" unless type
+      if args.empty?
+        type = Doing::Prompt.choose_from(Doing::Plugins.plugin_templates, sorted: false, prompt: 'Select template type > ')
+        type.sub!(/ \(.*?\)$/, '').strip!
+        options[:save] = Doing::Prompt.yn("Save to #{options[:path]}? (No outputs to STDOUT)", default_response: false)
+      else
+        type = args[0]
+      end
+
+      raise InvalidPluginType, "No type specified, use `doing template [#{Doing::Plugins.plugin_templates.join('|')}]`" unless type
 
-    if options[:save]
-      Doing::Plugins.template_for_trigger(type, save_to: options[:path])
-    else
-      $stdout.puts Doing::Plugins.template_for_trigger(type, save_to: nil)
+      if options[:save]
+        Doing::Plugins.template_for_trigger(type, save_to: options[:path])
+      else
+        $stdout.puts Doing::Plugins.template_for_trigger(type, save_to: nil)
+      end
     end
-
-    # case args[0]
-    # when /html|haml/i
-    #   $stdout.puts @wwid.haml_template
-    # when /css/i
-    #   $stdout.puts @wwid.css_template
-    # when /markdown|md|erb/i
-    #   $stdout.puts @wwid.markdown_template
-    # else
-    #   exit_now! 'Invalid type specified, must be HAML or CSS'
-    # end
   end
 end

data/bin/commands/today.rb

@@ -15,6 +15,7 @@ command :today do |c|
   add_options(:output_template, c, default_template: 'today')
   add_options(:time_filter, c)
   add_options(:time_display, c)
+  add_options(:save, c)
 
   c.action do |_global_options, options, _args|
     raise InvalidPlugin.new('output', options[:output]) if options[:output] && options[:output] !~ Doing::Plugins.plugin_regex(type: :export)
@@ -22,7 +23,9 @@ command :today do |c|
     options[:times] = true if options[:totals]
     options[:sort_tags] = options[:tag_sort]
     filter_options = %i[after before times duration from section sort_tags totals tag_order template config_template only_timed].each_with_object({}) { |k, hsh| hsh[k] = options[k] }
-
+    filter_options[:today] = true
     Doing::Pager.page @wwid.today(options[:times], options[:output], filter_options).chomp
+    filter_options[:title] = options[:title]
+    Doing.config.save_view(filter_options.to_view, options[:save].downcase) if options[:save]
   end
 end

data/bin/commands/view.rb

@@ -15,28 +15,24 @@ command :view do |c|
   c.arg_name 'COUNT'
   c.flag %i[c count], must_match: /^\d+$/, type: Integer
 
-  c.desc "Output to export format (#{Doing::Plugins.plugin_names(type: :export)})"
-  c.arg_name 'FORMAT'
-  c.flag %i[o output]
-
   c.desc 'Age (oldest|newest)'
   c.arg_name 'AGE'
-  c.flag %i[age], default_value: :newest, type: AgeSymbol
+  c.flag %i[age], type: AgeSymbol
 
   c.desc 'Show time intervals on @done tasks'
   c.switch %i[t times], default_value: true, negatable: true
 
   c.desc 'Show elapsed time on entries without @done tag'
-  c.switch [:duration]
+  c.switch [:duration], default_value: false, negatable: false
 
   c.desc 'Show intervals with totals at the end of output'
   c.switch [:totals], default_value: false, negatable: false
 
   c.desc 'Include colors in output'
-  c.switch [:color], default_value: true, negatable: true
+  c.switch [:color], negatable: true
 
   c.desc "Highlight search matches in output. Only affects command line output"
-  c.switch %i[h hilite], default_value: Doing.settings.dig('search', 'highlight')
+  c.switch %i[h hilite], default_value: false, negatable: true
 
   c.desc 'Sort tags by (name|time)'
   c.arg_name 'KEY'
@@ -53,8 +49,9 @@ command :view do |c|
   c.switch %i[i interactive], negatable: false, default_value: false
 
   add_options(:search, c)
-  add_options(:tag_filter, c)
+  add_options(:tag_filter_no_defaults, c)
   add_options(:date_filter, c)
+  add_options(:output_template_no_defaults, c)
 
   c.action do |global_options, options, args|
     options[:fuzzy] = false
@@ -85,83 +82,55 @@ command :view do |c|
                 Doing.setting('current_section')
               end
 
-    view = @wwid.get_view(title)
+    view = @wwid.view_to_options(title)
 
     if view
-      page_title = view['title'] || title.cap_first
-      only_timed = if (view.key?('only_timed') && view['only_timed']) || options[:only_timed]
-                     true
-                   else
-                     false
-                   end
+      options = Doing::Util.deep_merge_hashes(view, options)
 
-      template = view['template'] || nil
-      date_format = view['date_format'] || nil
+      options[:totals] = view[:totals] unless options[:totals]
+      options[:only_timed] = view[:only_timed] unless options[:only_timed]
+      options[:times] = view[:times] if options[:times]
+      options[:duration] = view[:duration] unless options[:duration]
+      options[:hilite] = view[:hilite] unless options[:hilite]
 
-      tags_color = view['tags_color'] || nil
+      page_title = options[:title] || title.cap_first
       tag_filter = false
-      if options[:tag]
+      if options[:tag] && options[:tag].good
         tag_filter = { 'tags' => [], 'bool' => 'OR' }
-        bool = options[:bool]
+        bool = options[:bool].normalize_bool
         tag_filter['bool'] = bool
         tag_filter['tags'] = if bool == :pattern
                                options[:tag]
                              else
                                options[:tag].gsub(/[, ]+/, ' ').split(' ').map(&:strip)
                              end
-      elsif view.key?('tags') && view['tags'].good?
+        options[:tags] = nil
+        options[:bool] = bool
+      elsif options[:tags]
         tag_filter = { 'tags' => [], 'bool' => 'OR' }
-        bool = view.key?('tags_bool') && !view['tags_bool'].nil? ? view['tags_bool'].normalize_bool : :pattern
+        bool = options[:bool] ? options[:bool].normalize_bool : :pattern
         tag_filter['bool'] = bool
-        tag_filter['tags'] = if view['tags'].instance_of?(Array)
-                               bool == :pattern ? view['tags'].join(' ').strip : view['tags'].map(&:strip)
+        tag_filter['tags'] = if options[:tags].instance_of?(Array)
+                               bool == :pattern ? options[:tags].join(' ').strip : options[:tags].map(&:strip)
                              else
-                               bool == :pattern ? view['tags'].strip : view['tags'].gsub(/[, ]+/, ' ').split(' ').map(&:strip)
+                               bool == :pattern ? options[:tags].strip : options[:tags].gsub(/[, ]+/, ' ').split(' ').map(&:strip)
                              end
+        options[:tags] = nil
+        options[:bool] = bool
       end
 
-      # If the -o/--output flag was specified, override any default in the view template
-      options[:output] ||= view.key?('output_format') ? view['output_format'] : 'template'
-
-      count = if options[:count]
-                options[:count]
-              elsif view.key?('count')
-                view['count']
-              else
-                10
-              end
-
-      section = if options[:section]
-                  section
-                else
-                  view['section'] || Doing.setting('current_section')
-                end
-      order = if view.key?('order')
-                view['order'].normalize_order
-              else
-                :asc
-              end
-
-      totals = if options[:totals]
-                 true
-               else
-                 view['totals'] || false
-               end
-      tag_order = options[:tag_order] || view['tag_order']&.normalize_order || :asc
-
-      options[:times] = true if totals
+      section = options[:section] || Doing.setting('current_section')
+      order = options[:order]&.normalize_order || :asc
+      totals = options[:totals] || false
+      tag_order = options[:tag_order]&.normalize_order || :asc
       output_format = options[:output]&.downcase || 'template'
 
-      options[:sort_tags] = if options[:tag_sort]
-                              options[:tag_sort]
-                            elsif view.key?('tag_sort')
-                              view['tag_sort'].normalize_tag_sort
-                            else
-                              false
-                            end
-
-      %w[before after from duration].each { |k| options[k.to_sym] = view[k] if view.key?(k) && !options[k.to_sym] }
+      options[:times] = true if totals
 
+      options.rename_key(:tag_sort, :sort_tags)
+      options[:sort_tags] ||= :name
+      options.rename_key(:date_format, :format)
+      options.rename_key(:color, :highlight)
       search = nil
 
       if options[:search]
@@ -172,12 +141,8 @@ command :view do |c|
       options[:age] ||= :newest
 
       opts = options.clone
-      opts[:age] = options[:age]
-      opts[:count] = count
-      opts[:format] = date_format
-      opts[:highlight] = options[:color]
-      opts[:hilite] = options[:hilite]
-      opts[:only_timed] = only_timed
+
+      opts[:count] ||= 10
       opts[:order] = order
       opts[:output] = options[:interactive] ? nil : options[:output]
       opts[:output] = output_format
@@ -186,8 +151,6 @@ command :view do |c|
       opts[:section] = section
       opts[:tag_filter] = tag_filter
       opts[:tag_order] = tag_order
-      opts[:tags_color] = tags_color
-      opts[:template] = template
       opts[:totals] = totals
       opts[:view_template] = title
 

data/bin/commands/views.rb

@@ -1,11 +1,108 @@
 # @@views
-desc 'List available custom views'
+desc 'List available custom views. Specify view names to see YAML configurations.'
+arg_name 'NAME(S)', optional: true
 command :views do |c|
+  c.example 'doing views', desc: 'list all views'
+  c.example 'doing views -c', desc: 'list views in column, ideal for shell completion'
+  c.example 'doing views color', desc: 'dump the YAML for a single view'
+  c.example 'doing views -e color', desc: 'edit the YAML configuration for a single view'
+  c.example 'doing views -e -o json color finished', desc: 'edit multiple view configs as JSON'
+
   c.desc 'List in single column'
-  c.switch %i[c column], default_value: false
+  c.switch %i[c column], default_value: false, negatable: false
+
+  c.desc 'Open YAML for view in editor (requires argument)'
+  c.switch %i[e editor], negatable: false
+
+  c.desc 'Output/edit view in alternative format (json, yaml)'
+  c.arg_name 'FORMAT'
+  c.flag %i[o output], must_match: /^[jy]/i, default_value: 'yaml'
+
+  c.desc 'Delete view config'
+  c.switch %i[r remove], negatable: false
+
+  c.action do |_global_options, options, args|
+    cmd = Doing::ViewsCommand.new(options, args, @wwid)
+
+    if args.count.positive?
+      if options[:remove]
+        cmd.remove_views
+      elsif options[:editor]
+        cmd.edit_views
+      else
+        cmd.output_views
+      end
+    else
+      cmd.list_views
+    end
+  end
+end
+
+module Doing
+  # views Command
+  class ViewsCommand
+    def initialize(options, args, wwid)
+      @options = options
+      @args = args
+      @wwid = wwid
+
+      @views = {}
+      args.each do |v|
+        view = @wwid.get_view(v)
+        raise InvalidArgument, 'Unrecognized view' unless view
+
+        @views[v] = view if view
+      end
+    end
+
+    def list_views
+      joiner = @options[:column] ? "\n" : "\t"
+      print @wwid.views.join(joiner)
+    end
+
+    def save_view(view, res)
+      val = if res.nil? || !res.key?(view) || res[view]&.empty?
+              nil
+            else
+              res[view]
+            end
+
+      Doing.set("views.#{view}", val)
+    end
+
+    def remove_views
+      @args.each do |v|
+        Doing.set("views.#{v}", nil)
+      end
+
+      save_config
+    end
+
+    def edit_views
+      res = if @options[:output] =~ /^j/i
+              JSON.parse(@wwid.fork_editor(JSON.pretty_generate(@views), message: nil))
+            else
+              YAML.safe_load(@wwid.fork_editor(YAML.dump(@views), message: nil))
+            end
+      @args.each do |v|
+        save_view(v, res)
+      end
+      save_config
+    end
+
+    def output_views
+      out = if @options[:output] =~ /^j/i
+              JSON.pretty_generate(@views)
+            else
+              YAML.dump(@views)
+            end
+
+      Doing::Pager.page out
+    end
 
-  c.action do |_global_options, options, _args|
-    joiner = options[:column] ? "\n" : "\t"
-    print @wwid.views.join(joiner)
+    def save_config
+      Doing::Util.write_to_file(Doing.config.config_file, YAML.dump(Doing.settings), backup: true)
+      Doing.logger.warn('Config:', "#{Doing.config.config_file} updated")
+    end
   end
 end