dohtest 0.1.54 → 0.1.55

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f671b0ee5564d932bd5cf2edd188c31292a0fee261a8ad5207e446450b93cb1e
-  data.tar.gz: 92e6b918b818a6e1b3824cde7e08c7964999a1e8088d024ed3f7b6ee2f365a14
+  metadata.gz: bfbc04ce3b53966d24d062b84ba569837f0b31e4d3a2f62a6fd1dd3b034816fa
+  data.tar.gz: 693a91b6c27c0b262bd2313850b9cccdb67969cec40aaf2d9797cf159dd606fe
 SHA512:
-  metadata.gz: 98d77e960acc16540bd4e52588af6cb0a98c051d3d068b4cdd49632b247bc46ce164c55cffa0927622b0f28a01d33ab66f7ee171623e798da435203adacf75a3
-  data.tar.gz: 7a64336cbb411d9056253ba1e2c9ab8a0d99ed857ffea18751272a8ede1b38bc8838f04e2133caf53ed0ac4aa64753869a5cbcb49c08d7e354d332e00f07200b
+  metadata.gz: 919fdd8ddd3a2e839d83ddda295340bb335842aa610c374da1938c2e73546608432b744dbd7636af5d727f570d3ad6754d0215e1fb9aba533bab7c2c7890b8fe
+  data.tar.gz: 30857a2fc0ab018f01e271e59186fb518e1485fed9b72d56236128663720c8df136eea427fc14771653a4b76c6cbeac24aa2cde209b18da80f86b9c4275682bc

data/bin/dohtest_repeat

@@ -3,3 +3,4 @@
 cmd = "dohtest #{ARGV.join(' ')}"
 while(system(cmd)) do
 end
+exit($?.exitstatus || 1)

data/lib/dohtest/group_runner.rb

@@ -187,6 +187,10 @@ class GroupRunner
   def total_problems
     @error_count + @assertions_failed
   end
+
+  def total_assertions
+    return @assertions_passed + @assertions_failed
+  end
 end
 
 end

data/lib/dohtest/master_runner.rb

@@ -26,19 +26,30 @@ class MasterRunner
     end
 
     total_problems = 0
+    total_assertions = 0
+    callbacks_succeeded = true
     # sort them to be the same order no matter what (different machines were returning different results)
     TestGroup.descendants.sort{|a,b|a.to_s<=>b.to_s}.shuffle.each do |group_class|
       runner = GroupRunner.new(group_class, @output, @config)
       brink_hit = runner.run
       total_problems += runner.total_problems
+      total_assertions += runner.total_assertions
       break if brink_hit
     end
     @config[:post_all_callback].each do |proc|
       if !proc.call(total_problems)
+        callbacks_succeeded = false
         @output.callback_failed(proc.inspect)
       end
     end
     @output.run_end(Time.now - start_time)
+
+    success = (total_assertions > 0) && (total_problems == 0) && callbacks_succeeded
+    if success
+      return 0
+    else
+      return 1
+    end
   end
 end
 

data/lib/dohtest/stream_output.rb

@@ -72,9 +72,6 @@ class StreamOutput
     msg = "#{error_str}; #{group_str}; #{test_str}; #{assertion_str}"
     msg = colorize(:success, msg) if success
     @std_ios.puts msg
-
-    # this is to generate an exit code; true translates to 0, false to 1
-    success
   end
 
   def group_begin(group_name)

data/test/test_backtrace_parser.rb

@@ -4,7 +4,7 @@ require 'dohtest/backtrace_parser'
 
 module DohTest
 
-class TestBacktraceParser < MiniTest::Test
+class TestBacktraceParser < Minitest::Test
   def create_single_stack
     retval = []
     retval << "/Users/somebody/dohtest/lib/doh/test/assertions.rb:10:in `assert'"

data/test/test_exit_codes.rb

@@ -0,0 +1,106 @@
+require 'dohroot'; Doh.find_root_from_file
+require 'minitest/autorun'
+require 'tmpdir'
+
+module DohTest
+
+# runs bin/dohtest and bin/dohtest_repeat as subprocesses against generated
+# fixture suites, pinning the exit-code contract: 0 only when tests ran and
+# every assertion passed, 1 otherwise
+class TestExitCodes < Minitest::Test
+  BIN_DIR = File.join(Doh.root, 'bin')
+  LIB_DIR = File.join(Doh.root, 'lib')
+
+  PASSING_GROUP = <<~EOT
+    class TestExitPass < DohTest::TestGroup
+      def test_pass
+        assert_equal(4, 2 + 2)
+      end
+    end
+  EOT
+
+  FAILING_GROUP = <<~EOT
+    class TestExitFail < DohTest::TestGroup
+      def test_pass
+        assert_equal(4, 2 + 2)
+      end
+      def test_fail
+        assert_equal(5, 2 + 2)
+      end
+    end
+  EOT
+
+  ERROR_GROUP = <<~EOT
+    class TestExitError < DohTest::TestGroup
+      def test_error
+        raise 'boom'
+      end
+    end
+  EOT
+
+  NO_ASSERTION_GROUP = <<~EOT
+    class TestExitNoAssertions < DohTest::TestGroup
+      def test_nothing
+      end
+    end
+  EOT
+
+  def run_dohtest(path)
+    system('ruby', "-I#{LIB_DIR}", File.join(BIN_DIR, 'dohtest'), '-q', path, :out => File::NULL, :err => File::NULL)
+    return $?.exitstatus
+  end
+
+  def run_dohtest_repeat(path)
+    env = {'PATH' => "#{BIN_DIR}:#{ENV['PATH']}", 'RUBYLIB' => LIB_DIR}
+    system(env, 'ruby', File.join(BIN_DIR, 'dohtest_repeat'), '-q', path, :out => File::NULL, :err => File::NULL)
+    return $?.exitstatus
+  end
+
+  def with_fixture(group_source)
+    Dir.mktmpdir do |dir|
+      File.write(File.join(dir, 'dohroot'), '')
+      path = File.join(dir, 'fixture.dt.rb')
+      File.write(path, group_source)
+      yield path
+    end
+  end
+
+  def test_all_assertions_passing_exits_zero
+    with_fixture(PASSING_GROUP) do |path|
+      assert_equal(0, run_dohtest(path))
+    end
+  end
+
+  def test_assertion_failure_exits_one
+    with_fixture(FAILING_GROUP) do |path|
+      assert_equal(1, run_dohtest(path))
+    end
+  end
+
+  def test_error_exits_one
+    with_fixture(ERROR_GROUP) do |path|
+      assert_equal(1, run_dohtest(path))
+    end
+  end
+
+  def test_no_assertions_exits_one
+    with_fixture(NO_ASSERTION_GROUP) do |path|
+      assert_equal(1, run_dohtest(path))
+    end
+  end
+
+  def test_no_test_files_exits_one
+    Dir.mktmpdir do |dir|
+      File.write(File.join(dir, 'dohroot'), '')
+      assert_equal(1, run_dohtest(dir))
+    end
+  end
+
+  def test_dohtest_repeat_propagates_failure
+    with_fixture(FAILING_GROUP) do |path|
+      assert_equal(1, run_dohtest_repeat(path))
+    end
+  end
+end
+
+end

data/test/test_group_runner.rb

@@ -5,7 +5,7 @@ require 'dohtest/capture_output'
 
 module DohTest
 
-class TestGroupRunner < MiniTest::Test
+class TestGroupRunner < Minitest::Test
   def verify_event(expected_pairs, event)
     expected_pairs.each_pair do |key, value|
       assert_equal(value, event[key])

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dohtest
 version: !ruby/object:Gem::Version
-  version: 0.1.54
+  version: 0.1.55
 platform: ruby
 authors:
 - ATPSoft
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-03 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dohroot
@@ -64,12 +63,12 @@ files:
 - lib/dohtest/stream_output.rb
 - lib/dohtest/test_group.rb
 - test/test_backtrace_parser.rb
+- test/test_exit_codes.rb
 - test/test_group_runner.rb
 homepage: https://github.com/atpsoft/dohtest
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -84,10 +83,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.11
-signing_key: 
+rubygems_version: 4.0.17
 specification_version: 4
 summary: minimalist unit test framework
 test_files:
 - test/test_backtrace_parser.rb
+- test/test_exit_codes.rb
 - test/test_group_runner.rb