dodopayments 1.53.4 → 1.53.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5bbabecefa340663efbe0095949582e8248939ee5a74d41cb7a15d3f14daf2f3
-  data.tar.gz: 9bd2ba1cb5e385288c97a5a98067a6323c616334ed6f3fedbaeb4de6ce2b6c22
+  metadata.gz: aa5423b5289785f33d63e1cc61ecbf036f7f42b18bd9da4f29647cafa52df786
+  data.tar.gz: 3f8abcda4598c912e19afafc8b3cda63232b36ad266e896867592306c0c9c894
 SHA512:
-  metadata.gz: 4da1e34189f02858a1581291f218c6d89f5d8d043b0f72dfc15405d85838c78d86fa67595dd5e7f35e281fde5346eb666e43885e20d9a676b5a14f76e9045650
-  data.tar.gz: 3ff7123a5765039c24a5cd57144757d9e4f52d7b0a39c7b7cb7dc31f095934d103756d5a1974e5b856bc14e5fd48287614b40edafee04c14b89cc536cf057c8c
+  metadata.gz: cf2b1cc5655183c535603d6462ea702e0be3bec3aaaad869f0de91445eae6611bf3fc5ddea23c9bea6a0775ab1803bc06d96be07cf37bb73198a5ab42f07582f
+  data.tar.gz: cc9d49216945bc4c8d364524deb8dbfb9d90e7dd6400a319fbaa65592a5403bc25b710d7292f13c0c8656387d12adab919ecf0931897f3ba22375e406a264d15

data/CHANGELOG.md

@@ -1,5 +1,26 @@
 # Changelog
 
+## 1.53.5 (2025-10-01)
+
+Full Changelog: [v1.53.4...v1.53.5](https://github.com/dodopayments/dodopayments-ruby/compare/v1.53.4...v1.53.5)
+
+### Bug Fixes
+
+* always send `filename=...` for multipart requests where a file is expected ([2521920](https://github.com/dodopayments/dodopayments-ruby/commit/25219203e67ac52d02c0464ddbe2a1edfa584b55))
+* coroutine leaks from connection pool ([105ced3](https://github.com/dodopayments/dodopayments-ruby/commit/105ced3287dc953a6bb13cc6442ab74f5b72d852))
+* shorten multipart boundary sep to less than RFC specificed max length ([66ffab7](https://github.com/dodopayments/dodopayments-ruby/commit/66ffab71b6a77267df14a90fd5bde12d22ad4bee))
+
+
+### Performance Improvements
+
+* faster code formatting ([5e92807](https://github.com/dodopayments/dodopayments-ruby/commit/5e9280755725f1420ca9e0d87ca7fa3965db4331))
+
+
+### Chores
+
+* allow fast-format to use bsd sed as well ([5addb87](https://github.com/dodopayments/dodopayments-ruby/commit/5addb871c35167235fd876217b802fcb21897ae2))
+* **internal:** codegen related update ([66cddcb](https://github.com/dodopayments/dodopayments-ruby/commit/66cddcbfa5be3de026313de045736ec56ecb4c27))
+
 ## 1.53.4 (2025-09-24)
 
 Full Changelog: [v1.53.3...v1.53.4](https://github.com/dodopayments/dodopayments-ruby/compare/v1.53.3...v1.53.4)

data/README.md

@@ -17,7 +17,7 @@ To use this gem, install via Bundler by adding the following to your application
 <!-- x-release-please-start-version -->
 
 ```ruby
-gem "dodopayments", "~> 1.53.4"
+gem "dodopayments", "~> 1.53.5"
 ```
 
 <!-- x-release-please-end -->

data/lib/dodopayments/file_part.rb

@@ -38,18 +38,21 @@ module Dodopayments
     def to_yaml(*a) = read.to_yaml(*a)
 
     # @param content [Pathname, StringIO, IO, String]
-    # @param filename [String, nil]
+    # @param filename [Pathname, String, nil]
     # @param content_type [String, nil]
     def initialize(content, filename: nil, content_type: nil)
-      @content = content
+      @content_type = content_type
       @filename =
-        case content
-        in Pathname
-          filename.nil? ? content.basename.to_path : ::File.basename(filename)
+        case [filename, (@content = content)]
+        in [String | Pathname, _]
+          ::File.basename(filename)
+        in [nil, Pathname]
+          content.basename.to_path
+        in [nil, IO]
+          content.to_path
         else
-          filename.nil? ? nil : ::File.basename(filename)
+          filename
         end
-      @content_type = content_type
     end
   end
 end

data/lib/dodopayments/internal/transport/pooled_net_requester.rb

@@ -134,9 +134,9 @@ module Dodopayments
 
           # rubocop:disable Metrics/BlockLength
           enum = Enumerator.new do |y|
-            with_pool(url, deadline: deadline) do |conn|
-              next if finished
+            next if finished
 
+            with_pool(url, deadline: deadline) do |conn|
               req, closing = self.class.build_request(request) do
                 self.class.calibrate_socket_timeout(conn, deadline)
               end
@@ -149,7 +149,7 @@ module Dodopayments
 
               self.class.calibrate_socket_timeout(conn, deadline)
               conn.request(req) do |rsp|
-                y << [conn, req, rsp]
+                y << [req, rsp]
                 break if finished
 
                 rsp.read_body do |bytes|
@@ -160,6 +160,8 @@ module Dodopayments
                 end
                 eof = true
               end
+            ensure
+              conn.finish if !eof && conn&.started?
             end
           rescue Timeout::Error
             raise Dodopayments::Errors::APITimeoutError.new(url: url, request: req)
@@ -168,16 +170,11 @@ module Dodopayments
           end
           # rubocop:enable Metrics/BlockLength
 
-          conn, _, response = enum.next
+          _, response = enum.next
           body = Dodopayments::Internal::Util.fused_enum(enum, external: true) do
             finished = true
-            tap do
-              enum.next
-            rescue StopIteration
-              nil
-            end
+            loop { enum.next }
           ensure
-            conn.finish if !eof && conn&.started?
             closing&.call
           end
           [Integer(response.code), response, body]

data/lib/dodopayments/internal/type/file_input.rb

@@ -82,17 +82,20 @@ module Dodopayments
           #
           # @return [Pathname, StringIO, IO, String, Object]
           def dump(value, state:)
-            # rubocop:disable Lint/DuplicateBranch
             case value
+            in StringIO | String
+              # https://datatracker.ietf.org/doc/html/rfc7578#section-4.2
+              # while not required, a filename is recommended, and in practice many servers do expect this
+              Dodopayments::FilePart.new(value, filename: "upload")
             in IO
               state[:can_retry] = false
+              value.to_path.nil? ? Dodopayments::FilePart.new(value, filename: "upload") : value
             in Dodopayments::FilePart if value.content.is_a?(IO)
               state[:can_retry] = false
+              value
             else
+              value
             end
-            # rubocop:enable Lint/DuplicateBranch
-
-            value
           end
 
           # @api private

data/lib/dodopayments/internal/util.rb

@@ -566,7 +566,8 @@ module Dodopayments
         #
         # @return [Array(String, Enumerable<String>)]
         private def encode_multipart_streaming(body)
-          boundary = SecureRandom.urlsafe_base64(60)
+          # RFC 1521 Section 7.2.1 says we should have 70 char maximum for boundary length
+          boundary = SecureRandom.urlsafe_base64(46)
 
           closing = []
           strio = writable_enum do |y|

data/lib/dodopayments/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dodopayments
-  VERSION = "1.53.4"
+  VERSION = "1.53.5"
 end

data/rbi/dodopayments/file_part.rbi

@@ -27,7 +27,7 @@ module Dodopayments
     sig do
       params(
         content: T.any(Pathname, StringIO, IO, String),
-        filename: T.nilable(String),
+        filename: T.nilable(T.any(Pathname, String)),
         content_type: T.nilable(String)
       ).returns(T.attached_class)
     end

data/sig/dodopayments/file_part.rbs

@@ -14,7 +14,7 @@ module Dodopayments
 
     def initialize: (
       Pathname | StringIO | IO | String content,
-      ?filename: String?,
+      ?filename: (Pathname | String)?,
       ?content_type: String?
     ) -> void
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dodopayments
 version: !ruby/object:Gem::Version
-  version: 1.53.4
+  version: 1.53.5
 platform: ruby
 authors:
 - Dodo Payments
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-24 00:00:00.000000000 Z
+date: 2025-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool