documentrix 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11ea07d3133f8de898211353a4bcff7f926b9f75114696af333e928862ee5aeb
-  data.tar.gz: b60d8606b1974bcb43e6584f690ecb21a7e54af6915b09d9adb904bc9269b417
+  metadata.gz: ced4bf69e3ae1b4251844dd7915f8d75e72d1c40410f34c14311f70dd55c91f4
+  data.tar.gz: 6fc0799e4559f50a22d211e630ea5f7deaac671f24805f5501c85a11c7a9b853
 SHA512:
-  metadata.gz: ae907af900fc6932de6b2d022a4ca97367d6e1901442ed30e838eb7bf128b5e5d7dd572862f29cfe6196f58553d394e390062287b21cac6185e2c6845244ee5a
-  data.tar.gz: 75b95e852cbd6b412ae2651668db5cbffcb9f1c5845dd3bdfb2ea252380b9ab37d15f4b8381398f941c4c1dabeb1e7a174e9e6ef7dc4e0dc153455c4c0413b1e
+  metadata.gz: 8023a4b4d7cad8948e6cbd2a65cefd8b3993ae3de38ae5520a2ebf178989a78efb4c1296b51c614c4066c547372f9ad8067b6c8e196caaa098876a3adf44f523
+  data.tar.gz: 0c4544a80ecde5c98c1d3da64ffeb97155324fdc063993caddf6d2d0780c490b0c8ec24dbc2ca392b3ceb6023d964f58bad099ca4c509a6e43c33c4f7406beb0

data/CHANGES.md

@@ -1,5 +1,25 @@
 # Changes
 
+## 2026-06-17 v0.6.0
+
+### Changed
+
+- Refactored collection discovery to ensure strong consistency across multiple
+  client instances by delegating `Documentrix::Documents#collections` directly
+  to the cache backend.
+- Removed `@collections_cache` and the `invalidate_collections_cache!` method
+  from `lib/documentrix/documents.rb`.
+- Implemented a high-performance `#collections` method in
+  `lib/documentrix/documents/cache/redis_cache.rb` utilizing `scan_each`.
+- Implemented a high-performance `#collections` method in
+  `lib/documentrix/documents/cache/sqlite_cache.rb` using SQL `DISTINCT`.
+- Added specialized unit tests for collection extraction and regex patterns
+  within `spec/documentrix/documents/cache/redis_cache_spec.rb` and
+  `spec/documentrix/documents/cache/sqlite_cache_spec.rb`.
+- Updated `spec/documents_spec.rb` and
+  `spec/documentrix/documents/cache/interface_spec.rb` to remove dependencies
+  on the deleted invalidation method.
+
 ## 2026-06-16 v0.5.0
 
 ### Improvements

data/documentrix.gemspec

@@ -1,9 +1,9 @@
 # -*- encoding: utf-8 -*-
-# stub: documentrix 0.5.0 ruby lib
+# stub: documentrix 0.6.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "documentrix".freeze
-  s.version = "0.5.0".freeze
+  s.version = "0.6.0".freeze
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]

data/lib/documentrix/documents/cache/redis_cache.rb

@@ -101,8 +101,23 @@ class Documentrix::Documents::RedisCache
     s
   end
 
-  # The clear_all_with_prefix method removes all key-value pairs associated
-  # with the given prefix from this cache instance.
+  # Returns an array of collection names that match the given prefix.
+  # This is a high-performance override for Redis that only queries keys.
+  #
+  # @param prefix [String] the prefix to search for in collection names
+  # @return [Array<Symbol>] an array of matching collection names
+  def collections(prefix)
+    unique = Set.new
+    redis.scan_each(match: "#{prefix}*") do |key|
+      if key =~ /\A#{prefix}(.+)-/
+        unique << $1.to_sym
+      end
+    end
+    unique.to_a
+  end
+
+  # The clear_all_with_prefix method removes all key-value pairs associated with
+  # the given prefix from this cache instance.
   #
   # @return [Documentrix::Documents::RedisCache] self
   def clear_all_with_prefix

data/lib/documentrix/documents/cache/sqlite_cache.rb

@@ -108,6 +108,22 @@ class Documentrix::Documents::Cache::SQLiteCache
     result
   end
 
+  # Returns an array of collection names that match the given prefix.
+  # This is a high-performance override for SQLite that only queries keys.
+  #
+  # @param prefix [String] the prefix to search for in collection names
+  # @return [Array<Symbol>] an array of matching collection names
+  def collections(prefix)
+    execute(
+      %{ SELECT DISTINCT key FROM records WHERE key LIKE ? },
+      [ "#{prefix}%" ]
+    ).flatten.each_with_object(Set.new) do |key, set|
+      if key =~ /\A#{prefix}(.+)-/
+        set << $1.to_sym
+      end
+    end.to_a
+  end
+
   # The tags method returns an array of unique tags from the database.
   #
   # @return [Documentrix::Utils::Tags] An instance of Documentrix::Utils::Tags

data/lib/documentrix/documents.rb

@@ -163,7 +163,7 @@ class Documentrix::Documents
       infobar.progress by: batch.size
     end
     infobar.newline
-    invalidate_collections_cache!
+    self
   end
   alias << add
 
@@ -202,9 +202,7 @@ class Documentrix::Documents
   # @return [ FalseClass, TrueClass ] true if the text was removed, false
   #         otherwise.
   def delete(text)
-    res = @cache.delete(key(text))
-    invalidate_collections_cache! if res
-    res
+    @cache.delete(key(text))
   end
 
   # The size method returns the number of texts stored in the cache of this
@@ -223,7 +221,7 @@ class Documentrix::Documents
   # @return [ Documentrix::Documents ] self
   def clear(tags: nil)
     @cache.clear(tags:)
-    invalidate_collections_cache!
+    self
   end
 
   # Normalizes the source identifier to a canonical form.
@@ -321,7 +319,7 @@ class Documentrix::Documents
   def source_remove(source, digest: nil)
     source = normalize_source(source)
     @cache.clear_by_source(source, digest:, operator: '!=')
-    invalidate_collections_cache!
+    self
   end
 
   # The find method searches for strings within the cache by computing their
@@ -382,9 +380,7 @@ class Documentrix::Documents
   #
   # @return [Array] An array of unique collection names
   def collections
-    @collections_cache ||= (
-      [ default_collection ] + @cache.collections('%s-' % class_prefix)
-    ).uniq
+    [ default_collection ].concat(@cache.collections('%s-' % class_prefix)).uniq
   end
 
   # Rename the current collection, moving all keys from the old prefix to a new
@@ -400,7 +396,7 @@ class Documentrix::Documents
     new_prefix = '%s-%s-' % [ class_prefix, new_collection ]
     @cache.move_prefix(prefix, new_prefix)
     self.collection = new_collection
-    invalidate_collections_cache!
+    self
   end
 
   # The tags method returns an array of unique tags from the cache.
@@ -428,18 +424,6 @@ class Documentrix::Documents
 
   private
 
-  # Resets the memoized list of collections.
-  #
-  # This is called whenever a mutation occurs that could change the set of
-  # existing collections, ensuring that the #collections method returns a
-  # fresh, accurate list on the next call.
-  #
-  # @return [ Documentrix::Documents ] self
-  def invalidate_collections_cache!
-    @collections_cache = nil
-    self
-  end
-
   # The connect_cache method initializes and returns an instance of the
   # specified cache class.
   #

data/lib/documentrix/version.rb

@@ -1,6 +1,6 @@
 module Documentrix
   # Documentrix version
-  VERSION         = '0.5.0'
+  VERSION         = '0.6.0'
   VERSION_ARRAY   = VERSION.split('.').map(&:to_i) # :nodoc:
   VERSION_MAJOR   = VERSION_ARRAY[0] # :nodoc:
   VERSION_MINOR   = VERSION_ARRAY[1] # :nodoc:

data/spec/documentrix/documents/cache/interface_spec.rb

@@ -101,7 +101,7 @@ describe 'Documentrix::Documents::Cache Interface' do
 
       # Common methods from Cache::Common
       expect(cache).to respond_to(:collections)
-      expect(cache.method(:collections).owner).to eq Documentrix::Documents::Cache::Common
+      expect(cache.method(:collections).owner).to eq Documentrix::Documents::RedisCache
 
       expect(cache).to respond_to(:pre)
       expect(cache.method(:pre).owner).to eq Documentrix::Documents::Cache::Common
@@ -167,7 +167,7 @@ describe 'Documentrix::Documents::Cache Interface' do
 
       # Common methods from Cache::Common
       expect(cache).to respond_to(:collections)
-      expect(cache.method(:collections).owner).to eq Documentrix::Documents::Cache::Common
+      expect(cache.method(:collections).owner).to eq Documentrix::Documents::Cache::SQLiteCache
 
       expect(cache).to respond_to(:pre)
       expect(cache.method(:pre).owner).to eq Documentrix::Documents::Cache::Common

data/spec/documentrix/documents/cache/redis_cache_spec.rb

@@ -184,5 +184,29 @@ describe Documentrix::Documents::RedisCache do
       expect(redis).to receive(:get).with("#{prefix}foo").and_return(JSON(source: 's1', digest: 'd1'))
       expect(cache.source_exist?('s1', digest: 'd2')).to be false
     end
+
+    describe '#collections' do
+      it 'extracts unique collection names from keys' do
+        expect(redis).to receive(:scan_each).with(match: "#{prefix}*").and_yield(
+          "#{prefix}col1-foo"
+        ).and_yield(
+          "#{prefix}col1-bar"
+        ).and_yield(
+          "#{prefix}col2-baz"
+        )
+
+        expect(cache.collections(prefix)).to match_array([:col1, :col2])
+      end
+
+      it 'ignores keys that do not follow the collection pattern' do
+        expect(redis).to receive(:scan_each).with(match: "#{prefix}*").and_yield(
+          "#{prefix}valid-foo"
+        ).and_yield(
+          "#{prefix}invalid" # No trailing dash after the name
+        )
+
+        expect(cache.collections(prefix)).to eq [:valid]
+      end
+    end
   end
 end

data/spec/documentrix/documents/cache/sqlite_cache_spec.rb

@@ -353,4 +353,29 @@ describe Documentrix::Documents::SQLiteCache do
       expect(cache.find_records(needle)).to eq []
     end
   end
+
+  describe '#collections' do
+    it 'extracts unique collection names matching the prefix' do
+      # Since cache['key'] = val stores as "#{prefix}#{key}",
+      # we can create keys like "col1-foo" to get "test-col1-foo"
+      cache['col1-foo'] = test_value
+      cache['col1-bar'] = test_value
+      cache['col2-baz'] = test_value
+      cache['justprefix'] = test_value # Matches prefix, but not the pattern "prefix(name)-"
+
+      expect(cache.collections('test-')).to match_array([:col1, :col2])
+    end
+
+    it 'returns empty array when no keys match the prefix' do
+      cache['foo'] = test_value
+      expect(cache.collections('nonexistent-')).to eq []
+    end
+
+    it 'returns empty array when keys start with prefix but lack a following hyphen' do
+      # We need a key that starts with "test-" but doesn't have another "-" later.
+      # Because cache['foo'] = val results in "test-foo", this is exactly what happens.
+      cache['foo'] = test_value
+      expect(cache.collections('test-')).to eq []
+    end
+  end
 end

data/spec/documents_spec.rb

@@ -23,8 +23,6 @@ describe Documentrix::Documents do
     expect(ollama).to receive(:embed).
       with(model:, input: %w[ foo bar ], options: nil).
       and_return(double(embeddings: [ [ 0.1 ], [ 0.2 ] ]))
-    expect(documents).to receive(:invalidate_collections_cache!).
-      and_call_original
     expect(documents.add(%w[ foo bar ])).to eq documents
     expect(documents.exist?('foo')).to eq true
     expect(documents.exist?('bar')).to eq true
@@ -35,8 +33,6 @@ describe Documentrix::Documents do
     expect(ollama).to receive(:embed).
       with(model:, input: %w[ foo ], options: nil).
       and_return(double(embeddings: [ [ 0.1 ] ]))
-    expect(documents).to receive(:invalidate_collections_cache!).
-      and_call_original
     expect(documents << 'foo').to eq documents
     expect(documents.exist?('foo')).to eq true
     expect(documents.exist?('bar')).to eq false
@@ -127,8 +123,6 @@ describe Documentrix::Documents do
 
     it 'can delete texts' do
       expect(documents << 'foo').to eq documents
-      expect(documents).to receive(:invalidate_collections_cache!).
-        and_call_original
       expect {
         documents.delete('foo')
       }.to change { documents.exist?('foo') }.from(true).to(false)
@@ -142,8 +136,6 @@ describe Documentrix::Documents do
 
     it 'can clear texts' do
       expect(documents << 'foo').to eq documents
-      expect(documents).to receive(:invalidate_collections_cache!).
-        and_call_original
       expect {
         documents.clear
       }.to change { documents.size }.from(1).to(0)
@@ -156,13 +148,9 @@ describe Documentrix::Documents do
       expect(documents.add('foo', tags: %w[ test ])).to eq documents
       expect(documents.add('bar', tags: %w[ test2 ])).to eq documents
       expect(documents.tags.to_a).to eq %w[ test test2 ]
-      expect(documents).to receive(:invalidate_collections_cache!).
-        and_call_original
       expect {
         documents.clear tags: 'test'
       }.to change { documents.size }.from(2).to(1)
-      expect(documents).to receive(:invalidate_collections_cache!).
-        and_call_original
       expect {
         documents.clear tags: :test2
       }.to change { documents.size }.from(1).to(0)
@@ -178,8 +166,6 @@ describe Documentrix::Documents do
 
       expect(documents.size).to eq 3
 
-      expect(documents).to receive(:invalidate_collections_cache!).
-        and_call_original
       documents.source_remove('source1')
 
       expect(documents.size).to eq 1
@@ -196,8 +182,6 @@ describe Documentrix::Documents do
       documents.collection = :foo
       documents << 'foo'
       expect(documents.collections).to eq %i[ default foo ]
-      expect(documents).to receive(:invalidate_collections_cache!).
-        and_call_original
       documents.rename_collection(:bar)
       expect(documents.collection).to eq :bar
       expect(documents.collections).to eq %i[ default bar ]
@@ -211,8 +195,6 @@ describe Documentrix::Documents do
       documents.collection = :bar
       documents << 'foo'
       expect(documents.collections).to eq %i[ default foo bar ]
-      expect(documents).not_to receive(:invalidate_collections_cache!).
-        and_call_original
       expect {
         documents.rename_collection(:foo)
       }.to raise_error(ArgumentError, 'new collection foo already exists!')
@@ -287,8 +269,6 @@ describe Documentrix::Documents do
       documents.add('foo', source: 's1')
 
       expect(ollama).not_to receive(:embed)
-      expect(documents).to receive(:invalidate_collections_cache!).
-        and_call_original
       documents.source_update(['foo'], source: 's1')
       expect(documents.exist?('foo')).to be true
     end
@@ -301,8 +281,6 @@ describe Documentrix::Documents do
       allow(documents.cache).to receive(:compute_file_digest).with('s1').and_return('d2')
 
       expect(ollama).to receive(:embed).once
-      expect(documents).to receive(:invalidate_collections_cache!).
-        at_least(1).and_call_original
       documents.source_update(['bar'], source: 's1')
 
       expect(documents.exist?('bar')).to be true
@@ -311,8 +289,6 @@ describe Documentrix::Documents do
 
     it 'updates the source if it is an URL' do
       expect(ollama).to receive(:embed).once
-      expect(documents).to receive(:invalidate_collections_cache!).
-        and_call_original
       documents.source_update('foo', source: 'https://www.example.com/s1')
       expect(documents.exist?('foo')).to be true
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: documentrix
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Florian Frank