documentrix 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68c409476101e4632597c139494f3fc1fe67bc0af7a655e5e5b3e4ebbd58f58c
-  data.tar.gz: fcd07ca7694b3fbed81c3a25f3fa9d9a675d120e5b82b43a13f5f71970012f3a
+  metadata.gz: c3ab97426ab9fbd4ec832a422a18d574f4c03b11f22391cbc6eded16b9ba0609
+  data.tar.gz: 991215fb26b4165a4b3562075d9742e3756218e2a24f3f32a550e232f59fb92f
 SHA512:
-  metadata.gz: cf1e95f2d994bb130b89bff9d2e43062621b849b5d0f7fb4543092b1f491bab4b9dd9e51047c3dfb216090a4f9bc853c08ba35719dea7409c34a15758070fcba
-  data.tar.gz: 59aa3347c07c2521f5661326a55d73733470ef30c62e86fc7d1ff53a4acb6cbc2da06e4c7814896b59ca16bdfab8933a7018f3f41ab30ce29593c5fac480f342
+  metadata.gz: d67e453e27428bcd8364349e988556af844caab5faa8a8edb3dcfba9650554b8dbfc66ad322a6f9f59d5ac64350d7006bf899a16b6c83f92909793301b6954d5
+  data.tar.gz: 49706d4984b27ee7b3d0f8ef8a9efec4a8e74d8bef78d78f15ed5c76f5bacc0faf20c36cef739aa78c1f68e5733696d16999bbd14228ae7be8e6cf9c9baf0a75

data/CHANGES.md

@@ -1,5 +1,16 @@
 # Changes
 
+## 2026-05-18 v0.3.1
+
+- Fixed scoping bugs in `clear_by_source` and `source_exist?` by implementing a
+  `key LIKE ?` constraint.
+- Added regression tests for prefix isolation in
+  `spec/documentrix/documents/cache/sqlite_cache_spec.rb`.
+- Introduced the `start_with_prefix` method in
+  `lib/documentrix/documents/cache/sqlite_cache.rb` to unify prefix patterns.
+- Updated `tags`, `size`, `clear_all_with_prefix`, and `each` to utilize the
+  new `start_with_prefix` method.
+
 ## 2026-05-17 v0.3.0
 
 ### New Features

data/documentrix.gemspec

@@ -1,9 +1,9 @@
 # -*- encoding: utf-8 -*-
-# stub: documentrix 0.3.0 ruby lib
+# stub: documentrix 0.3.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "documentrix".freeze
-  s.version = "0.3.0".freeze
+  s.version = "0.3.1".freeze
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]

data/lib/documentrix/documents/cache/sqlite_cache.rb

@@ -114,7 +114,7 @@ class Documentrix::Documents::Cache::SQLiteCache
     result = Documentrix::Utils::Tags.new
     execute(%{
         SELECT DISTINCT(tags) FROM records WHERE key LIKE ?
-      }, [ "#@prefix%" ]
+      }, [ start_with_prefix ]
     ).flatten.each do
       JSON(_1).each { |t| result.add(t) }
     end
@@ -126,7 +126,10 @@ class Documentrix::Documents::Cache::SQLiteCache
   #
   # @return [ Integer ] the count of records
   def size
-    execute(%{SELECT COUNT(*) FROM records WHERE key LIKE ?}, [ "#@prefix%" ]).flatten.first
+    execute(
+      %{SELECT COUNT(*) FROM records WHERE key LIKE ?},
+      [ start_with_prefix ]
+    ).flatten.first
   end
 
   # The clear_for_tags method clears the cache for specific tags by deleting
@@ -154,7 +157,7 @@ class Documentrix::Documents::Cache::SQLiteCache
   #
   # @return [ Documentrix::Documents::RedisBackedMemoryCache ] self
   def clear_all_with_prefix
-    execute(%{DELETE FROM records WHERE key LIKE ?}, [ "#@prefix%" ])
+    execute(%{DELETE FROM records WHERE key LIKE ?}, [ start_with_prefix ])
     self
   end
 
@@ -172,9 +175,21 @@ class Documentrix::Documents::Cache::SQLiteCache
   def clear_by_source(source, digest: nil, operator: ?=)
     operator = '!=' if operator != ?=
     if digest
-      execute(%{DELETE FROM records WHERE source = ? AND digest #{operator} ? }, [ source, digest ])
+      execute(
+        %{
+          DELETE FROM records
+          WHERE key LIKE ? AND source = ? AND digest #{operator} ?
+        },
+        [ start_with_prefix, source, digest ]
+      )
     else
-      execute(%{DELETE FROM records WHERE source = ?}, [ source ])
+      execute(
+        %{
+          DELETE FROM records
+          WHERE key LIKE ? AND source = ?
+        },
+        [ start_with_prefix, source ]
+      )
     end
     self
   end
@@ -194,9 +209,19 @@ class Documentrix::Documents::Cache::SQLiteCache
   def source_exist?(source, digest: nil, operator: ?=)
     operator = '!=' if operator != ?=
     if digest
-      !!execute(%{SELECT 1 FROM records WHERE source = ? AND digest #{operator} ? }, [ source, digest ]).first
+      !!execute(
+        %{
+          SELECT 1 FROM records WHERE key LIKE ? AND source = ? AND digest #{operator} ?
+        },
+        [ start_with_prefix, source, digest ]
+      ).first
     else
-      !!execute(%{SELECT 1 FROM records WHERE source = ?}, [ source ]).first
+      !!execute(
+        %{
+          SELECT 1 FROM records WHERE key LIKE ? AND source = ?
+        },
+        [ start_with_prefix, source ]
+      ).first
     end
   end
 
@@ -211,10 +236,9 @@ class Documentrix::Documents::Cache::SQLiteCache
     block or return enum_for(__method__)
 
     execute(%{
-      SELECT DISTINCT source
-      FROM records
+      SELECT DISTINCT source FROM records
       WHERE key LIKE ? AND source IS NOT NULL
-    }, [ "#@prefix%" ]).each do |source,|
+    }, [ start_with_prefix ]).each do |source,|
       source = source.full? or next
 
       block.(source)
@@ -257,7 +281,7 @@ class Documentrix::Documents::Cache::SQLiteCache
   #   cache.each do |key, value|
   #     puts "#{key}: #{value}"
   #   end
-  def each(prefix: "#@prefix%", &block)
+  def each(prefix: start_with_prefix, &block)
     block or return enum_for(__method__, prefix:)
 
     execute(%{
@@ -315,7 +339,7 @@ class Documentrix::Documents::Cache::SQLiteCache
       SELECT key, tags, embedding_id
       FROM records
       WHERE key LIKE ?#{tags_where}
-    }, [ "#@prefix%" ])
+    }, [ start_with_prefix ])
     if tags_filter
       records = records.select { |key, tags, embedding_id|
         (tags_filter & JSON(tags.to_s).to_a).size >= 1
@@ -368,6 +392,13 @@ class Documentrix::Documents::Cache::SQLiteCache
 
   private
 
+  # Returns the SQL LIKE pattern for records starting with the current prefix.
+  #
+  # @return [ String ] the prefix pattern used in SQL WHERE clauses
+  def start_with_prefix
+    "#@prefix%"
+  end
+
   # The execute method executes an SQL query on the database by calling the
   # \@database.execute method.
   #

data/lib/documentrix/version.rb

@@ -1,6 +1,6 @@
 module Documentrix
   # Documentrix version
-  VERSION         = '0.3.0'
+  VERSION         = '0.3.1'
   VERSION_ARRAY   = VERSION.split('.').map(&:to_i) # :nodoc:
   VERSION_MAJOR   = VERSION_ARRAY[0] # :nodoc:
   VERSION_MINOR   = VERSION_ARRAY[1] # :nodoc:

data/spec/documentrix/documents/cache/sqlite_cache_spec.rb

@@ -250,6 +250,47 @@ describe Documentrix::Documents::SQLiteCache do
     ]
   end
 
+  describe 'Prefix Isolation' do
+    let(:cache2) { cache.dup }
+
+    before do
+      cache2.prefix = 'other-'
+
+      # Setup shared sources and tags across prefixes
+      cache['foo'] = test_value.merge(source: 'shared.txt', tags: %w[ a ])
+      cache2['bar'] = test_value.merge(source: 'shared.txt', tags: %w[ a ])
+    end
+
+    it 'does not leak clear_by_source' do
+      expect {
+        cache.clear_by_source('shared.txt')
+      }.to change { cache.size }.from(1).to(0)
+
+      expect(cache2.size).to eq 1
+      expect(cache2.key?('bar')).to be true
+    end
+
+    it 'does not leak source_exist?' do
+      # Ensure we are checking a source that ONLY exists in the other prefix
+      cache.clear_all_with_prefix
+      cache2['baz'] = test_value.merge(source: 'only-in-2.txt')
+
+      expect(cache.source_exist?('only-in-2.txt')).to be false
+      expect(cache2.source_exist?('only-in-2.txt')).to be true
+    end
+
+    it 'does not leak tags' do
+      cache.clear_all_with_prefix
+      cache2.clear_all_with_prefix
+
+      cache['foo'] = test_value.merge(tags: %w[ prefix1 ])
+      cache2['bar'] = test_value.merge(tags: %w[ prefix2 ])
+
+      expect(cache.tags.to_a).to match_array(['prefix1'])
+      expect(cache2.tags.to_a).to match_array(['prefix2'])
+    end
+  end
+
   describe '#find_records' do
     let(:needle) { [ 0.5 ] * 1_024 }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: documentrix
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Florian Frank