document_builder 0.2.1 → 0.2.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MDY1MjliOTFlMDFiNjVjOTdlMDBkOGU4NDBhYTEzM2IyMDRmNWViOA==
+    NDQ1MmRhN2FkMzIwNGEyZTcwYjk3OWE4YjRlMDc5NzBiNmM3M2ZkOA==
   data.tar.gz: !binary |-
-    ZDM3ZWE4Y2ZkNjU1NzI2MTJlMzFhYzZjYTkzYWRiMTUwYzNiYjdhNQ==
+    ODk4OWExNDgwN2ZkYWE3ZDFlZTlmZjliNzZlOWNkMmE0Y2YzMTA3NQ==
 SHA512:
   metadata.gz: !binary |-
-    OTc0NDAzOWZmYWM0NGFiNmIxYjdmNjdlNjBlOGI5NTU2YTkxNDllNTI0NWVk
-    Y2MwMjliOTMxMDcwODE1ZWZhNWRhMzNkY2E4ODkxYjRjMzYxODBhMjdiY2Q1
-    ODEzNWU0OGU2ZDU4OWM1NDJmNmUzNTIyMGRkOTg3Mjk2YjRlMDE=
+    YzVkYWE3NzA1MjBlN2FlMDRkOTBmODIwYjdhZjE2MWNhMDNlMjZjYzlhZTU2
+    ZGNkZjcwOWQ4NDYxYTViNTQ0Y2VhZDIyZTEwYjNkOTI4NGRlYTgyMDlhYjBl
+    MjY2MDJhYzE4ZGNlZWZhNjIyOTE3NDljNWMyZjdkZDM5NTJhOWY=
   data.tar.gz: !binary |-
-    ZjY5MDM2Y2M1MzU2YmIxNjlkYmFhMTZmMTc1MTM1MDFhZTQ1NWY4ODVjNWMy
-    Nzc5NTc2ZTM5ODFjZGY3MGY1ZGEzYjRmNTJhZmY5YmZlZDRhOTAyZGMwYzgx
-    ODY1MTUyYjdlZTlkNDAzNmNiYzRmNTc3ZDA0ZTY5MTc3YjYxYmY=
+    N2M0NDk3M2I0ZmU4MThlNmNkODQ2OTAzNzdhZDBjMWE4NGFlMTg3MTJiOWM3
+    MzAwOWUzZTg4Y2MzYWY1ZTlhMDEyODc5MWQ2ZDlhMmI1ZDVkZGNjYzRlNDdl
+    MTNhNTEyOWJkNjUyZjY3YTRhMmQ1MTc3MjljY2U4ODNiZjA3NjI=

data/lib/document_builder/model.rb

@@ -1,9 +1,12 @@
 module DocumentBuilder
   module Model
     module ClassMethods
-      def add_attribute(name, attribute)
+      def attributes
         @attributes ||= {}
-        @attributes[name.to_sym] = attribute
+      end
+
+      def add_attribute(name, attribute)
+       attributes[name.to_sym] = attribute
       end
 
       def property(name, selector: nil, type: nil)
@@ -22,12 +25,6 @@ module DocumentBuilder
         @root = selector
       end
 
-      def inherited(subclass)
-        subclass.instance_variable_set(:@attributes, @attributes)
-        subclass.instance_variable_set(:@root, @root)
-        super
-      end
-
       def call(document)
         self.new(document)
       end
@@ -57,7 +54,7 @@ module DocumentBuilder
     end
 
     def attributes
-      self.class.instance_variable_get(:@attributes)
+      self.class.attributes
     end
 
     def get_attribute(name)

data/lib/document_builder/version.rb

@@ -1,3 +1,3 @@
 module DocumentBuilder
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/spec/document_builder/model_spec.rb

@@ -2,19 +2,9 @@ require 'spec_helper'
 require 'nokogiri'
 
 RSpec.describe DocumentBuilder::Model do
-  DOCUMENT = <<-XML
-    <root>
-      <collection>
-        <inner-list-item>Inner Item 1</inner-list-item>
-        <inner-list-item>Inner Item 2</inner-list-item>
-      </collection>
-      <outer-list-item>Outer Item 1</outer-list-item>
-      <outer-list-item>Outer Item 2</outer-list-item>
-      <property>Some Property</property>
-    </root>
-  XML
-
-  let(:document) { Nokogiri::XML(DOCUMENT) }
+  class EmptyDocument
+    include DocumentBuilder::Model
+  end
 
   class ListItem
     include DocumentBuilder::Model
@@ -29,25 +19,57 @@ RSpec.describe DocumentBuilder::Model do
     property :property, selector: "//property", type: TextProperty
   end
 
-  subject { SomeDocument.new(document) }
+  context 'for an xml document' do
+    let(:xml) {
+      <<-XML
+        <root>
+          <collection>
+            <inner-list-item>Inner Item 1</inner-list-item>
+            <inner-list-item>Inner Item 2</inner-list-item>
+          </collection>
+          <outer-list-item>Outer Item 1</outer-list-item>
+          <outer-list-item>Outer Item 2</outer-list-item>
+          <property>Some Property</property>
+        </root>
+      XML
+    }
 
-  it 'returns the root' do
-    expect(subject.root).to eq "//root"
-  end
+    let(:document) { Nokogiri::XML(xml) }
 
-  it 'returns an innner collection' do
-    expect(subject.collection).to be_a DocumentBuilder::Collection
-    expect(subject.collection.first).to be_a ListItem
-    expect(subject.collection.first.name).to eq "Inner Item 1"
-  end
+    subject { SomeDocument.new(document) }
+
+    it 'returns the root' do
+      expect(subject.root).to eq "//root"
+    end
 
-  it 'returns an outer collection' do
-    expect(subject.outer_collection).to be_a DocumentBuilder::Collection
-    expect(subject.outer_collection.first).to be_a ListItem
-    expect(subject.outer_collection.first.name).to eq "Outer Item 1"
+    it 'returns an innner collection' do
+      expect(subject.collection).to be_a DocumentBuilder::Collection
+      expect(subject.collection.first).to be_a ListItem
+      expect(subject.collection.first.name).to eq "Inner Item 1"
+    end
+
+    it 'returns an outer collection' do
+      expect(subject.outer_collection).to be_a DocumentBuilder::Collection
+      expect(subject.outer_collection.first).to be_a ListItem
+      expect(subject.outer_collection.first.name).to eq "Outer Item 1"
+    end
+
+    it 'returns a property' do
+      expect(subject.property).to eq "Some Property"
+    end
   end
 
-  it 'returns a property' do
-    expect(subject.property).to eq "Some Property"
+
+  context 'for an empty document' do
+    let(:document) { Nokogiri::XML("") }
+    subject { EmptyDocument.new(document) }
+
+    it 'returns an empty document' do
+      expect(subject).to be_a EmptyDocument
+    end
+
+    it 'is serialized' do
+      expect(subject.to_s).to be_a String
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: document_builder
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Patrick Schmitz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-11 00:00:00.000000000 Z
+date: 2015-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport