dockly 3.4.1 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 643369ac9e98df641a6b68eb246c6453bbd5f228
-  data.tar.gz: 6539614f380fadd9867307fe2c0dfc3314f5dfb6
+SHA256:
+  metadata.gz: f95076bb1a6669dfc79828fa8801aee570fd2a0aba323725ffdd475029ff9538
+  data.tar.gz: 0e7f27b46aa45f31c65cf13631ff856ce67d048812dbbc6e3db9250c1f6142c6
 SHA512:
-  metadata.gz: c70fbeb01ec143d0d9c54fc9d66a38dcafc709a591e150cb6ae55201fe7ef895afd3e7a7105f66f2562f8b71514fba4a1c33cc0d30f06d49ead77559264a8ff5
-  data.tar.gz: e89ca5f52ade24755fa7a96a0442484c209633817b70fa4ff024b51900a6878adc93fe6b691bb4a8c47ff4b188b356beccec5b602dc82ef97cb766468770b53f
+  metadata.gz: 0dd1127b2e8726e6e3d96999f5353c2a93e329ada97d730c2ed2a6da7f806b3045338fd72d63fb7a7432a1853a44d78c44ea6a87dee1c96a51bba228b1e65162
+  data.tar.gz: f0e739007e82215ec72881324f6e0130e14d0ec03910e329ce3a308954364dd1bb9532b42d11bb8c7f9450f3e8607b9d756c1e93b1c825cc78d78f82e4551131

data/.github/workflows/unit_test.yml

@@ -0,0 +1,32 @@
+name: Unit Tests
+on: [push, pull_request]
+jobs:
+  docker-rspec:
+    runs-on:
+      - ubuntu-18.04
+    strategy:
+      matrix:
+        ruby:
+          - 2.7
+          - 2.6
+          - 2.5
+          - 2.4
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - name: install bundler
+        run: |
+          gem install bundler -v '~> 1.17.3'
+          bundle update
+      - name: install rpm
+        run: |
+          set -x
+          sudo apt-get update -y
+          sudo apt-get install -y rpm
+      - name: spec tests
+        run: CI=true bundle exec rake

data/.ruby-version

@@ -1 +1 @@
-1.9.3-p547
+2.3.1

data/.travis.yml

@@ -1,9 +1,9 @@
 language: ruby
 rvm:
-  - 1.9
   - 2.0
   - 2.1
   - 2.2
+  - 2.3
 script:
   - git fetch --tags
   - CI=true bundle exec rake

data/README.md

@@ -174,6 +174,11 @@ In addition to the above attributes, `docker` has the following references:
     - allows one
     - class: `Dockly::Docker::Registry`
     - description: a registry to push to in lieu of exporting as a tar -- the registry will be automatically pulled upon installing the package
+- `ecr`
+    - required: `false`
+    - allows one
+    - class: `Dockly::Docker::ECR`
+    - description: an AWS ECR Docker registry to push to in lieu of exporting as a tar -- the registry will be automatically pulled upon installing the package
 
 Need finer control of Docker packages? We also wrote [docker-api](https://github.com/swipely/docker-api).
 
@@ -200,6 +205,23 @@ The `registry` DSL is used to define Docker Registries. It has the following att
     - default: `https://index.docker.io/v1`
     - description: the server where the registry lives
 
+`ecr`
+--------
+
+The `ecr` DSL is used to define AWS ECR Docker registries. It has the following attributes:
+
+- `server_address`
+    - required: `true`
+    - description: the server where the registry lives without the repo name, eg `accountid.dkr.ecr.region.amazonaws.com`
+- `username`
+    - required: `false`
+    - default: pulled from auth data obtained using assumed role's credentials
+    - description: the username to authenticate
+- `password`
+    - required: `false`
+    - default: pulled from auth data obtained using assumed role's credentials
+    - description: the password to authenticate
+
 `foreman`
 ---------
 

data/dockly.gemspec

@@ -18,9 +18,11 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'docker-api', '>= 1.14.0'
   gem.add_dependency 'dockly-util', '>= 0.0.9', '< 1.0'
   gem.add_dependency 'excon'
-  gem.add_dependency 'aws-sdk', '~> 2.0'
+  gem.add_dependency 'aws-sdk-core', '~> 3'
+  gem.add_dependency 'aws-sdk-s3', '~> 1'
+  gem.add_dependency 'aws-sdk-ecr', '~> 1'
   gem.add_dependency 'foreman'
-  gem.add_dependency 'fpm', '~> 1.2.0'
+  gem.add_dependency 'fpm', '~> 1.2'
   gem.add_dependency 'minigit', '~> 0.0.4'
   gem.add_development_dependency 'cane'
   gem.add_development_dependency 'pry'

data/lib/dockly/bash_builder.rb

@@ -24,7 +24,8 @@ module Dockly
     generate_snippet_for :s3_docker_import, [:s3_url, :repo, :tag]
     generate_snippet_for :s3_diff_docker_import, [:base_image, :diff_image, :repo, :tag]
     generate_snippet_for :registry_import, [:repo, :tag], { :tag => "latest" }
+    generate_snippet_for :auth_ecr, [:server_address]
 
-    generate_snippet_for :docker_tag_latest, [:repo, :tag]
+    generate_snippet_for :docker_tag_latest, [:repo, :tag, :new_name]
   end
 end

data/lib/dockly/build_cache/docker.rb

@@ -77,7 +77,7 @@ class Dockly::BuildCache::Docker < Dockly::BuildCache::Base
     debug 'Restarting the container to copy the cache\'s output'
     # Restart the container so we can copy its output
     container = container.commit.run('sleep 3600')
-    container.copy(output_directory) { |chunk| file.write(chunk.to_s) }
+    container.archive_out(output_directory) { |chunk| file.write(chunk.to_s) }
     container.kill
     file.tap(&:rewind)
   end

data/lib/dockly/deb.rb

@@ -77,7 +77,6 @@ class Dockly::Deb
   end
 
   def upload_to_s3
-    info "uploading to s3"
     return if s3_bucket.nil?
     raise "Package wasn't created!" unless File.exist?(build_path)
     info "uploading package to s3"
@@ -181,7 +180,7 @@ private
   end
 
   def add_docker_auth_config(package)
-    return if (registry = get_registry).nil? || !registry.authentication_required?
+    return if (registry = get_registry).nil? || !should_auth?(registry)
     info "adding docker config file"
     registry.generate_config_file!
 
@@ -192,11 +191,18 @@ private
     package.attributes[:prefix] = nil
   end
 
+  def should_auth?(registry)
+    registry.is_a?(Dockly::Docker::Registry) &&
+      registry.authentication_required?
+  end
+
   def add_docker(package)
     return if docker.nil? || docker.s3_bucket
     info "adding docker image"
     docker.generate!
-    return unless docker.registry.nil?
+
+    return if get_registry
+
     package.attributes[:prefix] = docker.package_dir
     Dir.chdir(File.dirname(docker.tar_path)) do
       package.input(File.basename(docker.tar_path))
@@ -205,7 +211,7 @@ private
   end
 
   def get_registry
-    if docker && registry = docker.registry
+    if docker && (registry = docker.registry)
       registry
     end
   end
@@ -214,28 +220,43 @@ private
     scripts = ["#!/bin/bash"]
     bb = Dockly::BashBuilder.new
     scripts << bb.normalize_for_dockly
-    if get_registry
-      scripts << bb.registry_import(docker.repo, docker.tag)
-    elsif docker
-      if docker.s3_bucket.nil?
-        docker_output = File.join(docker.package_dir, docker.export_filename)
-        if docker.tar_diff
-          scripts << bb.file_diff_docker_import(docker.import, docker_output, docker.name, docker.tag)
-        else
-          scripts << bb.file_docker_import(docker_output, docker.name, docker.tag)
+
+    if docker
+      if (registry = docker.registry)
+        if registry.is_a?(Dockly::Docker::ECR)
+          scripts << bb.auth_ecr(registry.server_address)
         end
+
+        scripts << bb.registry_import(docker.repo, docker.tag)
+        scripts << bb.docker_tag_latest(docker.repo, docker.tag, docker.name)
       else
-        if docker.tar_diff
-          scripts << bb.s3_diff_docker_import(docker.import, docker.s3_url, docker.name, docker.tag)
-        else
-          scripts << bb.s3_docker_import(docker.s3_url, docker.name, docker.tag)
-        end
+        scripts += collect_non_registry_scripts(bb)
       end
-      scripts << bb.docker_tag_latest(docker.repo, docker.tag)
     end
     scripts.join("\n")
   end
 
+  def collect_non_registry_scripts(bb)
+    scripts = []
+
+    if docker.s3_bucket.nil?
+      docker_output = File.join(docker.package_dir, docker.export_filename)
+      if docker.tar_diff
+        scripts << bb.file_diff_docker_import(docker.import, docker_output, docker.name, docker.tag)
+      else
+        scripts << bb.file_docker_import(docker_output, docker.name, docker.tag)
+      end
+    else
+      if docker.tar_diff
+        scripts << bb.s3_diff_docker_import(docker.import, docker.s3_url, docker.name, docker.tag)
+      else
+        scripts << bb.s3_docker_import(docker.s3_url, docker.name, docker.tag)
+      end
+    end
+
+    scripts << bb.docker_tag_latest(docker.repo, docker.tag, docker.repo)
+  end
+
   def add_startup_script(package, startup_script = "dockly-startup.sh")
     ensure_present! :build_dir
     startup_script_path = File.join(build_dir, startup_script)

data/lib/dockly/docker/ecr.rb

@@ -0,0 +1,60 @@
+class Dockly::Docker::ECR
+  include Dockly::Util::DSL
+  include Dockly::Util::Logger::Mixin
+
+  logger_prefix '[dockly docker ecr]'
+
+  dsl_attribute :name, :server_address, :password, :username
+
+  def authenticate!
+    @username ||= login_from_aws[0]
+    @password ||= login_from_aws[1]
+
+    ensure_present! :password, :server_address, :username
+
+    debug "Attempting to authenticate at #{server_address}"
+
+    ::Docker.authenticate!(self.to_h)
+
+    info "Successfully authenticated at #{server_address}"
+  rescue ::Docker::Error::AuthenticationError
+    raise "Could not authenticate at #{server_address}"
+  end
+
+  def authentication_required?
+    true
+  end
+
+  def default_server_address?
+    false
+  end
+
+  def login_from_aws
+    @login_from_aws ||=
+      Base64
+        .decode64(auth_data.authorization_token)
+        .split(':')
+  end
+
+  def auth_data
+    @auth_data ||=
+      client
+        .get_authorization_token
+        .authorization_data
+        .first
+  end
+
+  def client
+    @client ||= Aws::ECR::Client.new(region: 'us-east-1')
+  end
+
+  def to_h
+    ensure_present! :username, :password, :server_address
+
+    {
+      'serveraddress' => "https://#{server_address}",
+      'username' => username,
+      'password' => password
+    }
+  end
+end

data/lib/dockly/docker.rb

@@ -10,11 +10,13 @@ class Dockly::Docker
   include Dockly::Util::Logger::Mixin
 
   autoload :Registry, 'dockly/docker/registry'
+  autoload :ECR, 'dockly/docker/ecr'
 
   logger_prefix '[dockly docker]'
 
   dsl_class_attribute :build_cache, Dockly::BuildCache.model, type: Array
-  dsl_class_attribute :registry, Dockly::Docker::Registry
+  dsl_class_attribute :docker_registry, Dockly::Docker::Registry
+  dsl_class_attribute :ecr, Dockly::Docker::ECR
 
   dsl_attribute :name, :import, :git_archive, :build, :tag, :build_dir, :package_dir,
     :timeout, :cleanup_images, :tar_diff, :s3_bucket, :s3_object_prefix
@@ -32,6 +34,10 @@ class Dockly::Docker
     (@build_env ||= {}).tap { |env| env.merge!(hash) if hash.is_a?(Hash) }
   end
 
+  def registry
+    ecr || docker_registry
+  end
+
   def copy_from_s3(sha)
     return if s3_bucket.nil?
     object = s3_object_for(sha)
@@ -318,14 +324,26 @@ class Dockly::Docker
   end
 
   def push_to_registry(image)
-    ensure_present! :registry
+    raise "No registry to push to" if registry.nil?
+
     info "Exporting #{image.id} to Docker registry at #{registry.server_address}"
+
     registry.authenticate!
-    image = Docker::Image.all(:all => true).find { |img|
-      img.id.start_with?(image.id) || image.id.start_with?(img.id)
-    }
+
+    image =
+      Docker::Image
+        .all(:all => true)
+        .find do |img|
+          img.id.include?(image.id) || image.id.include?(img.id)
+        end
+
     raise "Could not find image after authentication" if image.nil?
-    image.push(registry.to_h, :registry => registry.server_address)
+
+    image.push(registry.to_h, :registry => registry.server_address) do |resp|
+      if resp.include?('errorDetail')
+        raise "Error pushing to registry: #{resp}"
+      end
+    end
   end
 
   def fetch_import

data/lib/dockly/rpm.rb

@@ -31,5 +31,6 @@ private
     @deb_package.attributes[:rpm_user] = "root"
     @deb_package.attributes[:rpm_group] = "root"
     @deb_package.attributes[:rpm_os] = os
+    @deb_package.attributes[:workdir] = ::Dir.tmpdir
   end
 end

data/lib/dockly/version.rb

@@ -1,7 +1,7 @@
 module Dockly
-  MAJOR = 3
-  MINOR = 4
-  PATCH = 1
+  MAJOR = 4
+  MINOR = 3
+  PATCH = 0
   RELEASE = nil
 
   VERSION = [MAJOR, MINOR, PATCH, RELEASE].compact.join('.')

data/lib/dockly.rb

@@ -4,7 +4,9 @@ require 'dockly/util/git'
 require 'foreman/cli_fix'
 require 'foreman/export/base_fix'
 require 'minigit'
-require 'aws-sdk'
+require 'aws-sdk-core'
+require 'aws-sdk-s3'
+require 'aws-sdk-ecr'
 require 'open3'
 
 module Dockly

data/snippets/auth_ecr.erb

@@ -0,0 +1,14 @@
+auth_ecr() {
+  account_id=$(aws sts get-caller-identity --query Account --output text)
+  region="<%= ENV['AWS_REGION'] || 'us-east-1' %>"
+  aws ecr get-login-password --region $region | \
+    docker login --username AWS --password-stdin $account_id.dkr.ecr.$region.amazonaws.com
+}
+
+worked=1
+for attempt in {1..10}; do
+  [[ $worked != 0 ]] || break
+  auth_ecr && worked=0 || (log "ecr auth: attempt $attempt failed, sleeping 30"; sleep 30)
+done
+[[ $worked != 0 ]] && fatal "failed to auth to ecr"
+log "ecr auth: successfully authenticated"

data/snippets/docker_tag_latest.erb

@@ -1,3 +1,3 @@
 <% if data[:tag] %>
-docker tag <%= data[:repo] %>:<%= data[:tag] %> <%= data[:repo] %>:latest
+docker tag <%= data[:repo] %>:<%= data[:tag] %> <%= data[:new_name] %>:latest
 <% end %>

data/spec/dockly/bash_builder_spec.rb

@@ -32,8 +32,8 @@ describe Dockly::BashBuilder do
 
     context "when there is a tag" do
       it "tags the repo:tag as repo:latest" do
-        output = subject.docker_tag_latest("test_repo", "a_tag")
-        expect(output).to include("docker tag test_repo:a_tag test_repo:latest")
+        output = subject.docker_tag_latest("registry/test_repo", "a_tag", "test_repo")
+        expect(output).to include("docker tag registry/test_repo:a_tag test_repo:latest")
       end
     end
   end

data/spec/dockly/build_cache/base_spec.rb

@@ -14,8 +14,11 @@ describe Dockly::BuildCache::Base do
   describe '#up_to_date?' do
     context 'when the object exists in s3' do
       before do
-        allow(subject.connection)
-          .to receive(:head_object)
+        allow(Dockly)
+          .to receive(:s3)
+          .and_return(
+            Aws::S3::Client.new(stub_responses: true)
+          )
       end
 
       its(:up_to_date?) { should be_true }
@@ -23,9 +26,13 @@ describe Dockly::BuildCache::Base do
 
     context 'when the object does not exist in s3' do
       before do
-        allow(subject.connection)
-          .to receive(:head_object)
-          .and_raise(Aws::S3::Errors::NoSuchKey.new('Some Error', 500))
+        allow(Dockly)
+          .to receive(:s3)
+          .and_return(
+            Aws::S3::Client.new(
+              stub_responses: { :head_object => 'NoSuchKey' }
+            )
+          )
       end
 
       its(:up_to_date?) { should be_false }
@@ -37,9 +44,12 @@ describe Dockly::BuildCache::Base do
     let(:object) { double(:object) }
 
     before do
-      allow(subject.connection)
-        .to receive(:get_object)
-        .and_return(object)
+      allow(Dockly)
+        .to receive(:s3)
+        .and_return(Aws::S3::Client.new(
+          stub_responses: { :get_object => object }
+        ))
+
       allow(object)
         .to receive(:body)
         .and_return(StringIO.new('hey dad').tap(&:rewind))

data/spec/dockly/deb_spec.rb

@@ -205,14 +205,19 @@ describe Dockly::Deb do
         pre_install "ls"
         post_install "rd /s /q C:\*"
         build_dir 'build/deb/s3'
+        s3_bucket 'bucket'
       end
     end
 
     context 'when the object does exist' do
       before do
-        allow(Dockly.s3)
-          .to receive(:head_object)
-          .and_return({})
+        allow(Dockly)
+          .to receive(:s3)
+          .and_return(
+            Aws::S3::Client.new(
+              stub_responses: { :head_object => {} }
+            )
+          )
       end
 
       it 'is true' do
@@ -222,12 +227,16 @@ describe Dockly::Deb do
 
     context 'when the object does not exist' do
       before do
-        allow(Dockly.s3)
-          .to receive(:head_object)
-          .and_raise(StandardError.new('object does not exist'))
+        allow(Dockly)
+          .to receive(:s3)
+          .and_return(
+            Aws::S3::Client.new(
+              stub_responses: { :head_object => 'ObjectDoesNotExist' }
+            )
+          )
       end
 
-      it 'is true' do
+      it 'is false' do
         expect(subject.exists?).to be_false
       end
     end
@@ -267,12 +276,24 @@ describe Dockly::Deb do
       context 'when the package has been created' do
         before { subject.create_package! }
 
+        let(:client) do
+          client = Aws::S3::Client.new(stub_responses: true)
+          client.stub_responses(
+            :put_object, ->(context) do
+              expect(context.params[:bucket]).to eq(bucket_name)
+              expect(context.params[:key]).to eq(subject.s3_object_name)
+              expect(context.params).to have_key(:body)
+
+              {}
+            end
+          )
+          client
+        end
+
         it 'inserts the deb package into that bucket' do
-          expect(Dockly.s3).to receive(:put_object) do |hash|
-            expect(hash[:bucket]).to eq(bucket_name)
-            expect(hash[:key]).to eq(subject.s3_object_name)
-            expect(hash).to have_key(:body)
-          end
+          expect(Dockly)
+            .to receive(:s3)
+            .and_return(client)
 
           subject.upload_to_s3
         end

data/spec/dockly/docker/ecr_spec.rb

@@ -0,0 +1,80 @@
+require 'spec_helper'
+
+describe Dockly::Docker::ECR do
+  subject do
+    described_class.new(name: 'ecr', server_address: registry)
+  end
+
+  let(:username) { 'AWS' }
+  let(:password) { 'password' }
+  let(:registry) { 'accountid.dkr.ecr.region.amazonaws.com' }
+  let(:endpoint) { "https://#{registry}" }
+  let(:ecr_client) { Aws::ECR::Client.new(stub_responses: true) }
+
+  after do
+    Aws.config[:ecr] = { stub_responses: {} }
+  end
+
+  describe '#authenticate!' do
+    context 'when AWS provides a username and password for ECR' do
+      before do
+        Aws.config[:ecr] = {
+          stub_responses: {
+            get_authorization_token: {
+              authorization_data: [
+                {
+                  authorization_token: Base64.encode64("#{username}:#{password}"),
+                  proxy_endpoint: endpoint
+                }
+              ]
+            }
+          }
+        }
+      end
+
+      context 'and docker auth succeeds' do
+        before do
+          allow(::Docker)
+            .to receive(:authenticate!)
+            .with({
+              'serveraddress' => endpoint,
+              'username' => username,
+              'password' => password
+            })
+        end
+
+        it 'does not error' do
+          expect { subject.authenticate! }.to_not raise_error
+        end
+      end
+
+      context 'and docker auth raises and error' do
+        before do
+          allow(::Docker)
+            .to receive(:authenticate!)
+            .and_raise(::Docker::Error::AuthenticationError)
+        end
+
+        it 'raises' do
+          expect { subject.authenticate! }
+            .to raise_error(/Could not authenticate/)
+        end
+      end
+    end
+  end
+
+  context 'when it is unable to get auth from AWS' do
+    before do
+      Aws.config[:ecr] = {
+        stub_responses: {
+          get_authorization_token: ->(_context) { raise 'Unable to get token' }
+        }
+      }
+    end
+
+    it 'raises' do
+      expect(::Docker).not_to receive(:authenticate!)
+      expect { subject.authenticate! }.to raise_error
+    end
+  end
+end

data/spec/dockly/docker_spec.rb

@@ -3,6 +3,76 @@ require 'spec_helper'
 describe Dockly::Docker do
   subject { described_class.new(:name => :test_docker) }
 
+  describe '#registry' do
+    context 'when there is no registry' do
+      it 'returns nil' do
+        expect(subject.registry).to eq(nil)
+      end
+    end
+
+    context 'when there is only an ecr registry' do
+      subject do
+        Dockly::Docker.new do
+          ecr { server_address 'accountid.dkr.ecr.region.amazonaws.com' }
+        end
+      end
+
+      it 'returns an ecr registry' do
+        registry = subject.registry
+
+        expect(registry).not_to eq(nil)
+        expect(registry).to be_a(Dockly::Docker::ECR)
+        expect(registry.server_address)
+          .to eq('accountid.dkr.ecr.region.amazonaws.com')
+      end
+    end
+
+    context 'when there is a docker registry' do
+      context 'and an ecr registry' do
+        subject do
+          Dockly::Docker.new do
+            registry do
+              username ENV['DOCKER_USER']
+              email ENV['DOCKER_EMAIL']
+              password ENV['DOCKER_PASS']
+            end
+
+            ecr { server_address 'accountid.dkr.ecr.region.amazonaws.com' }
+          end
+        end
+
+        it 'prefers the ecr registry' do
+          registry = subject.registry
+
+          expect(registry).not_to eq(nil)
+          expect(registry).to be_a(Dockly::Docker::ECR)
+          expect(registry.server_address)
+            .to eq('accountid.dkr.ecr.region.amazonaws.com')
+        end
+      end
+
+      context 'and only a docker registry' do
+        subject do
+          Dockly::Docker.new do
+            registry do
+              username ENV['DOCKER_USER']
+              email ENV['DOCKER_EMAIL']
+              password ENV['DOCKER_PASS']
+            end
+          end
+
+          it 'returns the docker registry' do
+            registry = subject.registry
+
+            expect(registry).not_to eq(nil)
+            expect(registry).to be_a(Dockly::Docker::Registry)
+            expect(registry.username).to eq(ENV['DOCKER_USER'])
+          end
+        end
+      end
+    end
+  end
+
   describe '#ensure_tar' do
     let(:action) { subject.ensure_tar(file) }
 
@@ -134,11 +204,15 @@ describe Dockly::Docker do
         let(:url) { 's3://bucket/object' }
         let(:data) { 'sweet, sweet data' }
 
+        let(:client) { double() }
+
         before do
-          allow(Dockly.s3)
+          allow(client)
             .to receive(:get_object)
-            .with(bucket: 'bucket', key: 'object')
+            .with(hash_including({ bucket: 'bucket', key: 'object' }))
             .and_yield(data)
+
+          allow(Dockly).to receive(:s3).and_return(client)
         end
 
         it 'pulls the file from S3' do
@@ -172,7 +246,7 @@ describe Dockly::Docker do
     context "with a registry export" do
       let(:registry) { double(:registry) }
       before do
-        subject.instance_variable_set(:"@registry", registry)
+        subject.instance_variable_set(:"@docker_registry", registry)
         expect(subject).to receive(:push_to_registry)
       end
 
@@ -243,6 +317,107 @@ describe Dockly::Docker do
     end
   end
 
+  describe '#push_to_registry', :docker do
+    let(:image) { Docker::Image.create('fromImage' => 'ubuntu:14.04') }
+    let(:ecr) { double(:ecr) }
+
+    context 'when there is no registry' do
+      it 'raises' do
+        expect(subject.registry).to eq(nil)
+
+        expect { subject.push_to_registry(image) }.to raise_error(/No registry/)
+      end
+    end
+
+    context 'when there is a registry' do
+      before do
+        subject.instance_variable_set(:"@ecr", ecr)
+
+        allow(ecr)
+          .to receive(:server_address)
+          .and_return('server_address')
+
+        expect(subject.registry).to eq(ecr)
+      end
+
+      context "that can't be authenticated to" do
+        before do
+          allow(ecr)
+            .to receive(:authenticate!)
+            .and_raise
+        end
+
+        it 'raises' do
+          expect { subject.push_to_registry(image) }
+            .to raise_error(StandardError)
+        end
+      end
+
+      context 'that can be authenticated to' do
+        before do
+          allow(ecr).to receive(:authenticate!)
+
+          allow(Docker::Image)
+            .to receive(:all)
+            .with(all: true)
+            .and_return(available_images)
+        end
+
+        context "but the image isn't found" do
+          let(:available_images) { [] }
+
+          it 'raises' do
+            expect { subject.push_to_registry(image) }
+              .to raise_error(/Could not find image after authentication/)
+          end
+        end
+
+        context 'and the image is found' do
+          let(:available_images) { [image] }
+
+          before do
+            allow(ecr)
+              .to receive(:to_h)
+              .and_return({})
+            allow(image)
+              .to receive(:push)
+              .and_yield(push_message)
+          end
+
+          context 'but the push to the registry fails' do
+            let(:push_message) do
+              <<-EOF
+                {"errorDetail":{"message":"name unknown: The repository with name 'repository'
+                does not exist in the registry with id 'accoundid'"},"error":"name unknown:
+                The repository with name 'repository' does not exist in the registry with id 'accountid'"}
+              EOF
+            end
+
+            it 'raises' do
+              expect { subject.push_to_registry(image) }
+                .to raise_error(/Error pushing to registry/)
+            end
+          end
+
+          context 'and the push to the registry succeeds' do
+            let(:push_message) do
+              <<-EOF
+                {"status":"Pushed","progressDetail":{},"id":"id"}
+                {"status":"sha: digest: digest size: 2048"}
+                {"progressDetail":{},"aux":{"Tag":"sha","Digest":"digest","Size":2048}}
+              EOF
+            end
+
+            it 'passes' do
+              expect(subject.push_to_registry(image))
+                .not_to raise_error
+            end
+          end
+        end
+      end
+    end
+  end
+
   describe '#export_image_diff', :docker do
     let(:images) { [] }
     let(:output) { StringIO.new }

data/spec/dockly/rpm_spec.rb

@@ -11,6 +11,7 @@ describe Dockly::Rpm do
         pre_install "ls"
         post_install "rd /s /q C:\*"
         build_dir 'build'
+        s3_bucket 'bucket'
       end
     end
     let(:filename) { "build/rpm/my-sweet-rpm_77.0.8_x86_64.rpm" }
@@ -173,14 +174,17 @@ describe Dockly::Rpm do
         pre_install "ls"
         post_install "rd /s /q C:\*"
         build_dir 'build/rpm/s3'
+        s3_bucket 'bucket'
       end
     end
 
     context 'when the object does exist' do
       before do
-        allow(Dockly.s3)
-          .to receive(:head_object)
-          .and_return({})
+        allow(Dockly)
+          .to receive(:s3)
+          .and_return(
+            Aws::S3::Client.new(stub_responses: true)
+          )
       end
 
       it 'is true' do
@@ -190,9 +194,13 @@ describe Dockly::Rpm do
 
     context 'when the object does not exist' do
       before do
-        allow(Dockly.s3)
-          .to receive(:head_object)
-          .and_raise(StandardError.new('object does not exist'))
+        allow(Dockly)
+          .to receive(:s3)
+          .and_return(
+            Aws::S3::Client.new(
+              stub_responses: { :head_object => 'NoSuchKey' }
+            )
+          )
       end
 
       it 'is true' do
@@ -235,12 +243,24 @@ describe Dockly::Rpm do
       context 'when the package has been created' do
         before { subject.create_package! }
 
+        let(:client) do
+          client = Aws::S3::Client.new(stub_responses: true)
+          client.stub_responses(
+            :put_object, ->(context) do
+              expect(context.params[:bucket]).to eq(bucket_name)
+              expect(context.params[:key]).to eq(subject.s3_object_name)
+              expect(context.params).to have_key(:body)
+
+              {}
+            end
+          )
+          client
+        end
+
         it 'inserts the rpm package into that bucket' do
-          expect(Dockly.s3).to receive(:put_object) do |hash|
-            expect(hash[:bucket]).to eq(bucket_name)
-            expect(hash[:key]).to eq(subject.s3_object_name)
-            expect(hash).to have_key(:body)
-          end
+          expect(Dockly)
+            .to receive(:s3)
+            .and_return(client)
 
           subject.upload_to_s3
         end

metadata

@@ -1,229 +1,257 @@
 --- !ruby/object:Gem::Specification
 name: dockly
 version: !ruby/object:Gem::Version
-  version: 3.4.1
+  version: 4.3.0
 platform: ruby
 authors:
 - Swipely, Inc.
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-10-18 00:00:00.000000000 Z
+date: 2021-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: clamp
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.6'
 - !ruby/object:Gem::Dependency
   name: docker-api
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.14.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.14.0
 - !ruby/object:Gem::Dependency
   name: dockly-util
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.0.9
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.0.9
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: aws-sdk
+  name: aws-sdk-core
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3'
+- !ruby/object:Gem::Dependency
+  name: aws-sdk-s3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1'
+- !ruby/object:Gem::Dependency
+  name: aws-sdk-ecr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: foreman
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: fpm
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: minigit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.0.4
 - !ruby/object:Gem::Dependency
   name: cane
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '11.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '11.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.14.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.14.1
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - <=
+    - - "<="
       - !ruby/object:Gem::Version
         version: 1.18.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - <=
+    - - "<="
       - !ruby/object:Gem::Version
         version: 1.18.0
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - <=
+    - - "<="
       - !ruby/object:Gem::Version
         version: 2.3.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - <=
+    - - "<="
       - !ruby/object:Gem::Version
         version: 2.3.6
 description: Packaging made easy
@@ -236,11 +264,12 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .cane
-- .gitignore
-- .rspec
-- .ruby-version
-- .travis.yml
+- ".cane"
+- ".github/workflows/unit_test.yml"
+- ".gitignore"
+- ".rspec"
+- ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -257,6 +286,7 @@ files:
 - lib/dockly/cli.rb
 - lib/dockly/deb.rb
 - lib/dockly/docker.rb
+- lib/dockly/docker/ecr.rb
 - lib/dockly/docker/registry.rb
 - lib/dockly/foreman.rb
 - lib/dockly/history.rb
@@ -269,6 +299,7 @@ files:
 - lib/dockly/version.rb
 - lib/foreman/cli_fix.rb
 - lib/foreman/export/base_fix.rb
+- snippets/auth_ecr.erb
 - snippets/docker_tag_latest.erb
 - snippets/file_diff_docker_import.erb
 - snippets/file_docker_import.erb
@@ -286,6 +317,7 @@ files:
 - spec/dockly/build_cache/local_spec.rb
 - spec/dockly/cli_spec.rb
 - spec/dockly/deb_spec.rb
+- spec/dockly/docker/ecr_spec.rb
 - spec/dockly/docker/registry_spec.rb
 - spec/dockly/docker_spec.rb
 - spec/dockly/foreman_spec.rb
@@ -308,24 +340,23 @@ homepage: https://github.com/swipely/dockly
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.0.14
-signing_key: 
+rubygems_version: 3.0.6
+signing_key:
 specification_version: 4
 summary: Packaging made easy
 test_files:
@@ -335,6 +366,7 @@ test_files:
 - spec/dockly/build_cache/local_spec.rb
 - spec/dockly/cli_spec.rb
 - spec/dockly/deb_spec.rb
+- spec/dockly/docker/ecr_spec.rb
 - spec/dockly/docker/registry_spec.rb
 - spec/dockly/docker_spec.rb
 - spec/dockly/foreman_spec.rb