docker-remote 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 19acf54d628fdf18296c7a86ffdd6760840f7222fa28e5438e5b0edc7bac7136
-  data.tar.gz: 1ce08796037731c708c9f5ce79e8038d31d288654f0ea7070166a2d6ac4e711c
+  metadata.gz: fbe61af8e8709e3a11eb1df8bc561477d38c3540ce2d216bc81dc999d31822cf
+  data.tar.gz: 65a9d5336374a275246dc6ba950c3a4288823286ae1884f43f5a5bb748348c50
 SHA512:
-  metadata.gz: 273f430350900735e9efb3a63155d01d32d14afcc7ab5b34b94250e2de0d12c2cd5301f88d08c0729513848f06a559b918d7a762a0b1803854c6f8069e9263f3
-  data.tar.gz: 60684d86a0675c3465455b3df6373144db0894a908fd5c0491c5b822a7c5544d00dd50121a3d57d666ea4b5a4b0a4a34b674c29bd6e25e690c142217a63c60d0
+  metadata.gz: 6d04a849e0fe6fda791f19be79f7664a95f3c24c7b6a38c7b2f0831a9af09690c825c54b3a62c8477da65ac06902bb9bce712427c62dfbe8b619d4a9d24ad098
+  data.tar.gz: e927985c4d0a6b767941ce5ac77647c8e1c5e6c45446221fd3f237cfbf4f29754a54cf9eb08db6597aa694fb3f2eb8611d9660280771a8819fe82446c93568b5

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.0
+* Support registries with no auth.
+* Raise errors upon receiving unexpected response codes during auth flow.
+
 ## 0.2.0
 * Support both basic and bearer auth.
 

data/Gemfile

@@ -4,6 +4,7 @@ gemspec
 
 group :development do
   gem 'rake'
+  gem 'pry-byebug'
 end
 
 group :test do

data/lib/docker/remote.rb

@@ -10,6 +10,7 @@ module Docker
     autoload :BasicAuth,  'docker/remote/basic_auth'
     autoload :BearerAuth, 'docker/remote/bearer_auth'
     autoload :Client,     'docker/remote/client'
+    autoload :NoAuth,     'docker/remote/no_auth'
     autoload :Utils,      'docker/remote/utils'
   end
 end

data/lib/docker/remote/client.rb

@@ -4,6 +4,10 @@ require 'uri'
 
 module Docker
   module Remote
+    class DockerRemoteError < StandardError; end
+    class UnsupportedVersionError < DockerRemoteError; end
+    class UnexpectedResponseCodeError < DockerRemoteError; end
+
     class Client
       include Utils
 
@@ -43,35 +47,55 @@ module Docker
         @auth ||= begin
           request = Net::HTTP::Get.new('/v2/')
           response = registry_http.request(request)
-          auth = response['www-authenticate']
-
-          idx = auth.index(' ')
-          auth_type = auth[0..idx].strip
-
-          params = auth[idx..-1].split(',').each_with_object({}) do |param, ret|
-            key, value = param.split('=')
-            ret[key.strip] = value.strip[1..-2]  # remove quotes
-          end
 
-          case auth_type.downcase
-            when 'bearer'
-              BearerAuth.new(params, repo, username, password)
-            when 'basic'
-              BasicAuth.new(username, password)
+          case response.code
+            when '200'
+              NoAuth.instance
+            when '401'
+              www_auth(response)
+            when '404'
+              raise UnsupportedVersionError,
+                "the registry at #{registry_url} doesn't support v2 "\
+                  'of the Docker registry API'
             else
-              raise UnsupportedAuthTypeError, "unsupported Docker auth type '#{auth_type}'"
+              raise UnexpectedResponseCodeError,
+                "the registry at #{registry_url} responded with an "\
+                  "unexpected HTTP status code of #{response.code}"
           end
         end
       end
 
+      def www_auth(response)
+        auth = response['www-authenticate']
+
+        idx = auth.index(' ')
+        auth_type = auth[0..idx].strip
+
+        params = auth[idx..-1].split(',').each_with_object({}) do |param, ret|
+          key, value = param.split('=')
+          ret[key.strip] = value.strip[1..-2]  # remove quotes
+        end
+
+        case auth_type.downcase
+          when 'bearer'
+            BearerAuth.new(params, repo, username, password)
+          when 'basic'
+            BasicAuth.new(username, password)
+          else
+            raise UnsupportedAuthTypeError,
+              "unsupported Docker auth type '#{auth_type}'"
+        end
+      end
+
       def registry_uri
         @registry_uri ||= URI.parse(registry_url)
       end
 
       def registry_http
-        @registry_http ||= Net::HTTP.new(registry_uri.host, registry_uri.port).tap do |http|
-          http.use_ssl = true if registry_uri.scheme == 'https'
-        end
+        @registry_http ||=
+          Net::HTTP.new(registry_uri.host, registry_uri.port).tap do |http|
+            http.use_ssl = true if registry_uri.scheme == 'https'
+          end
       end
     end
   end

data/lib/docker/remote/no_auth.rb

@@ -0,0 +1,11 @@
+module Docker
+  module Remote
+    class NoAuth
+      include Singleton
+
+      def make_get(path)
+        Net::HTTP::Get.new(path)
+      end
+    end
+  end
+end

data/lib/docker/remote/version.rb

@@ -1,5 +1,5 @@
 module Docker
   module Remote
-    VERSION = '0.2.0'
+    VERSION = '0.3.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: docker-remote
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Cameron Dutro
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-26 00:00:00.000000000 Z
+date: 2020-10-29 00:00:00.000000000 Z
 dependencies: []
 description: A Ruby client for communicating with the Docker registry API v2.
 email:
@@ -26,6 +26,7 @@ files:
 - lib/docker/remote/basic_auth.rb
 - lib/docker/remote/bearer_auth.rb
 - lib/docker/remote/client.rb
+- lib/docker/remote/no_auth.rb
 - lib/docker/remote/utils.rb
 - lib/docker/remote/version.rb
 homepage: http://github.com/getkuby/docker-remote