docker-client 0.1.3 → 0.1.4

data/lib/docker/resource/container.rb

@@ -30,7 +30,9 @@ class Docker::Resource::Container < Docker::Resource::Base
   # inspect is a Ruby internal method that should not be overwritten 
   # therefore we use show as it displays the container details
   def show(container_id)
-    @connection.get("/containers/#{container_id}/json").body_as_json
+    response = @connection.get("/containers/#{container_id}/json")
+    raise_if_container_not_found(response.status)
+    response.body_as_json
   end
   
   def changes(container_id)
@@ -138,4 +140,3 @@ end
 
 
 
-  

data/lib/docker/version.rb

@@ -1,3 +1,3 @@
 module Docker
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/spec/cassettes/Docker_Resource_Container/shows/raises_an_exception_for_an_unknown_container.yml

@@ -0,0 +1,27 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://10.0.5.5:4243/containers/invalid_id/json
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers: {}
+  response:
+    status:
+      code: 404
+      message: Not Found
+    headers:
+      Content-Type:
+      - text/plain; charset=utf-8
+      Date:
+      - Thu, 13 Jun 2013 18:47:07 GMT
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: ASCII-8BIT
+      string: |
+        No such container: invalid_id
+    http_version: 
+  recorded_at: Thu, 13 Jun 2013 18:47:07 GMT
+recorded_with: VCR 2.5.0

data/spec/docker/resource/container_spec.rb

@@ -99,6 +99,12 @@ describe Docker::Resource::Container do
       details.should be_kind_of(Hash)
       details['Id'].should include(@c)
     end
+
+    it "raises an exception for an unknown container" do
+      expect {
+        subject.show('invalid_id')
+      }.to raise_error(Docker::Error::ContainerNotFound)
+    end
   end
   
   describe "changes", :vcr do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: docker-client
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-10 00:00:00.000000000 Z
+date: 2013-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -262,6 +262,7 @@ files:
 - spec/cassettes/Docker_Resource_Container/remove/raises_an_exception_with_an_invalid_container.yml
 - spec/cassettes/Docker_Resource_Container/restarts/raises_an_exception_for_an_unknown_container.yml
 - spec/cassettes/Docker_Resource_Container/restarts/the_container.yml
+- spec/cassettes/Docker_Resource_Container/shows/raises_an_exception_for_an_unknown_container.yml
 - spec/cassettes/Docker_Resource_Container/shows/the_low_level_details.yml
 - spec/cassettes/Docker_Resource_Container/start/brings_a_container_into_state_running.yml
 - spec/cassettes/Docker_Resource_Container/start/raises_an_exception_for_an_unknown_container.yml
@@ -364,6 +365,7 @@ test_files:
 - spec/cassettes/Docker_Resource_Container/remove/raises_an_exception_with_an_invalid_container.yml
 - spec/cassettes/Docker_Resource_Container/restarts/raises_an_exception_for_an_unknown_container.yml
 - spec/cassettes/Docker_Resource_Container/restarts/the_container.yml
+- spec/cassettes/Docker_Resource_Container/shows/raises_an_exception_for_an_unknown_container.yml
 - spec/cassettes/Docker_Resource_Container/shows/the_low_level_details.yml
 - spec/cassettes/Docker_Resource_Container/start/brings_a_container_into_state_running.yml
 - spec/cassettes/Docker_Resource_Container/start/raises_an_exception_for_an_unknown_container.yml