docker-api 0.1.0 → 1.0.0

data/spec/docker/image_spec.rb

@@ -1,57 +1,7 @@
 require 'spec_helper'
 
 describe Docker::Image do
-  describe '#initialize' do
-    subject { described_class }
-
-    context 'with no argument' do
-      let(:image) { subject.new }
-
-      it 'sets the id to nil' do
-        image.id.should be_nil
-      end
-
-      it 'keeps the default Connection' do
-        image.connection.should == Docker.connection
-      end
-    end
-
-    context 'with an argument' do
-      let(:id) { 'a7c2ee4' }
-      let(:image) { subject.new(:id => id) }
-
-      it 'sets the id to the argument' do
-        image.id.should == id
-      end
-
-      it 'keeps the default Connection' do
-        image.connection.should == Docker.connection
-      end
-    end
-
-    context 'with two arguments' do
-      context 'when the second argument is not a Docker::Connection' do
-        let(:id) { 'abc123f' }
-        let(:connection) { :not_a_connection }
-        let(:image) { subject.new(:id => id, :connection => connection) }
-
-        it 'raises an error' do
-          expect { image }.to raise_error(Docker::Error::ArgumentError)
-        end
-      end
-
-      context 'when the second argument is a Docker::Connection' do
-        let(:id) { 'cb3f14a' }
-        let(:connection) { Docker::Connection.new }
-        let(:image) { subject.new(:id => id, :connection => connection) }
-
-        it 'initializes the Image' do
-          image.id.should == id
-          image.connection.should == connection
-        end
-      end
-    end
-  end
+  subject { described_class.send(:new, :id => rand(10000).to_s) }
 
   describe '#to_s' do
     let(:id) { 'bf119e2' }
@@ -59,258 +9,196 @@ describe Docker::Image do
     let(:expected_string) do
       "Docker::Image { :id => #{id}, :connection => #{connection} }"
     end
-    subject { described_class.new(:id => id, :connection => connection) }
+    before do
+      {
+        :@id => id,
+        :@connection => connection
+      }.each { |k, v| subject.instance_variable_set(k, v) }
+    end
 
     its(:to_s) { should == expected_string }
   end
 
-  describe '#created?' do
-    context 'when the id is nil' do
-      its(:created?) { should be_false }
-    end
-
-    context 'when the id is present' do
-      subject { described_class.new(:id => 'a732ebf') }
+  describe '#remove' do
+    context 'when the HTTP response status is not 204' do
+      before { Excon.stub({ :method => :delete }, { :status => 500 }) }
+      after { Excon.stubs.shift }
 
-      its(:created?) { should be_true }
+      it 'raises an error' do
+        expect { subject.remove }
+            .to raise_error(Docker::Error::ServerError)
+      end
     end
-  end
 
-  describe '#create!' do
-    context 'when the Image has already been created' do
-      subject { described_class.new(:id => '5e88b2a') }
+    context 'when the HTTP response status is 204' do
+      let(:id) { subject.id }
+      subject { described_class.create('fromImage' => 'base') }
 
-      it 'raises an error' do
-        expect { subject.create! }
-            .to raise_error(Docker::Error::StateError)
+      it 'removes the Image', :vcr do
+        subject.remove
+        Docker::Image.all.map(&:id).should_not include(id)
       end
     end
+  end
+
+  describe '#insert' do
+    context 'when the HTTP response status is not 200' do
+      before { Excon.stub({ :method => :post }, { :status => 500 }) }
+      after { Excon.stubs.shift }
 
-    context 'when the body is not a Hash' do
       it 'raises an error' do
-        expect { subject.create!(:not_a_hash) }
-            .to raise_error(Docker::Error::ArgumentError)
+        expect { subject.insert }
+            .to raise_error(Docker::Error::ServerError)
       end
     end
 
-    context 'when the Image does not yet exist and the body is a Hash' do
-      context 'when the HTTP request does not return a 200' do
-        before { Excon.stub({ :method => :post }, { :status => 400 }) }
-        after { Excon.stubs.shift }
-
-        it 'raises an error' do
-          expect { subject.create! }.to raise_error(Docker::Error::ClientError)
-        end
-      end
+    context 'when the HTTP response status is 200' do
+      subject { described_class.build('from base') }
+      let(:new_image) { subject.insert(:path => '/stallman',
+                                       :url => 'http://stallman.org') }
+      let(:ls_output) { new_image.run('ls /').attach.split("\n") }
 
-      context 'when the HTTP request returns a 200' do
-        it 'sets the id', :vcr do
-          expect { subject.create!('fromImage' => 'base') }
-              .to change { subject.id }
-              .from(nil)
-        end
+      it 'inserts the url\'s file into a new Image', :vcr do
+        ls_output.should include('stallman')
       end
     end
   end
 
-  describe '#remove' do
-    context 'when the Image has not been created' do
+  describe '#push' do
+    context 'when the HTTP response status is not 200' do
+      before { Excon.stub({ :method => :post }, { :status => 500 }) }
+      after { Excon.stubs.shift }
+
       it 'raises an error' do
-        expect { subject.remove }.to raise_error Docker::Error::StateError
+        expect { subject.push }
+            .to raise_error(Docker::Error::ServerError)
       end
     end
 
-    context 'when the Image has been created' do
-      context 'when the HTTP response status is not 204' do
-        before do
-          subject.stub(:created?).and_return(true)
-          Excon.stub({ :method => :delete }, { :status => 500 })
-        end
-        after { Excon.stubs.shift }
-
-        it 'raises an error' do
-          expect { subject.remove }
-              .to raise_error(Docker::Error::ServerError)
-        end
-      end
-
-      context 'when the HTTP response status is 204' do
-        before { subject.create!('fromImage' => 'base') }
+    context 'when the HTTP response status is 200' do
+      subject { described_class.create('fromImage' => 'base') }
 
-        it 'nils out the id', :vcr do
-          expect { subject.remove }
-              .to change { subject.id }
-              .to nil
-        end
+      it 'pushes the Image', :vcr do
+        pending 'I don\'t want to push the Image to the Docker Registry'
+        subject.push
       end
     end
   end
 
-  describe "#insert" do
-    context 'when the Image has not been created' do
+  describe '#tag' do
+    context 'when the HTTP response status is not 200' do
+      before { Excon.stub({ :method => :post }, { :status => 500 }) }
+      after { Excon.stubs.shift }
+
       it 'raises an error' do
-        expect { subject.insert }.to raise_error Docker::Error::StateError
+        expect { subject.tag }
+            .to raise_error(Docker::Error::ServerError)
       end
     end
 
-    context 'when the Image has been created' do
-      context 'when the HTTP response status is not 200' do
-        before do
-          subject.stub(:created?).and_return(true)
-          Excon.stub({ :method => :post }, { :status => 500 })
-        end
-        after { Excon.stubs.shift }
+    context 'when the HTTP response status is 200' do
+      subject { described_class.create('fromImage' => 'base') }
 
-        it 'raises an error' do
-          expect { subject.insert }
-              .to raise_error(Docker::Error::ServerError)
-        end
-      end
-
-      context 'when the HTTP response status is 200' do
-        subject { described_class.build('from base') }
-        let(:new_image) { subject.insert(:path => '/stallman',
-                                         :url => 'http://stallman.org') }
-        let(:container) { Docker::Container.new }
-        let(:ls_output) do
-          container.tap(&:start)
-                   .attach(:stream => true, :stdout => true)
-                   .split("\n")
-        end
-        before { container.create!('Image' => new_image.id, 'Cmd' => %w[ls /]) }
-
-        it 'inserts the url\'s file into a new Image', :vcr do
-          ls_output.should include('stallman')
-        end
+      it 'tags the image with the repo name', :vcr do
+        expect { subject.tag(:repo => 'base2', :force => true) }
+            .to_not raise_error
       end
     end
   end
 
-  describe "#push" do
-    context 'when the Image has not been created' do
+  describe '#json' do
+    context 'when the HTTP response status is not 200' do
+      before do
+        subject.stub(:created?).and_return(true)
+        Excon.stub({ :method => :get }, { :status => 500 })
+      end
+      after { Excon.stubs.shift }
+
       it 'raises an error' do
-        expect { subject.push }.to raise_error Docker::Error::StateError
+        expect { subject.json }
+            .to raise_error(Docker::Error::ServerError)
       end
     end
 
-    context 'when the Image has been created' do
-      context 'when the HTTP response status is not 200' do
-        before do
-          subject.stub(:created?).and_return(true)
-          Excon.stub({ :method => :post }, { :status => 500 })
-        end
-        after { Excon.stubs.shift }
+    context 'when the HTTP response status is 200' do
+      subject { described_class.create('fromImage' => 'base') }
+      let(:json) { subject.json }
 
-        it 'raises an error' do
-          expect { subject.push }
-              .to raise_error(Docker::Error::ServerError)
-        end
-      end
-
-      context 'when the HTTP response status is 200' do
-        it 'pushes the Image', :vcr do
-          pending 'I don\'t want to push the Image to the Docker Registry'
-          subject.create!('fromImage' => 'base')
-          subject.push
-        end
+      it 'returns additional information about image image', :vcr do
+        json.should be_a Hash
+        json.length.should_not be_zero
       end
     end
   end
 
-  describe "#tag" do
-    context 'when the Image has not been created' do
+  describe '#history' do
+    context 'when the HTTP response status is not 200' do
+      before { Excon.stub({ :method => :get }, { :status => 500 }) }
+      after { Excon.stubs.shift }
+
       it 'raises an error' do
-        expect { subject.tag }.to raise_error Docker::Error::StateError
+        expect { subject.history }
+            .to raise_error(Docker::Error::ServerError)
       end
     end
 
-    context 'when the Image has been created' do
-      context 'when the HTTP response status is not 200' do
-        before do
-          subject.stub(:created?).and_return(true)
-          Excon.stub({ :method => :post }, { :status => 500 })
-        end
-        after { Excon.stubs.shift }
-
-        it 'raises an error' do
-          expect { subject.tag }
-              .to raise_error(Docker::Error::ServerError)
-        end
-      end
+    context 'when the HTTP response status is 200' do
+      subject { described_class.create('fromImage' => 'base') }
+      let(:history) { subject.history }
 
-      context 'when the HTTP response status is 200' do
-        before { subject.create!('fromImage' => 'base') }
-
-        it 'tags the image with the repo name', :vcr do
-          expect { subject.tag(:repo => 'base2', :force => true) }
-              .to_not raise_error
-        end
+      it 'returns the history of the Image', :vcr do
+        history.should be_a Array
+        history.length.should_not be_zero
+        history.should be_all { |elem| elem.is_a? Hash }
       end
     end
   end
 
-  describe "#json" do
-    context 'when the Image has not been created' do
-      it 'raises an error' do
-        expect { subject.json }.to raise_error Docker::Error::StateError
-      end
-    end
+  describe '#run' do
+    subject { described_class.create('fromImage' => 'base') }
+    let(:output) { subject.run(cmd).attach }
 
-    context 'when the Image has been created' do
-      context 'when the HTTP response status is not 200' do
-        before do
-          subject.stub(:created?).and_return(true)
-          Excon.stub({ :method => :get }, { :status => 500 })
-        end
-        after { Excon.stubs.shift }
-
-        it 'raises an error' do
-          expect { subject.json }
-              .to raise_error(Docker::Error::ServerError)
-        end
+    context 'when the argument is a String', :vcr do
+      let(:cmd) { 'ls /lib64/' }
+      it 'splits the String by spaces and creates a new Container' do
+        output.should == "ld-linux-x86-64.so.2\n"
       end
+    end
 
-      context 'when the HTTP response status is 200' do
-        let(:json) { subject.json }
-        before { subject.create!('fromImage' => 'base') }
+    context 'when the argument is an Array' do
+      let(:cmd) { %[which pwd] }
 
-        it 'returns additional information about image image', :vcr do
-          json.should be_a Hash
-          json.length.should_not be_zero
-        end
+      it 'creates a new Container', :vcr do
+        output.should == "/bin/pwd\n"
       end
     end
   end
 
-  describe "#history" do
-    context 'when the Image has not been created' do
+  describe '.create' do
+    subject { described_class }
+
+    context 'when the body is not a Hash' do
       it 'raises an error' do
-        expect { subject.history }.to raise_error Docker::Error::StateError
+        expect { subject.create(:not_a_hash) }
+            .to raise_error(Docker::Error::ArgumentError)
       end
     end
 
-    context 'when the Image has been created' do
-      context 'when the HTTP response status is not 200' do
-        before do
-          subject.stub(:created?).and_return(true)
-          Excon.stub({ :method => :get }, { :status => 500 })
-        end
+    context 'when the Image does not yet exist and the body is a Hash' do
+      context 'when the HTTP request does not return a 200' do
+        before { Excon.stub({ :method => :post }, { :status => 400 }) }
         after { Excon.stubs.shift }
 
         it 'raises an error' do
-          expect { subject.history }
-              .to raise_error(Docker::Error::ServerError)
+          expect { subject.create }.to raise_error(Docker::Error::ClientError)
         end
       end
 
-      context 'when the HTTP response status is 200' do
-        let(:history) { subject.history }
-        before { subject.create!('fromImage' => 'base') }
-
-        it 'returns the history of the Image', :vcr do
-          history.should be_a Array
-          history.length.should_not be_zero
-          history.should be_all { |elem| elem.is_a? Hash }
+      context 'when the HTTP request returns a 200' do
+        let(:image) { subject.create('fromImage' => 'base') }
+        it 'sets the id', :vcr do
+          image.should be_a Docker::Image
+          image.id.should_not be_nil
         end
       end
     end
@@ -359,7 +247,8 @@ describe Docker::Image do
 
     context 'when the HTTP response is a 200' do
       let(:images) { subject.all(:all => true) }
-      before { subject.new.create!('fromImage' => 'base') }
+      before { subject.create('fromImage' => 'base') }
+
       it 'materializes each Image into a Docker::Image', :vcr do
         images.should be_all { |image|
           !image.id.nil? && image.is_a?(described_class)
@@ -384,7 +273,6 @@ describe Docker::Image do
 
     context 'when the HTTP response is a 200' do
       it 'materializes each Image into a Docker::Image', :vcr do
-        subject.new.create!('fromImage' => 'base')
         subject.search('term' => 'sshd').should be_all { |image|
           !image.id.nil? && image.is_a?(described_class)
         }
@@ -412,7 +300,7 @@ describe Docker::Image do
     end
   end
 
-  describe '.build_from_dir', :current do
+  describe '.build_from_dir' do
     subject { described_class }
 
     context 'with a valid Dockerfile' do
@@ -420,13 +308,11 @@ describe Docker::Image do
       let(:docker_file) { File.new("#{dir}/Dockerfile") }
       let(:image) { subject.build_from_dir(dir) }
       let(:container) do
-        Docker::Container.new.create!('Image' => image.id,
-                                      'Cmd' => %w[cat /Dockerfile])
+        Docker::Container.create('Image' => image.id,
+                                 'Cmd' => %w[cat /Dockerfile])
       end
       let(:output) { container.tap(&:start)
-                              .attach(:stream => true,
-                                      :stdout => true,
-                                      :stderr => true) }
+                              .attach(:stderr => true) }
 
       it 'builds the image', :vcr do
         pending 'webmock / vcr issue'